From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UiEsT-0007ps-3y
	for qemu-devel@nongnu.org; Thu, 30 May 2013 22:15:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UiEsQ-0007IE-Cv
	for qemu-devel@nongnu.org; Thu, 30 May 2013 22:15:36 -0400
Received: from usindpps05.hds.com ([207.126.252.18]:36285)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tomoki.sekiyama@hds.com>) id 1UiEsP-0007Hz-KR
	for qemu-devel@nongnu.org; Thu, 30 May 2013 22:15:34 -0400
From: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Date: Fri, 31 May 2013 02:15:24 +0000
Message-ID: <DC2D5EE4C7435B43AB459823CD432F1E0190E92B@USINDEM102.corp.hds.com>
References: <20130523122221.GL9093@stefanha-thinkpad.redhat.com>
	<CDC3D58B.2954%Tomoki.Sekiyama@hds.com>
	<20130528210125.GB7662@localhost.localdomain>,
	<20130529073925.GA20199@stefanha-thinkpad.redhat.com>
In-Reply-To: <20130529073925.GA20199@stefanha-thinkpad.redhat.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC PATCH v3 05/11] qemu-ga: Add Windows VSS
 provider to quiesce applications on fsfreeze
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, Jeff Cody <jcody@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "mdroth@linux.vnet.ibm.com" <mdroth@linux.vnet.ibm.com>, "lcapitulino@redhat.com" <lcapitulino@redhat.com>, "vrozenfe@redhat.com" <vrozenfe@redhat.com>, "pbonzini@redhat.com" <pbonzini@redhat.com>, Seiji Aguchi <seiji.aguchi@hds.com>, "areis@redhat.com" <areis@redhat.com>

>On Tue, May 28, 2013 at 05:01:25PM -0400, Jeff Cody wrote:=0A=
>> On Thu, May 23, 2013 at 06:36:35PM +0000, Tomoki Sekiyama wrote:=0A=
>> > On 5/23/13 8:22 , "Stefan Hajnoczi" <stefanha@gmail.com> wrote:=0A=
>> > >On Tue, May 21, 2013 at 11:33:52AM -0400, Tomoki Sekiyama wrote:=0A=
<snip>=0A=
>> > >> +# rules to build qga-provider.tlb=0A=
>> > >> +# Currently, only native build is supported because building .tlb=
=0A=
>> > >> +# (TypeLibrary) from .idl requires WindowsSDK and MIDL (included i=
n=0A=
>> > >>VC++).=0A=
>> > >> +MIDL=3Dmidl=0A=
>> > >> +WINSDK=3D"C:\\Program Files\\Microsoft SDKs\\Windows\\v7.1\\Includ=
e"=0A=
>> > >=0A=
>> > >This needs to be a ./configure option.=0A=
>> >=0A=
>> > OK. I will add something like --with-winsdk=3D"\\path\to\windows\sdk" =
to=0A=
>> > configure this.=0A=
>> >=0A=
>>=0A=
>> Patch 9/11 adds a binary tlb in, so that midl is not required. I would=
=0A=
>> like to see patch 09/11 just be squashed into this patch, so the build=
=0A=
>> will always work without requiring midl.  Otherwise, from this patch=0A=
>> up through patch 9, qemu-ga.exe will fail to build unless you have the=
=0A=
>> Windows SDK installed.=0A=
> =0A=
> Good idea.=0A=
=0A=
That's true. I will squash 09/11 into 05/11.=0A=
=0A=
>> And if that is done, I don't know if this needs a ./configure option=0A=
>> or not, because you will only build the .tlb if you explicitly purge=0A=
>> the existing binary.  Stefan, would you still like to see it in=0A=
>> ./configure option, in that case?=0A=
=0A=
> It still feels weird to hardcode an install path to a specific version=0A=
> of the Windows SDK.  Please make it a configure option - that way it can=
=0A=
> be automated in a clean way by anyone who builds the tlb from source=0A=
> (downstream).=0A=
=0A=
I understood your concern, I'll move this into configure, and make it searc=
h=0A=
the newest version of SDK installed (only if it is in the default path=0A=
(%PROGRAMFILES%\Microsoft SDKs\Windows\v*)).=0A=
=0A=
Thanks,=0A=
Tomoki Sekiyama=