All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zi Yan <ziy@nvidia.com>
To: Yang Shi <shy828301@gmail.com>
Cc: nao.horiguchi@gmail.com, mhocko@suse.com,
	kirill.shutemov@linux.intel.com, hughd@google.com,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mempolicy: don't have to split pmd for huge zero page
Date: Fri, 04 Jun 2021 17:23:51 -0400	[thread overview]
Message-ID: <DC3A8596-DC59-4B3B-8BA9-A0C2432552DF@nvidia.com> (raw)
In-Reply-To: <20210604203513.240709-1-shy828301@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

On 4 Jun 2021, at 16:35, Yang Shi wrote:

> When trying to migrate pages to obey mempolicy, the huge zero page is
> split then the page table walk at PTE level just skips zero page.  So it
> seems pointless to split huge zero page, it could be just skipped like
> base zero page.
>
> Set ACTION_CONTINUE to prevent the walk_page_range() split the pmd for
> this case.
>
> Signed-off-by: Yang Shi <shy828301@gmail.com>

LGTM. Thanks.

Reviewed-by: Zi Yan <ziy@nvidia.com>


—
Best Regards,
Yan, Zi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]

  reply	other threads:[~2021-06-04 21:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 20:35 [PATCH] mm: mempolicy: don't have to split pmd for huge zero page Yang Shi
2021-06-04 21:23 ` Zi Yan [this message]
2021-06-07  6:21 ` Michal Hocko
2021-06-07 17:00   ` Yang Shi
2021-06-07 17:00     ` Yang Shi
2021-06-07 18:41     ` Yang Shi
2021-06-07 18:41       ` Yang Shi
2021-06-07 18:55     ` Michal Hocko
2021-06-07 22:02       ` Yang Shi
2021-06-07 22:02         ` Yang Shi
2021-06-08  6:41         ` Michal Hocko
2021-06-08 17:15           ` Yang Shi
2021-06-08 17:15             ` Yang Shi
2021-06-08 17:49             ` Michal Hocko
2021-06-08 19:36               ` Yang Shi
2021-06-08 19:36                 ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DC3A8596-DC59-4B3B-8BA9-A0C2432552DF@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=nao.horiguchi@gmail.com \
    --cc=shy828301@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.