From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Liu, Chunmei" Subject: Re: [PATCH] fix ceph async messenger runtime bug based on spdk/dpdk Date: Wed, 13 Dec 2017 22:34:03 +0000 Message-ID: References: <1513193552-159561-1-git-send-email-chunmei.liu@intel.com> <20171213133100.530518bd@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: 'Stephen Hemminger' Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 74CC02030 for ; Wed, 13 Dec 2017 23:34:05 +0100 (CET) In-Reply-To: <20171213133100.530518bd@xeon-e3> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" But if not initialize allocated mbuf->next =3D NULL, when do ip package ass= emble, the last mbuf->next maybe not be null, all the logical has error, th= e application use null pointer determine a packaged end. DPDK NIC doesn't w= ork now. -----Original Message----- From: Stephen Hemminger [mailto:stephen@networkplumber.org]=20 Sent: Wednesday, December 13, 2017 1:31 PM To: Liu, Chunmei Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] fix ceph async messenger runtime bug based = on spdk/dpdk On Wed, 13 Dec 2017 11:32:32 -0800 chunmei Liu wrote: > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c=20 > b/drivers/net/ixgbe/ixgbe_rxtx.c index 1e07895..30fdbc1 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -1589,6 +1589,7 @@ ixgbe_rx_alloc_bufs(struct ixgbe_rx_queue *rxq, boo= l reset_mbuf) > } > =20 > rte_mbuf_refcnt_set(mb, 1); > + mb->next =3D NULL; > mb->data_off =3D RTE_PKTMBUF_HEADROOM; > =20 This will have measurable performance impact because the next pointer is on= the second cache line.