Re: [PATCH 2/4] ext4: support STATX_ATTR_VERITY

From: Andreas Dilger <adilger@dilger.ca>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org,
	Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-api@vger.kernel.org, David Howells <dhowells@redhat.com>,
	Theodore Ts'o <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,
	Victor Hsieh <victorhsieh@google.com>
Subject: Re: [PATCH 2/4] ext4: support STATX_ATTR_VERITY
Date: Wed, 30 Oct 2019 12:27:19 -0600	[thread overview]
Message-ID: <DC633400-06B3-4235-9AC6-0B9C5B373F86@dilger.ca> (raw)
In-Reply-To: <20191029204141.145309-3-ebiggers@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]


> On Oct 29, 2019, at 2:41 PM, Eric Biggers <ebiggers@kernel.org> wrote:
> 
> From: Eric Biggers <ebiggers@google.com>
> 
> Set the STATX_ATTR_VERITY bit when the statx() system call is used on a
> verity file on ext4.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>


> ---
> fs/ext4/inode.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 516faa280ceda8..a7ca6517798008 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -5717,12 +5717,15 @@ int ext4_getattr(const struct path *path, struct kstat *stat,
> 		stat->attributes |= STATX_ATTR_IMMUTABLE;
> 	if (flags & EXT4_NODUMP_FL)
> 		stat->attributes |= STATX_ATTR_NODUMP;
> +	if (flags & EXT4_VERITY_FL)
> +		stat->attributes |= STATX_ATTR_VERITY;
> 
> 	stat->attributes_mask |= (STATX_ATTR_APPEND |
> 				  STATX_ATTR_COMPRESSED |
> 				  STATX_ATTR_ENCRYPTED |
> 				  STATX_ATTR_IMMUTABLE |
> -				  STATX_ATTR_NODUMP);
> +				  STATX_ATTR_NODUMP |
> +				  STATX_ATTR_VERITY);
> 
> 	generic_fillattr(inode, stat);
> 	return 0;
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
> 


Cheers, Andreas


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]