From mboxrd@z Thu Jan  1 00:00:00 1970
From: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Date: Fri, 1 Feb 2019 09:38:53 +0100
Subject: [U-Boot] [U-Boot,
 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now
In-Reply-To: <201902010932116387593@rock-chips.com>
References: <20181229131641.131209-2-sjg@chromium.org>
 <E1gpJd4-0008JF-BU@mail.theobroma-systems.com>
 <201902010932116387593@rock-chips.com>
Message-ID: <DC771EC4-1BFC-4A02-9343-7689FDB07BD8@theobroma-systems.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

Andy,

> On 01.02.2019, at 02:32, andy.yan at rock-chips.com wrote:
> 
> Hi：
> 
> > This function causes a 5-second delay and stops the display working on
> > minnie. This code should be in a driver and should only be enabled by
> > a device-tree property, so that it does not affect devices which do not
> > have this feature.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > ---
> >
> >  arch/arm/mach-rockchip/boot_mode.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
>  
> 》Applied to u-boot-rockchip, thanks!
> 
> 
> According to the previous discussing， shouldn‘t this be fixed by  by setting CONFIG_BOOT_MODE_REG=0 ？
> All rockchip products need this function，we really don't want it be turned off.

The actual decision was that this needed to be converted to the driver-model.
Setting CONFIG_BOOT_MODE_REG=0 was a workaround that we used only
for 2019.1, so I could delay applying Simon’s patch until this cycle.

Please convert this into a DM driver, so we can add the driver for 2019.4.

Thanks,
Philipp.