* [PATCH 3/4] regulator: palmas: Removing duplicated code
@ 2013-02-18 5:14 J Keerthy
2013-02-18 8:24 ` Graeme Gregory
2013-02-27 18:35 ` Stephen Warren
0 siblings, 2 replies; 5+ messages in thread
From: J Keerthy @ 2013-02-18 5:14 UTC (permalink / raw)
To: broonie, lgirdwood, linux-kernel; +Cc: j-keerthy, gg
Removing duplicate assignment in the existing code.
Signed-off-by: J Keerthy <j-keerthy@ti.com>
---
drivers/regulator/palmas-regulator.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index c9e912f..22c6ae2 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -566,11 +566,6 @@ static void palmas_dt_to_pdata(struct device *dev,
pdata->reg_init[idx]->mode_sleep = prop;
ret = of_property_read_u32(palmas_matches[idx].of_node,
- "ti,warm_reset", &prop);
- if (!ret)
- pdata->reg_init[idx]->warm_reset = prop;
-
- ret = of_property_read_u32(palmas_matches[idx].of_node,
"ti,tstep", &prop);
if (!ret)
pdata->reg_init[idx]->tstep = prop;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/4] regulator: palmas: Removing duplicated code
2013-02-18 5:14 [PATCH 3/4] regulator: palmas: Removing duplicated code J Keerthy
@ 2013-02-18 8:24 ` Graeme Gregory
2013-02-18 8:34 ` J, KEERTHY
2013-02-27 18:35 ` Stephen Warren
1 sibling, 1 reply; 5+ messages in thread
From: Graeme Gregory @ 2013-02-18 8:24 UTC (permalink / raw)
To: J Keerthy; +Cc: broonie, lgirdwood, linux-kernel
On 18/02/13 05:14, J Keerthy wrote:
> Removing duplicate assignment in the existing code.
>
> Signed-off-by: J Keerthy <j-keerthy@ti.com>
> ---
> drivers/regulator/palmas-regulator.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
> index c9e912f..22c6ae2 100644
> --- a/drivers/regulator/palmas-regulator.c
> +++ b/drivers/regulator/palmas-regulator.c
> @@ -566,11 +566,6 @@ static void palmas_dt_to_pdata(struct device *dev,
> pdata->reg_init[idx]->mode_sleep = prop;
>
> ret = of_property_read_u32(palmas_matches[idx].of_node,
> - "ti,warm_reset", &prop);
> - if (!ret)
> - pdata->reg_init[idx]->warm_reset = prop;
> -
> - ret = of_property_read_u32(palmas_matches[idx].of_node,
> "ti,tstep", &prop);
> if (!ret)
> pdata->reg_init[idx]->tstep = prop;
This hunk has already been upstreamed by Axel Lin.
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commit;h=f33d0081ff3ffb7180a9794e60318458d7671b36
Graeme
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 3/4] regulator: palmas: Removing duplicated code
2013-02-18 8:24 ` Graeme Gregory
@ 2013-02-18 8:34 ` J, KEERTHY
0 siblings, 0 replies; 5+ messages in thread
From: J, KEERTHY @ 2013-02-18 8:34 UTC (permalink / raw)
To: Graeme Gregory; +Cc: broonie, lgirdwood, linux-kernel
> -----Original Message-----
> From: Graeme Gregory [mailto:gg@slimlogic.co.uk]
> Sent: Monday, February 18, 2013 1:54 PM
> To: J, KEERTHY
> Cc: broonie@opensource.wolfsonmicro.com; lgirdwood@gmail.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 3/4] regulator: palmas: Removing duplicated code
>
>
> On 18/02/13 05:14, J Keerthy wrote:
> > Removing duplicate assignment in the existing code.
> >
> > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > ---
> > drivers/regulator/palmas-regulator.c | 5 -----
> > 1 files changed, 0 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/regulator/palmas-regulator.c
> b/drivers/regulator/palmas-regulator.c
> > index c9e912f..22c6ae2 100644
> > --- a/drivers/regulator/palmas-regulator.c
> > +++ b/drivers/regulator/palmas-regulator.c
> > @@ -566,11 +566,6 @@ static void palmas_dt_to_pdata(struct device
> *dev,
> > pdata->reg_init[idx]->mode_sleep = prop;
> >
> > ret = of_property_read_u32(palmas_matches[idx].of_node,
> > - "ti,warm_reset", &prop);
> > - if (!ret)
> > - pdata->reg_init[idx]->warm_reset = prop;
> > -
> > - ret = of_property_read_u32(palmas_matches[idx].of_node,
> > "ti,tstep", &prop);
> > if (!ret)
> > pdata->reg_init[idx]->tstep = prop;
> This hunk has already been upstreamed by Axel Lin.
Ok. Thanks Graeme. I had missed this.
>
> http://git.kernel.org/?p=linux/kernel/git/next/linux-
> next.git;a=commit;h=f33d0081ff3ffb7180a9794e60318458d7671b36
>
> Graeme
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 3/4] regulator: palmas: Removing duplicated code
2013-02-18 5:14 [PATCH 3/4] regulator: palmas: Removing duplicated code J Keerthy
2013-02-18 8:24 ` Graeme Gregory
@ 2013-02-27 18:35 ` Stephen Warren
2013-02-28 5:22 ` J, KEERTHY
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Warren @ 2013-02-27 18:35 UTC (permalink / raw)
To: J Keerthy; +Cc: broonie, lgirdwood, linux-kernel, gg
On 02/17/2013 10:14 PM, J Keerthy wrote:
> Removing duplicate assignment in the existing code.
...
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
...
> @@ -566,11 +566,6 @@ static void palmas_dt_to_pdata(struct device *dev,
> pdata->reg_init[idx]->mode_sleep = prop;
>
> ret = of_property_read_u32(palmas_matches[idx].of_node,
> - "ti,warm_reset", &prop);
> - if (!ret)
> - pdata->reg_init[idx]->warm_reset = prop;
> -
> - ret = of_property_read_u32(palmas_matches[idx].of_node,
Can you point out where the duplicate of that is; I don't see any other
assignment to warm_reset.
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 3/4] regulator: palmas: Removing duplicated code
2013-02-27 18:35 ` Stephen Warren
@ 2013-02-28 5:22 ` J, KEERTHY
0 siblings, 0 replies; 5+ messages in thread
From: J, KEERTHY @ 2013-02-28 5:22 UTC (permalink / raw)
To: Stephen Warren; +Cc: broonie, lgirdwood, linux-kernel, gg
Hello Stephen,
> -----Original Message-----
> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
> Sent: Thursday, February 28, 2013 12:05 AM
> To: J, KEERTHY
> Cc: broonie@opensource.wolfsonmicro.com; lgirdwood@gmail.com; linux-
> kernel@vger.kernel.org; gg@slimlogic.co.uk
> Subject: Re: [PATCH 3/4] regulator: palmas: Removing duplicated code
>
> On 02/17/2013 10:14 PM, J Keerthy wrote:
> > Removing duplicate assignment in the existing code.
> ...
> > diff --git a/drivers/regulator/palmas-regulator.c
> > b/drivers/regulator/palmas-regulator.c
> ...
> > @@ -566,11 +566,6 @@ static void palmas_dt_to_pdata(struct device
> *dev,
> > pdata->reg_init[idx]->mode_sleep = prop;
> >
> > ret = of_property_read_u32(palmas_matches[idx].of_node,
> > - "ti,warm_reset", &prop);
> > - if (!ret)
> > - pdata->reg_init[idx]->warm_reset = prop;
> > -
> > - ret = of_property_read_u32(palmas_matches[idx].of_node,
>
> Can you point out where the duplicate of that is; I don't see any other
> assignment to warm_reset.
As pointed out by Graeme this is already fixed.
Regards,
Keerthy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-28 5:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-18 5:14 [PATCH 3/4] regulator: palmas: Removing duplicated code J Keerthy
2013-02-18 8:24 ` Graeme Gregory
2013-02-18 8:34 ` J, KEERTHY
2013-02-27 18:35 ` Stephen Warren
2013-02-28 5:22 ` J, KEERTHY
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.