All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Pascal Mazon <pascal.mazon@6wind.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Olga Shern <olgas@mellanox.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH v1] net/tap: fix isolation mode toggling
Date: Mon, 14 May 2018 22:28:35 +0000	[thread overview]
Message-ID: <DD0A156C-4F68-4EFF-BB2D-2C7362191DF3@intel.com> (raw)
In-Reply-To: <HE1PR0501MB2314D7EDBCCFA43A9B6F9509D19C0@HE1PR0501MB2314.eurprd05.prod.outlook.com>


>> 
>> Using double negation is not very readable IMO, I would prefer this
>> converted to a true boolean type if required.
>> 
> 
> Double negation usage was eliminated. 

Thanks I acked already.

> 
>> variable ‘set' here should a 0 or 1 already, please expand this code to not use
>> !!, using this in modern compilers should not be required. I understand this
>> maybe shorted to write, but not very readable IMO and we need to make
>> DPDK readable.
>> 

Regards,
Keith


  reply	other threads:[~2018-05-14 22:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07  8:36 [PATCH v1] net/tap: fix isolation mode toggling Ophir Munk
2018-05-14 12:32 ` Wiles, Keith
2018-05-14 22:20   ` Ophir Munk
2018-05-14 22:28     ` Wiles, Keith [this message]
2018-05-14 22:11 ` [PATCH v2] " Ophir Munk
2018-05-14 22:18   ` Wiles, Keith
2018-05-14 22:19     ` Ophir Munk
2018-05-14 22:26   ` [PATCH v3] " Ophir Munk
2018-05-14 22:46     ` Wiles, Keith
2018-05-17 14:13       ` [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DD0A156C-4F68-4EFF-BB2D-2C7362191DF3@intel.com \
    --to=keith.wiles@intel.com \
    --cc=dev@dpdk.org \
    --cc=olgas@mellanox.com \
    --cc=ophirmu@mellanox.com \
    --cc=pascal.mazon@6wind.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.