From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751076AbdEaJHK (ORCPT ); Wed, 31 May 2017 05:07:10 -0400 Received: from mga14.intel.com ([192.55.52.115]:9681 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbdEaJHI (ORCPT ); Wed, 31 May 2017 05:07:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,422,1491289200"; d="scan'208";a="268405565" From: "Chen, Xiaoguang" To: Gerd Hoffmann , "alex.williamson@redhat.com" , "chris@chris-wilson.co.uk" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "zhenyuw@linux.intel.com" , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" , "Tian, Kevin" Subject: RE: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Thread-Topic: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Thread-Index: AQHS1sTYUmbVcDeCvUyKFGcQMRiB9KIMKfYAgAGTeiD//+dGAIAAhxxA Date: Wed, 31 May 2017 09:07:02 +0000 Message-ID: References: <1495874332-2851-1-git-send-email-xiaoguang.chen@intel.com> <1496139820.4100.3.camel@redhat.com> <1496221156.4100.10.camel@redhat.com> In-Reply-To: <1496221156.4100.10.camel@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4V97Rd4012337 Hi Gerd, I found this problem once I sent the patches :( I checked the uapi definitions and found it is usually called pad to do the aligning. So I changed the 'resv' to 'pad' in the patch but forgot to update it in the last patch and did not test after the "small" change. Next time I will test even when the change is very small. I will change this in the next version. Sorry for the mistake. >-----Original Message----- >From: Gerd Hoffmann [mailto:kraxel@redhat.com] >Sent: Wednesday, May 31, 2017 4:59 PM >To: Chen, Xiaoguang ; >alex.williamson@redhat.com; chris@chris-wilson.co.uk; intel- >gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; >zhenyuw@linux.intel.com; Lv, Zhiyuan ; intel-gvt- >dev@lists.freedesktop.org; Wang, Zhi A ; Tian, Kevin > >Subject: Re: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g > >On Wed, 2017-05-31 at 02:29 +0000, Chen, Xiaoguang wrote: >> Hi Gerd, >> >> It is based on 4.12.0-rc1 > >Applies, good. >But then fails to build: > >error: ‘struct vfio_vgpu_dmabuf_info’ has no member named ‘resv’ > >gvt/kvmgt.c:611:11: note: in expansion of macro ‘offsetofend’ >   minsz = offsetofend(struct vfio_vgpu_dmabuf_info, resv); > >/me wonders how this was tested ... > >cheers, > Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Xiaoguang" Subject: Re: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Date: Wed, 31 May 2017 09:07:02 +0000 Message-ID: References: <1495874332-2851-1-git-send-email-xiaoguang.chen@intel.com> <1496139820.4100.3.camel@redhat.com> <1496221156.4100.10.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1496221156.4100.10.camel@redhat.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Gerd Hoffmann , "alex.williamson@redhat.com" , "chris@chris-wilson.co.uk" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "zhenyuw@linux.intel.com" , "Lv, Zhiyuan" , "intel-gvt-dev@lists.freedesktop.org" , "Wang, Zhi A" , "Tian, Kevin" List-Id: intel-gfx@lists.freedesktop.org SGkgR2VyZCwNCg0KSSBmb3VuZCB0aGlzIHByb2JsZW0gb25jZSBJIHNlbnQgdGhlIHBhdGNoZXMg OigNCg0KSSBjaGVja2VkIHRoZSB1YXBpIGRlZmluaXRpb25zIGFuZCBmb3VuZCBpdCBpcyB1c3Vh bGx5IGNhbGxlZCBwYWQgdG8gZG8gdGhlIGFsaWduaW5nLiBTbyBJIGNoYW5nZWQgdGhlICdyZXN2 JyB0byAncGFkJyBpbiB0aGUgcGF0Y2ggYnV0IGZvcmdvdCB0byB1cGRhdGUgaXQgaW4gdGhlIGxh c3QgcGF0Y2ggYW5kIGRpZCBub3QgdGVzdCBhZnRlciB0aGUgInNtYWxsIiBjaGFuZ2UuIE5leHQg dGltZSBJIHdpbGwgdGVzdCBldmVuIHdoZW4gdGhlIGNoYW5nZSBpcyB2ZXJ5IHNtYWxsLg0KDQpJ IHdpbGwgY2hhbmdlIHRoaXMgaW4gdGhlIG5leHQgdmVyc2lvbi4NClNvcnJ5IGZvciB0aGUgbWlz dGFrZS4NCg0KPi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+RnJvbTogR2VyZCBIb2ZmbWFu biBbbWFpbHRvOmtyYXhlbEByZWRoYXQuY29tXQ0KPlNlbnQ6IFdlZG5lc2RheSwgTWF5IDMxLCAy MDE3IDQ6NTkgUE0NCj5UbzogQ2hlbiwgWGlhb2d1YW5nIDx4aWFvZ3VhbmcuY2hlbkBpbnRlbC5j b20+Ow0KPmFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tOyBjaHJpc0BjaHJpcy13aWxzb24uY28u dWs7IGludGVsLQ0KPmdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2Vy Lmtlcm5lbC5vcmc7DQo+emhlbnl1d0BsaW51eC5pbnRlbC5jb207IEx2LCBaaGl5dWFuIDx6aGl5 dWFuLmx2QGludGVsLmNvbT47IGludGVsLWd2dC0NCj5kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn OyBXYW5nLCBaaGkgQSA8emhpLmEud2FuZ0BpbnRlbC5jb20+OyBUaWFuLCBLZXZpbg0KPjxrZXZp bi50aWFuQGludGVsLmNvbT4NCj5TdWJqZWN0OiBSZTogW1BBVENIIHY2IDAvNl0gZHJtL2k5MTUv Z3Z0OiBEbWEtYnVmIHN1cHBvcnQgZm9yIEdWVC1nDQo+DQo+T24gV2VkLCAyMDE3LTA1LTMxIGF0 IDAyOjI5ICswMDAwLCBDaGVuLCBYaWFvZ3Vhbmcgd3JvdGU6DQo+PiBIaSBHZXJkLA0KPj4NCj4+ IEl0IGlzIGJhc2VkIG9uIDQuMTIuMC1yYzENCj4NCj5BcHBsaWVzLCBnb29kLg0KPkJ1dCB0aGVu IGZhaWxzIHRvIGJ1aWxkOg0KPg0KPmVycm9yOiDigJhzdHJ1Y3QgdmZpb192Z3B1X2RtYWJ1Zl9p bmZv4oCZIGhhcyBubyBtZW1iZXIgbmFtZWQg4oCYcmVzduKAmQ0KPg0KPmd2dC9rdm1ndC5jOjYx MToxMTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvIOKAmG9mZnNldG9mZW5k4oCZDQo+wqDC oMKgbWluc3ogPSBvZmZzZXRvZmVuZChzdHJ1Y3QgdmZpb192Z3B1X2RtYWJ1Zl9pbmZvLCByZXN2 KTsNCj4NCj4vbWUgd29uZGVycyBob3cgdGhpcyB3YXMgdGVzdGVkIC4uLg0KPg0KPmNoZWVycywN Cj4gIEdlcmQNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=