All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Romain Naour <romain.naour@gmail.com>,
	Will Newton <will.newton@gmail.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/gcc: define _REENTRANT for OpenRISC when -pthread is passed
Date: Wed, 19 Jan 2022 09:14:48 +0100	[thread overview]
Message-ID: <DDA3B9CA-4DF9-4E3E-8B23-B62D04711735@benettiengineering.com> (raw)
In-Reply-To: <20220119085411.22ee6fb6@windsurf>

Hi Thomas, All,

> Il giorno 19 gen 2022, alle ore 08:56, Thomas Petazzoni <thomas.petazzoni@bootlin.com> ha scritto:
> 
> Hello Fabrice,
> 
>> On Tue, 18 Jan 2022 23:24:24 +0100
>> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>> 
>> Patch added by commit eee96b0f0ad224b3e09a9b98c26d056e18f17fd5 on gcc
>> 9.3.0 must also be applied on gcc 10 and 11 to avoid the following build
>> failure on numerous packages (babeltrace2, pcsc-lite, tpm2-pkcs11,
>> etc.):
>> 
>> configure:13774: checking whether pthreads work with -pthread
>> configure:13868: /home/giuliobenetti/autobuild/run/instance-0/output-1/host/bin/or1k-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os -g2  -std=gnu99 -pthread -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  conftest.c   >&5
>> conftest.c:27:26: error: #error "_REENTRANT must be defined"
>>   27 | #                        error "_REENTRANT must be defined"
>>      |                          ^~~~~
>> 
>> It should be noted that external bootlins will have to be rebuilt.
>> 
>> Fixes:
>> - http://autobuild.buildroot.org/results/cb58d4fbaeb08d188c2f8bf05ef1604789fa8766
>> - http://autobuild.buildroot.org/results/7af9d4b68bd46ed260ed66ba2cc3c9c21482e741
>> - http://autobuild.buildroot.org/results/6f926bec146752873f8032b593f0de1cb222ea46
>> 
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> 
> Wow, this patch still hasn't been accepted in upstream gcc? It's been
> submitted a looong time ago I believe.

That’s when the new maintainer took over the previous one. I ping him about this so he can commit it. YetAnotherOr1kBug :-)

Best regards
Giulio

> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-01-19  8:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18 22:24 [Buildroot] [PATCH 1/2] package/gcc: define _REENTRANT for OpenRISC when -pthread is passed Fabrice Fontaine
2022-01-18 22:24 ` [Buildroot] [PATCH 2/2] Revert "package/libmicrohttpd: fix pthread detection" Fabrice Fontaine
2022-01-19  7:54 ` [Buildroot] [PATCH 1/2] package/gcc: define _REENTRANT for OpenRISC when -pthread is passed Thomas Petazzoni
2022-01-19  8:13   ` Stafford Horne
2022-01-19  8:16     ` Giulio Benetti
2022-01-19  8:14   ` Giulio Benetti [this message]
2022-01-22 14:36 ` Thomas Petazzoni
2022-01-28 20:05 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DDA3B9CA-4DF9-4E3E-8B23-B62D04711735@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=will.newton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.