From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Tomsich Date: Wed, 28 Nov 2018 10:25:46 +0100 Subject: [U-Boot] EXT: [PATCH v2 0/2] Update RV3029 driver to DM and add DM-backed bootcount support In-Reply-To: References: <1543356019-47135-1-git-send-email-philipp.tomsich@theobroma-systems.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de > On 28.11.2018, at 07:29, Ray, Ian (GE Healthcare) wrote: > > > >> On 28 Nov 2018, at 0.00, Philipp Tomsich wrote: >> >> >> On one of our application-specific carrier boards, a MicroCrystal >> RV3029 acts as an off-module battery-backed RTC for the RK3399-Q7. >> The RV3029 is intended both to provide RTC services (to Linux) and >> to store the bootcount in its battery-backed SRAM section. >> >> To support this use-case, this series adds the following: >> * replaces the existing RV3029 driver by a DM-based one (note that the >> existing driver appears unused and didn't even have a Kconfig entry) >> that closely mirrors its incarnation in Linux 4.17 > > While true in v1, drivers/rtc/rv3029.c is not modified in this patchset. Good point. The cover letter needs updating (or I need to avoid last-minute decisions to split a series…). The RV3029 changes have been split off into the following series: https://patchwork.ozlabs.org/project/uboot/list/?series=78378 I’ll wait for comments and repost with an updated coverletter after those, if necessary. >> * adds a bootcount-method interfacing back into DM devices (implementing >> support for the RTC uclass as of now). >> >> >> Changes in v2: >> - changed to provide a UCLASS-based implementation, as requested by >> SJG in his earlier review >> - split off the RV3029 driver into a separate series >> >> Philipp Tomsich (2): >> bootcount: add uclass for bootcount >> bootcount: add a DM RTC backing store for bootcount >> > > Reviewed-by: Ian Ray > > >> doc/device-tree-bindings/chosen.txt | 30 ++++++++++++ >> drivers/bootcount/Kconfig | 28 +++++++++++ >> drivers/bootcount/Makefile | 3 ++ >> drivers/bootcount/bootcount-uclass.c | 93 ++++++++++++++++++++++++++++++++++++ >> drivers/bootcount/rtc.c | 89 ++++++++++++++++++++++++++++++++++ >> include/bootcount.h | 48 +++++++++++++++++++ >> include/dm/uclass-id.h | 1 + >> 7 files changed, 292 insertions(+) >> create mode 100644 drivers/bootcount/bootcount-uclass.c >> create mode 100644 drivers/bootcount/rtc.c >> >> -- >> 2.1.4 >> >