From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yongseok Koh Subject: Re: [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer Date: Fri, 8 Mar 2019 02:05:02 +0000 Message-ID: References: <20190109085426.39965-1-yskoh@mellanox.com> <20190114211622.6900-1-yskoh@mellanox.com> <20190114211622.6900-2-yskoh@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Olivier Matz , Shahaf Shuler , dev , Andrew Rybchenko , Rami Rosen , David Marchand , "stable@dpdk.org" To: Kevin Traynor Return-path: In-Reply-To: Content-Language: en-US Content-ID: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Oops, I missed this email somehow, probably out of mind during my long vacation. :-) I've also encountered this issue with 17.11.6. http://git.dpdk.org/dpdk-stable/commit/?h=3D17.11&id=3D63f06f3fccc87c55adb3= 3248e5c68a0175d213f1 I'll send a backport to you. Sorry for late reply. Yongseok > On Feb 21, 2019, at 11:10 AM, Kevin Traynor wrote: >=20 > Hi Yongseok, >=20 > Can you let me know how you want to proceed with the below. I think we > could just drop as it's a performance optimization, or maybe you have a > different idea. >=20 > thanks, > Kevin. >=20 > On 06/02/2019 15:54, Kevin Traynor wrote: >> On 01/14/2019 09:16 PM, Yongseok Koh wrote: >>> On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't need= ed >>> to be accessed as it is static and easily calculated from the mbuf addr= ess. >>> Accessing the mbuf content causes unnecessary load stall and it is wors= ened >>> on ARM. >>>=20 >>> Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SSE Rx") >>> Cc: stable@dpdk.org >>>=20 >>=20 >> This is using the API introduced in 1/2, so it's not really suitable for >> backport. Maybe you want to send an alternative for stable? >>=20 >>> Signed-off-by: Yongseok Koh >>> Acked-by: Shahaf Shuler >>> --- >=20