All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Lindig <christian.lindig@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <Ian.Jackson@citrix.com>,
	Jonathan Ludlam <Jonathan.Ludlam@citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	"dave@recoil.org" <dave@recoil.org>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH for-4.9 0/2] oxenstored: make it work on FreeBSD
Date: Tue, 18 Apr 2017 10:11:20 +0000	[thread overview]
Message-ID: <DE864954-F373-49F2-85E9-2123CF26F69C@citrix.com> (raw)
In-Reply-To: <20170418095955.y7kf4gkamlgux7es@citrix.com>


> On 18. Apr 2017, at 10:59, Wei Liu <wei.liu2@citrix.com> wrote:
> 
> Forgive my ignorance for the Ocaml ecosystem, but I can't seem to find a
> way to conditionally compile ocaml source code easily.
> 
> Presumably you mean "Determine the path at *configure* time"?  Even if
> we make those configurable, there should still be two default values in
> define.ml -- what should they be?

Sorry for the confusion. I was conflating configure time and compile times. The configure step could provide the correct paths in the config file that is read at startup. I would definitely avoid conditional compilation.

— Christian
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-04-18 10:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 10:20 [PATCH for-4.9 0/2] oxenstored: make it work on FreeBSD Wei Liu
2017-04-14 10:20 ` [PATCH for-4.9 1/2] oxenstored: add an Unix syscall C extension Wei Liu
2017-04-18 10:14   ` Ian Jackson
2017-04-14 10:20 ` [PATCH for-4.9 2/2] oxenstored: make it work on FreeBSD Wei Liu
2017-04-14 10:32   ` [PATCH for-4.9] oxenstored: remove "_proc" in names Wei Liu
2017-04-18 10:15     ` Ian Jackson
2017-04-18 10:16   ` [PATCH for-4.9 2/2] oxenstored: make it work on FreeBSD Ian Jackson
2017-04-18 10:22     ` Christian Lindig
2017-04-18  9:46 ` [PATCH for-4.9 0/2] " Christian Lindig
2017-04-18  9:59   ` Wei Liu
2017-04-18 10:11     ` Christian Lindig [this message]
2017-04-18 10:11     ` Christian Lindig
2017-04-18 13:07       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DE864954-F373-49F2-85E9-2123CF26F69C@citrix.com \
    --to=christian.lindig@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=Jonathan.Ludlam@citrix.com \
    --cc=dave@recoil.org \
    --cc=julien.grall@arm.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.