From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: "kusumi.tomohiro@gmail.com" <kusumi.tomohiro@gmail.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"fio@vger.kernel.org" <fio@vger.kernel.org>
Cc: Tomohiro Kusumi <tkusumi@tuxera.com>
Subject: RE: [PATCH 2/6] configure: Use x86 instead of i386 for $cpu for IA32
Date: Mon, 13 Feb 2017 19:24:15 +0000 [thread overview]
Message-ID: <DF4PR84MB01697A35FA0838226A39B300AB590@DF4PR84MB0169.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20170213163239.46188-2-tkusumi@tuxera.com>
> -----Original Message-----
> From: fio-owner@vger.kernel.org [mailto:fio-owner@vger.kernel.org] On
> Behalf Of kusumi.tomohiro@gmail.com
> Sent: Monday, February 13, 2017 10:33 AM
> To: axboe@kernel.dk; fio@vger.kernel.org
> Cc: Tomohiro Kusumi <tkusumi@tuxera.com>
> Subject: [PATCH 2/6] configure: Use x86 instead of i386 for $cpu for IA32
>
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> fio internally uses "x86" for any sort of IA32, so use x86 for $cpu
> as well which gets printed on ./configure.
That's the gcc cpu_type, and derives from the __i386__ macro value
that configure is checking for. All the other architectures stay with
the cpu_type name at this level.
> # grep i386 . -rI
> ./arch/arch.h:#if defined(__i386__)
> ./configure:elif check_define __i386__ ; then
> ./configure: cpu="i386"
> ./configure: i386|i486|i586|i686|i86pc|BePC)
> ./configure: cpu="i386"
> ./crc/sha1.c:#if defined(__i386__) || defined(__x86_64__)
> ./crc/xxhash.c:#if defined(__ARM_FEATURE_UNALIGNED) ||
> defined(__i386) || defined(_M_IX86) || defined(__x86_64__) ||
> defined(_M_X64)
That search points out crc/xxhash.c is missing the trailing __ on the
__i386__ macro, which seems like a bug.
The search should have also found this in arch/arch-x86.h:
#define FIO_ARCH (arch_i386)
and an enum arch/arch.h:
enum {
arch_i386,
I think they would also need to be changed, if the change is made.
FIO_ARCH is used by gfio in the Architecture box.
---
Robert Elliott, HPE Persistent Memory
next prev parent reply other threads:[~2017-02-13 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 16:32 [PATCH 1/6] configure: Drop default CONFIG_LITTLE_ENDIAN for Cygwin kusumi.tomohiro
2017-02-13 16:32 ` [PATCH 2/6] configure: Use x86 instead of i386 for $cpu for IA32 kusumi.tomohiro
2017-02-13 19:24 ` Elliott, Robert (Persistent Memory) [this message]
2017-02-13 19:34 ` Tomohiro Kusumi
2017-02-13 16:32 ` [PATCH 3/6] Drop conditional declaration of disk_list kusumi.tomohiro
2017-02-13 16:32 ` [PATCH 4/6] Always set ->real_file_size to -1 when failed to get file size kusumi.tomohiro
2017-02-13 16:32 ` [PATCH 5/6] Acquire file ->lock while the lock itself is being copied kusumi.tomohiro
2017-02-13 19:49 ` Jens Axboe
2017-02-13 20:03 ` Tomohiro Kusumi
2017-02-13 16:32 ` [PATCH 6/6] Add missing "rand"/"trimwrite" strings to corresponding ddir slots kusumi.tomohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF4PR84MB01697A35FA0838226A39B300AB590@DF4PR84MB0169.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=tkusumi@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.