From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426522AbcFIEel (ORCPT ); Thu, 9 Jun 2016 00:34:41 -0400 Received: from mail-by2on0136.outbound.protection.outlook.com ([207.46.100.136]:16730 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932385AbcFIEej convert rfc822-to-8bit (ORCPT ); Thu, 9 Jun 2016 00:34:39 -0400 From: "Elliott, Robert (Persistent Memory)" To: Andi Kleen , "x86@kernel.org" CC: "linux-kernel@vger.kernel.org" , Andi Kleen Subject: RE: [PATCH] x86/microcode/intel: Quieten down microcode updates on large systems Thread-Topic: [PATCH] x86/microcode/intel: Quieten down microcode updates on large systems Thread-Index: AQHRu79ZIGXob/VdkEOltyFqwSNfUp/gl/kg Date: Thu, 9 Jun 2016 04:34:35 +0000 Message-ID: References: <1464729764-108209-1-git-send-email-andi@firstfloor.org> In-Reply-To: <1464729764-108209-1-git-send-email-andi@firstfloor.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=elliott@hpe.com; x-originating-ip: [73.206.127.124] x-ms-office365-filtering-correlation-id: 0e8acd46-00f2-4b04-2dee-08d3901f5c49 x-microsoft-exchange-diagnostics: 1;DF4PR84MB0170;5:1RrcdNclieXN8GrOzfHAsM/HjtFXWstm7CHZGdiij77fh5ivMsJHUTABIud5lUoT3HZ9OCTZ+g6xzBZnND8lTu1I2tjM6Ogu59GPKswWKsYKGiCI4oJ4568kY+hbULTMV1MlNPDzUz7igfkjc4Osww==;24:BZrAJP7N9NbUjVUkNnCXU+GcEKrV67OVVlM7spCYR2o5D6/DP1Z9sWi/BB8uLZLxIzTXgmTKUA64aqenDY/nMDEZUjgrzNIIM4tmcMqP6jU=;7:vadHqs+zfFywzck6b9xnaeMhFRwqJYMoqr02R4hDjb4YRJ0jzyT602ZGSlbLIMJQsvarzlSCYZnQ1fq5Z7YkH5zRFsO4u519uVQ5ro4T4xXds1qX/fFcB+1mcgeyU0C81EwKnmvOxytkpoW4S8cMhiyz3kGmzaU07HM8VOYQFawEKF8Zc4QSXYEK7/JYgrlzqTen61fIRSrHgbNgGr1WN+TG76aQN9KA/AsJDVp91nY= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DF4PR84MB0170; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DF4PR84MB0170;BCL:0;PCL:0;RULEID:;SRVR:DF4PR84MB0170; x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(189002)(199003)(13464003)(2950100001)(33656002)(106116001)(5001770100001)(66066001)(106356001)(189998001)(68736007)(3846002)(6116002)(77096005)(2501003)(102836003)(101416001)(2900100001)(10400500002)(3280700002)(5004730100002)(87936001)(97736004)(99286002)(105586002)(50986999)(54356999)(76176999)(5008740100001)(8936002)(5003600100002)(3660700001)(4326007)(8676002)(81166006)(9686002)(19580405001)(586003)(92566002)(81156014)(19580395003)(2906002)(11100500001)(122556002)(5002640100001)(15650500001)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0170;H:DF4PR84MB0169.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2016 04:34:35.4651 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0170 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of Andi Kleen > Sent: Tuesday, May 31, 2016 4:23 PM > To: x86@kernel.org > Cc: linux-kernel@vger.kernel.org; Andi Kleen > Subject: [PATCH] x86/microcode/intel: Quieten down microcode updates > on large systems ... > diff --git a/arch/x86/kernel/cpu/microcode/intel.c > @@ -808,8 +809,14 @@ static int collect_cpu_info(int cpu_num, struct > cpu_signature *csig) > } > > csig->rev = c->microcode; > - pr_info("CPU%d sig=0x%x, pf=0x%x, revision=0x%x\n", > - cpu_num, csig->sig, csig->pf, csig->rev); > + > + /* No extra locking on prev, races are harmless. */ > + if (csig->sig != prev.sig || csig->pf != prev.pf || > + csig->rev != prev.rev) { > + pr_info("CPU sig=0x%x, pf=0x%x, revision=0x%x\n", > + csig->sig, csig->pf, csig->rev); > + prev = *csig; > + } ... > - pr_info("CPU%d updated to revision 0x%x, date = %04x-%02x- > %02x\n", > - cpu, val[1], > - mc->hdr.date & 0xffff, > - mc->hdr.date >> 24, > - (mc->hdr.date >> 16) & 0xff); > + if (val[1] != prev_rev) { > + pr_info("CPU updated to revision 0x%x, date = %04x-%02x- > %02x\n", "CPU(s)" would help convey that the messages now apply to one or more CPUs.