On May 25, 2018 6:54:12 AM GMT+03:00, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>On 24-05-18, 18:03, Ilia Lin wrote:
>> +static int __init qcom_cpufreq_kryo_init(void)
>> +{
>> + struct device_node *np;
>> + struct device *cpu_dev;
>> + int ret;
>> +
>> + cpu_dev = get_cpu_device(0);
>> + if (NULL == cpu_dev)
>> + ret = -ENODEV;
>> +
>> + np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
>> + if (IS_ERR(np))
>> + return PTR_ERR(np);
>> +
>> + ret = of_device_is_compatible(np, "operating-points-v2-kryo-cpu");
>> + of_node_put(np);
>> + if (!ret)
>> + return -ENOENT;
>> +
>
>I hate the fact that it is taking so long to get done with this. But
>can't you
>just check machine compatibility instead of this complicated setup to
>check OPP
>node ? Like:
>
> if (!of_device_is_compatible("qcom,apq8096") &&
> !of_device_is_compatible("qcom,msm8996"))
> return;

I have to check the "operating-points-v2-kryo-cpu" anyway, so I moved it from probe to the init.

>
>And please see if you can add an entry in MAINTAINERS and add your
>working email
>id there.

Sure. Should this be part of the patch itself?