All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ludkiewicz, Adam <adam.ludkiewicz@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S2-V2 10/12] i40e: Report advertised link modes on 40GBASE_SR4
Date: Tue, 12 Feb 2019 09:41:59 +0000	[thread overview]
Message-ID: <DF8E614BFAF5EA4981FDD45CE6FAFAED3661BEEF@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20190206230826.24970-10-alice.michael@intel.com>

ACK

-----Original Message-----
From: Michael, Alice 
Sent: Thursday, February 7, 2019 12:08 AM
To: Michael, Alice <alice.michael@intel.com>; intel-wired-lan at lists.osuosl.org
Cc: Ludkiewicz, Adam <adam.ludkiewicz@intel.com>
Subject: [next PATCH S2-V2 10/12] i40e: Report advertised link modes on 40GBASE_SR4

From: Adam Ludkiewicz <adam.ludkiewicz@intel.com>

Defined the advertised link mode field for 40000baseSR4_Full for use with ethtool.

Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 4e347637e36a..14b52f8aedd0 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -535,9 +535,12 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf,
 			ethtool_link_ksettings_add_link_mode(ks, advertising,
 							     1000baseT_Full);
 	}
-	if (phy_types & I40E_CAP_PHY_TYPE_40GBASE_SR4)
+	if (phy_types & I40E_CAP_PHY_TYPE_40GBASE_SR4) {
 		ethtool_link_ksettings_add_link_mode(ks, supported,
 						     40000baseSR4_Full);
+		ethtool_link_ksettings_add_link_mode(ks, advertising,
+						     40000baseSR4_Full);
+	}
 	if (phy_types & I40E_CAP_PHY_TYPE_40GBASE_LR4)
 		ethtool_link_ksettings_add_link_mode(ks, supported,
 						     40000baseLR4_Full);
@@ -724,6 +727,8 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,
 	case I40E_PHY_TYPE_40GBASE_SR4:
 		ethtool_link_ksettings_add_link_mode(ks, supported,
 						     40000baseSR4_Full);
+		ethtool_link_ksettings_add_link_mode(ks, advertising,
+						     40000baseSR4_Full);
 		break;
 	case I40E_PHY_TYPE_40GBASE_LR4:
 		ethtool_link_ksettings_add_link_mode(ks, supported,
--
2.19.2

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.


  reply	other threads:[~2019-02-12  9:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-06 23:08 [Intel-wired-lan] [next PATCH S2-V2 01/12] i40e: Queues are reserved despite "Invalid argument" error Alice Michael
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 02/12] i40e: Implement DDP support in i40e driver Alice Michael
2019-02-13 20:14   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 03/12] i40e: don't allow changes to HW vlan stripping on active port vlans Alice Michael
2019-03-02  0:00   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 04/12] i40e: save PTP time before a device reset Alice Michael
2019-02-12 19:51   ` Keller, Jacob E
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 05/12] i40e: Fix for 10G ports LED not blinking Alice Michael
2019-02-13 20:15   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 06/12] i40e: Update i40e_init_dcb to return correct error Alice Michael
2019-02-13 20:16   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 07/12] i40e: Remove misleading messages for untrusted VF Alice Michael
2019-02-13 20:16   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 08/12] i40e: Changed maximum supported FW API version to 1.8 Alice Michael
2019-02-13 20:17   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 09/12] i40e: The driver now prints the API version in error message Alice Michael
2019-02-12  9:41   ` Ludkiewicz, Adam
2019-02-13 20:17   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 10/12] i40e: Report advertised link modes on 40GBASE_SR4 Alice Michael
2019-02-12  9:41   ` Ludkiewicz, Adam [this message]
2019-02-13 20:21   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 11/12] i40e: Able to add up to 16 MAC filters on an untrusted VF Alice Michael
2019-02-13 20:24   ` Bowers, AndrewX
2019-02-06 23:08 ` [Intel-wired-lan] [next PATCH S2-V2 12/12] i40e: Fix misleading error message Alice Michael
2019-02-13 20:24   ` Bowers, AndrewX
2019-02-13 18:57 ` [Intel-wired-lan] [next PATCH S2-V2 01/12] i40e: Queues are reserved despite "Invalid argument" error Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF8E614BFAF5EA4981FDD45CE6FAFAED3661BEEF@irsmsx105.ger.corp.intel.com \
    --to=adam.ludkiewicz@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.