From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbeCMSj2 (ORCPT ); Tue, 13 Mar 2018 14:39:28 -0400 Received: from mail-cys01nam02on0083.outbound.protection.outlook.com ([104.47.37.83]:56672 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751996AbeCMSjY (ORCPT ); Tue, 13 Mar 2018 14:39:24 -0400 From: Jolly Shah To: Rob Herring CC: "mturquette@baylibre.com" , "sboyd@codeaurora.org" , "michal.simek@xilinx.com" , "mark.rutland@arm.com" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , Shubhrajyoti Datta , "linux-kernel@vger.kernel.org" , Rajan Vaja , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP clock driver Thread-Topic: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP clock driver Thread-Index: AQHTsONzi5kT5xZmx0aJGWwSpBvQuKPCd+2AgALw7dCAACyGAIAI+snw Date: Tue, 13 Mar 2018 18:39:13 +0000 Message-ID: References: <1519856861-31384-1-git-send-email-jollys@xilinx.com> <1519856861-31384-3-git-send-email-jollys@xilinx.com> <20180306014549.6t3ae5adzc3cpi5v@rob-hp-laptop> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: x-originating-ip: [149.199.62.254] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM2PR0201MB0862;7:WfcFzY0F+ecgKE6GWEGyqvjRLiVZNDzLEI+Cqe3M5szpiltSIBRZCvIvWDTsSwtPX8/XfVk6ZtXSD2Ji64YlWQvrGDDqAJ5T3IXmDZGtVM6jlOshldo4NYExactaPWdRX6GVi42hkxQ4Fel8gnzNwU/68ixpw1Of6YcbQpMtl+wdHb7TOvKS5TMKPXZ7mr6QH4j7Qd99EO/y44oFba1wUsoG9ZCh/CAkbqllkwZWQskJUounFOnkv5aFWl3PyCcU x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(39860400002)(396003)(366004)(39380400002)(346002)(376002)(199004)(189003)(13464003)(26005)(6436002)(54906003)(229853002)(4326008)(3280700002)(9686003)(186003)(2906002)(76176011)(3660700001)(5250100002)(93886005)(55016002)(105586002)(5660300001)(68736007)(7696005)(316002)(6916009)(86362001)(6506007)(53546011)(2950100002)(99286004)(72206003)(33656002)(102836004)(2900100001)(8936002)(66066001)(478600001)(305945005)(97736004)(74316002)(14454004)(7736002)(25786009)(6116002)(8676002)(106356001)(3846002)(6246003)(81156014)(53936002)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0201MB0862;H:DM2PR0201MB0767.namprd02.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b09e9136-0444-46c4-dfbb-08d58911b80b x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DM2PR0201MB0862; x-ms-traffictypediagnostic: DM2PR0201MB0862: authentication-results: spf=none (sender IP is ) smtp.mailfrom=JOLLYS@xilinx.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(9452136761055)(258649278758335)(192813158149592); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231221)(944501244)(52105095)(10201501046)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011);SRVR:DM2PR0201MB0862;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0201MB0862; x-forefront-prvs: 0610D16BBE x-microsoft-antispam-message-info: LhX2IfVUkFoolyjWSFTrO3Dfif+PkXx4gZ2pj9r7RyA5tNOcJ0siwQ/FwUR9ogfEWxeKlgcDwZ9jmcSGk9/Jk6X+G65LkY9d2u39T0XfJeVsmkrl448Y4gKSu0zDfcQFCkfQPc+thccVu/A8hZx9IyCsQKxzDAOlAhTIElWZRv7b8u8tDSzttc1T8Fdt1naHqcenvVpwHFdK310ATSXTg5hGPXJd+JcEytibgcBnWGmQTP/On3JQwc8Sw8RquRQNOuqzbgIpR0Fif4D+81r4K8JqDJhL5EuG0U1rzWcjv2o5G+AZpVUSNT8LaseOsl/5R8HRO3KKa0KDtRG5eJAvUQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: b09e9136-0444-46c4-dfbb-08d58911b80b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2018 18:39:13.5997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB0862 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w2DIdVes006471 Hi Rob, > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: Wednesday, March 07, 2018 5:20 PM > To: Jolly Shah > Cc: mturquette@baylibre.com; sboyd@codeaurora.org; > michal.simek@xilinx.com; mark.rutland@arm.com; linux-clk@vger.kernel.org; > devicetree@vger.kernel.org; Shubhrajyoti Datta ; linux- > kernel@vger.kernel.org; Rajan Vaja ; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP clock > driver > > On Wed, Mar 7, 2018 at 4:47 PM, Jolly Shah wrote: > > Hi Rob, > > > > > >> -----Original Message----- > >> From: Rob Herring [mailto:robh@kernel.org] > >> Sent: Monday, March 05, 2018 5:46 PM > >> To: Jolly Shah > >> Cc: mturquette@baylibre.com; sboyd@codeaurora.org; > >> michal.simek@xilinx.com; mark.rutland@arm.com; > >> linux-clk@vger.kernel.org; devicetree@vger.kernel.org; Shubhrajyoti > >> Datta ; linux- kernel@vger.kernel.org; Jolly > >> Shah ; Rajan Vaja ; > >> linux-arm-kernel@lists.infradead.org > >> Subject: Re: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP > >> clock driver > >> > >> On Wed, Feb 28, 2018 at 02:27:40PM -0800, Jolly Shah wrote: > >> > Add documentation to describe Xilinx ZynqMP clock driver bindings. > >> > > >> > Signed-off-by: Jolly Shah > >> > Signed-off-by: Rajan Vaja > >> > Signed-off-by: Shubhrajyoti Datta > >> > --- > > >> > +95 dpll_post_src > >> > +96 vpll_int > >> > +97 vpll_pre_src > >> > +98 vpll_half > >> > +99 vpll_int_mux > >> > +100 vpll_post_src > >> > +101 can0_mio > >> > +102 can1_mio > >> > + > >> > +Example: > >> > + > >> > +clk: clk { > >> > + #clock-cells = <1>; > >> > + compatible = "xlnx,zynqmp-clk"; > >> > >> How do you control the clocks? > > > > Clocks are controlled by a dedicated platform management controller. Above > clock ids are used to identify clocks between master and PMU. > > What is the interface to the "platform management controller"? Because you > have no registers, I'm guessing a firmware interface? If so, then just define the > firmware node as a clock provider. Yes it is firmware interface. Along with clocks, firmware interface also controls power and pinctrl operations as major. I am not sure if I understand you correctly. Do you suggest to register clocks through Firmware driver or just use firmware DT node as clock provider and clock driver DT node can reference clocks from FW node to register same? > > Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jolly Shah To: Rob Herring CC: "mturquette@baylibre.com" , "sboyd@codeaurora.org" , "michal.simek@xilinx.com" , "mark.rutland@arm.com" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , Shubhrajyoti Datta , "linux-kernel@vger.kernel.org" , Rajan Vaja , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP clock driver Date: Tue, 13 Mar 2018 18:39:13 +0000 Message-ID: References: <1519856861-31384-1-git-send-email-jollys@xilinx.com> <1519856861-31384-3-git-send-email-jollys@xilinx.com> <20180306014549.6t3ae5adzc3cpi5v@rob-hp-laptop> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: SGkgUm9iLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IFJvYiBIZXJy aW5nIFttYWlsdG86cm9iaEBrZXJuZWwub3JnXQ0KPiBTZW50OiBXZWRuZXNkYXksIE1hcmNoIDA3 LCAyMDE4IDU6MjAgUE0NCj4gVG86IEpvbGx5IFNoYWggPEpPTExZU0B4aWxpbnguY29tPg0KPiBD YzogbXR1cnF1ZXR0ZUBiYXlsaWJyZS5jb207IHNib3lkQGNvZGVhdXJvcmEub3JnOw0KPiBtaWNo YWwuc2ltZWtAeGlsaW54LmNvbTsgbWFyay5ydXRsYW5kQGFybS5jb207IGxpbnV4LWNsa0B2Z2Vy Lmtlcm5lbC5vcmc7DQo+IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnOyBTaHViaHJhanlvdGkg RGF0dGEgPHNodWJocmFqQHhpbGlueC5jb20+OyBsaW51eC0NCj4ga2VybmVsQHZnZXIua2VybmVs Lm9yZzsgUmFqYW4gVmFqYSA8UkFKQU5WQHhpbGlueC5jb20+OyBsaW51eC1hcm0tDQo+IGtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMi8zXSBkdC1iaW5k aW5nczogY2xvY2s6IEFkZCBiaW5kaW5ncyBmb3IgWnlucU1QIGNsb2NrDQo+IGRyaXZlcg0KPiAN Cj4gT24gV2VkLCBNYXIgNywgMjAxOCBhdCA0OjQ3IFBNLCBKb2xseSBTaGFoIDxKT0xMWVNAeGls aW54LmNvbT4gd3JvdGU6DQo+ID4gSGkgUm9iLA0KPiA+DQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogUm9iIEhlcnJpbmcgW21haWx0bzpyb2JoQGtlcm5l bC5vcmddDQo+ID4+IFNlbnQ6IE1vbmRheSwgTWFyY2ggMDUsIDIwMTggNTo0NiBQTQ0KPiA+PiBU bzogSm9sbHkgU2hhaCA8Sk9MTFlTQHhpbGlueC5jb20+DQo+ID4+IENjOiBtdHVycXVldHRlQGJh eWxpYnJlLmNvbTsgc2JveWRAY29kZWF1cm9yYS5vcmc7DQo+ID4+IG1pY2hhbC5zaW1la0B4aWxp bnguY29tOyBtYXJrLnJ1dGxhbmRAYXJtLmNvbTsNCj4gPj4gbGludXgtY2xrQHZnZXIua2VybmVs Lm9yZzsgZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IFNodWJocmFqeW90aQ0KPiA+PiBEYXR0 YSA8c2h1YmhyYWpAeGlsaW54LmNvbT47IGxpbnV4LSBrZXJuZWxAdmdlci5rZXJuZWwub3JnOyBK b2xseQ0KPiA+PiBTaGFoIDxKT0xMWVNAeGlsaW54LmNvbT47IFJhamFuIFZhamEgPFJBSkFOVkB4 aWxpbnguY29tPjsNCj4gPj4gbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnDQo+ ID4+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMi8zXSBkdC1iaW5kaW5nczogY2xvY2s6IEFkZCBiaW5k aW5ncyBmb3IgWnlucU1QDQo+ID4+IGNsb2NrIGRyaXZlcg0KPiA+Pg0KPiA+PiBPbiBXZWQsIEZl YiAyOCwgMjAxOCBhdCAwMjoyNzo0MFBNIC0wODAwLCBKb2xseSBTaGFoIHdyb3RlOg0KPiA+PiA+ IEFkZCBkb2N1bWVudGF0aW9uIHRvIGRlc2NyaWJlIFhpbGlueCBaeW5xTVAgY2xvY2sgZHJpdmVy IGJpbmRpbmdzLg0KPiA+PiA+DQo+ID4+ID4gU2lnbmVkLW9mZi1ieTogSm9sbHkgU2hhaCA8am9s bHlzQHhpbGlueC5jb20+DQo+ID4+ID4gU2lnbmVkLW9mZi1ieTogUmFqYW4gVmFqYSA8cmFqYW52 QHhpbGlueC5jb20+DQo+ID4+ID4gU2lnbmVkLW9mZi1ieTogU2h1YmhyYWp5b3RpIERhdHRhIDxz aHViaHJhanlvdGkuZGF0dGFAeGlsaW54LmNvbT4NCj4gPj4gPiAtLS0NCj4gDQo+ID4+ID4gKzk1 ICAgICAgICAgZHBsbF9wb3N0X3NyYw0KPiA+PiA+ICs5NiAgICAgICAgIHZwbGxfaW50DQo+ID4+ ID4gKzk3ICAgICAgICAgdnBsbF9wcmVfc3JjDQo+ID4+ID4gKzk4ICAgICAgICAgdnBsbF9oYWxm DQo+ID4+ID4gKzk5ICAgICAgICAgdnBsbF9pbnRfbXV4DQo+ID4+ID4gKzEwMCAgICAgICAgICAg ICAgICB2cGxsX3Bvc3Rfc3JjDQo+ID4+ID4gKzEwMSAgICAgICAgICAgICAgICBjYW4wX21pbw0K PiA+PiA+ICsxMDIgICAgICAgICAgICAgICAgY2FuMV9taW8NCj4gPj4gPiArDQo+ID4+ID4gK0V4 YW1wbGU6DQo+ID4+ID4gKw0KPiA+PiA+ICtjbGs6IGNsayB7DQo+ID4+ID4gKyAgICNjbG9jay1j ZWxscyA9IDwxPjsNCj4gPj4gPiArICAgY29tcGF0aWJsZSA9ICJ4bG54LHp5bnFtcC1jbGsiOw0K PiA+Pg0KPiA+PiBIb3cgZG8geW91IGNvbnRyb2wgdGhlIGNsb2Nrcz8NCj4gPg0KPiA+IENsb2Nr cyBhcmUgY29udHJvbGxlZCBieSBhIGRlZGljYXRlZCBwbGF0Zm9ybSBtYW5hZ2VtZW50IGNvbnRy b2xsZXIuIEFib3ZlDQo+IGNsb2NrIGlkcyBhcmUgdXNlZCB0byBpZGVudGlmeSBjbG9ja3MgYmV0 d2VlbiBtYXN0ZXIgYW5kIFBNVS4NCj4gDQo+IFdoYXQgaXMgdGhlIGludGVyZmFjZSB0byB0aGUg InBsYXRmb3JtIG1hbmFnZW1lbnQgY29udHJvbGxlciI/IEJlY2F1c2UgeW91DQo+IGhhdmUgbm8g cmVnaXN0ZXJzLCBJJ20gZ3Vlc3NpbmcgYSBmaXJtd2FyZSBpbnRlcmZhY2U/IElmIHNvLCB0aGVu IGp1c3QgZGVmaW5lIHRoZQ0KPiBmaXJtd2FyZSBub2RlIGFzIGEgY2xvY2sgcHJvdmlkZXIuDQoN ClllcyBpdCBpcyBmaXJtd2FyZSBpbnRlcmZhY2UuIEFsb25nIHdpdGggY2xvY2tzLCBmaXJtd2Fy ZSBpbnRlcmZhY2UgYWxzbyBjb250cm9scyBwb3dlciBhbmQgcGluY3RybCBvcGVyYXRpb25zIGFz IG1ham9yLg0KSSBhbSBub3Qgc3VyZSBpZiBJIHVuZGVyc3RhbmQgeW91IGNvcnJlY3RseS4gRG8g eW91IHN1Z2dlc3QgdG8gcmVnaXN0ZXIgY2xvY2tzIHRocm91Z2ggRmlybXdhcmUgZHJpdmVyIG9y IGp1c3QgdXNlIGZpcm13YXJlIERUIG5vZGUgYXMgY2xvY2sgcHJvdmlkZXIgYW5kIGNsb2NrIGRy aXZlciBEVCBub2RlIGNhbiByZWZlcmVuY2UgY2xvY2tzIGZyb20gRlcgbm9kZSB0byByZWdpc3Rl ciBzYW1lPw0KIA0KPiANCj4gUm9iDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: JOLLYS@xilinx.com (Jolly Shah) Date: Tue, 13 Mar 2018 18:39:13 +0000 Subject: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP clock driver In-Reply-To: References: <1519856861-31384-1-git-send-email-jollys@xilinx.com> <1519856861-31384-3-git-send-email-jollys@xilinx.com> <20180306014549.6t3ae5adzc3cpi5v@rob-hp-laptop> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, > -----Original Message----- > From: Rob Herring [mailto:robh at kernel.org] > Sent: Wednesday, March 07, 2018 5:20 PM > To: Jolly Shah > Cc: mturquette at baylibre.com; sboyd at codeaurora.org; > michal.simek at xilinx.com; mark.rutland at arm.com; linux-clk at vger.kernel.org; > devicetree at vger.kernel.org; Shubhrajyoti Datta ; linux- > kernel at vger.kernel.org; Rajan Vaja ; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP clock > driver > > On Wed, Mar 7, 2018 at 4:47 PM, Jolly Shah wrote: > > Hi Rob, > > > > > >> -----Original Message----- > >> From: Rob Herring [mailto:robh at kernel.org] > >> Sent: Monday, March 05, 2018 5:46 PM > >> To: Jolly Shah > >> Cc: mturquette at baylibre.com; sboyd at codeaurora.org; > >> michal.simek at xilinx.com; mark.rutland at arm.com; > >> linux-clk at vger.kernel.org; devicetree at vger.kernel.org; Shubhrajyoti > >> Datta ; linux- kernel at vger.kernel.org; Jolly > >> Shah ; Rajan Vaja ; > >> linux-arm-kernel at lists.infradead.org > >> Subject: Re: [PATCH 2/3] dt-bindings: clock: Add bindings for ZynqMP > >> clock driver > >> > >> On Wed, Feb 28, 2018 at 02:27:40PM -0800, Jolly Shah wrote: > >> > Add documentation to describe Xilinx ZynqMP clock driver bindings. > >> > > >> > Signed-off-by: Jolly Shah > >> > Signed-off-by: Rajan Vaja > >> > Signed-off-by: Shubhrajyoti Datta > >> > --- > > >> > +95 dpll_post_src > >> > +96 vpll_int > >> > +97 vpll_pre_src > >> > +98 vpll_half > >> > +99 vpll_int_mux > >> > +100 vpll_post_src > >> > +101 can0_mio > >> > +102 can1_mio > >> > + > >> > +Example: > >> > + > >> > +clk: clk { > >> > + #clock-cells = <1>; > >> > + compatible = "xlnx,zynqmp-clk"; > >> > >> How do you control the clocks? > > > > Clocks are controlled by a dedicated platform management controller. Above > clock ids are used to identify clocks between master and PMU. > > What is the interface to the "platform management controller"? Because you > have no registers, I'm guessing a firmware interface? If so, then just define the > firmware node as a clock provider. Yes it is firmware interface. Along with clocks, firmware interface also controls power and pinctrl operations as major. I am not sure if I understand you correctly. Do you suggest to register clocks through Firmware driver or just use firmware DT node as clock provider and clock driver DT node can reference clocks from FW node to register same? > > Rob