From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756704AbbLBHFO (ORCPT ); Wed, 2 Dec 2015 02:05:14 -0500 Received: from mail-bn1bon0140.outbound.protection.outlook.com ([157.56.111.140]:48492 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755974AbbLBHFM convert rfc822-to-8bit (ORCPT ); Wed, 2 Dec 2015 02:05:12 -0500 From: Liberman Igal To: David Miller CC: "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Scott Wood , Madalin-Cristian Bucur , "pebolle@tiscali.nl" , "joakim.tjernlund@transmode.se" , "ppc@mindchasers.com" , "stephen@networkplumber.org" Subject: RE: [v8, 2/6] fsl/fman: Add FMan support Thread-Topic: [v8, 2/6] fsl/fman: Add FMan support Thread-Index: AQHRK4n1UTeCmgv6CEiSV6qBHvP81J62p0YAgAChBYA= Date: Wed, 2 Dec 2015 07:05:09 +0000 Message-ID: References: <1448886062-16962-1-git-send-email-igal.liberman@freescale.com> <1448886062-16962-3-git-send-email-igal.liberman@freescale.com> <20151201.162810.1750455760429212300.davem@davemloft.net> In-Reply-To: <20151201.162810.1750455760429212300.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igal.Liberman@freescale.com; x-originating-ip: [192.88.162.1] x-microsoft-exchange-diagnostics: 1;BN3PR03MB1480;5:1fCB9/013i6E4ZG40YTnwZkzyzKgk0ZL7CkHROmZjfrZfC+aCgDAZPjaMiSY7Pop7uZ2m+tsm9ShwVYGqBCmhmbdk40sz5O170GPIPjouJCryOZtf4BwRtR/OkOuIYnkgrcEeQKfrghZPkxhEvWa+g==;24:dfQ9gq92M35xV1IGLlmmwrzHU06+51MTQarZ9g1xdJ3LSLoBq31vT6T+7xQfRaRYqvQfq62E7vGkgUOsbEtHL0PgKPrzHSnisjOfzcfsAJE= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1480; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(101931422205132); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046);SRVR:BN3PR03MB1480;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1480; x-forefront-prvs: 077884B8B5 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(13464003)(189002)(199003)(377454003)(102836003)(19580395003)(10400500002)(3846002)(5002640100001)(5003600100002)(6116002)(5008740100001)(19580405001)(87936001)(586003)(1220700001)(86362001)(1096002)(66066001)(74316001)(5004730100002)(11100500001)(76576001)(99286002)(76176999)(110136002)(122556002)(40100003)(54356999)(5001960100002)(189998001)(101416001)(2900100001)(50986999)(106116001)(106356001)(105586002)(81156007)(97736004)(33656002)(92566002)(2950100001)(77096005)(19627235001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1480;H:DM2PR03MB509.namprd03.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2015 07:05:09.9892 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1480 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, Thank you for your feedback, I'll address it and re-submit. Regards, Igal Liberman > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Tuesday, December 01, 2015 11:28 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > kernel@vger.kernel.org; Wood Scott-B07421 ; > Bucur Madalin-Cristian-B32716 ; > pebolle@tiscali.nl; joakim.tjernlund@transmode.se; ppc@mindchasers.com; > stephen@networkplumber.org > Subject: Re: [v8, 2/6] fsl/fman: Add FMan support > > From: > Date: Mon, 30 Nov 2015 14:20:58 +0200 > > > +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman, > > + enum fman_exceptions exception); > > Function and function pointer declarations and definitions should be > indented such that the second and subsequent lines begin precisely at the > first column after the openning parenthesis of the first line. > > Please audit this and fix it in your entire submission, almost ever new such > case is done incorrectly. > > > + fman->state->exceptions = (EX_DMA_BUS_ERROR | > > + EX_DMA_READ_ECC | > > + EX_DMA_SYSTEM_WRITE_ECC | > > + EX_DMA_FM_WRITE_ECC | > > + EX_FPM_STALL_ON_TASKS | > > + EX_FPM_SINGLE_ECC | > > + EX_FPM_DOUBLE_ECC | > > + > EX_QMI_DEQ_FROM_UNKNOWN_PORTID | > > + EX_BMI_LIST_RAM_ECC | > > + EX_BMI_STORAGE_PROFILE_ECC | > > + EX_BMI_STATISTICS_RAM_ECC | > > + EX_MURAM_ECC | > > + EX_BMI_DISPATCH_RAM_ECC | > > + EX_QMI_DOUBLE_ECC | > > + EX_QMI_SINGLE_ECC); > > The same applies to multi-line parenthesized expressions like this one. > Again, please audit and fix this in your entire submission. > > Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bbn0109.outbound.protection.outlook.com [157.56.111.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 22AB51A0286 for ; Wed, 2 Dec 2015 18:05:18 +1100 (AEDT) From: Liberman Igal To: David Miller CC: "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Scott Wood , Madalin-Cristian Bucur , "pebolle@tiscali.nl" , "joakim.tjernlund@transmode.se" , "ppc@mindchasers.com" , "stephen@networkplumber.org" Subject: RE: [v8, 2/6] fsl/fman: Add FMan support Date: Wed, 2 Dec 2015 07:05:09 +0000 Message-ID: References: <1448886062-16962-1-git-send-email-igal.liberman@freescale.com> <1448886062-16962-3-git-send-email-igal.liberman@freescale.com> <20151201.162810.1750455760429212300.davem@davemloft.net> In-Reply-To: <20151201.162810.1750455760429212300.davem@davemloft.net> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi David, Thank you for your feedback, I'll address it and re-submit. Regards, Igal Liberman > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Tuesday, December 01, 2015 11:28 PM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > kernel@vger.kernel.org; Wood Scott-B07421 ; > Bucur Madalin-Cristian-B32716 ; > pebolle@tiscali.nl; joakim.tjernlund@transmode.se; ppc@mindchasers.com; > stephen@networkplumber.org > Subject: Re: [v8, 2/6] fsl/fman: Add FMan support >=20 > From: > Date: Mon, 30 Nov 2015 14:20:58 +0200 >=20 > > +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman, > > + enum fman_exceptions exception); >=20 > Function and function pointer declarations and definitions should be > indented such that the second and subsequent lines begin precisely at the > first column after the openning parenthesis of the first line. >=20 > Please audit this and fix it in your entire submission, almost ever new s= uch > case is done incorrectly. >=20 > > + fman->state->exceptions =3D (EX_DMA_BUS_ERROR | > > + EX_DMA_READ_ECC | > > + EX_DMA_SYSTEM_WRITE_ECC | > > + EX_DMA_FM_WRITE_ECC | > > + EX_FPM_STALL_ON_TASKS | > > + EX_FPM_SINGLE_ECC | > > + EX_FPM_DOUBLE_ECC | > > + > EX_QMI_DEQ_FROM_UNKNOWN_PORTID | > > + EX_BMI_LIST_RAM_ECC | > > + EX_BMI_STORAGE_PROFILE_ECC | > > + EX_BMI_STATISTICS_RAM_ECC | > > + EX_MURAM_ECC | > > + EX_BMI_DISPATCH_RAM_ECC | > > + EX_QMI_DOUBLE_ECC | > > + EX_QMI_SINGLE_ECC); >=20 > The same applies to multi-line parenthesized expressions like this one. > Again, please audit and fix this in your entire submission. >=20 > Thanks.