From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1834C636D6 for ; Thu, 2 Feb 2023 14:50:08 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 425D442D20; Thu, 2 Feb 2023 15:50:08 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id EFE7040EDC for ; Thu, 2 Feb 2023 15:50:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675349407; x=1706885407; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RDMBLMuK3R0MqXzQp9Y6SsT7EnMR97nnDqFJqw4XCss=; b=ACLnCKw1izQjfvgv5n6cHsUe4G+bOOFn8wbDXP/uToPXsbpShNqo0W3R G5jkiw+QchRaE4VdxZXQ56JEkm6lqK54TjxYKv/xlNESH0iYgESrNMWQx /tzVlgCkhNkZFCEcwFvDbQWc9KjY0BESt61OBD9HCmHvnkWJYSjKHLwcO UICF6TdCDPTZvQpI2dDUc6nxTkSurxlaXmal2nFJkDNZ+KGS0KvT0lq9e Uhj2yDqKC/YuclWktNWvbA/JksINhm8+o+xvsNwjjHZ07A/lD2Zl/nvGo SC4SYNUzk7C7OAj7QuvMpg36RJXzJcfs6jt7FKotfPGKSGdA/hpZOQKBm Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="393042424" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="393042424" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 06:50:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="695799885" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="695799885" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 02 Feb 2023 06:50:05 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 06:50:05 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 2 Feb 2023 06:50:05 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Feb 2023 06:50:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=loyFMTXIvon+lODsuNgytkTtjXdi44q6LYcEBfRFrGpjLgwGSxj/G4fhs4r5QcLwF0LEluhz4S/g00Yp76S+rTkldWkNNvkV1lIMhDXX1rq/e+YiE9tgtxNOjfoDLN8YyRnHdkdqlkUFVfjJsWmIXrVcDXaW5fcMZXpd5pqaflnCgM5+kKBiYo7C2R57upb4mH5TBfOH/AtiADalTzYPUqZoP2IIdDHzadnzEBea5RUaqH420JCQ4bxaDu6pHAxu5/CAeginSe4Ty8f5Iw8sm7HSgoeGMwWv9shzQRN6iXLl5QVfWrWK6D9ZaS1Nqb+lq50To0QAitSwMTJOmPKcIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oXKkb+pgFA3Hl/DdUtkXrCbeIl6t1oVVSX1ncd6qRYE=; b=SiOPeM+wv5oCXdOEmE+hnaRJyN8Bagv/GL2Qu0VVhTe95rUKDUrd2FVYlxJOuN1WHZSx+a7xjnU8mDspABWCTJYhnBFS/6uOkYsZZKw3KXUOKJb7ORv5tCDQFl8cI/uGQP34RtjYNo22p+4WHyO02kCzoMXaLqUjFOIbnUvFKR3MFVZCOhMa2RIQ6xcbkCUqBIg7MpGxbabWmelFhOHLT6G8OTo3RqZqsmKh8yk5SvRTepyfXQF6BW2oArF7s1boSmC7lQK+0BD8Z+LtLujlrW0wmjNhgRKeh+mI199QcX2dIYm+1b5+9CvHwkYETci2PYjy0hPGJy2uOSXoI5QOKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CO1PR11MB4930.namprd11.prod.outlook.com (2603:10b6:303:9b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 14:49:52 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5%9]) with mapi id 15.20.6043.038; Thu, 2 Feb 2023 14:49:52 +0000 From: "Zhang, Qi Z" To: "Koikkara Reeny, Shibin" , "dev@dpdk.org" , "Burakov, Anatoly" , "Richardson, Bruce" CC: "Loftus, Ciara" Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration Thread-Topic: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration Thread-Index: AQHZD9KLg3yJAyWJXESupanX+QJqc66kSwvggAHFhoCAFfqlAA== Date: Thu, 2 Feb 2023 14:49:52 +0000 Message-ID: References: <20221214154102.1521489-1-shibin.koikkara.reeny@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CO1PR11MB4930:EE_ x-ms-office365-filtering-correlation-id: 0991fa40-8118-473e-f03b-08db052cbe03 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DiAcLQM1OBr5TaGHAEr3t9lciWsmLBCsmHUsNe1z02VFnIbvV+eKoZh6uMpZVFitWCXGPDjqrhdQzJCaGIgWkWFZ0tOGOtX/bkKmPVIB1yaKcHl8nwBxEO5DF/obH81Dc3xWqAI3rWPTfOs9I5BzSdyc4EowRWYjAh4tSckWBL9AE1UHt1maevtdW0qN/wuY1YBAk9e04spVUnYGBTfXS8ocdMjH7nvZvw/5esVHvP8rfR5UIftVjO7LTaacQrshKfa78NpNh+7Jw1AZRaIdRN9pk/lDRce0uZTdJ+G1sYkIp7tdZGpKUyLPKVheWJ+zhR1EK0ag+b7kc/rCf8argn9y+F40n4XjHXGb3M5tV+WMjGNSer+fNFlRTfiIxWH8TutZxWXzIh5LpNejq5tQFwLirlinoZEU9+dpkMThF5pCgcFiMmH0Hlz0r5EayslRZ4FyqC+XgR5xkPKAmLigUviZmn/TEL4lPZL+Aft2fJ3LA6Cbbw4yjBzuApw3BNz1tZRAakCwSf9HhmNEznBqNlfIIjhYGqLjUAKQ5VSTSsnmtcPaHuQUa5xjzX5+iaQyv7R3Qo93sgpJSbcREUBmjOIWzUlS4AIvsnzDwF+wUzCXDbdiqCSGMnhGe3T3LLnDoX/8grNS9L3kC9NM+moIZ9eZcDqr9YnrSqWG8n8lmblcpnsCPbM6RFGXvD9IqPJQyEHuoSqDxo8Sv8c6uNF1Gz9lOHJ4t8WBITkZawI1bBEi0Pky5yZ3Mn10aKVwjAZvYSgonQ1bPOc6KgXbsrIwSg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(376002)(346002)(136003)(366004)(39860400002)(451199018)(82960400001)(66946007)(122000001)(38100700002)(107886003)(6506007)(53546011)(26005)(966005)(83380400001)(33656002)(9686003)(186003)(64756008)(66556008)(66476007)(478600001)(66446008)(4326008)(316002)(110136005)(76116006)(6636002)(41300700001)(2906002)(8676002)(7696005)(8936002)(52536014)(5660300002)(86362001)(71200400001)(55016003)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YFH3cZ834iMIkSo9L+HSq/fpx42bQeGlABO9033GnVQ7aC/v391BkW+x7lDx?= =?us-ascii?Q?wWk2MenkBELKLRsb3Qc3b6Hg7I0KLo07Fxakgm9Zrerj5ncXP45FIiwwB6JP?= =?us-ascii?Q?k5/KzMo6mIaqYLvQzYHktoywP9oxn7dl6me1P9zLwY3QZPmr3AJ3us6P+wdQ?= =?us-ascii?Q?+3e3DB+7aQyTgR8bq0hUsfbKS256N+S1oGX0+2GObWKCschSe506zv3LvKKQ?= =?us-ascii?Q?POo/me85wmj5Ef+vhvrn4NuIO/Ur5PgCJld70BhJrTVqkOvzlY1D97oY3uWR?= =?us-ascii?Q?0ve8BzQcjnmBOjcvlq155WtK4Xj8ijISRQ/05BkZ8eEF4FrzTw3gdn1l6w5r?= =?us-ascii?Q?1OJyHo0MOUybw5arHHCzypzOIpWQAN929WlVy5ht4/l9m7OTJ9nzEMF8x6NY?= =?us-ascii?Q?+XV8cSeOSueAbjOr8UhsIBBgnL+cjSmngAiYwmjGDFiSz/uTKCEfHCyL37Aa?= =?us-ascii?Q?uX/hMd3wyfr0aZjb3TuUHUfhsVnAm49C4hfk9kowzwSepOjqPT+8G3486BKw?= =?us-ascii?Q?LNdCo89/FTr9830Q+JTq/zMR/gGU7Nk7FGWkbvDAlBpejSjs/dCLhvC5rXds?= =?us-ascii?Q?zYqCVy3JC/JI4+Y9OiNCYDjnO+hmyQyVmHl7HTB/V3V4rgyjYxi6gkhlc1nj?= =?us-ascii?Q?azeyhV329r0NEMRoFOQynWaGyv59L9scEg4JrmThWuoSRD6UkQPR4ztpYH1m?= =?us-ascii?Q?+yXpKunND1ABDAZj3m1iNa2zQODvgaHsW0Pipcaalvnbg21o1wFlu5OVSCPe?= =?us-ascii?Q?wGpoMUGQ0EwBHmr5PX3urnTL65Nadb+XLklX5njfieaCaruMZZ9Yd3KvjpML?= =?us-ascii?Q?ejVWg5oJO01Oljz7uLL+ahZQCEB4R50E2+biCP5qa3TmuMerbAJd02eusayg?= =?us-ascii?Q?KxVKKStFg29smuaZ6l7IMd1qrr1NoZBm1lvw65AVaWoQ3OUu8iVgD7w8DHsv?= =?us-ascii?Q?ZJ/J8cZHa5Vz1VbYqJs3/mbOpNwXozie6al1LidCl4Ug+n4Rz4xIDgoLK5YM?= =?us-ascii?Q?qTbIGL0Tioy6luIf9xgg5hBD+DGYySB6ppGD4rbdf10tFfe6xrjWKFBTOpf4?= =?us-ascii?Q?ysOE34W5bPHK50GK6KnWDXBbv9wrM0YqDjwgp/XaJ6XJteld7gf62/NOJZO6?= =?us-ascii?Q?noaWZzRft/1urpUF7UImynCWSJ1KyXUsmArWV1k9dipa9OqP8PjcasyWMhhn?= =?us-ascii?Q?4OpYfYe8XzABBINhDSmDPNeVJbfJ9gmzQZwGUwmTK8oaFgyd2/LMFJ72ty5v?= =?us-ascii?Q?dBSR8yxizaDh0T2H6kaQXGLxl97s+vkgxDGQ3u4bH4H28j+hswLke0SZLShK?= =?us-ascii?Q?4Q70W+tWf60ANtdKZnEhyFuwc6SbAFva5pA0s1rvCiiKfLJkPzHSpwu5uvp9?= =?us-ascii?Q?X0mkYsxCRW0gH2KZXzl7I26JSt5yvGwkkh/7/vAJHhCrf/rBwufPwlSrmybI?= =?us-ascii?Q?CkNucpF6PQ0STMOHSe0pUK8rhz0RYRXkbuzS5uSXZQB5VFxvwr33+hZ/GTku?= =?us-ascii?Q?eFNMcU7nToxjdYFwIlDJfepVFFjdNOZII+Jt6exqkv+IoFARfM60jioEEdU0?= =?us-ascii?Q?9rInLTf2bGezM3VJ0z4eFlLqUcc668U6J66tBO2E?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0991fa40-8118-473e-f03b-08db052cbe03 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 14:49:52.7061 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MSQxdFevIHTwKnU7S3Qi0dH1UPtKzNlsib4w4v/Tp2ikxCYPfHn1+bPJh5GAd2pnFDxXffirBXIb38ZamkeZvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4930 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Koikkara Reeny, Shibin > Sent: Thursday, January 19, 2023 11:10 PM > To: Zhang, Qi Z ; dev@dpdk.org; Burakov, Anatoly > ; Richardson, Bruce > > Cc: Loftus, Ciara > Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, January 18, 2023 12:10 PM > > To: Koikkara Reeny, Shibin ; > > dev@dpdk.org; Burakov, Anatoly ; > > Richardson, Bruce > > Cc: Loftus, Ciara > > Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > > > > > -----Original Message----- > > > From: Koikkara Reeny, Shibin > > > Sent: Wednesday, December 14, 2022 11:41 PM > > > To: dev@dpdk.org; Burakov, Anatoly ; > > > Richardson, Bruce > > > Cc: Loftus, Ciara ; Zhang, Qi Z > > > ; Koikkara Reeny, Shibin > > > > > > Subject: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > > Integrate support for the AF_XDP CNI and device plugin [1] so that > > > the DPDK AF_XDP PMD can work in an unprivileged container > environment. > > > Part of the AF_XDP PMD initialization process involves loading an > > > eBPF program onto the given netdev. This operation requires > > > privileges, which prevents the PMD from being able to work in an > > > unprivileged container (without root access). The plugin CNI handles > > > the program loading. CNI open Unix Domain Socket (UDS) and waits > > > listening for a client to make requests over that UDS. The > > > client(DPDK) connects and a "handshake" occurs, then the File > > > Descriptor which points to the XSKMAP associated with the loaded > > > eBPF program is handed over to the client. The client can then > > > proceed with creating an AF_XDP socket and inserting the socket into > > > the XSKMAP pointed to by the FD received on the > > UDS. > > > > > > A new vdev arg "use_cni" is created to indicate user wishes to run > > > the PMD in unprivileged mode and to receive the XSKMAP FD from the > CNI. > > > When this flag is set, the XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD > > > libbpf flag should be used when creating the socket, which tells > > > libbpf not to load the default libbpf program on the netdev. We tell > > > libbpf not to do this because the loading is handled by the CNI in th= is > scenario. > > > > > > [1]: https://github.com/intel/afxdp-plugins-for-kubernetes > > > > > > Signed-off-by: Shibin Koikkara Reeny > > > > > > --- > > > drivers/net/af_xdp/rte_eth_af_xdp.c | 337 > > > +++++++++++++++++++++++++++- > > > 1 file changed, 325 insertions(+), 12 deletions(-) > > > > > > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > > > b/drivers/net/af_xdp/rte_eth_af_xdp.c > > > index b6ec9bf490..196d98ad97 100644 > > > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > > > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > > > @@ -7,6 +7,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -81,6 +82,24 @@ RTE_LOG_REGISTER_DEFAULT(af_xdp_logtype, > > > NOTICE); > > > > > > #define ETH_AF_XDP_MP_KEY "afxdp_mp_send_fds" > > > > > > +#define MAX_LONG_OPT_SZ 64 > > > +#define UDS_MAX_FD_NUM 2 > > > +#define UDS_MAX_CMD_LEN 64 > > > +#define UDS_MAX_CMD_RESP 128 > > > +#define UDS_XSK_MAP_FD_MSG "/xsk_map_fd" > > > +#define UDS_SOCK "/tmp/afxdp.sock" > > > +#define UDS_CONNECT_MSG "/connect" > > > +#define UDS_HOST_OK_MSG "/host_ok" > > > +#define UDS_HOST_NAK_MSG "/host_nak" > > > +#define UDS_VERSION_MSG "/version" > > > +#define UDS_XSK_MAP_FD_MSG "/xsk_map_fd" > > > +#define UDS_XSK_SOCKET_MSG "/xsk_socket" > > > +#define UDS_FD_ACK_MSG "/fd_ack" > > > +#define UDS_FD_NAK_MSG "/fd_nak" > > > +#define UDS_FIN_MSG "/fin" > > > +#define UDS_FIN_ACK_MSG "/fin_ack" > > > + > > > + > > > static int afxdp_dev_count; > > > > > > /* Message header to synchronize fds via IPC */ @@ -151,6 +170,7 @@ > > > struct pmd_internals { > > > char prog_path[PATH_MAX]; > > > bool custom_prog_configured; > > > bool force_copy; > > > + bool use_cni; > > > struct bpf_map *map; > > > > > > struct rte_ether_addr eth_addr; > > > @@ -170,6 +190,7 @@ struct pmd_process_private { > > > #define ETH_AF_XDP_PROG_ARG "xdp_prog" > > > #define ETH_AF_XDP_BUDGET_ARG > > "busy_budget" > > > #define ETH_AF_XDP_FORCE_COPY_ARG "force_copy" > > > +#define ETH_AF_XDP_USE_CNI_ARG "use_cni" > > > > > > static const char * const valid_arguments[] =3D { > > > ETH_AF_XDP_IFACE_ARG, > > > @@ -179,8 +200,8 @@ static const char * const valid_arguments[] =3D { > > > ETH_AF_XDP_PROG_ARG, > > > ETH_AF_XDP_BUDGET_ARG, > > > ETH_AF_XDP_FORCE_COPY_ARG, > > > - NULL > > > -}; > > > + ETH_AF_XDP_USE_CNI_ARG, > > > + NULL}; > > > > > > static const struct rte_eth_link pmd_link =3D { > > > .link_speed =3D RTE_ETH_SPEED_NUM_10G, @@ -1129,7 +1150,8 > @@ > > > xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals, > > > ret =3D xsk_umem__create(&umem->umem, base_addr, > > umem_size, > > > &rxq->fq, &rxq->cq, &usr_config); > > > if (ret) { > > > - AF_XDP_LOG(ERR, "Failed to create umem\n"); > > > + AF_XDP_LOG(ERR, "Failed to create umem [%d]: > > > [%s]\n", > > > + errno, strerror(errno)); > > > goto err; > > > } > > > umem->buffer =3D base_addr; > > > @@ -1314,6 +1336,245 @@ configure_preferred_busy_poll(struct > > > pkt_rx_queue *rxq) > > > return 0; > > > } > > > > > > +static int > > > +init_uds_sock(struct sockaddr_un *server) { > > > + int sock; > > > + > > > + sock =3D socket(AF_UNIX, SOCK_SEQPACKET, 0); > > > + if (sock < 0) { > > > + AF_XDP_LOG(ERR, "Failed to opening stream socket\n"); > > > + return -1; > > > + } > > > + > > > + server->sun_family =3D AF_UNIX; > > > + strlcpy(server->sun_path, UDS_SOCK, sizeof(server->sun_path)); > > > + > > > + if (connect(sock, (struct sockaddr *)server, sizeof(struct > > > sockaddr_un)) < 0) { > > > > seems the server address is hard coded as "/tmp/afxdp.sock", is any > > spec we follows, or should we parse this as a devargs? > > better add some comment or external link that help to explain this >=20 > It was already hardcoded in the afxdp-plugins > https://github.com/intel/afxdp-plugins-for- > kubernetes/blob/main/constants/constants.go . OK, I saw this has been explained in your new doc patch. Reviewed-by: Qi Zhang >=20 > If we want to go with the devargs we will still need to put a default > hardcoded value as there is no documentation showing the where and what > is the name of the socket in the repo without going through the code.