All of lore.kernel.org
 help / color / mirror / Atom feed
From: "B, Jeevan" <jeevan.b@intel.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/kms_psr2_sf: Fix cleanup
Date: Thu, 23 Mar 2023 07:43:27 +0000	[thread overview]
Message-ID: <DM4PR11MB6312C198ECD11440E90784FC90879@DM4PR11MB6312.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230323073739.553919-1-jouni.hogander@intel.com>

Can we set display_reset before setting pipe ?? 

> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander@intel.com>
> Sent: Thursday, March 23, 2023 1:08 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Hogander, Jouni <jouni.hogander@intel.com>; B, Jeevan
> <jeevan.b@intel.com>
> Subject: [PATCH i-g-t] tests/i915/kms_psr2_sf: Fix cleanup
> 
> Cleanup is leaving pipe reserved. This is causing failures like:
> 
> igt_kms-CRITICAL: DP-1 and eDP-1 are both trying to use pipe A
> 
> Fix by setting pipe of output as PIPE_NONE.
> 
> Cc: Jeevan B <jeevan.b@intel.com>
> 
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> ---
>  tests/i915/kms_psr2_sf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c index
> 2d761d31..4a8608c1 100644
> --- a/tests/i915/kms_psr2_sf.c
> +++ b/tests/i915/kms_psr2_sf.c
> @@ -846,10 +846,10 @@ static void cleanup(data_t *data)
>  		igt_plane_set_fb(sprite, NULL);
>  	}
> 
> -	if (data->coexist_feature & FEATURE_DSC) {
> +	if (data->coexist_feature & FEATURE_DSC)
>  		restore_force_dsc_en();
> -		igt_output_set_pipe(output, PIPE_NONE);
> -	}
> +
> +	igt_output_set_pipe(output, PIPE_NONE);
> 
>  	igt_display_commit2(&data->display, COMMIT_ATOMIC);
> 
> --
> 2.34.1


  reply	other threads:[~2023-03-23  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23  7:37 [igt-dev] [PATCH i-g-t] tests/i915/kms_psr2_sf: Fix cleanup Jouni Högander
2023-03-23  7:43 ` B, Jeevan [this message]
2023-03-23  7:46   ` Hogander, Jouni
2023-03-23  7:51     ` B, Jeevan
2023-03-23  8:29 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-03-23 10:17 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-03-27  7:02   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB6312C198ECD11440E90784FC90879@DM4PR11MB6312.namprd11.prod.outlook.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.