From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id E927410E098 for ; Thu, 15 Dec 2022 15:29:12 +0000 (UTC) From: "B, Jeevan" To: "igt-dev@lists.freedesktop.org" , "Vudum, Lakshminarayana" Date: Thu, 15 Dec 2022 15:27:38 +0000 Message-ID: References: <20221215081934.13919-1-jeevan.b@intel.com> In-Reply-To: <20221215081934.13919-1-jeevan.b@intel.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_draw: Change MOCS settings for MTL List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: We are seeing at BAT failure which is not related to this patch. Can you pl= ease help with this.=20 IGT changes Possible regressions igt@i915_selftest@live@guc_multi_lrc: fi-kbl-soraka: NOTRUN -> INCOMPLETE Thanks=20 Jeevan B=20 > -----Original Message----- > From: B, Jeevan > Sent: Thursday, December 15, 2022 1:50 PM > To: igt-dev@lists.freedesktop.org > Cc: Roper, Matthew D ; B S, Karthik > ; B, Jeevan > Subject: [PATCH i-g-t] lib/igt_draw: Change MOCS settings for MTL >=20 > On MTL, we want the table entry labelled "UC (GO:Mem)" > which has index 5. This means that the MOCS value is 10. >=20 > Signed-off-by: Jeevan B > --- > lib/igt_draw.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/igt_draw.c b/lib/igt_draw.c index 975d65cd..d8cc60f9 100= 644 > --- a/lib/igt_draw.c > +++ b/lib/igt_draw.c > @@ -703,7 +703,10 @@ static void draw_rect_blt(int fd, struct cmd_data > *cmd_data, >=20 > intel_bb_out(ibb, XY_FAST_COLOR_BLT | blt_cmd_depth); > /* DG2 MOCS entry 2 is "UC - Non-Coherent; GO:Memory" */ > - intel_bb_out(ibb, blt_cmd_tiling | 2 << 21 | (pitch-1)); > + if (IS_METEORLAKE(intel_get_drm_devid(fd))) > + intel_bb_out(ibb, blt_cmd_tiling | 10 << 21 | (pitch- > 1)); > + else > + intel_bb_out(ibb, blt_cmd_tiling | 2 << 21 | (pitch- > 1)); > intel_bb_out(ibb, (rect->y << 16) | rect->x); > intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect- > >w)); > intel_bb_emit_reloc_fenced(ibb, dst->handle, 0, > -- > 2.36.0