Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Thorsten Leemhuis]

Hi, this is your Linux kernel regression tracker.

I noticed a regression report in bugzilla.kernel.org that afaics nobody
acted upon since it was reported about a week ago, that's why I decided
to forward it to the lists and all people that seemed to be relevant
here. It looks to me like this is something for Basavaraj, as it seems
to be caused by	b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
all command"). But I'm not totally sure, I only looked briefly into the
details. Or was this discussed somewhere else already? Or even fixed?

To quote from https://bugzilla.kernel.org/show_bug.cgi?id=215744 :

>  Marco 2022-03-25 15:22:19 UTC
> 
> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c?id=b300667b33b2b5a2c8e5f8f22826befb3d7f4f2b. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
> 
> Marco.

Anyway, to get this tracked:

#regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
#regzbot from: Marco <rodomar705@protonmail.com>
#regzbot title: input: hid: input from the accelerometer disappeared due
to changes to amd_sfh
#regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=215744

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I'm getting a lot of
reports on my table. I can only look briefly into most of them and lack
knowledge about most of the areas they concern. I thus unfortunately
will sometimes get things wrong or miss something important. I hope
that's not the case here; if you think it is, don't hesitate to tell me
in a public reply, it's in everyone's interest to set the public record
straight.

-- 
Additional information about regzbot:

If you want to know more about regzbot, check out its web-interface, the
getting start guide, and the references documentation:

https://linux-regtracking.leemhuis.info/regzbot/
https://gitlab.com/knurd42/regzbot/-/blob/main/docs/getting_started.md
https://gitlab.com/knurd42/regzbot/-/blob/main/docs/reference.md

The last two documents will explain how you can interact with regzbot
yourself if your want to.

Hint for reporters: when reporting a regression it's in your interest to
CC the regression list and tell regzbot about the issue, as that ensures
the regression makes it onto the radar of the Linux kernel's regression
tracker -- that's in your interest, as it ensures your report won't fall
through the cracks unnoticed.

Hint for developers: you normally don't need to care about regzbot once
it's involved. Fix the issue as you normally would, just remember to
include 'Link:' tag in the patch descriptions pointing to all reports
about the issue. This has been expected from developers even before
regzbot showed up for reasons explained in
'Documentation/process/submitting-patches.rst' and
'Documentation/process/5.Posting.rst'.

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Basavaraj Natikar]

Hi,

Committed patch is disabling the interrupt mode and does not cause any
functionality or working issues.

I also cross verified on 3 system and working fine on 5.17 and not able
to reproduce or recreate.

Output on 5.17:

--------------------------------------------------------------

root@amd-HP-ENVY-x360-Convertible-15-eu0xxx:/home/amd# uname -a

Linux amd-HP-ENVY-x360-Convertible-15-eu0xxx 5.17.0+ #5 SMP PREEMPT Fri
Apr 1 23:28:34 IST 2022 x86_64 x86_64 x86_64 GNU/Linux

root@amd-HP-ENVY-x360-Convertible-15-eu0xxx:/home/amd# monitor-sensor

    Waiting for iio-sensor-proxy to appear

+++ iio-sensor-proxy appeared

=== Has accelerometer (orientation: normal)

=== No ambient light sensor

    Accelerometer orientation changed: right-up

    Accelerometer orientation changed: normal

    Accelerometer orientation changed: right-up

    Accelerometer orientation changed: normal

    Accelerometer orientation changed: left-up

    Accelerometer orientation changed: normal

    Accelerometer orientation changed: right-up

    Accelerometer orientation changed: normal

    Accelerometer orientation changed: left-up

    Accelerometer orientation changed: normal

    Accelerometer orientation changed: right-up

    Accelerometer orientation changed: normal

    Accelerometer orientation changed: bottom-up

    Accelerometer orientation changed: normal

    Accelerometer orientation changed: right-up

    Accelerometer orientation changed: normal

root@amd-HP-ENVY-x360-Convertible-15-eu0xxx:/home/amd# dmidecode -s
bios-version

B.16T19

root@amd-HP-ENVY-x360-Convertible-15-eu0xxx:/home/amd# dmidecode -s
system-product-name

HP ENVY x360 Convertible 15-eu0xxx

root@amd-HP-ENVY-x360-Convertible-15-eu0xxx:/home/amd# dmidecode -s
system-manufacturer

HP

root@amd-HP-ENVY-x360-Convertible-15-eu0xxx:/home/amd#

------------------------------------------------

Looks like this is not regression. May be some hardware/firmware bug.

Just curious reverting this patch how it is working just suspecting
firmware undefined behavior.

If possible, please check on other platform/system also if same behavior
occurs.

Could you please provide me platform/system details so that I can check
this behavior?

Thanks,
Basavaraj

On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker.
>
> I noticed a regression report in bugzilla.kernel.org that afaics nobody
> acted upon since it was reported about a week ago, that's why I decided
> to forward it to the lists and all people that seemed to be relevant
> here. It looks to me like this is something for Basavaraj, as it seems
> to be caused by	b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
> all command"). But I'm not totally sure, I only looked briefly into the
> details. Or was this discussed somewhere else already? Or even fixed?
>
> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=HbQ5LymDwsc94RZhNuzN83%2F0BUplqRUG7bB%2BXymViP0%3D&reserved=0 :
>
>>  Marco 2022-03-25 15:22:19 UTC
>>
>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=odHA0EIxLb0xpSJJ9ShzgGL0%2BOAJ6tbG68lQe0QOqLY%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>
>> Marco.
> Anyway, to get this tracked:
>
> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
> #regzbot from: Marco <rodomar705@protonmail.com>
> #regzbot title: input: hid: input from the accelerometer disappeared due
> to changes to amd_sfh
> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=HbQ5LymDwsc94RZhNuzN83%2F0BUplqRUG7bB%2BXymViP0%3D&amp;reserved=0
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>
> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> reports on my table. I can only look briefly into most of them and lack
> knowledge about most of the areas they concern. I thus unfortunately
> will sometimes get things wrong or miss something important. I hope
> that's not the case here; if you think it is, don't hesitate to tell me
> in a public reply, it's in everyone's interest to set the public record
> straight.
>

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Thorsten Leemhuis]

On 01.04.22 21:47, Basavaraj Natikar wrote:
> 
> Committed patch is disabling the interrupt mode and does not cause any
> functionality or working issues.

Well, for the reporter it clearly does cause problems, unless something
in testing went sideways.

> I also cross verified on 3 system and working fine on 5.17 and not able
> to reproduce or recreate.

> [...]

> ------------------------------------------------
> 
> Looks like this is not regression. May be some hardware/firmware bug.

Well, from the point of the kernel development process it afaics is a
regression, unless the testing went sideways. It doesn't matter if the
root cause is in fact a hardware/firmware bug, as what matters in the
scope of the kernel development is: things worked, and now they don't.
For details please check this file and read the quotes from Linus:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/plain/Documentation/process/handling-regressions.rst

Ciao, Thorsten

> Just curious reverting this patch how it is working just suspecting
> firmware undefined behavior.
> 
> If possible, please check on other platform/system also if same behavior
> occurs.
> 
> Could you please provide me platform/system details so that I can check
> this behavior?
> 
> Thanks,
> Basavaraj
> 
> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
>> Hi, this is your Linux kernel regression tracker.
>>
>> I noticed a regression report in bugzilla.kernel.org that afaics nobody
>> acted upon since it was reported about a week ago, that's why I decided
>> to forward it to the lists and all people that seemed to be relevant
>> here. It looks to me like this is something for Basavaraj, as it seems
>> to be caused by	b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
>> all command"). But I'm not totally sure, I only looked briefly into the
>> details. Or was this discussed somewhere else already? Or even fixed?
>>
>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=HbQ5LymDwsc94RZhNuzN83%2F0BUplqRUG7bB%2BXymViP0%3D&reserved=0 :
>>
>>>  Marco 2022-03-25 15:22:19 UTC
>>>
>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=odHA0EIxLb0xpSJJ9ShzgGL0%2BOAJ6tbG68lQe0QOqLY%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>>
>>> Marco.
>> Anyway, to get this tracked:
>>
>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
>> #regzbot from: Marco <rodomar705@protonmail.com>
>> #regzbot title: input: hid: input from the accelerometer disappeared due
>> to changes to amd_sfh
>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C9155f6987d45479f721208da13b682f9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637843972013904577%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=HbQ5LymDwsc94RZhNuzN83%2F0BUplqRUG7bB%2BXymViP0%3D&amp;reserved=0
>>
>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>
>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>> reports on my table. I can only look briefly into most of them and lack
>> knowledge about most of the areas they concern. I thus unfortunately
>> will sometimes get things wrong or miss something important. I hope
>> that's not the case here; if you think it is, don't hesitate to tell me
>> in a public reply, it's in everyone's interest to set the public record
>> straight.
>>
> 
> 

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Basavaraj Natikar]

On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:
> On 01.04.22 21:47, Basavaraj Natikar wrote:
>> Committed patch is disabling the interrupt mode and does not cause any
>> functionality or working issues.
> Well, for the reporter it clearly does cause problems, unless something
> in testing went sideways.
>
>> I also cross verified on 3 system and working fine on 5.17 and not able
>> to reproduce or recreate.
>> [...]
>> ------------------------------------------------
>>
>> Looks like this is not regression. May be some hardware/firmware bug.
> Well, from the point of the kernel development process it afaics is a
> regression, unless the testing went sideways. It doesn't matter if the
> root cause is in fact a hardware/firmware bug, as what matters in the
> scope of the kernel development is: things worked, and now they don't.
> For details please check this file and read the quotes from Linus:

can you help to answer the below questions:

Did you attempt to test it multiple times on the tip of the git to see
if the problems goes away?

if same test is performed multiple times with or without reverting patch
on same platform (laptop/hardware/firmware) on which issue is observed
we may see same working/issue behavior. if it is regressing then always
it should work with or without reverting patches on same laptop. is this
the case here?

I don't see any regression here. I requested to retest with other
hardware/platform/system also as per my above test (output) all working
fine in 3 different platforms and not able to reproduce or recreate for
my side on 5.17.

Thanks,

Basavaraj

>
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nv4ZzNeRgRCrjnEgh5wHGcqSAHaCffdWxGm%2BsjiPu0Y%3D&reserved=0
>
> Ciao, Thorsten
>
>> Just curious reverting this patch how it is working just suspecting
>> firmware undefined behavior.
>>
>> If possible, please check on other platform/system also if same behavior
>> occurs.
>>
>> Could you please provide me platform/system details so that I can check
>> this behavior?
>>
>> Thanks,
>> Basavaraj
>>
>> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
>>> Hi, this is your Linux kernel regression tracker.
>>>
>>> I noticed a regression report in bugzilla.kernel.org that afaics nobody
>>> acted upon since it was reported about a week ago, that's why I decided
>>> to forward it to the lists and all people that seemed to be relevant
>>> here. It looks to me like this is something for Basavaraj, as it seems
>>> to be caused by	b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
>>> all command"). But I'm not totally sure, I only looked briefly into the
>>> details. Or was this discussed somewhere else already? Or even fixed?
>>>
>>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jXu50hKBHkHzjOrfEQ0sXme3%2BdliBd%2FleA%2F9oE61EpI%3D&reserved=0 :
>>>
>>>>  Marco 2022-03-25 15:22:19 UTC
>>>>
>>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=o443EB8xRW%2BwEi7pxB82A8B0oty64pBSQwAEU4sF2UA%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>>>
>>>> Marco.
>>> Anyway, to get this tracked:
>>>
>>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
>>> #regzbot from: Marco <rodomar705@protonmail.com>
>>> #regzbot title: input: hid: input from the accelerometer disappeared due
>>> to changes to amd_sfh
>>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=jXu50hKBHkHzjOrfEQ0sXme3%2BdliBd%2FleA%2F9oE61EpI%3D&amp;reserved=0
>>>
>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>
>>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>>> reports on my table. I can only look briefly into most of them and lack
>>> knowledge about most of the areas they concern. I thus unfortunately
>>> will sometimes get things wrong or miss something important. I hope
>>> that's not the case here; if you think it is, don't hesitate to tell me
>>> in a public reply, it's in everyone's interest to set the public record
>>> straight.
>>>
>>

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Thorsten Leemhuis]

On 04.04.22 09:18, Basavaraj Natikar wrote:
> 
> 
> On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:
>> On 01.04.22 21:47, Basavaraj Natikar wrote:
>>> Committed patch is disabling the interrupt mode and does not cause any
>>> functionality or working issues.
>> Well, for the reporter it clearly does cause problems, unless something
>> in testing went sideways.
>>
>>> I also cross verified on 3 system and working fine on 5.17 and not able
>>> to reproduce or recreate.
>>> [...]
>>> ------------------------------------------------
>>>
>>> Looks like this is not regression. May be some hardware/firmware bug.
>> Well, from the point of the kernel development process it afaics is a
>> regression, unless the testing went sideways. It doesn't matter if the
>> root cause is in fact a hardware/firmware bug, as what matters in the
>> scope of the kernel development is: things worked, and now they don't.
>> For details please check this file and read the quotes from Linus:
> 
> can you help to answer the below questions:

Me? No, I'm just the Linux kernels regression tracker trying to make
sure all regressions are handled appropriately. :-D

Marco, can you help out here?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I'm getting a lot of
reports on my table. I can only look briefly into most of them and lack
knowledge about most of the areas they concern. I thus unfortunately
will sometimes get things wrong or miss something important. I hope
that's not the case here; if you think it is, don't hesitate to tell me
in a public reply, it's in everyone's interest to set the public record
straight.

> Did you attempt to test it multiple times on the tip of the git to see
> if the problems goes away?
> 
> if same test is performed multiple times with or without reverting patch
> on same platform (laptop/hardware/firmware) on which issue is observed
> we may see same working/issue behavior. if it is regressing then always
> it should work with or without reverting patches on same laptop. is this
> the case here?
> 
> I don't see any regression here. I requested to retest with other
> hardware/platform/system also as per my above test (output) all working
> fine in 3 different platforms and not able to reproduce or recreate for
> my side on 5.17.
> 
> Thanks,
> 
> Basavaraj
> 
>>
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nv4ZzNeRgRCrjnEgh5wHGcqSAHaCffdWxGm%2BsjiPu0Y%3D&reserved=0
>>
>> Ciao, Thorsten
>>
>>> Just curious reverting this patch how it is working just suspecting
>>> firmware undefined behavior.
>>>
>>> If possible, please check on other platform/system also if same behavior
>>> occurs.
>>>
>>> Could you please provide me platform/system details so that I can check
>>> this behavior?
>>>
>>> Thanks,
>>> Basavaraj
>>>
>>> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
>>>> Hi, this is your Linux kernel regression tracker.
>>>>
>>>> I noticed a regression report in bugzilla.kernel.org that afaics nobody
>>>> acted upon since it was reported about a week ago, that's why I decided
>>>> to forward it to the lists and all people that seemed to be relevant
>>>> here. It looks to me like this is something for Basavaraj, as it seems
>>>> to be caused by	b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
>>>> all command"). But I'm not totally sure, I only looked briefly into the
>>>> details. Or was this discussed somewhere else already? Or even fixed?
>>>>
>>>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jXu50hKBHkHzjOrfEQ0sXme3%2BdliBd%2FleA%2F9oE61EpI%3D&reserved=0 :
>>>>
>>>>>  Marco 2022-03-25 15:22:19 UTC
>>>>>
>>>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=o443EB8xRW%2BwEi7pxB82A8B0oty64pBSQwAEU4sF2UA%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>>>>
>>>>> Marco.
>>>> Anyway, to get this tracked:
>>>>
>>>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
>>>> #regzbot from: Marco <rodomar705@protonmail.com>
>>>> #regzbot title: input: hid: input from the accelerometer disappeared due
>>>> to changes to amd_sfh
>>>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=jXu50hKBHkHzjOrfEQ0sXme3%2BdliBd%2FleA%2F9oE61EpI%3D&amp;reserved=0
>>>>
>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>>
>>>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>>>> reports on my table. I can only look briefly into most of them and lack
>>>> knowledge about most of the areas they concern. I thus unfortunately
>>>> will sometimes get things wrong or miss something important. I hope
>>>> that's not the case here; if you think it is, don't hesitate to tell me
>>>> in a public reply, it's in everyone's interest to set the public record
>>>> straight.
>>>>
>>>
> 
> 
> 

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Thorsten Leemhuis]

On 04.04.22 09:25, Thorsten Leemhuis wrote:
> On 04.04.22 09:18, Basavaraj Natikar wrote:
>>
>>
>> On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:
>>> On 01.04.22 21:47, Basavaraj Natikar wrote:
>>>> Committed patch is disabling the interrupt mode and does not cause any
>>>> functionality or working issues.
>>> Well, for the reporter it clearly does cause problems, unless something
>>> in testing went sideways.
>>>
>>>> I also cross verified on 3 system and working fine on 5.17 and not able
>>>> to reproduce or recreate.
>>>> [...]
>>>> ------------------------------------------------
>>>>
>>>> Looks like this is not regression. May be some hardware/firmware bug.
>>> Well, from the point of the kernel development process it afaics is a
>>> regression, unless the testing went sideways. It doesn't matter if the
>>> root cause is in fact a hardware/firmware bug, as what matters in the
>>> scope of the kernel development is: things worked, and now they don't.
>>> For details please check this file and read the quotes from Linus:
>>
>> can you help to answer the below questions:
> 
> Me? No, I'm just the Linux kernels regression tracker trying to make
> sure all regressions are handled appropriately. :-D
> 
> Marco, can you help out here?

Marco replied in private and allowed me to forward his reply:

```
I can't since, as mentioned previously, this is the only AMD laptop
device that I have.
I am sure this is a regression for me, even if the issue is firmware
related. I have tested the 5.17 stock arch kernel and the sensor is
gone. With the last three patches reverted the sensor is back and
working fine.

I would love to verify if the issue is hardware or software related, but
being outside of AMD and with AMD not releasing any public information
with datasheet/specification on their Sensor Fusion Hub I really can't
say anything specific.

This still remains a regression, since the hardware was working before
and now it doesn't.

By the way, I already have seen also this rework of this specific driver
https://github.com/conqp/amd-sfh-hid-dkms that even added a still
missing handler for the lid sensor switch for disabling touchpad and
keyboard, and all efforts tried to merge it upstream with all sorts of
issues.

Regardless of everything, this is a driver supported in kernel by AMD
engineers, so all of this doesn't matter. On my hardware this three
patches break a previously working hardware.
```

Ciao, Thorsten

> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> 
> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> reports on my table. I can only look briefly into most of them and lack
> knowledge about most of the areas they concern. I thus unfortunately
> will sometimes get things wrong or miss something important. I hope
> that's not the case here; if you think it is, don't hesitate to tell me
> in a public reply, it's in everyone's interest to set the public record
> straight.
> 
>> Did you attempt to test it multiple times on the tip of the git to see
>> if the problems goes away?
>>
>> if same test is performed multiple times with or without reverting patch
>> on same platform (laptop/hardware/firmware) on which issue is observed
>> we may see same working/issue behavior. if it is regressing then always
>> it should work with or without reverting patches on same laptop. is this
>> the case here?
>>
>> I don't see any regression here. I requested to retest with other
>> hardware/platform/system also as per my above test (output) all working
>> fine in 3 different platforms and not able to reproduce or recreate for
>> my side on 5.17.
>>
>> Thanks,
>>
>> Basavaraj
>>
>>>
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nv4ZzNeRgRCrjnEgh5wHGcqSAHaCffdWxGm%2BsjiPu0Y%3D&reserved=0
>>>
>>> Ciao, Thorsten
>>>
>>>> Just curious reverting this patch how it is working just suspecting
>>>> firmware undefined behavior.
>>>>
>>>> If possible, please check on other platform/system also if same behavior
>>>> occurs.
>>>>
>>>> Could you please provide me platform/system details so that I can check
>>>> this behavior?
>>>>
>>>> Thanks,
>>>> Basavaraj
>>>>
>>>> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
>>>>> Hi, this is your Linux kernel regression tracker.
>>>>>
>>>>> I noticed a regression report in bugzilla.kernel.org that afaics nobody
>>>>> acted upon since it was reported about a week ago, that's why I decided
>>>>> to forward it to the lists and all people that seemed to be relevant
>>>>> here. It looks to me like this is something for Basavaraj, as it seems
>>>>> to be caused by	b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
>>>>> all command"). But I'm not totally sure, I only looked briefly into the
>>>>> details. Or was this discussed somewhere else already? Or even fixed?
>>>>>
>>>>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jXu50hKBHkHzjOrfEQ0sXme3%2BdliBd%2FleA%2F9oE61EpI%3D&reserved=0 :
>>>>>
>>>>>>  Marco 2022-03-25 15:22:19 UTC
>>>>>>
>>>>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=o443EB8xRW%2BwEi7pxB82A8B0oty64pBSQwAEU4sF2UA%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>>>>>
>>>>>> Marco.
>>>>> Anyway, to get this tracked:
>>>>>
>>>>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
>>>>> #regzbot from: Marco <rodomar705@protonmail.com>
>>>>> #regzbot title: input: hid: input from the accelerometer disappeared due
>>>>> to changes to amd_sfh
>>>>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7Ca64876e42c174bf2df5608da16054550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846509153638366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=jXu50hKBHkHzjOrfEQ0sXme3%2BdliBd%2FleA%2F9oE61EpI%3D&amp;reserved=0
>>>>>
>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>>>
>>>>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>>>>> reports on my table. I can only look briefly into most of them and lack
>>>>> knowledge about most of the areas they concern. I thus unfortunately
>>>>> will sometimes get things wrong or miss something important. I hope
>>>>> that's not the case here; if you think it is, don't hesitate to tell me
>>>>> in a public reply, it's in everyone's interest to set the public record
>>>>> straight.
>>>>>
>>>>
>>
>>
>>

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Basavaraj Natikar]

On 4/4/2022 7:23 PM, Thorsten Leemhuis wrote:
> On 04.04.22 09:25, Thorsten Leemhuis wrote:
>> On 04.04.22 09:18, Basavaraj Natikar wrote:
>>>
>>> On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:
>>>> On 01.04.22 21:47, Basavaraj Natikar wrote:
>>>>> Committed patch is disabling the interrupt mode and does not cause any
>>>>> functionality or working issues.
>>>> Well, for the reporter it clearly does cause problems, unless something
>>>> in testing went sideways.
>>>>
>>>>> I also cross verified on 3 system and working fine on 5.17 and not able
>>>>> to reproduce or recreate.
>>>>> [...]
>>>>> ------------------------------------------------
>>>>>
>>>>> Looks like this is not regression. May be some hardware/firmware bug.
>>>> Well, from the point of the kernel development process it afaics is a
>>>> regression, unless the testing went sideways. It doesn't matter if the
>>>> root cause is in fact a hardware/firmware bug, as what matters in the
>>>> scope of the kernel development is: things worked, and now they don't.
>>>> For details please check this file and read the quotes from Linus:
>>> can you help to answer the below questions:
>> Me? No, I'm just the Linux kernels regression tracker trying to make
>> sure all regressions are handled appropriately. :-D
>>
>> Marco, can you help out here?
> Marco replied in private and allowed me to forward his reply:
>
> ```
> I can't since, as mentioned previously, this is the only AMD laptop
> device that I have.
> I am sure this is a regression for me, even if the issue is firmware
> related. I have tested the 5.17 stock arch kernel and the sensor is
> gone. With the last three patches reverted the sensor is back and
> working fine.
>
> I would love to verify if the issue is hardware or software related, but
> being outside of AMD and with AMD not releasing any public information
> with datasheet/specification on their Sensor Fusion Hub I really can't
> say anything specific.
>
> This still remains a regression, since the hardware was working before
> and now it doesn't.
>
> By the way, I already have seen also this rework of this specific driver
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fconqp%2Famd-sfh-hid-dkms&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nAmJdcP2ALl9cEaejWezLb9B3bU5Omp72Z6kjTbaBRY%3D&reserved=0 that even added a still
> missing handler for the lid sensor switch for disabling touchpad and
> keyboard, and all efforts tried to merge it upstream with all sorts of
> issues.
>
> Regardless of everything, this is a driver supported in kernel by AMD
> engineers, so all of this doesn't matter. On my hardware this three
> patches break a previously working hardware.
> ```

Thank You Marco for the information. 

Could you please provide me below results for acceleration
by re-applying and reverting patch once again on same laptop.

Did you attempt to test it multiple times on the tip of the git to see
if the problems goes away?

if same test is performed multiple times with or without reverting patch
on same laptop on which issue is observed
we may see same working/issue behavior. if it is regressing then always
it should work with or without reverting patches on same laptop. is this
the case here?

Thanks,

Basavaraj


> Ciao, Thorsten
>
>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>
>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>> reports on my table. I can only look briefly into most of them and lack
>> knowledge about most of the areas they concern. I thus unfortunately
>> will sometimes get things wrong or miss something important. I hope
>> that's not the case here; if you think it is, don't hesitate to tell me
>> in a public reply, it's in everyone's interest to set the public record
>> straight.
>>
>>> Did you attempt to test it multiple times on the tip of the git to see
>>> if the problems goes away?
>>>
>>> if same test is performed multiple times with or without reverting patch
>>> on same platform (laptop/hardware/firmware) on which issue is observed
>>> we may see same working/issue behavior. if it is regressing then always
>>> it should work with or without reverting patches on same laptop. is this
>>> the case here?
>>>
>>> I don't see any regression here. I requested to retest with other
>>> hardware/platform/system also as per my above test (output) all working
>>> fine in 3 different platforms and not able to reproduce or recreate for
>>> my side on 5.17.
>>>
>>> Thanks,
>>>
>>> Basavaraj
>>>
>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=9ORA2inmfocvEJ%2FXOov67q2ebzZrcuguViSPV%2B58yA0%3D&reserved=0
>>>>
>>>> Ciao, Thorsten
>>>>
>>>>> Just curious reverting this patch how it is working just suspecting
>>>>> firmware undefined behavior.
>>>>>
>>>>> If possible, please check on other platform/system also if same behavior
>>>>> occurs.
>>>>>
>>>>> Could you please provide me platform/system details so that I can check
>>>>> this behavior?
>>>>>
>>>>> Thanks,
>>>>> Basavaraj
>>>>>
>>>>> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
>>>>>> Hi, this is your Linux kernel regression tracker.
>>>>>>
>>>>>> I noticed a regression report in bugzilla.kernel.org that afaics nobody
>>>>>> acted upon since it was reported about a week ago, that's why I decided
>>>>>> to forward it to the lists and all people that seemed to be relevant
>>>>>> here. It looks to me like this is something for Basavaraj, as it seems
>>>>>> to be caused by	b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
>>>>>> all command"). But I'm not totally sure, I only looked briefly into the
>>>>>> details. Or was this discussed somewhere else already? Or even fixed?
>>>>>>
>>>>>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=pLGKHCV1ZNrXghGdDFG16sguRA8xi0VzUSG%2Fbw%2FQsBw%3D&reserved=0 :
>>>>>>
>>>>>>>  Marco 2022-03-25 15:22:19 UTC
>>>>>>>
>>>>>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=L36JFc%2BnejM4bJXfNui49v2uJKrS4cJnU93dpEhXPms%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>>>>>>
>>>>>>> Marco.
>>>>>> Anyway, to get this tracked:
>>>>>>
>>>>>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
>>>>>> #regzbot from: Marco <rodomar705@protonmail.com>
>>>>>> #regzbot title: input: hid: input from the accelerometer disappeared due
>>>>>> to changes to amd_sfh
>>>>>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=pLGKHCV1ZNrXghGdDFG16sguRA8xi0VzUSG%2Fbw%2FQsBw%3D&amp;reserved=0
>>>>>>
>>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>>>>
>>>>>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>>>>>> reports on my table. I can only look briefly into most of them and lack
>>>>>> knowledge about most of the areas they concern. I thus unfortunately
>>>>>> will sometimes get things wrong or miss something important. I hope
>>>>>> that's not the case here; if you think it is, don't hesitate to tell me
>>>>>> in a public reply, it's in everyone's interest to set the public record
>>>>>> straight.
>>>>>>
>>>
>>>

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Marco]

I've added the three test cases (dmesg + sudo monitor-sensor on all three tests) on the bug report on bugzilla.kernel.org. One is with the stock kernel from arch, 5.17.1. The other two is using zen patches on top of 5.17. One is without the three reverts above mentioned. Sensor is missing still. Then my same custom configuration only with the three reverts applied. The sensor is back and working.

If you need anything more, just let me know.

Link to bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215744

Marco.

Inviato con l'email sicura di ProtonMail.
------- Original Message -------
Il lunedì 4 aprile 2022 16:26, Marco <rodomar705@protonmail.com> ha scritto:


> I haven't tested this on the tip of the git tree, I can do this probably wednesday if it is needed.
>
> I'll post the output from sensors-detect shortly.
>
> Marco.
>
>
> Inviato da ProtonMail mobile
>
>
>
> -------- Messaggio originale --------
> On 4 apr 2022, 16:04, Basavaraj Natikar < bnatikar@amd.com> ha scritto:
>
> >
> >
> > >
> > >
> > > On 4/4/2022 7:23 PM, Thorsten Leemhuis wrote:
> > > > On 04.04.22 09:25, Thorsten Leemhuis wrote:
> > > >> On 04.04.22 09:18, Basavaraj Natikar wrote:
> > > >>>
> > > >>> On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:
> > > >>>> On 01.04.22 21:47, Basavaraj Natikar wrote:
> > > >>>>> Committed patch is disabling the interrupt mode and does not cause any
> > > >>>>> functionality or working issues.
> > > >>>> Well, for the reporter it clearly does cause problems, unless something
> > > >>>> in testing went sideways.
> > > >>>>
> > > >>>>> I also cross verified on 3 system and working fine on 5.17 and not able
> > > >>>>> to reproduce or recreate.
> > > >>>>> [...]
> > > >>>>> ------------------------------------------------
> > > >>>>>
> > > >>>>> Looks like this is not regression. May be some hardware/firmware bug.
> > > >>>> Well, from the point of the kernel development process it afaics is a
> > > >>>> regression, unless the testing went sideways. It doesn't matter if the
> > > >>>> root cause is in fact a hardware/firmware bug, as what matters in the
> > > >>>> scope of the kernel development is: things worked, and now they don't.
> > > >>>> For details please check this file and read the quotes from Linus:
> > > >>> can you help to answer the below questions:
> > > >> Me? No, I'm just the Linux kernels regression tracker trying to make
> > > >> sure all regressions are handled appropriately. :-D
> > > >>
> > > >> Marco, can you help out here?
> > > > Marco replied in private and allowed me to forward his reply:
> > > >
> > > > ```
> > > > I can't since, as mentioned previously, this is the only AMD laptop
> > > > device that I have.
> > > > I am sure this is a regression for me, even if the issue is firmware
> > > > related. I have tested the 5.17 stock arch kernel and the sensor is
> > > > gone. With the last three patches reverted the sensor is back and
> > > > working fine.
> > > >
> > > > I would love to verify if the issue is hardware or software related, but
> > > > being outside of AMD and with AMD not releasing any public information
> > > > with datasheet/specification on their Sensor Fusion Hub I really can't
> > > > say anything specific.
> > > >
> > > > This still remains a regression, since the hardware was working before
> > > > and now it doesn't.
> > > >
> > > > By the way, I already have seen also this rework of this specific driver
> > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fconqp%2Famd-sfh-hid-dkms&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=nAmJdcP2ALl9cEaejWezLb9B3bU5Omp72Z6kjTbaBRY%3D&amp;reserved=0 that even added a still
> > > > missing handler for the lid sensor switch for disabling touchpad and
> > > > keyboard, and all efforts tried to merge it upstream with all sorts of
> > > > issues.
> > > >
> > > > Regardless of everything, this is a driver supported in kernel by AMD
> > > > engineers, so all of this doesn't matter. On my hardware this three
> > > > patches break a previously working hardware.
> > > > ```
> > >
> > > Thank You Marco for the information.
> > >
> > > Could you please provide me below results for acceleration
> > > by re-applying and reverting patch once again on same laptop.
> > >
> > > Did you attempt to test it multiple times on the tip of the git to see
> > > if the problems goes away?
> > >
> > > if same test is performed multiple times with or without reverting patch
> > > on same laptop on which issue is observed
> > > we may see same working/issue behavior. if it is regressing then always
> > > it should work with or without reverting patches on same laptop. is this
> > > the case here?
> > >
> > > Thanks,
> > >
> > > Basavaraj
> > >
> > > > Ciao, Thorsten
> > > >
> > > >> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > > >>
> > > >> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > > >> reports on my table. I can only look briefly into most of them and lack
> > > >> knowledge about most of the areas they concern. I thus unfortunately
> > > >> will sometimes get things wrong or miss something important. I hope
> > > >> that's not the case here; if you think it is, don't hesitate to tell me
> > > >> in a public reply, it's in everyone's interest to set the public record
> > > >> straight.
> > > >>
> > > >>> Did you attempt to test it multiple times on the tip of the git to see
> > > >>> if the problems goes away?
> > > >>>
> > > >>> if same test is performed multiple times with or without reverting patch
> > > >>> on same platform (laptop/hardware/firmware) on which issue is observed
> > > >>> we may see same working/issue behavior. if it is regressing then always
> > > >>> it should work with or without reverting patches on same laptop. is this
> > > >>> the case here?
> > > >>>
> > > >>> I don't see any regression here. I requested to retest with other
> > > >>> hardware/platform/system also as per my above test (output) all working
> > > >>> fine in 3 different platforms and not able to reproduce or recreate for
> > > >>> my side on 5.17.
> > > >>>
> > > >>> Thanks,
> > > >>>
> > > >>> Basavaraj
> > > >>>
> > > >>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=9ORA2inmfocvEJ%2FXOov67q2ebzZrcuguViSPV%2B58yA0%3D&amp;reserved=0
> > > >>>>
> > > >>>> Ciao, Thorsten
> > > >>>>
> > > >>>>> Just curious reverting this patch how it is working just suspecting
> > > >>>>> firmware undefined behavior.
> > > >>>>>
> > > >>>>> If possible, please check on other platform/system also if same behavior
> > > >>>>> occurs.
> > > >>>>>
> > > >>>>> Could you please provide me platform/system details so that I can check
> > > >>>>> this behavior?
> > > >>>>>
> > > >>>>> Thanks,
> > > >>>>> Basavaraj
> > > >>>>>
> > > >>>>> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
> > > >>>>>> Hi, this is your Linux kernel regression tracker.
> > > >>>>>>
> > > >>>>>> I noticed a regression report in bugzilla.kernel.org that afaics nobody
> > > >>>>>> acted upon since it was reported about a week ago, that's why I decided
> > > >>>>>> to forward it to the lists and all people that seemed to be relevant
> > > >>>>>> here. It looks to me like this is something for Basavaraj, as it seems
> > > >>>>>> to be caused by b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
> > > >>>>>> all command"). But I'm not totally sure, I only looked briefly into the
> > > >>>>>> details. Or was this discussed somewhere else already? Or even fixed?
> > > >>>>>>
> > > >>>>>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=pLGKHCV1ZNrXghGdDFG16sguRA8xi0VzUSG%2Fbw%2FQsBw%3D&amp;reserved=0 :
> > > >>>>>>
> > > >>>>>>> Marco 2022-03-25 15:22:19 UTC
> > > >>>>>>>
> > > >>>>>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=L36JFc%2BnejM4bJXfNui49v2uJKrS4cJnU93dpEhXPms%3D&amp;reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
> > > >>>>>>>
> > > >>>>>>> Marco.
> > > >>>>>> Anyway, to get this tracked:
> > > >>>>>>
> > > >>>>>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
> > > >>>>>> #regzbot from: Marco <rodomar705@protonmail.com>
> > > >>>>>> #regzbot title: input: hid: input from the accelerometer disappeared due
> > > >>>>>> to changes to amd_sfh
> > > >>>>>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=04%7C01%7CBasavaraj.Natikar%40amd.com%7C05891d0582f94d68e7f908da164272ca%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637846771908092322%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=pLGKHCV1ZNrXghGdDFG16sguRA8xi0VzUSG%2Fbw%2FQsBw%3D&amp;reserved=0
> > > >>>>>>
> > > >>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > > >>>>>>
> > > >>>>>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > > >>>>>> reports on my table. I can only look briefly into most of them and lack
> > > >>>>>> knowledge about most of the areas they concern. I thus unfortunately
> > > >>>>>> will sometimes get things wrong or miss something important. I hope
> > > >>>>>> that's not the case here; if you think it is, don't hesitate to tell me
> > > >>>>>> in a public reply, it's in everyone's interest to set the public record
> > > >>>>>> straight.
> > > >>>>>>
> > > >>>
> > > >>>

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Marco]

Any updates to this issue? The latest kernel 5.17.3 is still problematic for me.

Inviato con l'email sicura di ProtonMail.
------- Original Message -------
Il lunedì 4 aprile 2022 19:40, Marco <rodomar705@protonmail.com> ha scritto:


> I've added the three test cases (dmesg + sudo monitor-sensor on all three tests) on the bug report on bugzilla.kernel.org. One is with the stock kernel from arch, 5.17.1. The other two is using zen patches on top of 5.17. One is without the three reverts above mentioned. Sensor is missing still. Then my same custom configuration only with the three reverts applied. The sensor is back and working.
>
> If you need anything more, just let me know.
>
> Link to bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215744
>
> Marco.
>
> Inviato con l'email sicura di ProtonMail.
> ------- Original Message -------
> Il lunedì 4 aprile 2022 16:26, Marco rodomar705@protonmail.com ha scritto:
>
>
>
> > I haven't tested this on the tip of the git tree, I can do this probably wednesday if it is needed.
> >
> > I'll post the output from sensors-detect shortly.
> >
> > Marco.
> >
> > Inviato da ProtonMail mobile
> >
> > -------- Messaggio originale --------
> > On 4 apr 2022, 16:04, Basavaraj Natikar < bnatikar@amd.com> ha scritto:
> >
> > > > On 4/4/2022 7:23 PM, Thorsten Leemhuis wrote:
> > > >
> > > > > On 04.04.22 09:25, Thorsten Leemhuis wrote:
> > > > >
> > > > > > On 04.04.22 09:18, Basavaraj Natikar wrote:
> > > > > >
> > > > > > > On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:
> > > > > > >
> > > > > > > > On 01.04.22 21:47, Basavaraj Natikar wrote:
> > > > > > > >
> > > > > > > > > Committed patch is disabling the interrupt mode and does not cause any
> > > > > > > > > functionality or working issues.
> > > > > > > > > Well, for the reporter it clearly does cause problems, unless something
> > > > > > > > > in testing went sideways.
> > > > > > > >
> > > > > > > > > I also cross verified on 3 system and working fine on 5.17 and not able
> > > > > > > > > to reproduce or recreate.
> > > > > > > > > [...]
> > > > > > > > > ------------------------------------------------
> > > > > > > > >
> > > > > > > > > Looks like this is not regression. May be some hardware/firmware bug.
> > > > > > > > > Well, from the point of the kernel development process it afaics is a
> > > > > > > > > regression, unless the testing went sideways. It doesn't matter if the
> > > > > > > > > root cause is in fact a hardware/firmware bug, as what matters in the
> > > > > > > > > scope of the kernel development is: things worked, and now they don't.
> > > > > > > > > For details please check this file and read the quotes from Linus:
> > > > > > > > > can you help to answer the below questions:
> > > > > > > > > Me? No, I'm just the Linux kernels regression tracker trying to make
> > > > > > > > > sure all regressions are handled appropriately. :-D
> > > > > >
> > > > > > Marco, can you help out here?
> > > > > > Marco replied in private and allowed me to forward his reply:
> > > > >
> > > > > ```
> > > > > I can't since, as mentioned previously, this is the only AMD laptop
> > > > > device that I have.
> > > > > I am sure this is a regression for me, even if the issue is firmware
> > > > > related. I have tested the 5.17 stock arch kernel and the sensor is
> > > > > gone. With the last three patches reverted the sensor is back and
> > > > > working fine.
> > > > >
> > > > > I would love to verify if the issue is hardware or software related, but
> > > > > being outside of AMD and with AMD not releasing any public information
> > > > > with datasheet/specification on their Sensor Fusion Hub I really can't
> > > > > say anything specific.
> > > > >
> > > > > This still remains a regression, since the hardware was working before
> > > > > and now it doesn't.
> > > > >
> > > > > By the way, I already have seen also this rework of this specific driver
> > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fconqp%2Famd-sfh-hid-dkms&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=nAmJdcP2ALl9cEaejWezLb9B3bU5Omp72Z6kjTbaBRY%3D&reserved=0 that even added a still
> > > > > missing handler for the lid sensor switch for disabling touchpad and
> > > > > keyboard, and all efforts tried to merge it upstream with all sorts of
> > > > > issues.
> > > > >
> > > > > Regardless of everything, this is a driver supported in kernel by AMD
> > > > > engineers, so all of this doesn't matter. On my hardware this three
> > > > > patches break a previously working hardware.
> > > > > ```
> > > >
> > > > Thank You Marco for the information.
> > > >
> > > > Could you please provide me below results for acceleration
> > > > by re-applying and reverting patch once again on same laptop.
> > > >
> > > > Did you attempt to test it multiple times on the tip of the git to see
> > > > if the problems goes away?
> > > >
> > > > if same test is performed multiple times with or without reverting patch
> > > > on same laptop on which issue is observed
> > > > we may see same working/issue behavior. if it is regressing then always
> > > > it should work with or without reverting patches on same laptop. is this
> > > > the case here?
> > > >
> > > > Thanks,
> > > >
> > > > Basavaraj
> > > >
> > > > > Ciao, Thorsten
> > > > >
> > > > > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > > > > >
> > > > > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > > > > > reports on my table. I can only look briefly into most of them and lack
> > > > > > knowledge about most of the areas they concern. I thus unfortunately
> > > > > > will sometimes get things wrong or miss something important. I hope
> > > > > > that's not the case here; if you think it is, don't hesitate to tell me
> > > > > > in a public reply, it's in everyone's interest to set the public record
> > > > > > straight.
> > > > > >
> > > > > > > Did you attempt to test it multiple times on the tip of the git to see
> > > > > > > if the problems goes away?
> > > > > > >
> > > > > > > if same test is performed multiple times with or without reverting patch
> > > > > > > on same platform (laptop/hardware/firmware) on which issue is observed
> > > > > > > we may see same working/issue behavior. if it is regressing then always
> > > > > > > it should work with or without reverting patches on same laptop. is this
> > > > > > > the case here?
> > > > > > >
> > > > > > > I don't see any regression here. I requested to retest with other
> > > > > > > hardware/platform/system also as per my above test (output) all working
> > > > > > > fine in 3 different platforms and not able to reproduce or recreate for
> > > > > > > my side on 5.17.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Basavaraj
> > > > > > >
> > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=9ORA2inmfocvEJ%2FXOov67q2ebzZrcuguViSPV%2B58yA0%3D&reserved=0
> > > > > > > >
> > > > > > > > Ciao, Thorsten
> > > > > > > >
> > > > > > > > > Just curious reverting this patch how it is working just suspecting
> > > > > > > > > firmware undefined behavior.
> > > > > > > > >
> > > > > > > > > If possible, please check on other platform/system also if same behavior
> > > > > > > > > occurs.
> > > > > > > > >
> > > > > > > > > Could you please provide me platform/system details so that I can check
> > > > > > > > > this behavior?
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Basavaraj
> > > > > > > > >
> > > > > > > > > On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
> > > > > > > > >
> > > > > > > > > > Hi, this is your Linux kernel regression tracker.
> > > > > > > > > >
> > > > > > > > > > I noticed a regression report in bugzilla.kernel.org that afaics nobody
> > > > > > > > > > acted upon since it was reported about a week ago, that's why I decided
> > > > > > > > > > to forward it to the lists and all people that seemed to be relevant
> > > > > > > > > > here. It looks to me like this is something for Basavaraj, as it seems
> > > > > > > > > > to be caused by b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
> > > > > > > > > > all command"). But I'm not totally sure, I only looked briefly into the
> > > > > > > > > > details. Or was this discussed somewhere else already? Or even fixed?
> > > > > > > > > >
> > > > > > > > > > To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=pLGKHCV1ZNrXghGdDFG16sguRA8xi0VzUSG%2Fbw%2FQsBw%3D&reserved=0 :
> > > > > > > > > >
> > > > > > > > > > > Marco 2022-03-25 15:22:19 UTC
> > > > > > > > > > >
> > > > > > > > > > > After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=L36JFc%2BnejM4bJXfNui49v2uJKrS4cJnU93dpEhXPms%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
> > > > > > > > > > >
> > > > > > > > > > > Marco.
> > > > > > > > > > > Anyway, to get this tracked:
> > > > > > > > > >
> > > > > > > > > > #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
> > > > > > > > > > #regzbot from: Marco rodomar705@protonmail.com
> > > > > > > > > > #regzbot title: input: hid: input from the accelerometer disappeared due
> > > > > > > > > > to changes to amd_sfh
> > > > > > > > > > #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=pLGKHCV1ZNrXghGdDFG16sguRA8xi0VzUSG%2Fbw%2FQsBw%3D&reserved=0
> > > > > > > > > >
> > > > > > > > > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > > > > > > > > >
> > > > > > > > > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > > > > > > > > > reports on my table. I can only look briefly into most of them and lack
> > > > > > > > > > knowledge about most of the areas they concern. I thus unfortunately
> > > > > > > > > > will sometimes get things wrong or miss something important. I hope
> > > > > > > > > > that's not the case here; if you think it is, don't hesitate to tell me
> > > > > > > > > > in a public reply, it's in everyone's interest to set the public record
> > > > > > > > > > straight.

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Benjamin Tissoires]

Jiri, it seems you are pushing patches to the tree (or at least were),
I would suggest reverting b300667b33b2 because there is obviously a
regression, and we'll let Basavaraj figure out a better solution in a
future release.

Cheers,
Benjamin

On Sun, Apr 17, 2022 at 7:16 PM Marco <rodomar705@protonmail.com> wrote:
>
> Any updates to this issue? The latest kernel 5.17.3 is still problematic for me.
>
> Inviato con l'email sicura di ProtonMail.
> ------- Original Message -------
> Il lunedì 4 aprile 2022 19:40, Marco <rodomar705@protonmail.com> ha scritto:
>
>
> > I've added the three test cases (dmesg + sudo monitor-sensor on all three tests) on the bug report on bugzilla.kernel.org. One is with the stock kernel from arch, 5.17.1. The other two is using zen patches on top of 5.17. One is without the three reverts above mentioned. Sensor is missing still. Then my same custom configuration only with the three reverts applied. The sensor is back and working.
> >
> > If you need anything more, just let me know.
> >
> > Link to bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215744
> >
> > Marco.
> >
> > Inviato con l'email sicura di ProtonMail.
> > ------- Original Message -------
> > Il lunedì 4 aprile 2022 16:26, Marco rodomar705@protonmail.com ha scritto:
> >
> >
> >
> > > I haven't tested this on the tip of the git tree, I can do this probably wednesday if it is needed.
> > >
> > > I'll post the output from sensors-detect shortly.
> > >
> > > Marco.
> > >
> > > Inviato da ProtonMail mobile
> > >
> > > -------- Messaggio originale --------
> > > On 4 apr 2022, 16:04, Basavaraj Natikar < bnatikar@amd.com> ha scritto:
> > >
> > > > > On 4/4/2022 7:23 PM, Thorsten Leemhuis wrote:
> > > > >
> > > > > > On 04.04.22 09:25, Thorsten Leemhuis wrote:
> > > > > >
> > > > > > > On 04.04.22 09:18, Basavaraj Natikar wrote:
> > > > > > >
> > > > > > > > On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:
> > > > > > > >
> > > > > > > > > On 01.04.22 21:47, Basavaraj Natikar wrote:
> > > > > > > > >
> > > > > > > > > > Committed patch is disabling the interrupt mode and does not cause any
> > > > > > > > > > functionality or working issues.
> > > > > > > > > > Well, for the reporter it clearly does cause problems, unless something
> > > > > > > > > > in testing went sideways.
> > > > > > > > >
> > > > > > > > > > I also cross verified on 3 system and working fine on 5.17 and not able
> > > > > > > > > > to reproduce or recreate.
> > > > > > > > > > [...]
> > > > > > > > > > ------------------------------------------------
> > > > > > > > > >
> > > > > > > > > > Looks like this is not regression. May be some hardware/firmware bug.
> > > > > > > > > > Well, from the point of the kernel development process it afaics is a
> > > > > > > > > > regression, unless the testing went sideways. It doesn't matter if the
> > > > > > > > > > root cause is in fact a hardware/firmware bug, as what matters in the
> > > > > > > > > > scope of the kernel development is: things worked, and now they don't.
> > > > > > > > > > For details please check this file and read the quotes from Linus:
> > > > > > > > > > can you help to answer the below questions:
> > > > > > > > > > Me? No, I'm just the Linux kernels regression tracker trying to make
> > > > > > > > > > sure all regressions are handled appropriately. :-D
> > > > > > >
> > > > > > > Marco, can you help out here?
> > > > > > > Marco replied in private and allowed me to forward his reply:
> > > > > >
> > > > > > ```
> > > > > > I can't since, as mentioned previously, this is the only AMD laptop
> > > > > > device that I have.
> > > > > > I am sure this is a regression for me, even if the issue is firmware
> > > > > > related. I have tested the 5.17 stock arch kernel and the sensor is
> > > > > > gone. With the last three patches reverted the sensor is back and
> > > > > > working fine.
> > > > > >
> > > > > > I would love to verify if the issue is hardware or software related, but
> > > > > > being outside of AMD and with AMD not releasing any public information
> > > > > > with datasheet/specification on their Sensor Fusion Hub I really can't
> > > > > > say anything specific.
> > > > > >
> > > > > > This still remains a regression, since the hardware was working before
> > > > > > and now it doesn't.
> > > > > >
> > > > > > By the way, I already have seen also this rework of this specific driver
> > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fconqp%2Famd-sfh-hid-dkms&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=nAmJdcP2ALl9cEaejWezLb9B3bU5Omp72Z6kjTbaBRY%3D&reserved=0 that even added a still
> > > > > > missing handler for the lid sensor switch for disabling touchpad and
> > > > > > keyboard, and all efforts tried to merge it upstream with all sorts of
> > > > > > issues.
> > > > > >
> > > > > > Regardless of everything, this is a driver supported in kernel by AMD
> > > > > > engineers, so all of this doesn't matter. On my hardware this three
> > > > > > patches break a previously working hardware.
> > > > > > ```
> > > > >
> > > > > Thank You Marco for the information.
> > > > >
> > > > > Could you please provide me below results for acceleration
> > > > > by re-applying and reverting patch once again on same laptop.
> > > > >
> > > > > Did you attempt to test it multiple times on the tip of the git to see
> > > > > if the problems goes away?
> > > > >
> > > > > if same test is performed multiple times with or without reverting patch
> > > > > on same laptop on which issue is observed
> > > > > we may see same working/issue behavior. if it is regressing then always
> > > > > it should work with or without reverting patches on same laptop. is this
> > > > > the case here?
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Basavaraj
> > > > >
> > > > > > Ciao, Thorsten
> > > > > >
> > > > > > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > > > > > >
> > > > > > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > > > > > > reports on my table. I can only look briefly into most of them and lack
> > > > > > > knowledge about most of the areas they concern. I thus unfortunately
> > > > > > > will sometimes get things wrong or miss something important. I hope
> > > > > > > that's not the case here; if you think it is, don't hesitate to tell me
> > > > > > > in a public reply, it's in everyone's interest to set the public record
> > > > > > > straight.
> > > > > > >
> > > > > > > > Did you attempt to test it multiple times on the tip of the git to see
> > > > > > > > if the problems goes away?
> > > > > > > >
> > > > > > > > if same test is performed multiple times with or without reverting patch
> > > > > > > > on same platform (laptop/hardware/firmware) on which issue is observed
> > > > > > > > we may see same working/issue behavior. if it is regressing then always
> > > > > > > > it should work with or without reverting patches on same laptop. is this
> > > > > > > > the case here?
> > > > > > > >
> > > > > > > > I don't see any regression here. I requested to retest with other
> > > > > > > > hardware/platform/system also as per my above test (output) all working
> > > > > > > > fine in 3 different platforms and not able to reproduce or recreate for
> > > > > > > > my side on 5.17.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Basavaraj
> > > > > > > >
> > > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=9ORA2inmfocvEJ%2FXOov67q2ebzZrcuguViSPV%2B58yA0%3D&reserved=0
> > > > > > > > >
> > > > > > > > > Ciao, Thorsten
> > > > > > > > >
> > > > > > > > > > Just curious reverting this patch how it is working just suspecting
> > > > > > > > > > firmware undefined behavior.
> > > > > > > > > >
> > > > > > > > > > If possible, please check on other platform/system also if same behavior
> > > > > > > > > > occurs.
> > > > > > > > > >
> > > > > > > > > > Could you please provide me platform/system details so that I can check
> > > > > > > > > > this behavior?
> > > > > > > > > >
> > > > > > > > > > Thanks,
> > > > > > > > > > Basavaraj
> > > > > > > > > >
> > > > > > > > > > On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
> > > > > > > > > >
> > > > > > > > > > > Hi, this is your Linux kernel regression tracker.
> > > > > > > > > > >
> > > > > > > > > > > I noticed a regression report in bugzilla.kernel.org that afaics nobody
> > > > > > > > > > > acted upon since it was reported about a week ago, that's why I decided
> > > > > > > > > > > to forward it to the lists and all people that seemed to be relevant
> > > > > > > > > > > here. It looks to me like this is something for Basavaraj, as it seems
> > > > > > > > > > > to be caused by b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
> > > > > > > > > > > all command"). But I'm not totally sure, I only looked briefly into the
> > > > > > > > > > > details. Or was this discussed somewhere else already? Or even fixed?
> > > > > > > > > > >
> > > > > > > > > > > To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=pLGKHCV1ZNrXghGdDFG16sguRA8xi0VzUSG%2Fbw%2FQsBw%3D&reserved=0 :
> > > > > > > > > > >
> > > > > > > > > > > > Marco 2022-03-25 15:22:19 UTC
> > > > > > > > > > > >
> > > > > > > > > > > > After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=L36JFc%2BnejM4bJXfNui49v2uJKrS4cJnU93dpEhXPms%3D&reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
> > > > > > > > > > > >
> > > > > > > > > > > > Marco.
> > > > > > > > > > > > Anyway, to get this tracked:
> > > > > > > > > > >
> > > > > > > > > > > #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
> > > > > > > > > > > #regzbot from: Marco rodomar705@protonmail.com
> > > > > > > > > > > #regzbot title: input: hid: input from the accelerometer disappeared due
> > > > > > > > > > > to changes to amd_sfh
> > > > > > > > > > > #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&data=04|01|Basavaraj.Natikar%40amd.com|05891d0582f94d68e7f908da164272ca|3dd8961fe4884e608e11a82d994e183d|0|0|637846771908092322|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=pLGKHCV1ZNrXghGdDFG16sguRA8xi0VzUSG%2Fbw%2FQsBw%3D&reserved=0
> > > > > > > > > > >
> > > > > > > > > > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > > > > > > > > > >
> > > > > > > > > > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> > > > > > > > > > > reports on my table. I can only look briefly into most of them and lack
> > > > > > > > > > > knowledge about most of the areas they concern. I thus unfortunately
> > > > > > > > > > > will sometimes get things wrong or miss something important. I hope
> > > > > > > > > > > that's not the case here; if you think it is, don't hesitate to tell me
> > > > > > > > > > > in a public reply, it's in everyone's interest to set the public record
> > > > > > > > > > > straight.
>

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Basavaraj Natikar]

Hi Benjamin,

BIOS/firmware confirmed that there is issue in ASUS BIOS/firmware.
I will update BIOS details in bug which resolves this BIOS/firmware issue.

Also issue is not seen in any other systems/laptops.

Thanks,
Basavaraj


On 4/21/2022 2:45 PM, Benjamin Tissoires wrote:
> Jiri, it seems you are pushing patches to the tree (or at least were),
> I would suggest reverting b300667b33b2 because there is obviously a
> regression, and we'll let Basavaraj figure out a better solution in a
> future release.
>
> Cheers,
> Benjamin
>
> On Sun, Apr 17, 2022 at 7:16 PM Marco <rodomar705@protonmail.com> wrote:
>> Any updates to this issue? The latest kernel 5.17.3 is still problematic for me.
>>
>> Inviato con l'email sicura di ProtonMail.
>> ------- Original Message -------
>> Il lunedì 4 aprile 2022 19:40, Marco <rodomar705@protonmail.com> ha scritto:
>>
>>
>>> I've added the three test cases (dmesg + sudo monitor-sensor on all three tests) on the bug report on bugzilla.kernel.org. One is with the stock kernel from arch, 5.17.1. The other two is using zen patches on top of 5.17. One is without the three reverts above mentioned. Sensor is missing still. Then my same custom configuration only with the three reverts applied. The sensor is back and working.
>>>
>>> If you need anything more, just let me know.
>>>
>>> Link to bugzilla: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=xA%2FLcZu8M1xEQsT3qJ5ESSEHybNFOVhoHchhuOryF8A%3D&amp;reserved=0
>>>
>>> Marco.
>>>
>>> Inviato con l'email sicura di ProtonMail.
>>> ------- Original Message -------
>>> Il lunedì 4 aprile 2022 16:26, Marco rodomar705@protonmail.com ha scritto:
>>>
>>>
>>>
>>>> I haven't tested this on the tip of the git tree, I can do this probably wednesday if it is needed.
>>>>
>>>> I'll post the output from sensors-detect shortly.
>>>>
>>>> Marco.
>>>>
>>>> Inviato da ProtonMail mobile
>>>>
>>>> -------- Messaggio originale --------
>>>> On 4 apr 2022, 16:04, Basavaraj Natikar < bnatikar@amd.com> ha scritto:
>>>>
>>>>>> On 4/4/2022 7:23 PM, Thorsten Leemhuis wrote:
>>>>>>
>>>>>>> On 04.04.22 09:25, Thorsten Leemhuis wrote:
>>>>>>>
>>>>>>>> On 04.04.22 09:18, Basavaraj Natikar wrote:
>>>>>>>>
>>>>>>>>> On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:
>>>>>>>>>
>>>>>>>>>> On 01.04.22 21:47, Basavaraj Natikar wrote:
>>>>>>>>>>
>>>>>>>>>>> Committed patch is disabling the interrupt mode and does not cause any
>>>>>>>>>>> functionality or working issues.
>>>>>>>>>>> Well, for the reporter it clearly does cause problems, unless something
>>>>>>>>>>> in testing went sideways.
>>>>>>>>>>> I also cross verified on 3 system and working fine on 5.17 and not able
>>>>>>>>>>> to reproduce or recreate.
>>>>>>>>>>> [...]
>>>>>>>>>>> ------------------------------------------------
>>>>>>>>>>>
>>>>>>>>>>> Looks like this is not regression. May be some hardware/firmware bug.
>>>>>>>>>>> Well, from the point of the kernel development process it afaics is a
>>>>>>>>>>> regression, unless the testing went sideways. It doesn't matter if the
>>>>>>>>>>> root cause is in fact a hardware/firmware bug, as what matters in the
>>>>>>>>>>> scope of the kernel development is: things worked, and now they don't.
>>>>>>>>>>> For details please check this file and read the quotes from Linus:
>>>>>>>>>>> can you help to answer the below questions:
>>>>>>>>>>> Me? No, I'm just the Linux kernels regression tracker trying to make
>>>>>>>>>>> sure all regressions are handled appropriately. :-D
>>>>>>>> Marco, can you help out here?
>>>>>>>> Marco replied in private and allowed me to forward his reply:
>>>>>>> ```
>>>>>>> I can't since, as mentioned previously, this is the only AMD laptop
>>>>>>> device that I have.
>>>>>>> I am sure this is a regression for me, even if the issue is firmware
>>>>>>> related. I have tested the 5.17 stock arch kernel and the sensor is
>>>>>>> gone. With the last three patches reverted the sensor is back and
>>>>>>> working fine.
>>>>>>>
>>>>>>> I would love to verify if the issue is hardware or software related, but
>>>>>>> being outside of AMD and with AMD not releasing any public information
>>>>>>> with datasheet/specification on their Sensor Fusion Hub I really can't
>>>>>>> say anything specific.
>>>>>>>
>>>>>>> This still remains a regression, since the hardware was working before
>>>>>>> and now it doesn't.
>>>>>>>
>>>>>>> By the way, I already have seen also this rework of this specific driver
>>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fconqp%2Famd-sfh-hid-dkms&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=dwq1ETuquRbWavl4Sb98TOesitSiQjeuq6hN2mxqamQ%3D&amp;reserved=0 that even added a still
>>>>>>> missing handler for the lid sensor switch for disabling touchpad and
>>>>>>> keyboard, and all efforts tried to merge it upstream with all sorts of
>>>>>>> issues.
>>>>>>>
>>>>>>> Regardless of everything, this is a driver supported in kernel by AMD
>>>>>>> engineers, so all of this doesn't matter. On my hardware this three
>>>>>>> patches break a previously working hardware.
>>>>>>> ```
>>>>>> Thank You Marco for the information.
>>>>>>
>>>>>> Could you please provide me below results for acceleration
>>>>>> by re-applying and reverting patch once again on same laptop.
>>>>>>
>>>>>> Did you attempt to test it multiple times on the tip of the git to see
>>>>>> if the problems goes away?
>>>>>>
>>>>>> if same test is performed multiple times with or without reverting patch
>>>>>> on same laptop on which issue is observed
>>>>>> we may see same working/issue behavior. if it is regressing then always
>>>>>> it should work with or without reverting patches on same laptop. is this
>>>>>> the case here?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Basavaraj
>>>>>>
>>>>>>> Ciao, Thorsten
>>>>>>>
>>>>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>>>>>>
>>>>>>>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>>>>>>>> reports on my table. I can only look briefly into most of them and lack
>>>>>>>> knowledge about most of the areas they concern. I thus unfortunately
>>>>>>>> will sometimes get things wrong or miss something important. I hope
>>>>>>>> that's not the case here; if you think it is, don't hesitate to tell me
>>>>>>>> in a public reply, it's in everyone's interest to set the public record
>>>>>>>> straight.
>>>>>>>>
>>>>>>>>> Did you attempt to test it multiple times on the tip of the git to see
>>>>>>>>> if the problems goes away?
>>>>>>>>>
>>>>>>>>> if same test is performed multiple times with or without reverting patch
>>>>>>>>> on same platform (laptop/hardware/firmware) on which issue is observed
>>>>>>>>> we may see same working/issue behavior. if it is regressing then always
>>>>>>>>> it should work with or without reverting patches on same laptop. is this
>>>>>>>>> the case here?
>>>>>>>>>
>>>>>>>>> I don't see any regression here. I requested to retest with other
>>>>>>>>> hardware/platform/system also as per my above test (output) all working
>>>>>>>>> fine in 3 different platforms and not able to reproduce or recreate for
>>>>>>>>> my side on 5.17.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>>
>>>>>>>>> Basavaraj
>>>>>>>>>
>>>>>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandling-regressions.rst&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=XBa%2Bf69TKahhgksrEvjgpEDFNwV453INzJ7pO6BGTHM%3D&amp;reserved=0
>>>>>>>>>>
>>>>>>>>>> Ciao, Thorsten
>>>>>>>>>>
>>>>>>>>>>> Just curious reverting this patch how it is working just suspecting
>>>>>>>>>>> firmware undefined behavior.
>>>>>>>>>>>
>>>>>>>>>>> If possible, please check on other platform/system also if same behavior
>>>>>>>>>>> occurs.
>>>>>>>>>>>
>>>>>>>>>>> Could you please provide me platform/system details so that I can check
>>>>>>>>>>> this behavior?
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Basavaraj
>>>>>>>>>>>
>>>>>>>>>>> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi, this is your Linux kernel regression tracker.
>>>>>>>>>>>>
>>>>>>>>>>>> I noticed a regression report in bugzilla.kernel.org that afaics nobody
>>>>>>>>>>>> acted upon since it was reported about a week ago, that's why I decided
>>>>>>>>>>>> to forward it to the lists and all people that seemed to be relevant
>>>>>>>>>>>> here. It looks to me like this is something for Basavaraj, as it seems
>>>>>>>>>>>> to be caused by b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
>>>>>>>>>>>> all command"). But I'm not totally sure, I only looked briefly into the
>>>>>>>>>>>> details. Or was this discussed somewhere else already? Or even fixed?
>>>>>>>>>>>>
>>>>>>>>>>>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=xA%2FLcZu8M1xEQsT3qJ5ESSEHybNFOVhoHchhuOryF8A%3D&amp;reserved=0 :
>>>>>>>>>>>>
>>>>>>>>>>>>> Marco 2022-03-25 15:22:19 UTC
>>>>>>>>>>>>>
>>>>>>>>>>>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=REu14KaEX0CrJgKvUedQ%2BXI%2Fw5Y156l%2BFEfCPMWbgGI%3D&amp;reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Marco.
>>>>>>>>>>>>> Anyway, to get this tracked:
>>>>>>>>>>>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
>>>>>>>>>>>> #regzbot from: Marco rodomar705@protonmail.com
>>>>>>>>>>>> #regzbot title: input: hid: input from the accelerometer disappeared due
>>>>>>>>>>>> to changes to amd_sfh
>>>>>>>>>>>> #regzbot link: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=xA%2FLcZu8M1xEQsT3qJ5ESSEHybNFOVhoHchhuOryF8A%3D&amp;reserved=0
>>>>>>>>>>>>
>>>>>>>>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>>>>>>>>>>
>>>>>>>>>>>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>>>>>>>>>>>> reports on my table. I can only look briefly into most of them and lack
>>>>>>>>>>>> knowledge about most of the areas they concern. I thus unfortunately
>>>>>>>>>>>> will sometimes get things wrong or miss something important. I hope
>>>>>>>>>>>> that's not the case here; if you think it is, don't hesitate to tell me
>>>>>>>>>>>> in a public reply, it's in everyone's interest to set the public record
>>>>>>>>>>>> straight.

RE: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17

[Natikar, Basavaraj]

[-- Attachment #1.1: Type: text/plain, Size: 15086 bytes --]

[AMD Official Use Only - General]


Hi Marco,



BIOS/firmware confirmed that there is issue in ASUS BIOS/firmware.

Please find attached BIOS details from ASUS which resolves this BIOS/firmware issue.



Please contact ASUS for any ASUS BIOS support.



As this is not Linux issue .Please close this bug.



Sorry for attaching this to mail . Since Bugzilla.kernel.org displaying this below message.



The file you are trying to attach is 5615 kilobytes (KB) in size. Attachments cannot be more than 5120 KB.

We recommend that you store your attachment elsewhere and then paste the URL to this file on the attachment creation page in the appropriate text field, which you can access by clicking the "paste text as attachment" link.

Alternately, if your attachment is an image, you could convert it to a compressible format like JPG or PNG and try again.



Thanks,

Basavaraj



-----Original Message-----
From: Natikar, Basavaraj
Sent: Thursday, April 21, 2022 2:54 PM
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>; Marco <rodomar705@protonmail.com>
Cc: regressions@leemhuis.info; Natikar, Basavaraj <Basavaraj.Natikar@amd.com>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; regressions@lists.linux.dev; jkosina@suse.cz
Subject: Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17



Hi Benjamin,



BIOS/firmware confirmed that there is issue in ASUS BIOS/firmware.

I will update BIOS details in bug which resolves this BIOS/firmware issue.



Also issue is not seen in any other systems/laptops.



Thanks,

Basavaraj





On 4/21/2022 2:45 PM, Benjamin Tissoires wrote:

> Jiri, it seems you are pushing patches to the tree (or at least were),

> I would suggest reverting b300667b33b2 because there is obviously a

> regression, and we'll let Basavaraj figure out a better solution in a

> future release.

>

> Cheers,

> Benjamin

>

> On Sun, Apr 17, 2022 at 7:16 PM Marco <rodomar705@protonmail.com<mailto:rodomar705@protonmail.com>> wrote:

>> Any updates to this issue? The latest kernel 5.17.3 is still problematic for me.

>>

>> Inviato con l'email sicura di ProtonMail.

>> ------- Original Message -------

>> Il lunedì 4 aprile 2022 19:40, Marco <rodomar705@protonmail.com<mailto:rodomar705@protonmail.com>> ha scritto:

>>

>>

>>> I've added the three test cases (dmesg + sudo monitor-sensor on all three tests) on the bug report on bugzilla.kernel.org. One is with the stock kernel from arch, 5.17.1. The other two is using zen patches on top of 5.17. One is without the three reverts above mentioned. Sensor is missing still. Then my same custom configuration only with the three reverts applied. The sensor is back and working.

>>>

>>> If you need anything more, just let me know.

>>>

>>> Link to bugzilla:

>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbu

>>> gzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=05%7C01%7CBa

>>> savaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd89

>>> 61fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7

>>> CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ

>>> XVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=xA%2FLcZu8M1xEQsT3qJ5ESSEHybNF

>>> OVhoHchhuOryF8A%3D&amp;reserved=0

>>>

>>> Marco.

>>>

>>> Inviato con l'email sicura di ProtonMail.

>>> ------- Original Message -------

>>> Il lunedì 4 aprile 2022 16:26, Marco rodomar705@protonmail.com<mailto:rodomar705@protonmail.com> ha scritto:

>>>

>>>

>>>

>>>> I haven't tested this on the tip of the git tree, I can do this probably wednesday if it is needed.

>>>>

>>>> I'll post the output from sensors-detect shortly.

>>>>

>>>> Marco.

>>>>

>>>> Inviato da ProtonMail mobile

>>>>

>>>> -------- Messaggio originale -------- On 4 apr 2022, 16:04,

>>>> Basavaraj Natikar < bnatikar@amd.com<mailto:bnatikar@amd.com>> ha scritto:

>>>>

>>>>>> On 4/4/2022 7:23 PM, Thorsten Leemhuis wrote:

>>>>>>

>>>>>>> On 04.04.22 09:25, Thorsten Leemhuis wrote:

>>>>>>>

>>>>>>>> On 04.04.22 09:18, Basavaraj Natikar wrote:

>>>>>>>>

>>>>>>>>> On 4/4/2022 12:05 PM, Thorsten Leemhuis wrote:

>>>>>>>>>

>>>>>>>>>> On 01.04.22 21:47, Basavaraj Natikar wrote:

>>>>>>>>>>

>>>>>>>>>>> Committed patch is disabling the interrupt mode and does not

>>>>>>>>>>> cause any functionality or working issues.

>>>>>>>>>>> Well, for the reporter it clearly does cause problems,

>>>>>>>>>>> unless something in testing went sideways.

>>>>>>>>>>> I also cross verified on 3 system and working fine on 5.17

>>>>>>>>>>> and not able to reproduce or recreate.

>>>>>>>>>>> [...]

>>>>>>>>>>> ------------------------------------------------

>>>>>>>>>>>

>>>>>>>>>>> Looks like this is not regression. May be some hardware/firmware bug.

>>>>>>>>>>> Well, from the point of the kernel development process it

>>>>>>>>>>> afaics is a regression, unless the testing went sideways. It

>>>>>>>>>>> doesn't matter if the root cause is in fact a

>>>>>>>>>>> hardware/firmware bug, as what matters in the scope of the kernel development is: things worked, and now they don't.

>>>>>>>>>>> For details please check this file and read the quotes from Linus:

>>>>>>>>>>> can you help to answer the below questions:

>>>>>>>>>>> Me? No, I'm just the Linux kernels regression tracker trying

>>>>>>>>>>> to make sure all regressions are handled appropriately. :-D

>>>>>>>> Marco, can you help out here?

>>>>>>>> Marco replied in private and allowed me to forward his reply:

>>>>>>> ```

>>>>>>> I can't since, as mentioned previously, this is the only AMD

>>>>>>> laptop device that I have.

>>>>>>> I am sure this is a regression for me, even if the issue is

>>>>>>> firmware related. I have tested the 5.17 stock arch kernel and

>>>>>>> the sensor is gone. With the last three patches reverted the

>>>>>>> sensor is back and working fine.

>>>>>>>

>>>>>>> I would love to verify if the issue is hardware or software

>>>>>>> related, but being outside of AMD and with AMD not releasing any

>>>>>>> public information with datasheet/specification on their Sensor

>>>>>>> Fusion Hub I really can't say anything specific.

>>>>>>>

>>>>>>> This still remains a regression, since the hardware was working

>>>>>>> before and now it doesn't.

>>>>>>>

>>>>>>> By the way, I already have seen also this rework of this

>>>>>>> specific driver

>>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%25>

>>>>>>> 2Fgithub.com%2Fconqp%2Famd-sfh-hid-dkms&amp;data=05%7C01%7CBasav

>>>>>>> araj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8

>>>>>>> 961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=dwq1ETuquRbWavl4Sb98TOesitSiQjeuq6hN2mxqamQ%3D&amp;reserved=0 that even added a still missing handler for the lid sensor switch for disabling touchpad and keyboard, and all efforts tried to merge it upstream with all sorts of issues.

>>>>>>>

>>>>>>> Regardless of everything, this is a driver supported in kernel

>>>>>>> by AMD engineers, so all of this doesn't matter. On my hardware

>>>>>>> this three patches break a previously working hardware.

>>>>>>> ```

>>>>>> Thank You Marco for the information.

>>>>>>

>>>>>> Could you please provide me below results for acceleration by

>>>>>> re-applying and reverting patch once again on same laptop.

>>>>>>

>>>>>> Did you attempt to test it multiple times on the tip of the git

>>>>>> to see if the problems goes away?

>>>>>>

>>>>>> if same test is performed multiple times with or without

>>>>>> reverting patch on same laptop on which issue is observed we may

>>>>>> see same working/issue behavior. if it is regressing then always

>>>>>> it should work with or without reverting patches on same laptop.

>>>>>> is this the case here?

>>>>>>

>>>>>> Thanks,

>>>>>>

>>>>>> Basavaraj

>>>>>>

>>>>>>> Ciao, Thorsten

>>>>>>>

>>>>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression

>>>>>>>> tracker' hat)

>>>>>>>>

>>>>>>>> P.S.: As the Linux kernel's regression tracker I'm getting a

>>>>>>>> lot of reports on my table. I can only look briefly into most

>>>>>>>> of them and lack knowledge about most of the areas they

>>>>>>>> concern. I thus unfortunately will sometimes get things wrong

>>>>>>>> or miss something important. I hope that's not the case here;

>>>>>>>> if you think it is, don't hesitate to tell me in a public

>>>>>>>> reply, it's in everyone's interest to set the public record straight.

>>>>>>>>

>>>>>>>>> Did you attempt to test it multiple times on the tip of the

>>>>>>>>> git to see if the problems goes away?

>>>>>>>>>

>>>>>>>>> if same test is performed multiple times with or without

>>>>>>>>> reverting patch on same platform (laptop/hardware/firmware) on

>>>>>>>>> which issue is observed we may see same working/issue

>>>>>>>>> behavior. if it is regressing then always it should work with

>>>>>>>>> or without reverting patches on same laptop. is this the case here?

>>>>>>>>>

>>>>>>>>> I don't see any regression here. I requested to retest with

>>>>>>>>> other hardware/platform/system also as per my above test

>>>>>>>>> (output) all working fine in 3 different platforms and not

>>>>>>>>> able to reproduce or recreate for my side on 5.17.

>>>>>>>>>

>>>>>>>>> Thanks,

>>>>>>>>>

>>>>>>>>> Basavaraj

>>>>>>>>>

>>>>>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%<https://nam11.safelinks.protection.outlook.com/?url=https%3A%25>

>>>>>>>>>> 2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext

>>>>>>>>>> %2Flinux-next.git%2Fplain%2FDocumentation%2Fprocess%2Fhandlin

>>>>>>>>>> g-regressions.rst&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.

>>>>>>>>>> com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11

>>>>>>>>>> a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZ

>>>>>>>>>> sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX

>>>>>>>>>> VCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=XBa%2Bf69TKahhgksrEvjgpE

>>>>>>>>>> DFNwV453INzJ7pO6BGTHM%3D&amp;reserved=0

>>>>>>>>>>

>>>>>>>>>> Ciao, Thorsten

>>>>>>>>>>

>>>>>>>>>>> Just curious reverting this patch how it is working just

>>>>>>>>>>> suspecting firmware undefined behavior.

>>>>>>>>>>>

>>>>>>>>>>> If possible, please check on other platform/system also if

>>>>>>>>>>> same behavior occurs.

>>>>>>>>>>>

>>>>>>>>>>> Could you please provide me platform/system details so that

>>>>>>>>>>> I can check this behavior?

>>>>>>>>>>>

>>>>>>>>>>> Thanks,

>>>>>>>>>>> Basavaraj

>>>>>>>>>>>

>>>>>>>>>>> On 4/1/2022 1:36 PM, Thorsten Leemhuis wrote:

>>>>>>>>>>>

>>>>>>>>>>>> Hi, this is your Linux kernel regression tracker.

>>>>>>>>>>>>

>>>>>>>>>>>> I noticed a regression report in bugzilla.kernel.org that

>>>>>>>>>>>> afaics nobody acted upon since it was reported about a week

>>>>>>>>>>>> ago, that's why I decided to forward it to the lists and

>>>>>>>>>>>> all people that seemed to be relevant here. It looks to me

>>>>>>>>>>>> like this is something for Basavaraj, as it seems to be

>>>>>>>>>>>> caused by b300667b33b2 ("HID: amd_sfh: Disable the

>>>>>>>>>>>> interrupt for all command"). But I'm not totally sure, I only looked briefly into the details. Or was this discussed somewhere else already? Or even fixed?

>>>>>>>>>>>>

>>>>>>>>>>>> To quote from https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=xA%2FLcZu8M1xEQsT3qJ5ESSEHybNFOVhoHchhuOryF8A%3D&amp;reserved=0 :

>>>>>>>>>>>>

>>>>>>>>>>>>> Marco 2022-03-25 15:22:19 UTC

>>>>>>>>>>>>>

>>>>>>>>>>>>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git%2Fcommit%2Fdrivers%2Fhid%2Famd-sfh-hid%2Famd_sfh_pcie.c%3Fid%3Db300667b33b2b5a2c8e5f8f22826befb3d7f4f2b&amp;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=REu14KaEX0CrJgKvUedQ%2BXI%2Fw5Y156l%2BFEfCPMWbgGI%3D&amp;reserved=0. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.

>>>>>>>>>>>>>

>>>>>>>>>>>>> Marco.

>>>>>>>>>>>>> Anyway, to get this tracked:

>>>>>>>>>>>> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4

>>>>>>>>>>>> #regzbot from: Marco rodomar705@protonmail.com<mailto:rodomar705@protonmail.com> #regzbot

>>>>>>>>>>>> title: input: hid: input from the accelerometer disappeared

>>>>>>>>>>>> due to changes to amd_sfh #regzbot link:

>>>>>>>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3<https://nam11.safelinks.protection.outlook.com/?url=https%253>

>>>>>>>>>>>> A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D215744&amp

>>>>>>>>>>>> ;data=05%7C01%7CBasavaraj.Natikar%40amd.com%7Ce8b58d32f7f44

>>>>>>>>>>>> e7290bb08da237787c8%7C3dd8961fe4884e608e11a82d994e183d%7C0%

>>>>>>>>>>>> 7C0%7C637861293540308810%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC

>>>>>>>>>>>> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C

>>>>>>>>>>>> 3000%7C%7C%7C&amp;sdata=xA%2FLcZu8M1xEQsT3qJ5ESSEHybNFOVhoH

>>>>>>>>>>>> chhuOryF8A%3D&amp;reserved=0

>>>>>>>>>>>>

>>>>>>>>>>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression

>>>>>>>>>>>> tracker' hat)

>>>>>>>>>>>>

>>>>>>>>>>>> P.S.: As the Linux kernel's regression tracker I'm getting

>>>>>>>>>>>> a lot of reports on my table. I can only look briefly into

>>>>>>>>>>>> most of them and lack knowledge about most of the areas

>>>>>>>>>>>> they concern. I thus unfortunately will sometimes get

>>>>>>>>>>>> things wrong or miss something important. I hope that's not

>>>>>>>>>>>> the case here; if you think it is, don't hesitate to tell

>>>>>>>>>>>> me in a public reply, it's in everyone's interest to set the public record straight.



[-- Attachment #1.2: Type: text/html, Size: 34103 bytes --]

[-- Attachment #2: TP420IA.zip --]
[-- Type: application/x-zip-compressed, Size: 5750129 bytes --]

Re: Bug 215744 - input from the accelerometer disappeared, regression on amd_sfh on kernel 5.17 #forregzbot

[Thorsten Leemhuis]

TWIMC: this mail is primarily send for documentation purposes and for
regzbot, my Linux kernel regression tracking bot. These mails usually
contain '#forregzbot' in the subject, to make them easy to spot and filter.

#regzbot invalid: bios bug and reporter seems to be satisfied by
resolving this with a bios update

On 01.04.22 10:06, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker.
> 
> I noticed a regression report in bugzilla.kernel.org that afaics nobody
> acted upon since it was reported about a week ago, that's why I decided
> to forward it to the lists and all people that seemed to be relevant
> here. It looks to me like this is something for Basavaraj, as it seems
> to be caused by	b300667b33b2 ("HID: amd_sfh: Disable the interrupt for
> all command"). But I'm not totally sure, I only looked briefly into the
> details. Or was this discussed somewhere else already? Or even fixed?
> 
> To quote from https://bugzilla.kernel.org/show_bug.cgi?id=215744 :
> 
>>  Marco 2022-03-25 15:22:19 UTC
>>
>> After updating to 5.17, the input from the accelerometer disappeared, completely. No devices available from IIO tree. First bad commit causing it is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c?id=b300667b33b2b5a2c8e5f8f22826befb3d7f4f2b. Reverting this and the the other two on top fixed this. Tried to not revert only the above mentioned commit, but it's still not working.
>>
>> Marco.
> 
> Anyway, to get this tracked:
> 
> #regzbot introduced: b300667b33b2b5a2c8e5f8f22826befb3d7f4
> #regzbot from: Marco <rodomar705@protonmail.com>
> #regzbot title: input: hid: input from the accelerometer disappeared due
> to changes to amd_sfh
> #regzbot link: https://bugzilla.kernel.org/show_bug.cgi?id=215744
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> 
> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> reports on my table. I can only look briefly into most of them and lack
> knowledge about most of the areas they concern. I thus unfortunately
> will sometimes get things wrong or miss something important. I hope
> that's not the case here; if you think it is, don't hesitate to tell me
> in a public reply, it's in everyone's interest to set the public record
> straight.
>