From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2078.outbound.protection.outlook.com [40.107.237.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id CAD4389E0C for ; Mon, 27 Sep 2021 17:28:34 +0000 (UTC) From: "Pillai, Aurabindo" Date: Mon, 27 Sep 2021 17:28:32 +0000 Message-ID: References: <20210927160700.1570885-1-aurabindo.pillai@amd.com> In-Reply-To: Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM4PR12MB5295DB9A15801BDE6F78D3AB8BA79DM4PR12MB5295namp_" MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Mark Yacoub Cc: Development mailing list for IGT GPU Tools , Mark Yacoub , "Siqueira, Rodrigo" List-ID: --_000_DM4PR12MB5295DB9A15801BDE6F78D3AB8BA79DM4PR12MB5295namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only] Hi Mark, Both bo-too-big and bo-too-big-interruptible shall be skipped with this pat= ch. The other location where TEST_BO_TOOBIG is mentioned is in the same fun= ction. -- Regards, Jay ________________________________ From: Mark Yacoub Sent: Monday, September 27, 2021 1:21 PM To: Pillai, Aurabindo Cc: Development mailing list for IGT GPU Tools ; Mark Yacoub ; Siqueira, Rodrigo Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-b= ig On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai wrote: > > [Why] > The rationale of the test does not hold true for AMD hardware. The > aperture size calculation has an upper bound check which is done through > i915 specific IOCTL. Hence this part of subtest must be moved > out of the platform agnostic tests. Moreover, AMD hardware > supports buffers larger than aperture size. > > [How] > Skip the bo-too-big subtest unless its run on i915 as the test fails on > AMD, VKMS and VC4 > > Signed-off-by: Aurabindo Pillai > --- > tests/kms_flip.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c > index 54137871..20112de1 100755 > --- a/tests/kms_flip.c > +++ b/tests/kms_flip.c > @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_outp= ut *o, int *crtc_idxs, > /* 256 MB is usually the maximum mappable aperture, > * (make it 4x times that to ensure failure) */ > if (o->flags & TEST_BO_TOOBIG) { There is also another place where TEST_BO_TOOBIG is used, should we skip this one as well or it's only this part? > + igt_skip_on(!is_i915_device(drm_fd)); > bo_size =3D 4*gem_mappable_aperture_size(drm_fd); > igt_require(bo_size < gem_global_aperture_size(drm_fd)); > } > -- > 2.30.2 > --_000_DM4PR12MB5295DB9A15801BDE6F78D3AB8BA79DM4PR12MB5295namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only]


Hi Mark,


Both bo-too-big and bo-too-big-interruptible shall be skipped with this pat= ch. The other location where TEST_BO_TOOBIG is mentioned is in the same fun= ction.

--

Regards,
Jay
From: Mark Yacoub <marky= acoub@chromium.org>
Sent: Monday, September 27, 2021 1:21 PM
To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com>
Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.fre= edesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodr= igo <Rodrigo.Siqueira@amd.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest b= o-too-big
 
On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai<= br> <aurabindo.pillai@amd.com> wrote:
>
> [Why]
> The rationale of the test does not hold true for AMD hardware. The
> aperture size calculation has an upper bound check which is done throu= gh
> i915 specific IOCTL. Hence this part of subtest must be moved
> out of the platform agnostic tests. Moreover, AMD hardware
> supports buffers larger than aperture size.
>
> [How]
> Skip the bo-too-big subtest unless its run on i915 as the test fails o= n
> AMD, VKMS and VC4
>
> Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> ---
>  tests/kms_flip.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 54137871..20112de1 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_o= utput *o, int *crtc_idxs,
>         /* 256 MB is usually t= he maximum mappable aperture,
>          * (make it 4x ti= mes that to ensure failure) */
>         if (o->flags & = TEST_BO_TOOBIG) {
There is also another place where TEST_BO_TOOBIG is used, should we
skip this one as well or it's only this part?
> +           &nb= sp;   igt_skip_on(!is_i915_device(drm_fd));
>            = ;     bo_size =3D 4*gem_mappable_aperture_size(drm_fd);=
>            = ;     igt_require(bo_size < gem_global_aperture_size= (drm_fd));
>         }
> --
> 2.30.2
>
--_000_DM4PR12MB5295DB9A15801BDE6F78D3AB8BA79DM4PR12MB5295namp_--