All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: RE: [PATCH v2] common/mlx5: fix MPRQ mempool registration
Date: Tue, 16 Nov 2021 16:04:45 +0000	[thread overview]
Message-ID: <DM4PR12MB53127002D32F329E242E874BCF999@DM4PR12MB5312.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211116115545.2441025-1-dkozlyuk@nvidia.com>

Hi,
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, November 16, 2021 1:56 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH v2] common/mlx5: fix MPRQ mempool registration
> 
> Mempool registration code had a wrong assumption
> that it is always dealing with packet mempools
> and always called rte_pktmbuf_priv_flags(),
> which returned a random value for different types of mempools.
> In particular, it could consider MPRQ mempools
> as having externally pinned buffers, which is wrong.
> Packet mempools cannot be reliably recognized,
> but it is sufficient to check that the mempool is not a packet one,
> so it cannot have externally pinned buffers.
> Compare mempool private data size to that of packet mempools to check.
> 
> Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities")
> Fixes: fec28ca0e3a9 ("net/mlx5: support mempool registration")
> 
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> v2: improve logging, add ack.

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh


      reply	other threads:[~2021-11-16 16:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16  8:57 [PATCH] common/mlx5: fix MPRQ mempool registration Dmitry Kozlyuk
2021-11-16  9:01 ` Slava Ovsiienko
2021-11-16 11:55 ` [PATCH v2] " Dmitry Kozlyuk
2021-11-16 16:04   ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR12MB53127002D32F329E242E874BCF999@DM4PR12MB5312.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dkozlyuk@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.