From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC10C433ED for ; Wed, 12 May 2021 05:57:34 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id AEDAE6162B for ; Wed, 12 May 2021 05:57:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEDAE6162B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8773D4003F; Wed, 12 May 2021 07:57:32 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2065.outbound.protection.outlook.com [40.107.92.65]) by mails.dpdk.org (Postfix) with ESMTP id B6BF64003E for ; Wed, 12 May 2021 07:57:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L8qmaQggFmjscxw/27uNqFWPoOSnr/94JX0z57PeQSL6hR5s8EjjvZmnjrpA215HbUkrQu7BzV/pUhcBEZjwE5ge5n4A0COyuZ/9+lRUJp0EKToK22Efe4xyFb2pQYWbHgNiHmDEz3G4NnXnTUFuvDNsIR+BscdlVKugTY8/TcBXmCsSuiXnryorqZKQiThxQLaHVJJ1trEGlCJvCSqtBbWWvvwFH9uwhgVIoVcV+NJsw8f50SMsYTpJqXGL7Upn5OsvHBH2Ia8/s7WVnih6dkbZDuT4OlJ49tGgn+U+VT8KXul0ddUuZqJIW3j+E/65ycYOEMDifYwMy2AQ0hMGMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nQmsvlqntut0kWbegpB1OZ7pFBl6m8u6UuSxh2xrYXI=; b=GyMyUxT/NGToRNBexoZ50hLMe3x5bCxXEapob6XMA8tgjhCkixvLgEqpDZQgYvakYkZ7pOlH3FmI0TzZVk8yNW1yszjcEAEVH15c9vy5nMNqqe+80h2kYUuQRoMNYv0jSBM2YdXfQfe72sHDDw/rUPSb5rL7Pka3k4PsWKSsX8X9fsdqzelGade4XdlAaD1GnULjJtzVOpLAeJh1eGLnsIMG+7m3vAmx7B933ohhmU/5Q6qyLnOIw9vMeTzJKAx32Ca4MWNRTq9St5yHtq4j1Exvy9mzsJOiUvU4uw4HDJHt1dUlP+sO71HmNOJvUS8o9MzPuVpqsQnPSvNLhaKZzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nQmsvlqntut0kWbegpB1OZ7pFBl6m8u6UuSxh2xrYXI=; b=K8USm1b3un9aUf43sFJPjoZO1Xd2oAGNGVyWzUI0fy24KLcVzeJbEdU80Szl1ftoXVqyq4CNeFCKE0jq6JQWNrYVtEql/FewDVU0lpQxoVtRoj4QGdO2F8cFTVfIYMLrEN7EkgX6k8ylN+sMIKdhoadiOnCLPHquREAVT6Yn1ZSzTY6Dni1gLjI6lek0v6N0byzvUuY2SA22paP2BAKJCVm6gp+Fj5bBPNfQxyJkxSZjIC47LGtuS0LOVdISOB2CjW/QmWoqiIgMZ4z7Nbq793shunTBGqCjpvQoRe13tqZgIwCQL/DWqfYrMZCwvLjLDDBvBrrtNBgk+cdG0ngeSQ== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM6PR12MB5552.namprd12.prod.outlook.com (2603:10b6:5:1bd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 12 May 2021 05:57:29 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Wed, 12 May 2021 05:57:29 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" , NBU-Contact-Thomas Monjalon CC: Suanming Mou Thread-Topic: [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument Thread-Index: AQHXQSnSPX12ALWtTU2ZgSHu5s6FNarZibiAgAFLZ/CAABDwgIAAVRsAgANbbgCAAM1uMA== Date: Wed, 12 May 2021 05:57:29 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-11-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.12.22] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d23c222-dd7a-44fe-b675-08d9150ad3c3 x-ms-traffictypediagnostic: DM6PR12MB5552: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:883; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3VNbmMFGdw9FSIgainLRaozkBuQS3I8XfyqaAzT1jRUjSkHwetaeT2GWVcXi+qEoBBUQBPDOVxhkqic31zOTZZ2FFuSfP0PPnSUrukRsD8vpeiMEepV3DhB7rPLzppMC27NCrnciNV6yh/bibK/Lw7XpPnV7xmvfoyBr+V7+IQ4pe65EXa068jNky67EFV2WPBvVJ3YUy8HbaZWU3ujlPuCK7XGB4XIfbF9Lly1jwFoFV1Q6BrXnFXfnmtxDgQDiNJiWFfMD2kwGBKTtAhtphL1KYcU0UYSQ+uAlBYRqJ7307uTbFQ3/uhHMJebzvFkFXzLp8iJ0nKxi9R1i4ZIC3s1l4YXf+fougrWyKqk0qLJ2d92s/w0d6kghSpZNoaAWfUpxXppB//LWH9j7NBoYayIOZWTKRS4LXwU8/Rp2UdQjuj1IuYGDaHLpbVdJtNz+2fMLKQDOhN7Zx0WcSp5EoZbWR+g9rfRZdHh1tKipFJRqKNnbQOjWu2O6XEDsxXE1ZZO32dJxZDoEwLOdpo082/aEQdue81zAZOwxVr0UggtmQJg7ABaIKfGXqGaqiPMK6Ldt3wD5nN4cOc70uCyEmHQOt9jC4ZL5BE9A37ld/+4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(55016002)(4326008)(66446008)(86362001)(64756008)(66556008)(66946007)(66476007)(107886003)(8676002)(71200400001)(52536014)(316002)(26005)(478600001)(9686003)(5660300002)(2906002)(33656002)(186003)(83380400001)(76116006)(7696005)(8936002)(38100700002)(110136005)(6506007)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?RCqPxgSz0E5VSu/XR/iMmn7TvNxS4BrbDl8J+xSMt0VOqGmgHGFtR88iU7UU?= =?us-ascii?Q?reacgRIrXmszmxSOhDP/l2SwxVR9J7M1DSb/QFU9Vo/4P8k0LhU1uykxnOD6?= =?us-ascii?Q?Te1exWJfrcPLCrNUDXgXAmHoafohy5B8+NxFDM5GT1ZzK14RqCIPTGi8gVPE?= =?us-ascii?Q?+ks0ymxyUp8PMrqxkSBn9Fq0TX3fsG3M1+srNCo3cFTz5PNfFL9rvZpThk8m?= =?us-ascii?Q?S1AaeO4aiGCTQN2kibW0PWmLhLzhD0Vkn6XhUmib3oS27rjUG0aOwY55h1Gq?= =?us-ascii?Q?hczUvTuz0GeO/diNmcVdPwh7riS6J5aw5hU/GN5q3Vy6nBriJTpMBXuqQXEh?= =?us-ascii?Q?PQHS75y/aiR4kdQp4QyiZ8+Yy0zC25A5imsci+cTgvU7aNeE7ruRSmnvBWaq?= =?us-ascii?Q?GAQUBkA74pAueBDXqPgMabgd9Mi/K6utx/pC1dJVNRwcvJYEQUdC345LEp8o?= =?us-ascii?Q?lnVFS1LVbBhQ6Y3WlJg+R3/RCrbjsDZJAgkTlSo+sWhfp+vgiHUdDoxvzf64?= =?us-ascii?Q?yDgezWrnsDCL+E/Xd9GMlMX4+WKt/4SO+GHc7YcSJbRTeYEeoIMD/mMgV/UT?= =?us-ascii?Q?ULAnNV5XjK/pjVwmK2f7y6c2mdagtlxi+SPDmPuTxlYptJXREz4gTV2obKZS?= =?us-ascii?Q?5+t1wi5Kn26YteoTA2ZWJ0edxsE1hSUKLVKqH6jE7+BlkZSXVoOLkKSAHnt5?= =?us-ascii?Q?5AH8YlX3aG8suIJHR8No+91PIbPsbQukxSdywpPMXYfIwYPtqoHwiV7DEfkS?= =?us-ascii?Q?SOb3kLG3kd+Z8Cm9HVQPZlLw5IaSjjtdfBKe6LK7h+nZbuDhw/cTAJuxQMBJ?= =?us-ascii?Q?5xX+Xz3nUcSAtVc8SiAzvasZGF88YQajnCOp/B/42sfwqSiaqlcvtkIU/3Hm?= =?us-ascii?Q?9/mkgWXitzdrJ06+Ugm+nFETICgQxSUxhlIzevEQ7Dcxrbg+P6BONAy4OjK/?= =?us-ascii?Q?Nih+lT4B3pC1UIPZmpWs+keKwU9aL28kjh7kkICz/KIjNLYvbEHGH2xWb0Kb?= =?us-ascii?Q?Y1r6Ik4VkrnDctqTNrbmTgiw0Vj2/MIpxaDII7G71hhzKQRWzeIqJEmJrdbK?= =?us-ascii?Q?E7hP2qP5Jmr/kKsd/Bx27Npwewiql2Oxn2hN8ywB4kDFPSJVj7lc6jgqZKCQ?= =?us-ascii?Q?crt9ofR5RE0cjfxZOeeb+7YjVxPX0LesnoKWNmRYzp9wmGnvsfSvCZk51a4P?= =?us-ascii?Q?9h7YxGsrTXX6DZDdlCVD2syT7rZ59JbxnX7rtk58jnjIvK530lsMfdvegADE?= =?us-ascii?Q?GgAmfPR2vlTFWJ9XJ9ozBRLgqCi0Hht1kxKQw/0FS9aWllsU7ZmShGTWbUZG?= =?us-ascii?Q?+EA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d23c222-dd7a-44fe-b675-08d9150ad3c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 05:57:29.4130 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d82IaqT7bbA8Xm0RlXh2mgss2aN2+BeMVctRZD9ZKlEYuNgOH8WwDASXZ3K2Rz6LH8mUbtsz8taE4gjrxZKH5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5552 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 10/15] crypto/mlx5: add keytag device argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal=20 > > From: Akhil Goyal > > > > From: Akhil Goyal > > > > > > From: Suanming Mou > > > > > > > > > > > > A keytag is a piece of data encrypted together with a DEK. > > > > > > > > > > > > When a DEK is referenced by an MKEY.bsf through its index, the > > > > > > keytag is also supplied in the BSF as plaintext. The HW will > > > > > > decrypt the DEK (and the attached keytag) and will fail the > > > > > > operation if the keytags don't match. > > > > > > > > > > > > This commit adds the configuration of the keytag with devargs. > > > > > > > > > > > > Signed-off-by: Suanming Mou > > > > > > Signed-off-by: Matan Azrad > > > > > > --- > > > > > Documentation for devargs should be part of this patch. > > > > > Please split the last patch accordingly. > > > > > > > > > > Title can be shortened to > > > > > Crypto/mlx5: add keytag devarg > > > > > > > > > > Fix other patches of devargs accordingly. > > > > > > > > As I said before, no devargs is really active before adding > > > > datapath > > patches. > > > > The option to add all the supported features \ documentations in > > > > the patch which actually adds the support is correct. > > > > > > > > The last patch adds the capabilities and docs when all of them are > > > > really supported. > > > > > > > In that case split the patches in such a manner that data path is > > > added > > Before > > > devargs patch with some dummy values and add the devargs with > > > Appropriate documentation update in a later patch. > > > > > > No, data-path must know all the devargs in advance, it cannot work > > well without them. >=20 > The suggestion is to have a sequence like this > Crypto/mlx5: add datapath -- (with some dummy values of devargs.) > Crypto/mlx5: add keytag devarg -- (replace the dummy values from previou= s > patch > with correct one. Add documentatio= n ) > Crypto/mx5: add xyz devarg -- (same as keytag) Yes, it can be another option. But I don't see it critical. If you insist we can do it. =20 > Regards, > Akhil