From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84AAC433B4 for ; Sun, 9 May 2021 14:25:49 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 56DA061055 for ; Sun, 9 May 2021 14:25:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56DA061055 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFF5040140; Sun, 9 May 2021 16:25:48 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2071.outbound.protection.outlook.com [40.107.237.71]) by mails.dpdk.org (Postfix) with ESMTP id 8AE044003E for ; Sun, 9 May 2021 16:25:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hd+6tDSzQ5CXA/PuRe9xTHe3hgwUQ3saFTQcaij92Vgp1I2t2th8SQ2xjsEvGENFm3S+nVYiGOT/xfWCWfLJFfKi8HM41NO9CWWjglhteawZOXMrx3qqltyNpnQ9TLfDIKXipuBxnx3Rq/Ngf2qG/VAiDQPDDVHZMG3WTfPLL6V1OvkKneKyTGeVsqgc1mrbJKHIFBiYEUvaDfWnSBVtbZnlPFjnClSTyD0t/bElOiMQT2rmfPlBbGamktICnzwV2EanesnSkaI0/X63jIyjBDUJtBPU92rHQBy9iJdw/Z9keL9urqENfJ/YC6CrWsHDak3k+s4PEO4pXWMLF5T+wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ImejDWMpQbQ08FaV1Cz6Qp4CEyZpvyTSHoOV3rKniIs=; b=N90K3pVvgg8g7z2SqjkkmqaRXKEkMO5j5oNfYmGyUikFUKPCw9xX4krZIsoLYaDGEcn3wh4u0U0l9dao1CZoWqcT6VG2zEwzAdF4F5CwVd2GH4DtFH46wXGUhLKtofkr+PpNJQj9uhaQeje2DwPQ6Vj7MwB5DO6GmnYKhj79qLXMpJXQDti63aVKqIs+rAbl/3+J/4qRlnLIPX3vgSjPL1q55JG2XyYu6R9qxaG3VHIdsW/Gg8/mC8RHGiHgbX3uvB4H5oGw1iG6GiaWDdY7Wk0j1zaY18OorEVnE1M9rMC4Os/338ypSG3LaDQGjGXyrb4eJYZM/iipnpV26yHXgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ImejDWMpQbQ08FaV1Cz6Qp4CEyZpvyTSHoOV3rKniIs=; b=pHQOKj5J6WgJ2L6KLXQ74zRu6Ah0sDseKyVdSHw07RPjoYjKhpuV3gGtpd8rI6kEXaCJ9Ui4ZCGv8jsx9K0x+GfaGphogNwkVsTOJDSQkA+euLGozyv4A+t2bnSL6PDM72YGWfuIl5ASL67iFxoaZW6YsrdATYK14J74/0vFrGBjdwHVnrA6fhsaq9DQq2JUjj6a/PztSB1vtvgXEvkGRlTJEeg5g8LI606i07pROtfMfnFjt/BMzj9Kx2L0DvW1WZDjVekRnAryhFwNCwuAbCAmAK7D1bEfU3InEffJ9Ljn5AwidTxarN9xdR0U9JQD6UMKtmMPsjPn8QY6poUOdw== Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39a::7) by DM4PR12MB5230.namprd12.prod.outlook.com (2603:10b6:5:399::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Sun, 9 May 2021 14:25:46 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::70df:ef1e:d98c:ce4%6]) with mapi id 15.20.4108.031; Sun, 9 May 2021 14:25:46 +0000 From: Matan Azrad To: Akhil Goyal , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD Thread-Index: AQHXQSnD6vYVcRj7jUOdKtk8oGg08KrZdOsAgAFWbCCAAB7dgIAAUa3A Date: Sun, 9 May 2021 14:25:46 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-2-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [79.179.26.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dceb1490-520d-4a90-084b-08d912f6563d x-ms-traffictypediagnostic: DM4PR12MB5230: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dlrhT6+MMPFVYmyd/TmQC6lGekLArEaKz3eokt8lrkaXpUamILGRqf8L3EmEN64THC527PeYbfxgiyH7Kfq248SC8I48Dol/g5pluELDGEhfD4js8xWPwEOqzVYaIyWaqqg9OqIOCCMRXbgaPM5MMCzR/RwC/Hv7+ABkchiuQ1jLLtz6zb7w9t0TluDAxk5WizorG4kcTJsI3/pUyP7DvabMWMk863JI2aEjVl4mVxymAejuWQPP/J5WaT61vQQ/WBE1i3FsxXwGD9jnH1MKOqQhYrbx27ETTuEZddXvtb7rdCIey3QM4N342CF1NGO4LH//xCh/kd3I7uZjub6/Aq5gPdvJ7Er8IlVJudQBJfSxQ9hLg0r99jE+e0llNY0VlfhP4g/qb6vOrHkOgM4C6MVAiOhRP0ZEHMDxRUwxJjRV5Us2QyzinTn3j2o/x5je8RPwi57vANcgzdorrsnjX2EMaF3ak1x9NOaeN11w38WiyHrFBkfWKVgT58CeTuI91aYT7Ao+3qxyXT0bWHNSgZFK9tBpVIy7rS98SILASRB11uO03lbAoLikrQxSvenBWbqHiOP+fqVp4wreaAdq3+hniSWrxbCm1uxeNihQWUE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR12MB5389.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(366004)(376002)(346002)(107886003)(186003)(8676002)(54906003)(66556008)(71200400001)(66476007)(64756008)(66946007)(66446008)(316002)(86362001)(7696005)(478600001)(76116006)(110136005)(83380400001)(8936002)(52536014)(38100700002)(26005)(9686003)(55016002)(6506007)(122000001)(5660300002)(33656002)(2906002)(53546011)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?OkaGh47Ywi2TTReUYpWpQ2uXgx2i0J+5bROyZSYsUaerK9YxWmz8iHYzmsIu?= =?us-ascii?Q?h1B7N+SXanhys9sdTOAVi/WWCB3Co4OIxvaKSXpweE7hHyBqNQzsXimp3kfZ?= =?us-ascii?Q?r1dapQZ0o3t0fAQg7UAuEKSt++rvR99zcvX1tCG6O3kwC34cTUFK5kon3TXP?= =?us-ascii?Q?XGp7h0vYzi6mr9CjFynAszrGDEOB+lhvRsvbH0YcBVA8fKbYi4wTI+XdAC9r?= =?us-ascii?Q?lyR+us2mWguTHmI6thmyLym0Xrg/ig6OQ26h1jmKjGhdw/A6SmodQosSOvtG?= =?us-ascii?Q?LoctaealfChJ26gOHu+7v3kHix70hxuJae39lAMqLZeheGt/0Vmn+Bom79al?= =?us-ascii?Q?HBSa2vZFvQSAkzmI7Ae+Jm12rV5+2HBf6+Tf9x44IRqq9th5MzB15i2tJc/f?= =?us-ascii?Q?960f6lyK9mkyoPslfEDl0+M6cr5+dTXsY8tZyDoX04xQ0upF8MO7J0x+Ucfs?= =?us-ascii?Q?8OsgAKr6NW+fKU3atTpw2WP5Bb4xDiXxp116qBnQ+K7Pq0dlcDGLMLfS3E48?= =?us-ascii?Q?v10bZns/Kz2Ai1npQBJhckLBPXfVXK3RRCi3EcR5FOKElFqlRIho3Yz1IuQh?= =?us-ascii?Q?6qS9F66qA6zcW4YR3HDEzhKN/kNiquS7FrWldu1p87gSChPr2qkZyudkBkkH?= =?us-ascii?Q?HR6GeWsEoZLnB5LoGCIaZo8GBqwsTTe/DKNFgiM0a/ygzxXRZDa0Bml9FiqX?= =?us-ascii?Q?rsGoRCy2BvGu7jELMCL581r6FM4WovCA8faZTOSLE9Sf9k1eWQQ1XFktnD7o?= =?us-ascii?Q?fhVr+dSeYvcQfMzUK6EZQQ2P70NNxAUF2bTq2YViTBr/IO477FPLpEfItcNO?= =?us-ascii?Q?4EF5jQINYa+BpMRtiOpdffecTlzrajjyEcej54gXKD9e71QamLS5y48jnAk4?= =?us-ascii?Q?yhgUXec2qW3uW8B+ZTYYTh6HSn4b2FhS98Y8CG6OHyxedpUsNUCoPKdSgEIY?= =?us-ascii?Q?e08OzIiJ5ta4IjHcHwXi2sRg0QNjq50NMmARlVX8yiysYedNT2yi63E2a5MI?= =?us-ascii?Q?2ML++IRLKIIZPNFjcwGKSb5zygrbUfYoU6+crZpSiQvY686WfI3c6Q306Iy5?= =?us-ascii?Q?nwJV5SJor1lvhUGxMdXTJJROxV/5WWcAEctd1m17h57rkfoYHAtcZW2Nov5u?= =?us-ascii?Q?QaO0ULJofFXN7axOe4npOnayz7b1XCjeR88bONGU2g1hDn+nWp16+KcBPRfw?= =?us-ascii?Q?P38HXrrlMCjWtlbM3TDSfIVK/SuB1x6r+aAC41ffFLN2QvZILKLWTeIAGfwc?= =?us-ascii?Q?CgR+8VyPF2fVAbQCCZblhhohEs9r417E5yXsTgxbXSCh8yIubJVw6LRidcGC?= =?us-ascii?Q?4CutUhTgGRYTmhYMeG9Wx1Nb?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dceb1490-520d-4a90-084b-08d912f6563d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2021 14:25:46.4236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kmyg+BNwrQOLPBc0qgvqHfZmLb2JubzeXEeKpGn8KAHu3bSrqZi5+07K7gV4iAo8NVyaIIswCaC7EE0RVJz63g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5230 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Sunday, May 9, 2021 12:33 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Suanming Mou ; NBU-Contact-Thomas > Monjalon ; Shiri Kuzin > Subject: RE: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD >=20 > External email: Use caution opening links or attachments >=20 >=20 > > > > + > > > > +fmt_name =3D 'mlx5_crypto' > > > > +deps +=3D ['common_mlx5', 'eal', 'cryptodev'] > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > See RTE_LOG_REGISTER. >=20 > Compilation works fine even after removing this dependency. > I believe it is internally managed in cryptodev. Yes, but it is better to add the libs we use directly. > > > > +sources =3D files( > > > > + 'mlx5_crypto.c', > > > > +) > > > > +cflags_options =3D [ > > > > + '-std=3Dc11', > > > > + '-Wno-strict-prototypes', > > > > + '-D_BSD_SOURCE', > > > > + '-D_DEFAULT_SOURCE', > > > > + '-D_XOPEN_SOURCE=3D600', > > > > +] > > > > > > Any specific reason to use '-Wno-strict-prototypes' > > > Compilation works without this as well. > > > > We use it in Mellanox driver usually. > > This is internal mlx5 code convention. > > > Ok.