From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08336C433ED for ; Tue, 11 May 2021 12:38:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B96E66191D for ; Tue, 11 May 2021 12:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231570AbhEKMjZ (ORCPT ); Tue, 11 May 2021 08:39:25 -0400 Received: from mail-co1nam11on2068.outbound.protection.outlook.com ([40.107.220.68]:11008 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231669AbhEKMjU (ORCPT ); Tue, 11 May 2021 08:39:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3P/JoRiGPyNhbEYNHIzinVXi78Ab/803TT5/zJ/cs8paKzt6ksNzCFAVgy97XMELemePjoBv2EZgu5xIqzY53GMRkyTFgmixFG/GTw3ePqO6LD6W2NGSkz6e+YPJWB+Ki3Ix42ZIHEG+OVnC4SZBAfcSLOPEX39+IGuIQ/fVzsLpqsq7em4JI1hsuGeVIag9miiBVSUTNHnWzigeeiHgjibIUtyPw2vfl7vHkTtEHEAIvjljqdV9ulxEYJJbTOL+upZLHKADBVvcotcxkh8q7dfdCumaILsDyskjBWM75LObwZykQ6uPViCi/oYgAX55ZSulN8ApHumtUmH73p5Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEs0b95P8RAtVBmSqWD8Ygrv276hC+eyK2iWbu7IAyU=; b=KChy65bHcfLDPaFqwoYxT791JLlD2+3xhupZjI3MW7OKQwVImJ3utHzJDXer3aDaOKEiyeRhhpdqLVe0sEoluV9z4e9pYVrwpyw8jhztfhQ18UAMmEV3hfzcJc7pMO5PjAujxzbh2Ju12eI8bns4S3Uj4zy24TNKTwPdnb4NS0XDlbb7+WEEeNabqa01pXgEuzNpQudqsdet0Sg028FmQwd3+kbA67bRnUjuUQvcr/IYQvyrNmzShsqtMFay060r8WfheaqdcaPT5PuouFw8IS66aPZ2NNe2trEnBK3hmgj0Q5qFBV8ZqMe9sZzpNO6ctD1H94mZG5jOuBFE4deihA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEs0b95P8RAtVBmSqWD8Ygrv276hC+eyK2iWbu7IAyU=; b=Kl4APPXNCzuuhCgjKRtyV9/GySh5EUhwxoZS5c02w0vaLotzKJI4EsxPvUVFww1v7HX6wpkt+JtMskm0TNax3BVNhcWS8ZYG//ddNonyoU11xGmSxmesqYmVR2Acv32idvo8dd8UCDFeHRy4q4QArw2Ex5jK/IdVNz/cxd67p4E= Received: from DM5PR02MB3877.namprd02.prod.outlook.com (2603:10b6:4:b9::34) by DM6PR02MB7018.namprd02.prod.outlook.com (2603:10b6:5:259::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May 2021 12:38:12 +0000 Received: from DM5PR02MB3877.namprd02.prod.outlook.com ([fe80::53:31a3:2e23:75e1]) by DM5PR02MB3877.namprd02.prod.outlook.com ([fe80::53:31a3:2e23:75e1%5]) with mapi id 15.20.4108.031; Tue, 11 May 2021 12:38:12 +0000 From: Sai Krishna Potthuri To: Andy Shevchenko CC: Linus Walleij , Rob Herring , Michal Simek , Greg Kroah-Hartman , linux-arm Mailing List , Linux Kernel Mailing List , devicetree , "open list:GPIO SUBSYSTEM" , git , "saikrishna12468@gmail.com" Subject: RE: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Topic: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Index: AQHXN1HnJ1dD/z2380CasZDNOXc+DarCQxoAgAQix4CAAHWwAIAAH53ggBdJowA= Date: Tue, 11 May 2021 12:38:12 +0000 Message-ID: References: <1619080202-31924-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1619080202-31924-4-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.50.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0708a1b2-5cd6-4562-b131-08d91479a3eb x-ms-traffictypediagnostic: DM6PR02MB7018: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aFaPMz8Tf0nxIl/EXYQCktu0KVy2mbV5cy1GoVpP1B0443CSzA0MSZYB1UEnkzVOPaO5TVQa2YriRkjs6iQ7Wz9svF7K7Qk6LF1sNEInwmFrUhxo3Fjujcp0Oo04nlVnxXkPDeECDi+BO88zi/VBTG6QKDpnuS4OV1k97xq55PD9HMeUeqlUsf274A/kce767RkN29eyDJGKzWr7AVOgY3TdGtNhtmCdAiqJgLPcoKq1DtLr2aZgkLF4f6spanJrcONYlNpynpswqO7UQk+PWlxe7JfW8Qft3SfHGVYPGV9Y3iYzEbH5pX/igiposFZ46RE6xECmoyY4TxDlYQnGF1nPZIdqM/jIKGNSwvR9soRoWuZgqQhvuydCVWyw8XEFZSD3xl5mMk/SiYJwntKXYHCVsdRZvKEi6oni4mzYXXP3ZwOgK/Aq9bJ+mIXkqlpouxDuCXrpX6Y1Yy0gjkFbvaEftgzVxgw+MQucCNovImKkq3ycjT5YUQC024zmjG6YSxnBW4LktGP7amhYah0tykjlXi7aSSrh2J1cWjkUi6apKC6cS5atIFUAeXJtVN9n8Ppit3GqSWBizGXpycqMP/crQQxMCHmL07pg+LLoQT4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR02MB3877.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39840400004)(136003)(346002)(396003)(376002)(366004)(66946007)(76116006)(26005)(55016002)(52536014)(7416002)(316002)(4326008)(8676002)(64756008)(478600001)(33656002)(54906003)(9686003)(66556008)(66446008)(8936002)(83380400001)(5660300002)(6506007)(53546011)(2906002)(71200400001)(66476007)(86362001)(122000001)(38100700002)(186003)(7696005)(6916009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NjRVV3RnTW5aOGRyc2lJYm9ZcjgydnUrdkJ5NFJNMi9Oa0tSOFpBS1RkMlRt?= =?utf-8?B?Ui8wYjBPT283S1NlaHhET1N4STNqM1p6VXlqSjNTT3lOSnF2VnBRVHY4Tlps?= =?utf-8?B?UlFwV2Vmc3JCSEsrYklLMVc2czF1Q2haQ1ZSTnFYRWx3UGsvSDRFMVBqN3Fo?= =?utf-8?B?cUxQcHdaT1I4SHZseTM2am1QZzcyY2dSalVHbUJJK1JlSHQya012bXI3SldQ?= =?utf-8?B?UFdmQWhhbUk1WVBzbFdTVWpPQ2VKdElzM1k0UVpSWXRnSGw0QmpHNUJWTjQz?= =?utf-8?B?R0NxNTAydHEydUxCOStjUUFyRkZpUG50NGljVXVOSnRISnl1YnQ4d2ZUYUFJ?= =?utf-8?B?N3kvZHN4R1B2T2Vad2ZhUDdvUURxOXhXUjRYLzJaRHBuSFMzSGpRQmRmQkIr?= =?utf-8?B?SE16TXRPUTloTHJhQ3FJS2xKVm1odGFJRC9HNy8yc2Rjd3FNUythV0l4WThI?= =?utf-8?B?RlNSdlh2TUNFZzBGSXpseVpQK3VzTkt5c0l6LzhrUEQ3Y3ZwWXJlNnBGV3o4?= =?utf-8?B?MGY2UGJKdjkwUlVkUkVCK2d0OStuREE1RjJSM1pBYVVudEhNNkhteTFKdUF1?= =?utf-8?B?NTFCVEFodG13ODlSak5DQ29qcXYrUGlycWxVQUZKRmUzK1M4Q25UOG9mSHFy?= =?utf-8?B?OVE2OFh2MnlkN3ZEdmJSUjVFN2pXV0pWazd3OGFnYU1VWGhQUkNMdXJJTDlC?= =?utf-8?B?cWFLUUpKNXpwM2FyWEJ3K2hrcExueHBlMzBISFhVNnZOVnZIK2pTallJS1g4?= =?utf-8?B?SGxwMnJ6bEtKZHZYbENqcXZWZGZiQ1VJendWeG1hSzQrUkhpQ0dDU1o3L3Vs?= =?utf-8?B?ZWMzN1ovbk1TS2xwQlNKY1lvNitMaWNHbTFHR2JuNU9JV1VwMXR4R25lQjhY?= =?utf-8?B?eTBKQjVWeUIwYnllM2sxd2ptQncyRjdRMWFicW9XVThsc2p1MkkyaHV2QWpO?= =?utf-8?B?VVJXVnc3cEtFSVd4Qy9HV0FSWUF5aGV3a3BRbDczVm9uYkdCSDhTTUYzMDJO?= =?utf-8?B?Y3Y5N3FjOWpJa3hqN0pJUGp0bFhjWkdpZ250ODR5cTBtUzUvKzZ0SzRFQUVU?= =?utf-8?B?K0xTQUpGT0NJcERkdlBtOE1RZlJ5YVVyaTlEVlVjQkJxWldmUWFKVGxyOFht?= =?utf-8?B?bjRCaFhST1NuWm5VeGJhcXYxOWdkeWFOV0FuVVhxc05SVmViMFFPSlRmbXU4?= =?utf-8?B?Q1ZVOEp4dHU4MlcvTkl1c1M3MjR5dS9pYXIrT0l5aFNkaGlzMkFJa3BLYis2?= =?utf-8?B?aUZXRXZKUm1DVFFMNkp1VUxPUlVUUU9KRDd6ZHorOFlGbm9XWGg2cDhEZzZv?= =?utf-8?B?Q1M4VDNXNW5maFA2VW9IVWV2OWhEaE9ZL1VGdTMrNUFpbnJjaUJZK212ZCtF?= =?utf-8?B?NUdjVkl3cEFZOTZYTEp2YmlXN0lkdHVkalVka1NBdEpscVFodXFIZEVnZUFm?= =?utf-8?B?RS9ZWlBmSmQvZnhPNXk5Q29JTDNmc1l6TE1xeWFtWUtGZzg0YklNaVhQbjdY?= =?utf-8?B?ZzM4YTFncEtWR1hRVmRCSGgxWW43WkNoSFoyMC9tNDZnd2U3Um9wRzhuS01G?= =?utf-8?B?RGplM1B3TVVOdzNQcXcxblV2dml3NkNaOWdncmVoV1Vjcm03WE4zWi8zRTB1?= =?utf-8?B?N0RUMlZURitVS1lXck5TdU12UWtHVDRlQ3Q1eG96bkQ1eUdwWUozUW5kY1h4?= =?utf-8?B?MTNhemg5U0pTSEg3WXdHcTNRMkNYTmlZeVJLckMrLzNTeDVrK1hJTVhBZktv?= =?utf-8?Q?ESOsn9NiMv3gmQeGbxuUSqTbfmrdJumFCfOmv9b?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR02MB3877.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0708a1b2-5cd6-4562-b131-08d91479a3eb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 12:38:12.2687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s67UbOYhGZ/JxrMs9RZGGTRwXcgIZfRcXfZtNhcM9+K18DoQ6FEoj2hebomJj/dZaPQwbDXNZOgoHYY0JyTQ9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB7018 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org SGkgQW5keSBTaGV2Y2hlbmtvLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZy b206IFNhaSBLcmlzaG5hIFBvdHRodXJpDQo+IFNlbnQ6IFdlZG5lc2RheSwgQXByaWwgMjgsIDIw MjEgMTE6MDQgQU0NCj4gVG86IEFuZHkgU2hldmNoZW5rbyA8YW5keS5zaGV2Y2hlbmtvQGdtYWls LmNvbT4NCj4gQ2M6IExpbnVzIFdhbGxlaWogPGxpbnVzLndhbGxlaWpAbGluYXJvLm9yZz47IFJv YiBIZXJyaW5nDQo+IDxyb2JoK2R0QGtlcm5lbC5vcmc+OyBNaWNoYWwgU2ltZWsgPG1pY2hhbHNA eGlsaW54LmNvbT47IEdyZWcgS3JvYWgtDQo+IEhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRp b24ub3JnPjsgbGludXgtYXJtIE1haWxpbmcgTGlzdCA8bGludXgtYXJtLQ0KPiBrZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZz47IExpbnV4IEtlcm5lbCBNYWlsaW5nIExpc3QgPGxpbnV4LQ0KPiBr ZXJuZWxAdmdlci5rZXJuZWwub3JnPjsgZGV2aWNldHJlZSA8ZGV2aWNldHJlZUB2Z2VyLmtlcm5l bC5vcmc+OyBvcGVuDQo+IGxpc3Q6R1BJTyBTVUJTWVNURU0gPGxpbnV4LWdwaW9Admdlci5rZXJu ZWwub3JnPjsgZ2l0IDxnaXRAeGlsaW54LmNvbT47DQo+IHNhaWtyaXNobmExMjQ2OEBnbWFpbC5j b20NCj4gU3ViamVjdDogUkU6IFtQQVRDSCB2NiAzLzNdIHBpbmN0cmw6IEFkZCBYaWxpbnggWnlu cU1QIHBpbmN0cmwgZHJpdmVyIHN1cHBvcnQNCj4gDQo+IEhpIEFuZHkgU2hldmNoZW5rbywNCj4g DQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBBbmR5IFNoZXZjaGVu a28gPGFuZHkuc2hldmNoZW5rb0BnbWFpbC5jb20+DQo+ID4gU2VudDogTW9uZGF5LCBBcHJpbCAy NiwgMjAyMSA3OjM1IFBNDQo+ID4gVG86IFNhaSBLcmlzaG5hIFBvdHRodXJpIDxsYWtzaG1pc0B4 aWxpbnguY29tPg0KPiA+IENjOiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxsZWlqQGxpbmFyby5v cmc+OyBSb2IgSGVycmluZw0KPiA+IDxyb2JoK2R0QGtlcm5lbC5vcmc+OyBNaWNoYWwgU2ltZWsg PG1pY2hhbHNAeGlsaW54LmNvbT47IEdyZWcgS3JvYWgtDQo+ID4gSGFydG1hbiA8Z3JlZ2toQGxp bnV4Zm91bmRhdGlvbi5vcmc+OyBsaW51eC1hcm0gTWFpbGluZyBMaXN0IDxsaW51eC1hcm0tDQo+ ID4ga2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc+OyBMaW51eCBLZXJuZWwgTWFpbGluZyBMaXN0 IDxsaW51eC0NCj4gPiBrZXJuZWxAdmdlci5rZXJuZWwub3JnPjsgZGV2aWNldHJlZSA8ZGV2aWNl dHJlZUB2Z2VyLmtlcm5lbC5vcmc+OyBvcGVuDQo+ID4gbGlzdDpHUElPIFNVQlNZU1RFTSA8bGlu dXgtZ3Bpb0B2Z2VyLmtlcm5lbC5vcmc+OyBnaXQgPGdpdEB4aWxpbnguY29tPjsNCj4gPiBzYWlr cmlzaG5hMTI0NjhAZ21haWwuY29tDQo+ID4gU3ViamVjdDogUmU6IFtQQVRDSCB2NiAzLzNdIHBp bmN0cmw6IEFkZCBYaWxpbnggWnlucU1QIHBpbmN0cmwgZHJpdmVyDQo+IHN1cHBvcnQNCi4uLg0K PiA+DQo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIHJldCA9IHp5bnFtcF9wbV9waW5jdHJsX2dl dF9jb25maWcocGluLCBwYXJhbSwgJmFyZyk7DQo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIGlm IChhcmcgIT0gUE1fUElOQ1RSTF9CSUFTX1BVTExfVVApDQo+ID4gPiA+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gPiA+DQo+ID4gPiA+IEVycm9yIGNvZGUg YmVpbmcgc2hhZG93ZWQuIEluc3RlYWQgY2hlY2sgaXQgaGVyZSBwcm9wZXJseS4NCj4gPg0KPiA+ ID4gQXJlIHlvdSBtZW50aW9uaW5nIHRoZSBjYXNlIHdoZXJlIHJldCBpcyBhbHNvIGEgbm9uLXpl cm8/DQo+ID4gPiBJZiB5ZXMsIHRoZW4gSSB3aWxsIHVwZGF0ZSB0aGlzIGNoZWNrIHRvDQo+ID4g PiBpZiAoIXJldCAmJiBhcmcgIT0gUE1fUElOQ1RSTF9CSUFTX1BVTExfVVApDQo+ID4gPiAgICAg ICAgIHJldHVybiAtRUlOVkFMOw0KPiA+DQo+ID4gTm8sIHRoaXMgaXMgd3JvbmcgaW4gdGhlIHNh bWUgd2F5Lg0KPiA+DQo+ID4gPiByZXQgbm9uLXplcm8gY2FzZSwgd2UgYXJlIGhhbmRsaW5nIGF0 IHRoZSBlbmQgb2Ygc3dpdGNoIGNhc2UuDQo+ID4NCj4gPiBJIG1lYW50IHRoYXQgeW91IG5lZWQg dG8gcGFzcyB0aGUgcmVhbCByZXR1cm4gY29kZSB0byB0aGUgKHVwcGVyKSBjYWxsZXIuDQo+IEhl cmUgd2UgYXJlIGNoZWNraW5nIGZvciB2YWxpZCBhcmd1bWVudCBhbmQgbm90IHRoZSByZXR1cm4g dmFsdWUgb2YgdGhlIEFQSS4NCj4gSWYgdGhlIHJlYWQgdmFsdWUoYXJndW1lbnQpIGlzIG5vdCB2 YWxpZCBhbmQgcmV0dXJuIHZhbHVlIG9mIHRoZSBBUEkgaXMNCj4gemVybyAoU1VDQ0VTUykgdGhl biBmcmFtZXdvcmsgZXhwZWN0cyBkcml2ZXIgdG8gYmUgcmV0dXJuZWQgd2l0aA0KPiAnLUVJTlZB TCcgYW5kIGl0IGlzIGEgbGVnYWwgZXJyb3IgY29kZSBpbiB0aGlzIGNhc2UuDQpEbyB5b3UgYWdy ZWUgb24gdGhpcz8NCkkgYW0gcmVhZHkgd2l0aCB0aGUgb3RoZXIgY2hhbmdlcywgd2lsbCBzZW5k IG91dCB0aGUgcGF0Y2ggdG8gYWRkcmVzcyB5b3VyIGNvbW1lbnRzLg0KDQpSZWdhcmRzDQpTYWkg S3Jpc2huYQ0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C294C433ED for ; Tue, 11 May 2021 13:34:03 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B08961621 for ; Tue, 11 May 2021 13:34:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B08961621 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vfb+HwpJ9usNnajvgWPP3crBqawWLbEttneAzIVs5bs=; b=Uv6obToa9yovZgwFyZ6GD6hrq eEp1oV0Z9gDfhTEl8MaNJtgI/HvrW5qKEaO6R+92QZHrT6VGmmsR2WAhPGvGXJz/QGJ4GM4gdwyZY YwvvtAPslwLUlvV5bd2FDUHYxmweQ5/eIuYM2cTYGg3f2/Z5+DBm682vouSsneHhffo2LXxZeEn29 iUHa82RLxHe5cwszLDKQhla0necb1YfQxVGm3p6xkvD/ncStIJraWzsLOW2G7GylpVRdEqQPXRsIJ e8V3dXABP0juD0AelDxseR+sFFGULQk1zI43mnp5TvjNMcbQ97dzngQYDiUV0LrwIDu1vTrrk0iDr TfPRdQp0A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgSUi-00094T-3H; Tue, 11 May 2021 13:32:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgReV-00HQaP-7p for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 12:38:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Message-ID:Date :Subject:CC:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=rEs0b95P8RAtVBmSqWD8Ygrv276hC+eyK2iWbu7IAyU=; b=carumS6N3sujXm6SBdNFxPRLo3 boPrUTjERutR3qvWs05EyoiWdHvbGvIdlxWzOrXcBQ2l4IMoxwz9D6mssTKhjqcgY5KvP1ztUi/s7 B+vttgCZjCxOVxCeB/AUWKYw9dtnML9J/ylS+lU93DmJLVxQ3nvjtoIBZNwPVFPngPguYXEMIU+OF jGbdEQdzeEOR/aJ3XnwIqis4c66NLtOHeeqtZXhVNu3me2oLVKf4qPcBklOF8Gglhgnp33LPL8Fhu JnY+91VnW/GVL4uQtA8R6I50lAtAHlIfcpTHjgP0drtVkfczGjpjcSTWMXqqo7amHss/ywXdA6qOi ZUW3DoBA==; Received: from mail-co1nam11on2046.outbound.protection.outlook.com ([40.107.220.46] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgReS-009Zqa-Dm for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 12:38:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3P/JoRiGPyNhbEYNHIzinVXi78Ab/803TT5/zJ/cs8paKzt6ksNzCFAVgy97XMELemePjoBv2EZgu5xIqzY53GMRkyTFgmixFG/GTw3ePqO6LD6W2NGSkz6e+YPJWB+Ki3Ix42ZIHEG+OVnC4SZBAfcSLOPEX39+IGuIQ/fVzsLpqsq7em4JI1hsuGeVIag9miiBVSUTNHnWzigeeiHgjibIUtyPw2vfl7vHkTtEHEAIvjljqdV9ulxEYJJbTOL+upZLHKADBVvcotcxkh8q7dfdCumaILsDyskjBWM75LObwZykQ6uPViCi/oYgAX55ZSulN8ApHumtUmH73p5Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEs0b95P8RAtVBmSqWD8Ygrv276hC+eyK2iWbu7IAyU=; b=KChy65bHcfLDPaFqwoYxT791JLlD2+3xhupZjI3MW7OKQwVImJ3utHzJDXer3aDaOKEiyeRhhpdqLVe0sEoluV9z4e9pYVrwpyw8jhztfhQ18UAMmEV3hfzcJc7pMO5PjAujxzbh2Ju12eI8bns4S3Uj4zy24TNKTwPdnb4NS0XDlbb7+WEEeNabqa01pXgEuzNpQudqsdet0Sg028FmQwd3+kbA67bRnUjuUQvcr/IYQvyrNmzShsqtMFay060r8WfheaqdcaPT5PuouFw8IS66aPZ2NNe2trEnBK3hmgj0Q5qFBV8ZqMe9sZzpNO6ctD1H94mZG5jOuBFE4deihA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xilinx.com; dmarc=pass action=none header.from=xilinx.com; dkim=pass header.d=xilinx.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEs0b95P8RAtVBmSqWD8Ygrv276hC+eyK2iWbu7IAyU=; b=Kl4APPXNCzuuhCgjKRtyV9/GySh5EUhwxoZS5c02w0vaLotzKJI4EsxPvUVFww1v7HX6wpkt+JtMskm0TNax3BVNhcWS8ZYG//ddNonyoU11xGmSxmesqYmVR2Acv32idvo8dd8UCDFeHRy4q4QArw2Ex5jK/IdVNz/cxd67p4E= Received: from DM5PR02MB3877.namprd02.prod.outlook.com (2603:10b6:4:b9::34) by DM6PR02MB7018.namprd02.prod.outlook.com (2603:10b6:5:259::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May 2021 12:38:12 +0000 Received: from DM5PR02MB3877.namprd02.prod.outlook.com ([fe80::53:31a3:2e23:75e1]) by DM5PR02MB3877.namprd02.prod.outlook.com ([fe80::53:31a3:2e23:75e1%5]) with mapi id 15.20.4108.031; Tue, 11 May 2021 12:38:12 +0000 From: Sai Krishna Potthuri To: Andy Shevchenko CC: Linus Walleij , Rob Herring , Michal Simek , Greg Kroah-Hartman , linux-arm Mailing List , Linux Kernel Mailing List , devicetree , "open list:GPIO SUBSYSTEM" , git , "saikrishna12468@gmail.com" Subject: RE: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Topic: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support Thread-Index: AQHXN1HnJ1dD/z2380CasZDNOXc+DarCQxoAgAQix4CAAHWwAIAAH53ggBdJowA= Date: Tue, 11 May 2021 12:38:12 +0000 Message-ID: References: <1619080202-31924-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1619080202-31924-4-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=xilinx.com; x-originating-ip: [149.199.50.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0708a1b2-5cd6-4562-b131-08d91479a3eb x-ms-traffictypediagnostic: DM6PR02MB7018: x-ld-processed: 657af505-d5df-48d0-8300-c31994686c5c,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aFaPMz8Tf0nxIl/EXYQCktu0KVy2mbV5cy1GoVpP1B0443CSzA0MSZYB1UEnkzVOPaO5TVQa2YriRkjs6iQ7Wz9svF7K7Qk6LF1sNEInwmFrUhxo3Fjujcp0Oo04nlVnxXkPDeECDi+BO88zi/VBTG6QKDpnuS4OV1k97xq55PD9HMeUeqlUsf274A/kce767RkN29eyDJGKzWr7AVOgY3TdGtNhtmCdAiqJgLPcoKq1DtLr2aZgkLF4f6spanJrcONYlNpynpswqO7UQk+PWlxe7JfW8Qft3SfHGVYPGV9Y3iYzEbH5pX/igiposFZ46RE6xECmoyY4TxDlYQnGF1nPZIdqM/jIKGNSwvR9soRoWuZgqQhvuydCVWyw8XEFZSD3xl5mMk/SiYJwntKXYHCVsdRZvKEi6oni4mzYXXP3ZwOgK/Aq9bJ+mIXkqlpouxDuCXrpX6Y1Yy0gjkFbvaEftgzVxgw+MQucCNovImKkq3ycjT5YUQC024zmjG6YSxnBW4LktGP7amhYah0tykjlXi7aSSrh2J1cWjkUi6apKC6cS5atIFUAeXJtVN9n8Ppit3GqSWBizGXpycqMP/crQQxMCHmL07pg+LLoQT4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR02MB3877.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39840400004)(136003)(346002)(396003)(376002)(366004)(66946007)(76116006)(26005)(55016002)(52536014)(7416002)(316002)(4326008)(8676002)(64756008)(478600001)(33656002)(54906003)(9686003)(66556008)(66446008)(8936002)(83380400001)(5660300002)(6506007)(53546011)(2906002)(71200400001)(66476007)(86362001)(122000001)(38100700002)(186003)(7696005)(6916009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NjRVV3RnTW5aOGRyc2lJYm9ZcjgydnUrdkJ5NFJNMi9Oa0tSOFpBS1RkMlRt?= =?utf-8?B?Ui8wYjBPT283S1NlaHhET1N4STNqM1p6VXlqSjNTT3lOSnF2VnBRVHY4Tlps?= =?utf-8?B?UlFwV2Vmc3JCSEsrYklLMVc2czF1Q2haQ1ZSTnFYRWx3UGsvSDRFMVBqN3Fo?= =?utf-8?B?cUxQcHdaT1I4SHZseTM2am1QZzcyY2dSalVHbUJJK1JlSHQya012bXI3SldQ?= =?utf-8?B?UFdmQWhhbUk1WVBzbFdTVWpPQ2VKdElzM1k0UVpSWXRnSGw0QmpHNUJWTjQz?= =?utf-8?B?R0NxNTAydHEydUxCOStjUUFyRkZpUG50NGljVXVOSnRISnl1YnQ4d2ZUYUFJ?= =?utf-8?B?N3kvZHN4R1B2T2Vad2ZhUDdvUURxOXhXUjRYLzJaRHBuSFMzSGpRQmRmQkIr?= =?utf-8?B?SE16TXRPUTloTHJhQ3FJS2xKVm1odGFJRC9HNy8yc2Rjd3FNUythV0l4WThI?= =?utf-8?B?RlNSdlh2TUNFZzBGSXpseVpQK3VzTkt5c0l6LzhrUEQ3Y3ZwWXJlNnBGV3o4?= =?utf-8?B?MGY2UGJKdjkwUlVkUkVCK2d0OStuREE1RjJSM1pBYVVudEhNNkhteTFKdUF1?= =?utf-8?B?NTFCVEFodG13ODlSak5DQ29qcXYrUGlycWxVQUZKRmUzK1M4Q25UOG9mSHFy?= =?utf-8?B?OVE2OFh2MnlkN3ZEdmJSUjVFN2pXV0pWazd3OGFnYU1VWGhQUkNMdXJJTDlC?= =?utf-8?B?cWFLUUpKNXpwM2FyWEJ3K2hrcExueHBlMzBISFhVNnZOVnZIK2pTallJS1g4?= =?utf-8?B?SGxwMnJ6bEtKZHZYbENqcXZWZGZiQ1VJendWeG1hSzQrUkhpQ0dDU1o3L3Vs?= =?utf-8?B?ZWMzN1ovbk1TS2xwQlNKY1lvNitMaWNHbTFHR2JuNU9JV1VwMXR4R25lQjhY?= =?utf-8?B?eTBKQjVWeUIwYnllM2sxd2ptQncyRjdRMWFicW9XVThsc2p1MkkyaHV2QWpO?= =?utf-8?B?VVJXVnc3cEtFSVd4Qy9HV0FSWUF5aGV3a3BRbDczVm9uYkdCSDhTTUYzMDJO?= =?utf-8?B?Y3Y5N3FjOWpJa3hqN0pJUGp0bFhjWkdpZ250ODR5cTBtUzUvKzZ0SzRFQUVU?= =?utf-8?B?K0xTQUpGT0NJcERkdlBtOE1RZlJ5YVVyaTlEVlVjQkJxWldmUWFKVGxyOFht?= =?utf-8?B?bjRCaFhST1NuWm5VeGJhcXYxOWdkeWFOV0FuVVhxc05SVmViMFFPSlRmbXU4?= =?utf-8?B?Q1ZVOEp4dHU4MlcvTkl1c1M3MjR5dS9pYXIrT0l5aFNkaGlzMkFJa3BLYis2?= =?utf-8?B?aUZXRXZKUm1DVFFMNkp1VUxPUlVUUU9KRDd6ZHorOFlGbm9XWGg2cDhEZzZv?= =?utf-8?B?Q1M4VDNXNW5maFA2VW9IVWV2OWhEaE9ZL1VGdTMrNUFpbnJjaUJZK212ZCtF?= =?utf-8?B?NUdjVkl3cEFZOTZYTEp2YmlXN0lkdHVkalVka1NBdEpscVFodXFIZEVnZUFm?= =?utf-8?B?RS9ZWlBmSmQvZnhPNXk5Q29JTDNmc1l6TE1xeWFtWUtGZzg0YklNaVhQbjdY?= =?utf-8?B?ZzM4YTFncEtWR1hRVmRCSGgxWW43WkNoSFoyMC9tNDZnd2U3Um9wRzhuS01G?= =?utf-8?B?RGplM1B3TVVOdzNQcXcxblV2dml3NkNaOWdncmVoV1Vjcm03WE4zWi8zRTB1?= =?utf-8?B?N0RUMlZURitVS1lXck5TdU12UWtHVDRlQ3Q1eG96bkQ1eUdwWUozUW5kY1h4?= =?utf-8?B?MTNhemg5U0pTSEg3WXdHcTNRMkNYTmlZeVJLckMrLzNTeDVrK1hJTVhBZktv?= =?utf-8?Q?ESOsn9NiMv3gmQeGbxuUSqTbfmrdJumFCfOmv9b?= MIME-Version: 1.0 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR02MB3877.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0708a1b2-5cd6-4562-b131-08d91479a3eb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 12:38:12.2687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s67UbOYhGZ/JxrMs9RZGGTRwXcgIZfRcXfZtNhcM9+K18DoQ6FEoj2hebomJj/dZaPQwbDXNZOgoHYY0JyTQ9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB7018 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_053816_493504_10FDD19B X-CRM114-Status: GOOD ( 23.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy Shevchenko, > -----Original Message----- > From: Sai Krishna Potthuri > Sent: Wednesday, April 28, 2021 11:04 AM > To: Andy Shevchenko > Cc: Linus Walleij ; Rob Herring > ; Michal Simek ; Greg Kroah- > Hartman ; linux-arm Mailing List kernel@lists.infradead.org>; Linux Kernel Mailing List kernel@vger.kernel.org>; devicetree ; open > list:GPIO SUBSYSTEM ; git ; > saikrishna12468@gmail.com > Subject: RE: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver support > > Hi Andy Shevchenko, > > > -----Original Message----- > > From: Andy Shevchenko > > Sent: Monday, April 26, 2021 7:35 PM > > To: Sai Krishna Potthuri > > Cc: Linus Walleij ; Rob Herring > > ; Michal Simek ; Greg Kroah- > > Hartman ; linux-arm Mailing List > kernel@lists.infradead.org>; Linux Kernel Mailing List > kernel@vger.kernel.org>; devicetree ; open > > list:GPIO SUBSYSTEM ; git ; > > saikrishna12468@gmail.com > > Subject: Re: [PATCH v6 3/3] pinctrl: Add Xilinx ZynqMP pinctrl driver > support ... > > > > > > > + ret = zynqmp_pm_pinctrl_get_config(pin, param, &arg); > > > > > + if (arg != PM_PINCTRL_BIAS_PULL_UP) > > > > > + return -EINVAL; > > > > > > > > Error code being shadowed. Instead check it here properly. > > > > > Are you mentioning the case where ret is also a non-zero? > > > If yes, then I will update this check to > > > if (!ret && arg != PM_PINCTRL_BIAS_PULL_UP) > > > return -EINVAL; > > > > No, this is wrong in the same way. > > > > > ret non-zero case, we are handling at the end of switch case. > > > > I meant that you need to pass the real return code to the (upper) caller. > Here we are checking for valid argument and not the return value of the API. > If the read value(argument) is not valid and return value of the API is > zero (SUCCESS) then framework expects driver to be returned with > '-EINVAL' and it is a legal error code in this case. Do you agree on this? I am ready with the other changes, will send out the patch to address your comments. Regards Sai Krishna _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel