All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
@ 2017-03-24 18:06 kys
  2017-03-24 18:07 ` [PATCH 1/2] PCI: hv: Fix a bug in specifying CPU affinity kys
                   ` (3 more replies)
  0 siblings, 4 replies; 14+ messages in thread
From: kys @ 2017-03-24 18:06 UTC (permalink / raw)
  To: helgaas, linux-pci, linux-kernel, devel, olaf, apw, vkuznets,
	jasowang, leann.ogasawara, marcelo.cerri, sthemmin
  Cc: K. Y. Srinivasan

From: K. Y. Srinivasan <kys@microsoft.com>

Some miscellaneous fixes.

K. Y. Srinivasan (2):
  pci-hyperv: Fix a bug in specifying CPU affinity
  pci-hyperv: Fix an atomic bug

 drivers/pci/host/pci-hyperv.c |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/2] PCI: hv: Fix a bug in specifying CPU affinity
  2017-03-24 18:06 [PATCH 0/2] pci-hyperv: Some miscellaneous fixes kys
@ 2017-03-24 18:07 ` kys
  2017-03-24 18:07 ` [PATCH 1/2] pci-hyperv: " kys
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 14+ messages in thread
From: kys @ 2017-03-24 18:07 UTC (permalink / raw)
  To: helgaas, linux-pci, linux-kernel, devel, olaf, apw, vkuznets,
	jasowang, leann.ogasawara, marcelo.cerri, sthemmin
  Cc: K. Y. Srinivasan, stable

From: K. Y. Srinivasan <kys@microsoft.com>

When we have 32 or more CPUs in the affinity mask, we should
use a special constant to specify that to the host. Fix this issue.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org>
---
 drivers/pci/host/pci-hyperv.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
index ada9856..2c2ea1e 100644
--- a/drivers/pci/host/pci-hyperv.c
+++ b/drivers/pci/host/pci-hyperv.c
@@ -897,9 +897,13 @@ static void hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
 	 * processors because Hyper-V only supports 64 in a guest.
 	 */
 	affinity = irq_data_get_affinity_mask(data);
-	for_each_cpu_and(cpu, affinity, cpu_online_mask) {
-		int_pkt->int_desc.cpu_mask |=
-			(1ULL << vmbus_cpu_number_to_vp_number(cpu));
+	if (cpumask_weight(affinity) >= 32) {
+		int_pkt->int_desc.cpu_mask = -1ULL;
+	} else {
+		for_each_cpu_and(cpu, affinity, cpu_online_mask) {
+			int_pkt->int_desc.cpu_mask |=
+				(1ULL << vmbus_cpu_number_to_vp_number(cpu));
+		}
 	}
 
 	ret = vmbus_sendpacket(hpdev->hbus->hdev->channel, int_pkt,
-- 
1.7.1

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/2] pci-hyperv: Fix a bug in specifying CPU affinity
  2017-03-24 18:06 [PATCH 0/2] pci-hyperv: Some miscellaneous fixes kys
  2017-03-24 18:07 ` [PATCH 1/2] PCI: hv: Fix a bug in specifying CPU affinity kys
@ 2017-03-24 18:07 ` kys
  2017-03-27 18:13     ` Long Li
  2017-03-24 18:07 ` [PATCH 2/2] pci-hyperv: Fix an atomic bug kys
  2017-04-04 19:03 ` [PATCH 0/2] pci-hyperv: Some miscellaneous fixes Bjorn Helgaas
  3 siblings, 1 reply; 14+ messages in thread
From: kys @ 2017-03-24 18:07 UTC (permalink / raw)
  To: helgaas, linux-pci, linux-kernel, devel, olaf, apw, vkuznets,
	jasowang, leann.ogasawara, marcelo.cerri, sthemmin
  Cc: K. Y. Srinivasan, stable

From: K. Y. Srinivasan <kys@microsoft.com>

When we have 32 or more CPUs in the affinity mask, we should
use a special constant to specify that to the host. Fix this issue.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org>
---
 drivers/pci/host/pci-hyperv.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
index ada9856..32a16fb 100644
--- a/drivers/pci/host/pci-hyperv.c
+++ b/drivers/pci/host/pci-hyperv.c
@@ -72,6 +72,7 @@ enum {
 	PCI_PROTOCOL_VERSION_CURRENT = PCI_PROTOCOL_VERSION_1_1
 };
 
+#define CPU_AFFINITY_ALL	-1ULL
 #define PCI_CONFIG_MMIO_LENGTH	0x2000
 #define CFG_PAGE_OFFSET 0x1000
 #define CFG_PAGE_SIZE (PCI_CONFIG_MMIO_LENGTH - CFG_PAGE_OFFSET)
@@ -897,9 +898,13 @@ static void hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
 	 * processors because Hyper-V only supports 64 in a guest.
 	 */
 	affinity = irq_data_get_affinity_mask(data);
-	for_each_cpu_and(cpu, affinity, cpu_online_mask) {
-		int_pkt->int_desc.cpu_mask |=
-			(1ULL << vmbus_cpu_number_to_vp_number(cpu));
+	if (cpumask_weight(affinity) >= 32) {
+		int_pkt->int_desc.cpu_mask = CPU_AFFINITY_ALL;
+	} else {
+		for_each_cpu_and(cpu, affinity, cpu_online_mask) {
+			int_pkt->int_desc.cpu_mask |=
+				(1ULL << vmbus_cpu_number_to_vp_number(cpu));
+		}
 	}
 
 	ret = vmbus_sendpacket(hpdev->hbus->hdev->channel, int_pkt,
-- 
1.7.1

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 2/2] pci-hyperv: Fix an atomic bug
  2017-03-24 18:06 [PATCH 0/2] pci-hyperv: Some miscellaneous fixes kys
  2017-03-24 18:07 ` [PATCH 1/2] PCI: hv: Fix a bug in specifying CPU affinity kys
  2017-03-24 18:07 ` [PATCH 1/2] pci-hyperv: " kys
@ 2017-03-24 18:07 ` kys
  2017-03-27 18:14     ` Long Li
  2017-04-04 19:03 ` [PATCH 0/2] pci-hyperv: Some miscellaneous fixes Bjorn Helgaas
  3 siblings, 1 reply; 14+ messages in thread
From: kys @ 2017-03-24 18:07 UTC (permalink / raw)
  To: helgaas, linux-pci, linux-kernel, devel, olaf, apw, vkuznets,
	jasowang, leann.ogasawara, marcelo.cerri, sthemmin
  Cc: K. Y. Srinivasan, stable

From: K. Y. Srinivasan <kys@microsoft.com>

The memory allocation here needs to be non-blocking.
Fix the issue.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org>
---
 drivers/pci/host/pci-hyperv.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
index 32a16fb..85088a1 100644
--- a/drivers/pci/host/pci-hyperv.c
+++ b/drivers/pci/host/pci-hyperv.c
@@ -877,7 +877,7 @@ static void hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
 		hv_int_desc_free(hpdev, int_desc);
 	}
 
-	int_desc = kzalloc(sizeof(*int_desc), GFP_KERNEL);
+	int_desc = kzalloc(sizeof(*int_desc), GFP_ATOMIC);
 	if (!int_desc)
 		goto drop_reference;
 
-- 
1.7.1

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH 1/2] pci-hyperv: Fix a bug in specifying CPU affinity
  2017-03-24 18:07 ` [PATCH 1/2] pci-hyperv: " kys
@ 2017-03-27 18:13     ` Long Li
  0 siblings, 0 replies; 14+ messages in thread
From: Long Li @ 2017-03-27 18:13 UTC (permalink / raw)
  To: KY Srinivasan, helgaas, linux-pci, linux-kernel, devel, olaf,
	apw, vkuznets, jasowang, leann.ogasawara, marcelo.cerri,
	Stephen Hemminger
  Cc: stable

> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On
> Behalf Of kys@exchange.microsoft.com
> Sent: Friday, March 24, 2017 11:07 AM
> To: helgaas@kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Cc: stable@vger.kernel.org
> Subject: [PATCH 1/2] pci-hyperv: Fix a bug in specifying CPU affinity
> 
> From: K. Y. Srinivasan <kys@microsoft.com>
> 
> When we have 32 or more CPUs in the affinity mask, we should use a special
> constant to specify that to the host. Fix this issue.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Cc: <stable@vger.kernel.org>

Reviewed-by: Long Li <longli@microsoft.com>

> ---
>  drivers/pci/host/pci-hyperv.c |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
> index ada9856..32a16fb 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -72,6 +72,7 @@ enum {
>         PCI_PROTOCOL_VERSION_CURRENT = PCI_PROTOCOL_VERSION_1_1  };
> 
> +#define CPU_AFFINITY_ALL       -1ULL
>  #define PCI_CONFIG_MMIO_LENGTH 0x2000
>  #define CFG_PAGE_OFFSET 0x1000
>  #define CFG_PAGE_SIZE (PCI_CONFIG_MMIO_LENGTH -
> CFG_PAGE_OFFSET) @@ -897,9 +898,13 @@ static void
> hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
>          * processors because Hyper-V only supports 64 in a guest.
>          */
>         affinity = irq_data_get_affinity_mask(data);
> -       for_each_cpu_and(cpu, affinity, cpu_online_mask) {
> -               int_pkt->int_desc.cpu_mask |=
> -                       (1ULL << vmbus_cpu_number_to_vp_number(cpu));
> +       if (cpumask_weight(affinity) >= 32) {
> +               int_pkt->int_desc.cpu_mask = CPU_AFFINITY_ALL;
> +       } else {
> +               for_each_cpu_and(cpu, affinity, cpu_online_mask) {
> +                       int_pkt->int_desc.cpu_mask |=
> +                               (1ULL << vmbus_cpu_number_to_vp_number(cpu));
> +               }
>         }
> 
>         ret = vmbus_sendpacket(hpdev->hbus->hdev->channel, int_pkt,
> --
> 1.7.1
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH 1/2] pci-hyperv: Fix a bug in specifying CPU affinity
@ 2017-03-27 18:13     ` Long Li
  0 siblings, 0 replies; 14+ messages in thread
From: Long Li @ 2017-03-27 18:13 UTC (permalink / raw)
  To: KY Srinivasan, helgaas, linux-pci, linux-kernel, devel, olaf,
	apw, vkuznets, jasowang, leann.ogasawara, marcelo.cerri,
	Stephen Hemminger
  Cc: stable

> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On
> Behalf Of kys@exchange.microsoft.com
> Sent: Friday, March 24, 2017 11:07 AM
> To: helgaas@kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Cc: stable@vger.kernel.org
> Subject: [PATCH 1/2] pci-hyperv: Fix a bug in specifying CPU affinity
>=20
> From: K. Y. Srinivasan <kys@microsoft.com>
>=20
> When we have 32 or more CPUs in the affinity mask, we should use a specia=
l
> constant to specify that to the host. Fix this issue.
>=20
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Cc: <stable@vger.kernel.org>

Reviewed-by: Long Li <longli@microsoft.com>

> ---
>  drivers/pci/host/pci-hyperv.c |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.=
c
> index ada9856..32a16fb 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -72,6 +72,7 @@ enum {
>         PCI_PROTOCOL_VERSION_CURRENT =3D PCI_PROTOCOL_VERSION_1_1  };
>=20
> +#define CPU_AFFINITY_ALL       -1ULL
>  #define PCI_CONFIG_MMIO_LENGTH 0x2000
>  #define CFG_PAGE_OFFSET 0x1000
>  #define CFG_PAGE_SIZE (PCI_CONFIG_MMIO_LENGTH -
> CFG_PAGE_OFFSET) @@ -897,9 +898,13 @@ static void
> hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
>          * processors because Hyper-V only supports 64 in a guest.
>          */
>         affinity =3D irq_data_get_affinity_mask(data);
> -       for_each_cpu_and(cpu, affinity, cpu_online_mask) {
> -               int_pkt->int_desc.cpu_mask |=3D
> -                       (1ULL << vmbus_cpu_number_to_vp_number(cpu));
> +       if (cpumask_weight(affinity) >=3D 32) {
> +               int_pkt->int_desc.cpu_mask =3D CPU_AFFINITY_ALL;
> +       } else {
> +               for_each_cpu_and(cpu, affinity, cpu_online_mask) {
> +                       int_pkt->int_desc.cpu_mask |=3D
> +                               (1ULL << vmbus_cpu_number_to_vp_number(cp=
u));
> +               }
>         }
>=20
>         ret =3D vmbus_sendpacket(hpdev->hbus->hdev->channel, int_pkt,
> --
> 1.7.1
>=20
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH 2/2] pci-hyperv: Fix an atomic bug
  2017-03-24 18:07 ` [PATCH 2/2] pci-hyperv: Fix an atomic bug kys
@ 2017-03-27 18:14     ` Long Li
  0 siblings, 0 replies; 14+ messages in thread
From: Long Li @ 2017-03-27 18:14 UTC (permalink / raw)
  To: KY Srinivasan, helgaas, linux-pci, linux-kernel, devel, olaf,
	apw, vkuznets, jasowang, leann.ogasawara, marcelo.cerri,
	Stephen Hemminger
  Cc: stable

> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On
> Behalf Of kys@exchange.microsoft.com
> Sent: Friday, March 24, 2017 11:07 AM
> To: helgaas@kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Cc: stable@vger.kernel.org
> Subject: [PATCH 2/2] pci-hyperv: Fix an atomic bug
> 
> From: K. Y. Srinivasan <kys@microsoft.com>
> 
> The memory allocation here needs to be non-blocking.
> Fix the issue.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Cc: <stable@vger.kernel.org>

Reviewed-by: Long Li <longli@microsoft.com>

> ---
>  drivers/pci/host/pci-hyperv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
> index 32a16fb..85088a1 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -877,7 +877,7 @@ static void hv_compose_msi_msg(struct irq_data
> *data, struct msi_msg *msg)
>                 hv_int_desc_free(hpdev, int_desc);
>         }
> 
> -       int_desc = kzalloc(sizeof(*int_desc), GFP_KERNEL);
> +       int_desc = kzalloc(sizeof(*int_desc), GFP_ATOMIC);
>         if (!int_desc)
>                 goto drop_reference;
> 
> --
> 1.7.1
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH 2/2] pci-hyperv: Fix an atomic bug
@ 2017-03-27 18:14     ` Long Li
  0 siblings, 0 replies; 14+ messages in thread
From: Long Li @ 2017-03-27 18:14 UTC (permalink / raw)
  To: KY Srinivasan, helgaas, linux-pci, linux-kernel, devel, olaf,
	apw, vkuznets, jasowang, leann.ogasawara, marcelo.cerri,
	Stephen Hemminger
  Cc: stable

> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@linuxdriverproject.org] On
> Behalf Of kys@exchange.microsoft.com
> Sent: Friday, March 24, 2017 11:07 AM
> To: helgaas@kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Cc: stable@vger.kernel.org
> Subject: [PATCH 2/2] pci-hyperv: Fix an atomic bug
>=20
> From: K. Y. Srinivasan <kys@microsoft.com>
>=20
> The memory allocation here needs to be non-blocking.
> Fix the issue.
>=20
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Cc: <stable@vger.kernel.org>

Reviewed-by: Long Li <longli@microsoft.com>

> ---
>  drivers/pci/host/pci-hyperv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.=
c
> index 32a16fb..85088a1 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -877,7 +877,7 @@ static void hv_compose_msi_msg(struct irq_data
> *data, struct msi_msg *msg)
>                 hv_int_desc_free(hpdev, int_desc);
>         }
>=20
> -       int_desc =3D kzalloc(sizeof(*int_desc), GFP_KERNEL);
> +       int_desc =3D kzalloc(sizeof(*int_desc), GFP_ATOMIC);
>         if (!int_desc)
>                 goto drop_reference;
>=20
> --
> 1.7.1
>=20
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
  2017-03-24 18:06 [PATCH 0/2] pci-hyperv: Some miscellaneous fixes kys
                   ` (2 preceding siblings ...)
  2017-03-24 18:07 ` [PATCH 2/2] pci-hyperv: Fix an atomic bug kys
@ 2017-04-04 19:03 ` Bjorn Helgaas
  2017-04-04 19:54     ` KY Srinivasan
  3 siblings, 1 reply; 14+ messages in thread
From: Bjorn Helgaas @ 2017-04-04 19:03 UTC (permalink / raw)
  To: kys
  Cc: linux-pci, linux-kernel, devel, olaf, apw, vkuznets, jasowang,
	leann.ogasawara, marcelo.cerri, sthemmin

On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com wrote:
> From: K. Y. Srinivasan <kys@microsoft.com>
> 
> Some miscellaneous fixes.
> 
> K. Y. Srinivasan (2):
>   pci-hyperv: Fix a bug in specifying CPU affinity
>   pci-hyperv: Fix an atomic bug
> 
>  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
>  1 files changed, 9 insertions(+), 4 deletions(-)

I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
following subject lines:

  PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
  PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC

There were two copies of [1/2], which makes this error-prone.  I applied
the second one that defines CPU_AFFINITY_ALL.

They're both marked for stable, but without any clue about when the
problems were introduced or how serious they are, I did not queue them for
v4.11.  If you want them in v4.11, please supply those additional details.

Bjorn

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
  2017-04-04 19:03 ` [PATCH 0/2] pci-hyperv: Some miscellaneous fixes Bjorn Helgaas
@ 2017-04-04 19:54     ` KY Srinivasan
  0 siblings, 0 replies; 14+ messages in thread
From: KY Srinivasan @ 2017-04-04 19:54 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-pci, linux-kernel, devel, olaf, apw, vkuznets, jasowang,
	leann.ogasawara, marcelo.cerri, Stephen Hemminger



> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: Tuesday, April 4, 2017 12:04 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> 
> On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com
> wrote:
> > From: K. Y. Srinivasan <kys@microsoft.com>
> >
> > Some miscellaneous fixes.
> >
> > K. Y. Srinivasan (2):
> >   pci-hyperv: Fix a bug in specifying CPU affinity
> >   pci-hyperv: Fix an atomic bug
> >
> >  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
> >  1 files changed, 9 insertions(+), 4 deletions(-)
> 
> I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
> following subject lines:
> 
>   PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
>   PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
> 
Thank you.

> There were two copies of [1/2], which makes this error-prone.  I applied
> the second one that defines CPU_AFFINITY_ALL.

Thanks again; sorry for the confusion.

> 
> They're both marked for stable, but without any clue about when the
> problems were introduced or how serious they are, I did not queue them for
> v4.11.  If you want them in v4.11, please supply those additional details.

I think these issues have been there since   the driver got merged upstream.
I would want this to be applied against 4.11 as well. Let me know if I should resend
these patches.

Thanks,

K. Y 
> 
> Bjorn

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
@ 2017-04-04 19:54     ` KY Srinivasan
  0 siblings, 0 replies; 14+ messages in thread
From: KY Srinivasan @ 2017-04-04 19:54 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-pci, linux-kernel, devel, olaf, apw, vkuznets, jasowang,
	leann.ogasawara, marcelo.cerri, Stephen Hemminger



> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: Tuesday, April 4, 2017 12:04 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
>=20
> On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com
> wrote:
> > From: K. Y. Srinivasan <kys@microsoft.com>
> >
> > Some miscellaneous fixes.
> >
> > K. Y. Srinivasan (2):
> >   pci-hyperv: Fix a bug in specifying CPU affinity
> >   pci-hyperv: Fix an atomic bug
> >
> >  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
> >  1 files changed, 9 insertions(+), 4 deletions(-)
>=20
> I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
> following subject lines:
>=20
>   PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >=3D 32 CPUs
>   PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
>=20
Thank you.

> There were two copies of [1/2], which makes this error-prone.  I applied
> the second one that defines CPU_AFFINITY_ALL.

Thanks again; sorry for the confusion.

>=20
> They're both marked for stable, but without any clue about when the
> problems were introduced or how serious they are, I did not queue them fo=
r
> v4.11.  If you want them in v4.11, please supply those additional details=
.

I think these issues have been there since   the driver got merged upstream=
.
I would want this to be applied against 4.11 as well. Let me know if I shou=
ld resend
these patches.

Thanks,

K. Y=20
>=20
> Bjorn

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
  2017-04-04 19:54     ` KY Srinivasan
  (?)
@ 2017-04-04 20:39     ` Bjorn Helgaas
  2017-04-04 21:47         ` KY Srinivasan
  -1 siblings, 1 reply; 14+ messages in thread
From: Bjorn Helgaas @ 2017-04-04 20:39 UTC (permalink / raw)
  To: KY Srinivasan
  Cc: linux-pci, linux-kernel, devel, olaf, apw, vkuznets, jasowang,
	leann.ogasawara, marcelo.cerri, Stephen Hemminger

On Tue, Apr 04, 2017 at 07:54:33PM +0000, KY Srinivasan wrote:
> > -----Original Message-----
> > From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> > Sent: Tuesday, April 4, 2017 12:04 PM
> > To: KY Srinivasan <kys@microsoft.com>
> > Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > vkuznets@redhat.com; jasowang@redhat.com;
> > leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> > Hemminger <sthemmin@microsoft.com>
> > Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> > 
> > On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com
> > wrote:
> > > From: K. Y. Srinivasan <kys@microsoft.com>
> > >
> > > Some miscellaneous fixes.
> > >
> > > K. Y. Srinivasan (2):
> > >   pci-hyperv: Fix a bug in specifying CPU affinity
> > >   pci-hyperv: Fix an atomic bug
> > >
> > >  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
> > >  1 files changed, 9 insertions(+), 4 deletions(-)
> > 
> > I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
> > following subject lines:
> > 
> >   PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
> >   PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
> > 
> Thank you.
> 
> > There were two copies of [1/2], which makes this error-prone.  I applied
> > the second one that defines CPU_AFFINITY_ALL.
> 
> Thanks again; sorry for the confusion.
> 
> > 
> > They're both marked for stable, but without any clue about when the
> > problems were introduced or how serious they are, I did not queue them for
> > v4.11.  If you want them in v4.11, please supply those additional details.
> 
> I think these issues have been there since   the driver got merged upstream.
> I would want this to be applied against 4.11 as well. Let me know if I should resend
> these patches.

No need to resend, but I do need more details about what issues these fix
and why they're more urgent than garden-variety bug fixes that are planned
for v4.12.  In general for-linus is for fixing problems we added during the
merge window, or other high-priority, low-risk changes.

Bjorn

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
  2017-04-04 20:39     ` Bjorn Helgaas
@ 2017-04-04 21:47         ` KY Srinivasan
  0 siblings, 0 replies; 14+ messages in thread
From: KY Srinivasan @ 2017-04-04 21:47 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-pci, linux-kernel, devel, olaf, apw, vkuznets, jasowang,
	leann.ogasawara, marcelo.cerri, Stephen Hemminger



> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: Tuesday, April 4, 2017 1:39 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> 
> On Tue, Apr 04, 2017 at 07:54:33PM +0000, KY Srinivasan wrote:
> > > -----Original Message-----
> > > From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> > > Sent: Tuesday, April 4, 2017 12:04 PM
> > > To: KY Srinivasan <kys@microsoft.com>
> > > Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > > vkuznets@redhat.com; jasowang@redhat.com;
> > > leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> > > Hemminger <sthemmin@microsoft.com>
> > > Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> > >
> > > On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com
> > > wrote:
> > > > From: K. Y. Srinivasan <kys@microsoft.com>
> > > >
> > > > Some miscellaneous fixes.
> > > >
> > > > K. Y. Srinivasan (2):
> > > >   pci-hyperv: Fix a bug in specifying CPU affinity
> > > >   pci-hyperv: Fix an atomic bug
> > > >
> > > >  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
> > > >  1 files changed, 9 insertions(+), 4 deletions(-)
> > >
> > > I applied these with Long's reviewed-by to pci/host-hv for v4.12 with the
> > > following subject lines:
> > >
> > >   PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >= 32 CPUs
> > >   PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
> > >
> > Thank you.
> >
> > > There were two copies of [1/2], which makes this error-prone.  I applied
> > > the second one that defines CPU_AFFINITY_ALL.
> >
> > Thanks again; sorry for the confusion.
> >
> > >
> > > They're both marked for stable, but without any clue about when the
> > > problems were introduced or how serious they are, I did not queue them
> for
> > > v4.11.  If you want them in v4.11, please supply those additional details.
> >
> > I think these issues have been there since   the driver got merged
> upstream.
> > I would want this to be applied against 4.11 as well. Let me know if I should
> resend
> > these patches.
> 
> No need to resend, but I do need more details about what issues these fix
> and why they're more urgent than garden-variety bug fixes that are planned
> for v4.12.  In general for-linus is for fixing problems we added during the
> merge window, or other high-priority, low-risk changes.

For sure I want to get this into 4.12. Since it fixes issues that have been there for a long time,
(including 4.11), it would be good to get it into 4.11 as well. 

Regards,

K. Y
> 
> Bjorn

^ permalink raw reply	[flat|nested] 14+ messages in thread

* RE: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
@ 2017-04-04 21:47         ` KY Srinivasan
  0 siblings, 0 replies; 14+ messages in thread
From: KY Srinivasan @ 2017-04-04 21:47 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: linux-pci, linux-kernel, devel, olaf, apw, vkuznets, jasowang,
	leann.ogasawara, marcelo.cerri, Stephen Hemminger



> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> Sent: Tuesday, April 4, 2017 1:39 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; jasowang@redhat.com;
> leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
>=20
> On Tue, Apr 04, 2017 at 07:54:33PM +0000, KY Srinivasan wrote:
> > > -----Original Message-----
> > > From: Bjorn Helgaas [mailto:helgaas@kernel.org]
> > > Sent: Tuesday, April 4, 2017 12:04 PM
> > > To: KY Srinivasan <kys@microsoft.com>
> > > Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> > > vkuznets@redhat.com; jasowang@redhat.com;
> > > leann.ogasawara@canonical.com; marcelo.cerri@canonical.com; Stephen
> > > Hemminger <sthemmin@microsoft.com>
> > > Subject: Re: [PATCH 0/2] pci-hyperv: Some miscellaneous fixes
> > >
> > > On Fri, Mar 24, 2017 at 11:06:40AM -0700, kys@exchange.microsoft.com
> > > wrote:
> > > > From: K. Y. Srinivasan <kys@microsoft.com>
> > > >
> > > > Some miscellaneous fixes.
> > > >
> > > > K. Y. Srinivasan (2):
> > > >   pci-hyperv: Fix a bug in specifying CPU affinity
> > > >   pci-hyperv: Fix an atomic bug
> > > >
> > > >  drivers/pci/host/pci-hyperv.c |   13 +++++++++----
> > > >  1 files changed, 9 insertions(+), 4 deletions(-)
> > >
> > > I applied these with Long's reviewed-by to pci/host-hv for v4.12 with=
 the
> > > following subject lines:
> > >
> > >   PCI: hv: Specify CPU_AFFINITY_ALL for MSI affinity when >=3D 32 CPU=
s
> > >   PCI: hv: Allocate interrupt descriptors with GFP_ATOMIC
> > >
> > Thank you.
> >
> > > There were two copies of [1/2], which makes this error-prone.  I appl=
ied
> > > the second one that defines CPU_AFFINITY_ALL.
> >
> > Thanks again; sorry for the confusion.
> >
> > >
> > > They're both marked for stable, but without any clue about when the
> > > problems were introduced or how serious they are, I did not queue the=
m
> for
> > > v4.11.  If you want them in v4.11, please supply those additional det=
ails.
> >
> > I think these issues have been there since   the driver got merged
> upstream.
> > I would want this to be applied against 4.11 as well. Let me know if I =
should
> resend
> > these patches.
>=20
> No need to resend, but I do need more details about what issues these fix
> and why they're more urgent than garden-variety bug fixes that are planne=
d
> for v4.12.  In general for-linus is for fixing problems we added during t=
he
> merge window, or other high-priority, low-risk changes.

For sure I want to get this into 4.12. Since it fixes issues that have been=
 there for a long time,
(including 4.11), it would be good to get it into 4.11 as well.=20

Regards,

K. Y
>=20
> Bjorn

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2017-04-04 21:47 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-24 18:06 [PATCH 0/2] pci-hyperv: Some miscellaneous fixes kys
2017-03-24 18:07 ` [PATCH 1/2] PCI: hv: Fix a bug in specifying CPU affinity kys
2017-03-24 18:07 ` [PATCH 1/2] pci-hyperv: " kys
2017-03-27 18:13   ` Long Li
2017-03-27 18:13     ` Long Li
2017-03-24 18:07 ` [PATCH 2/2] pci-hyperv: Fix an atomic bug kys
2017-03-27 18:14   ` Long Li
2017-03-27 18:14     ` Long Li
2017-04-04 19:03 ` [PATCH 0/2] pci-hyperv: Some miscellaneous fixes Bjorn Helgaas
2017-04-04 19:54   ` KY Srinivasan
2017-04-04 19:54     ` KY Srinivasan
2017-04-04 20:39     ` Bjorn Helgaas
2017-04-04 21:47       ` KY Srinivasan
2017-04-04 21:47         ` KY Srinivasan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.