From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92AC2C61DA4 for ; Thu, 2 Feb 2023 14:10:13 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C937542D3A; Thu, 2 Feb 2023 15:10:12 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id CEDE042D20 for ; Thu, 2 Feb 2023 15:10:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675347011; x=1706883011; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UeQNV49n/lKHVOedN+tXBA7XEAlc0Mse1/03fvCyBm0=; b=l0K3pRYGoPxIaonvpSgSZ9LlqkcwxYYA5Loo7+yK0hD39LKV9kGAS8GB 6aJu70nu5CVHJB3BB3wPoVJy7fK2sUTlXs5czrZkEx3aEVWdUdz8jk2Kb gLZ2WUr72UmU8TiLteuvfYTFrnqp0lD+Ja6sdmBR7pre3NTCmVGdyHSZP /xQfgWmbOvzPM4olvD9SpTOv3mzWEG926JGQRIAmu6v1FSS8CJ8NOw8MZ rXhjynC7s/D15LbUBjFlAaLyUSJ1CH+mfJIczdqDtQJkuX6/GqPO07+Ua j/Gd+bnNyqblabYdZsHNLXOP5z4vHb0+C7HZ/fCky8sM13kfvzReQMmLh g==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="355794030" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="355794030" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2023 06:10:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="733949537" X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; d="scan'208";a="733949537" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 02 Feb 2023 06:10:09 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 06:10:09 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 2 Feb 2023 06:10:08 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 2 Feb 2023 06:10:08 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Feb 2023 06:10:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQbBB1osfhgS9L5f4pz3oOduPoBN/aay89Ac/ASemj332EO1KxdJ63UWS/OGN3wcldsHoLsdjDvTB0d0AKjAZv2ldYkaLtUhmLQxV8uhnGUYP1w+aO/9HLJX+PBACln/RFBSODeaT3PGKcxLzYoYpqe8mVp4sJDSX+XUyezajQXEXRo1CI1VvN1qJq3kMKsrW3kXTN/EKSSki3VaPeQO0MpAjgjqAYtBYVx1SVivIrS6fWwHMz/ZH5YZ4TE5UUkgovmAXoqn3AYuKt4l9zGemOyVd0/vv1BpcVMChuk+yQxD4AI4Hc1wvfp6divtbvm/hG9NA8kv00x/BldrdjnQEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FF/oCjJcMVtodbFb6x1KAD7ZdRkQom/AEB2oQYgSjTM=; b=VXabUsyiF1pwLrVWf8D0r19ePD5VwMyrJfKv5Y/zy+vaPeEoTonyujG/IGULZXQ6u5dmKE0Hsn4n+DuCBzcnFyLH1YTIa1GpN6vNc1tRcYPpNliMaW87+5Gi/muzhjsgpUXkJXNuEuSzStwIGfWJ+ZcNclCYLveSLW+708TZV90aV52fd4Cg/B8T1qZofADbq6/zrbtx3BuMSosooGVRJEAFidyfxp/LB67KecYlaxuSeqI5UUslAkqzd7kA+8qmiEm6d1gR6/l46HB0Z+YGDBpeLPiKXWmTpBWEbMTsjLy6plHkPHlxvDST1+9qcU4xP46cb6tfJoMHoPj28A5Myw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM5PR11MB1851.namprd11.prod.outlook.com (2603:10b6:3:114::18) by PH8PR11MB7991.namprd11.prod.outlook.com (2603:10b6:510:25a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Thu, 2 Feb 2023 14:10:06 +0000 Received: from DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::c6d0:207:1a4e:756c]) by DM5PR11MB1851.namprd11.prod.outlook.com ([fe80::c6d0:207:1a4e:756c%8]) with mapi id 15.20.6064.024; Thu, 2 Feb 2023 14:10:05 +0000 From: "Dooley, Brian" To: "Power, Ciara" , "Ji, Kai" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" , "Power, Ciara" Subject: RE: [PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length Thread-Topic: [PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length Thread-Index: AQHZNZiwI5jTwB0+UU6ESm4EZ6GF5667tGNQ Date: Thu, 2 Feb 2023 14:10:05 +0000 Message-ID: References: <20230131172027.524502-1-ciara.power@intel.com> In-Reply-To: <20230131172027.524502-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM5PR11MB1851:EE_|PH8PR11MB7991:EE_ x-ms-office365-filtering-correlation-id: 2c9c2633-24b2-462c-55d2-08db05272f31 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ACdqQbw3nwVi00Rok02Aqv0/6BKeNhbfhA1NgXeeM+lzTNR+NwoRhO+bcQfa3bLnWmFCB2XX2H7ju5uqckK88iADzsKT4CaCyQ9UT0DrxI0IHuuiZO616uuGYobrOuBGUalKjnvGhVPPU3L8BLF4Ddm386h1v28chHjgeLLoF/rRWrUYVAT5yw+JAt9qJlToNV323QUtCJzYdMVSwlb+IkfWTFmRX+XrxDJMCj0TlrirsSH4U7wDzSVxUfWEtMz4poIUakKeWHPkzw8+Aae6nt52Tv687y8y6Ny8lZFwC4lxpzyndUYhsGBHRx/zWABU/PdwRfXMMHucOjgx3Z9hR4hQg0+kL9wBhwJmOR8J0Ste1nU6Njq6r08JKl6QR8O1nMkLfh6PKCwkRh70yj+fhRDKTo/EgXH36swBGSrwFGIKWLUANpbriEDAHU0uyiDG1/WMLTi6oCpDymfoRk7BGLpDo1u6EdcwhvSchiak5fuWxeA8dqjy4WmmGxgHWmkng1BdZe0quEDjN3BL6sV6pAubQTuMPzkbq+tqu/i3yQODwanBDSGfXXXybsulDPlDOby8qJinmiq4vweDqzv6ZnZaXMTG0jKXTDgs3+ToFZCWnfMYeJGQTC5mjx0D3I+iQh91oEN+E3G58aAs/2fwkgA+YXXFbxc5MpNgcnvybOabNqsGQ6HIoPjJVd52CPh8wmEohZlJIJKVN5YUXoWccQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR11MB1851.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(376002)(346002)(396003)(39860400002)(366004)(451199018)(76116006)(122000001)(38100700002)(316002)(64756008)(110136005)(33656002)(54906003)(6636002)(82960400001)(66556008)(83380400001)(66946007)(38070700005)(41300700001)(66476007)(55016003)(5660300002)(53546011)(52536014)(26005)(107886003)(8936002)(86362001)(186003)(2906002)(66446008)(9686003)(8676002)(71200400001)(7696005)(4326008)(6506007)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IeqGOU9SzZbzuy0iqXVxkSwhpeemSMx9R9VRFFR7UGxZHC22dVKbtYjxnZUY?= =?us-ascii?Q?OHJqX7eFYvhln9j63cyB1c9T0VIdt3z+laSSWmBAYiMJhCzP+Cgc4nlfQE6T?= =?us-ascii?Q?5/FFkCnlDQ23VkD6V+fdJnkRUkz3hRlnGFvhBFBviYpDdHR0K9a1JMUlQmX6?= =?us-ascii?Q?oCMWm6YhDp73/7fbUNv3irVfyNx7CoBOLfqVPmDKsaZjiYRiYrERmEYjdAbj?= =?us-ascii?Q?G97sK8lPHdmoXqVNOluKFuk5gDQcwESlY76Qk0j73DhN5G35Y5ePbPIIB9jz?= =?us-ascii?Q?XtIC9gS+5IvhOuI+O9UBa1P0TA9LUYPW8svKnOs6q7qdqxFLXVzsIgqlm24P?= =?us-ascii?Q?dlBs/79b/1vfo68c2Rn2uGBxCRtZ1gvUsZyd8v1I9UIKjVNGni03tToy9Xju?= =?us-ascii?Q?Pb87aoQMIhJT29Z80tfhGn5zBmCJdb4qLFX9YbDDd/0Q/ALIwwblO3FvswAy?= =?us-ascii?Q?2ci/vkFmZkU2fbLHJuY0vjfwTskMyYN4ztgVyvk3jW98qecjfG2Vgbf6C8vN?= =?us-ascii?Q?dNJtIBedx+pSmzNvMkFCql8N7Mr0d8nN8l4lphN+4ffE5sH2ja4R4DFMI9T9?= =?us-ascii?Q?JfMowY1i4O8bqtkUPMIIJ/0B0VTdAyxL6blE94jAKPpycw1F2jO5rnv5qw7P?= =?us-ascii?Q?nX0lLVlxG6TPb7zIMCh9LVn8Mz/IbRowBqRw9u6NvU4t8nihC0rgQQI6LmQM?= =?us-ascii?Q?9wb1L6a5f32JN42VkVAyb440EloSkU7rCvnJcAcXkENaUP1H6GCksXEU1Au5?= =?us-ascii?Q?7jgHvhPMrzkseCso/w27rXNw+J9XimM4NCSNH2HLzZMhaSh1ONDp5Guvm6cR?= =?us-ascii?Q?8NuKae/gKRV/Yw9oPNnelLFnDnMIjxjB4GeJQieYKvjY0X6EOnrkxW4LKduX?= =?us-ascii?Q?1CvSWk+USyzZX7V1wzO/5cfjOn8CfogqiHiaeeCgxu7rxhSHWWtICa29KPAm?= =?us-ascii?Q?9jqNC9663L/VLXplVMNiP0RMvycoszsNKdfYst2zMUxXXO2qXOnHYlY14Ixo?= =?us-ascii?Q?w5ezn31d9xB7lqOeNwt/fOzM/d1KIjeXa+iT7xWDj4O3IPsx2MsJV13iO5Z9?= =?us-ascii?Q?tTKJPiRX61HVO95KeDUa7VIAz57zvWh1wXn+9b7xJlrs5HZYBANeaSxfKqy8?= =?us-ascii?Q?GReMCTSzT/RDD/RZuDHcza9aXnJP6QcvjCfoVfuPKQOL14/8oFMlTexhxN/6?= =?us-ascii?Q?us4JwKq5RFI/3YkaU9ZYyIpj0KZpZK3fCmaUAZ1A7/ha3At8DkaCOWd9LVN/?= =?us-ascii?Q?AR/pPFIvVe0qX5I2wZmm1lgMc8tAzNlKseJba1l088dE+2E3+tMYXTIW7M6Q?= =?us-ascii?Q?NGsESyt0HdwdA6a7ph9B8q2rg0pJTkBEFaZI+m5EC36cyDmqEKw7Q3X/NMc2?= =?us-ascii?Q?bh5lEVwrFvazDAOJWXaA0861anoGML/upN4cWDX0Ee2CT6dgvbWwDfJXdi56?= =?us-ascii?Q?Nbxz95hQPtwNLYbMeKKySKoIWiYudW7sxvtfkH3NhI+GvnL/H3P7N7W28RJi?= =?us-ascii?Q?9U7RLtETTzb9aOygO8Nxija10WdzlOnPfIupzqtKfrTp/elXgaHgW5vDLrc/?= =?us-ascii?Q?gGqyi5GgNdSEfD/00mqyhnUFWAX1y7ZdTpxDVFBd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1851.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c9c2633-24b2-462c-55d2-08db05272f31 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 14:10:05.6058 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iOMLLlABYDCDTFLZhLfC4xvjcApaQkgbtdFRVpGAzHKrpNIYgbbY94v+crJKYDL+OS1f7CXvpH5CxxNsZfdFWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7991 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ciara, > -----Original Message----- > From: Ciara Power > Sent: Tuesday 31 January 2023 17:20 > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Power, Ciara > Subject: [PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length >=20 > The AESNI_MB PMD supports 8 and 16 byte tag lengths for ZUC256 when > intel-ipsec-mb version is 1.3 or newer. > The conditional check to enable these tag lengths had the incorrect opera= tor, > which enabled 8 and 16 byte tag lengths for versions below 1.2, which is = not > supported. >=20 > Fixes: 7babda4316f9 ("crypto/ipsec_mb: support all tag sizes for ZUC-EIA3= - > 256") > Cc: pablo.de.lara.guarch@intel.com >=20 > Signed-off-by: Ciara Power > --- > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 2 +- > drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > index 147a38932d..ac20d01937 100644 > --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > @@ -199,7 +199,7 @@ aesni_mb_set_session_auth_parameters(const > IMB_MGR *mb_mgr, > } > } else if (xform->auth.key.length =3D=3D 32) { > sess->auth.algo =3D IMB_AUTH_ZUC256_EIA3_BITLEN; > -#if IMB_VERSION(1, 2, 0) > IMB_VERSION_NUM > +#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM > if (sess->auth.req_digest_len !=3D 4 && > sess->auth.req_digest_len !=3D 8 && > sess->auth.req_digest_len !=3D 16) { > diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h > b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h > index 55fafbbbec..8a7c74f621 100644 > --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h > +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h > @@ -566,7 +566,7 @@ static const struct rte_cryptodev_capabilities > aesni_mb_capabilities[] =3D { > }, > .digest_size =3D { > .min =3D 4, > -#if IMB_VERSION(1, 2, 0) > IMB_VERSION_NUM > +#if IMB_VERSION(1, 2, 0) < IMB_VERSION_NUM > .max =3D 16, > .increment =3D 4 > #else > -- > 2.25.1 Reviewed-by: Brian Dooley