All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Hongzhan" <hongzhan.chen@intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	"xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: RE: [PATCH 1/3] rtdm/testing: latmus: introduce latmus driver
Date: Thu, 15 Apr 2021 00:56:52 +0000	[thread overview]
Message-ID: <DM5PR11MB18523829A1B3B550CACC4DEFF24D9@DM5PR11MB1852.namprd11.prod.outlook.com> (raw)
In-Reply-To: <18d563d0-53d7-b7a0-9b0c-f328afef2513@siemens.com>

>
>
>-----Original Message-----
>From: Jan Kiszka <jan.kiszka@siemens.com> 
>Sent: Wednesday, April 14, 2021 5:08 PM
>To: Chen, Hongzhan <hongzhan.chen@intel.com>; xenomai@xenomai.org
>Subject: Re: [PATCH 1/3] rtdm/testing: latmus: introduce latmus driver
>
>Missing commit message in this patch, and in patch 3.
>
>Also, could you provide cover letters with your patch series (for series
>> 1 patch)? That letter would provide a chance to set the context,
>explain potential dependencies.

OK. Thanks for your suggestions.

>
>Does this series already work over next? Or does it have dependencies on
>the dovetail patches?

Yes, I have validated it based on https://lab.xenomai.org/xenomai-rpm.git/log/?h=for-upstream/dovetail
with Rock PI X and FRDM boards. Even though still can not get correct gpio latency because of hardware
 issue that GPIO voltage (1.8 V <> 3.3 V) mismatch between RockPIX and FRDM K64F boards , basic function
works.   It depends on dovetail because it port from evl.

>
>Given that some hardware setup will be needed, a patch adding
>documentation would be useful. What does the user have to do to be able
>to use the benchmark?

Yes, you are right. It also took me long time to setup hardware environment and understand to use it.

>
>Thanks,
>Jan
>
>On 14.04.21 04:16, hongzha1 via Xenomai wrote:
>> Signed-off-by: hongzha1 <hongzhan.chen@intel.com>
>> 
>> diff --git a/include/rtdm/uapi/testing.h b/include/rtdm/uapi/testing.h

  reply	other threads:[~2021-04-15  0:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14  2:16 [PATCH 1/3] rtdm/testing: latmus: introduce latmus driver hongzha1
2021-04-14  2:16 ` [PATCH 2/3] drivers/gpio: core: introduce helper to find gpiochip hongzha1
2021-04-14  2:16 ` [PATCH 3/3] testsuite/latmus: introduce latmus benchmark hongzha1
2021-04-14  9:08 ` [PATCH 1/3] rtdm/testing: latmus: introduce latmus driver Jan Kiszka
2021-04-15  0:56   ` Chen, Hongzhan [this message]
2021-04-15  7:47   ` Philippe Gerum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR11MB18523829A1B3B550CACC4DEFF24D9@DM5PR11MB1852.namprd11.prod.outlook.com \
    --to=hongzhan.chen@intel.com \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.