All of lore.kernel.org
 help / color / mirror / Atom feed
From: khairul.rohaizzat.jamaluddin@intel.com
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] wic/bootimg-efi: Added feature to exclude IMAGE_BOOT_FILES
Date: Tue, 25 Aug 2020 01:15:14 +0000	[thread overview]
Message-ID: <DM5PR11MB1993D79AF7B255CDA55D145BDE570@DM5PR11MB1993.namprd11.prod.outlook.com> (raw)
In-Reply-To: <18639869486242f56549d4cdf82f1b1439c6cc1f.camel@linuxfoundation.org>

I suppose either way is fine, as long as the issue could be resolved.

And I agree, adding a new variable in the local.conf would give more flexibility in the built image than the method I applied.
It’s a better solution.


Thank you & Kind regards,
Khairul

-----Original Message-----
From: Richard Purdie <richard.purdie@linuxfoundation.org> 
Sent: Tuesday, August 25, 2020 6:26 AM
To: Jamaluddin, Khairul Rohaizzat <khairul.rohaizzat.jamaluddin@intel.com>; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] wic/bootimg-efi: Added feature to exclude IMAGE_BOOT_FILES

On Mon, 2020-08-24 at 14:39 +0800, khairul.rohaizzat.jamaluddin@intel.com wrote:
> From: Khairul Rohaizzat Jamaluddin 
> <khairul.rohaizzat.jamaluddin@intel.com>
> 
> Due to recent changes in bootimg-efi to include IMAGE_BOOT_FILES, when 
> both bootimg-partition and bootimg-efi occur in a single .wks and 
> IMAGE_BOOT_FILES are defined, files listed in IMAGE_BOOT_FILES will be 
> duplicated in both partition.
> Since IMAGE_BOOT_FILES are crucial for bootimg-partition, but optional 
> for bootimg-efi, hence allow bootimg-efi to have the option to ignore 
> it.
> 
> The new variable, excludeibf, in bootimg-efi.py need to be set in the 
> .wks file to make use of this feature. Simply remove the variable from 
> the the .wks file if not needed.
> Example:
>     part /boot --source bootimg-efi --sourceparams="loader=systemd-boot,
>     excludeibf=y" --ondisk sda --label msdos --active --align 1024 
> --use-uuid
> 
> [YOCTO #14011]
> 
> Signed-off-by: Khairul Rohaizzat Jamaluddin 
> <khairul.rohaizzat.jamaluddin@intel.com>
> ---
>  scripts/lib/wic/plugins/source/bootimg-efi.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

I'm torn between this and instead changing efi to use IMAGE_EFI_BOOT_FILES instead. Changing the variable would mean more flexibility in how the image is constructed...

Cheers,

Richard


      reply	other threads:[~2020-08-25  1:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  6:39 [PATCH] wic/bootimg-efi: Added feature to exclude IMAGE_BOOT_FILES khairul.rohaizzat.jamaluddin
2020-08-24 22:26 ` [OE-core] " Richard Purdie
2020-08-25  1:15   ` khairul.rohaizzat.jamaluddin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR11MB1993D79AF7B255CDA55D145BDE570@DM5PR11MB1993.namprd11.prod.outlook.com \
    --to=khairul.rohaizzat.jamaluddin@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.