RE: [PATCH 2/7] drm/amdgpu/virtual_dce: no need to an irq process callback

["Deng, Emily" <Emily.Deng-5C7GfCeVMHo@public.gmane.org>]

Reviewed-By: Emily Deng <Emily.Deng@amd.com>

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Alex Deucher
> Sent: Saturday, October 01, 2016 1:09 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
> Subject: [PATCH 2/7] drm/amdgpu/virtual_dce: no need to an irq process
> callback
> 
> Virtual crtcs interrupts do not show up in the IV ring, so it will never be called.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> index cf43caa..8163622 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> @@ -710,21 +710,6 @@ static int dce_virtual_set_crtc_irq_state(struct
> amdgpu_device *adev,
>  	return 0;
>  }
> 
> -static int dce_virtual_crtc_irq(struct amdgpu_device *adev,
> -			      struct amdgpu_irq_src *source,
> -			      struct amdgpu_iv_entry *entry)
> -{
> -	unsigned crtc = 0;
> -	unsigned irq_type = AMDGPU_CRTC_IRQ_VBLANK1;
> -
> -	if (amdgpu_irq_enabled(adev, source, irq_type)) {
> -		drm_handle_vblank(adev->ddev, crtc);
> -	}
> -	dce_virtual_pageflip_irq(adev, NULL, NULL);
> -	DRM_DEBUG("IH: D%d vblank\n", crtc + 1);
> -	return 0;
> -}
> -
>  static int dce_virtual_pageflip_irq(struct amdgpu_device *adev,
>  				  struct amdgpu_irq_src *source,
>  				  struct amdgpu_iv_entry *entry)
> @@ -775,7 +760,7 @@ static int dce_virtual_pageflip_irq(struct
> amdgpu_device *adev,
> 
>  static const struct amdgpu_irq_src_funcs dce_virtual_crtc_irq_funcs = {
>  	.set = dce_virtual_set_crtc_irq_state,
> -	.process = dce_virtual_crtc_irq,
> +	.process = NULL,
>  };
> 
>  static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)
> --
> 2.5.5
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx