All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] Revert "x86/mce/AMD: Collect error info even if valid bits are not set"
@ 2018-03-26 19:15 ` Yazen Ghannam
  0 siblings, 0 replies; 29+ messages in thread
From: Yazen Ghannam @ 2018-03-26 19:15 UTC (permalink / raw)
  To: linux-edac; +Cc: Yazen Ghannam, linux-kernel, bp, tony.luck, x86

From: Yazen Ghannam <yazen.ghannam@amd.com>

This reverts commit 4b1e84276a6172980c5bf39aa091ba13e90d6dad.

Software uses the valid bits to decide if the values can be used for
further processing or other actions. So setting the valid bits will have
software act on values that it shouldn't be acting on.

The recommendation to save all the register values does not mean that
the values are always valid.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
 arch/x86/kernel/cpu/mcheck/mce.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 86079b90ebcf..42cf2880d0ed 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -446,20 +446,6 @@ static inline void mce_gather_info(struct mce *m, struct pt_regs *regs)
 		if (mca_cfg.rip_msr)
 			m->ip = mce_rdmsrl(mca_cfg.rip_msr);
 	}
-
-	/*
-	 * Error handlers should save the values in MCA_ADDR, MCA_MISC0, and
-	 * MCA_SYND even if MCA_STATUS[AddrV], MCA_STATUS[MiscV], and
-	 * MCA_STATUS[SyndV] are zero.
-	 */
-	if (m->cpuvendor == X86_VENDOR_AMD) {
-		u64 status = MCI_STATUS_ADDRV | MCI_STATUS_MISCV;
-
-		if (mce_flags.smca)
-			status |= MCI_STATUS_SYNDV;
-
-		m->status |= status;
-	}
 }
 
 int mce_available(struct cpuinfo_x86 *c)
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2018-08-23 17:53 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-26 19:15 [PATCH 1/2] Revert "x86/mce/AMD: Collect error info even if valid bits are not set" Yazen Ghannam
2018-03-26 19:15 ` [1/2] " Yazen Ghannam
2018-03-26 19:15 ` [PATCH 2/2] x86/MCE: Always save MCA_{ADDR,MISC,SYND} register contents Yazen Ghannam
2018-03-26 19:15   ` [2/2] " Yazen Ghannam
2018-03-26 19:35   ` [PATCH 2/2] " Borislav Petkov
2018-03-26 19:35     ` [2/2] " Borislav Petkov
2018-03-26 20:05     ` [PATCH 2/2] " Ghannam, Yazen
2018-03-26 20:05       ` [2/2] " Yazen Ghannam
2018-03-26 20:09       ` [PATCH 2/2] " Borislav Petkov
2018-03-26 20:09         ` [2/2] " Borislav Petkov
2018-03-26 20:27         ` [PATCH 2/2] " Luck, Tony
2018-03-26 20:27           ` [2/2] " Luck, Tony
2018-03-27 14:07           ` [PATCH 2/2] " Ghannam, Yazen
2018-03-27 14:07             ` [2/2] " Yazen Ghannam
2018-03-26 19:30 ` [PATCH 1/2] Revert "x86/mce/AMD: Collect error info even if valid bits are not set" Borislav Petkov
2018-03-26 19:30   ` [1/2] " Borislav Petkov
2018-03-26 19:58   ` [PATCH 1/2] " Ghannam, Yazen
2018-03-26 19:58     ` [1/2] " Yazen Ghannam
2018-03-26 20:07     ` [PATCH 1/2] " Borislav Petkov
2018-03-26 20:07       ` [1/2] " Borislav Petkov
2018-03-27 14:02       ` [PATCH 1/2] " Ghannam, Yazen
2018-03-27 14:02         ` [1/2] " Yazen Ghannam
2018-03-27 15:59         ` [PATCH 1/2] " Ghannam, Yazen
2018-03-27 15:59           ` [1/2] " Yazen Ghannam
2018-08-23 12:24           ` [PATCH 1/2] " Borislav Petkov
2018-08-23 12:24             ` [1/2] " Borislav Petkov
2018-08-23 17:53             ` [PATCH 1/2] " Ghannam, Yazen
2018-08-23 17:53               ` [1/2] " Yazen Ghannam
2018-03-28 18:39 ` [tip:ras/core] " tip-bot for Yazen Ghannam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.