From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yin, Tianci (Rico)" Subject: Re: [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revision Date: Wed, 16 Oct 2019 02:24:40 +0000 Message-ID: References: <20191014032118.14020-1-tianci.yin@amd.com>, Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1017752991==" Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Tuikov, Luben" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" Cc: "Deucher, Alexander" , "Koenig, Christian" --===============1017752991== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM5PR12MB25351094FEEF76BE2325FB1895920DM5PR12MB2535namp_" --_000_DM5PR12MB25351094FEEF76BE2325FB1895920DM5PR12MB2535namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Luben! Patch 8 v2 has sent out, please review again. ________________________________ From: Tuikov, Luben Sent: Wednesday, October 16, 2019 2:01 To: Yin, Tianci (Rico) ; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org = Cc: Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to handle revi= sion Patches 1-7: Looks good. Reviewed-by: Luben Tuikov Patch 8: NAK! for the same exact reason as the previous review. No changes = to NAK reasoning from previous review. Regards, Luben On 2019-10-13 11:21 p.m., Tianci Yin wrote: > From: "Tianci.Yin" > > update amdgpu_discovery to get IP revision. > > Change-Id: If8152103d03b58e1dc0f32db63625e290f5f08a0 > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +++- > drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/= drm/amd/amdgpu/amdgpu_discovery.c > index 71198c5318e1..ddd8364102a2 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > @@ -333,7 +333,7 @@ int amdgpu_discovery_reg_base_init(struct amdgpu_devi= ce *adev) > } > > int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_i= d, > - int *major, int *minor) > + int *major, int *minor, int *revision) > { > struct binary_header *bhdr; > struct ip_discovery_header *ihdr; > @@ -369,6 +369,8 @@ int amdgpu_discovery_get_ip_version(struct amdgpu_dev= ice *adev, int hw_id, > *major =3D ip->major; > if (minor) > *minor =3D ip->minor; > + if (revision) > + *revision =3D ip->revision; > return 0; > } > ip_offset +=3D sizeof(*ip) + 4 * (ip->num_base_add= ress - 1); > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h b/drivers/gpu/= drm/amd/amdgpu/amdgpu_discovery.h > index 5a6693d7d269..ba78e15d9b05 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h > @@ -30,7 +30,7 @@ int amdgpu_discovery_init(struct amdgpu_device *adev); > void amdgpu_discovery_fini(struct amdgpu_device *adev); > int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev); > int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, int hw_i= d, > - int *major, int *minor); > + int *major, int *minor, int *revisio= n); > int amdgpu_discovery_get_gfx_info(struct amdgpu_device *adev); > > #endif /* __AMDGPU_DISCOVERY__ */ > --_000_DM5PR12MB25351094FEEF76BE2325FB1895920DM5PR12MB2535namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Thanks Luben!
Patch 8 v2 has sent out, please review again.
From: Tuikov, Luben <Lub= en.Tuikov-5C7GfCeVMHo@public.gmane.org>
Sent: Wednesday, October 16, 2019 2:01
To: Yin, Tianci (Rico) <Tianci.Yin-5C7GfCeVMHo@public.gmane.org>; amd-gfx-PD4FTy7X32mzQB+pC5nmwQ@public.gmane.org= edesktop.org <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: Deucher, Alexander <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>; Koenig, Ch= ristian <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 1/8] drm/amdgpu: update amdgpu_discovery to hand= le revision
 
Patches 1-7: Looks good.
Reviewed-by: Luben Tuikov <luben.tuikov-5C7GfCeVMHo@public.gmane.org>

Patch 8: NAK! for the same exact reason as the previous review. No changes = to NAK reasoning from previous review.

Regards,
Luben

On 2019-10-13 11:21 p.m., Tianci Yin wrote:
> From: "Tianci.Yin" <tianci.yin-5C7GfCeVMHo@public.gmane.org>
>
> update amdgpu_discovery to get IP revision.
>
> Change-Id: If8152103d03b58e1dc0f32db63625e290f5f08a0
> Reviewed-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
> Signed-off-by: Tianci.Yin <tianci.yin-5C7GfCeVMHo@public.gmane.org>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 +++= ;-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h | 2 +-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/g= pu/drm/amd/amdgpu/amdgpu_discovery.c
> index 71198c5318e1..ddd8364102a2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -333,7 +333,7 @@ int amdgpu_discovery_reg_base_init(struct amdg= pu_device *adev)
>  }
> 
>  int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, = int hw_id,
> -           &nb= sp;            =          int *major, int *minor) > +           = ;            &n= bsp;         int *major, int *minor= , int *revision)
>  {
>        struct binary_header *bhdr;<= br> >        struct ip_discovery_header *= ihdr;
> @@ -369,6 +369,8 @@ int amdgpu_discovery_get_ip_version(struct amd= gpu_device *adev, int hw_id,
>            = ;            &n= bsp;            = ;   *major =3D ip->major;
>            = ;            &n= bsp;       if (minor)
>            = ;            &n= bsp;            = ;   *minor =3D ip->minor;
> +           = ;            &n= bsp;     if (revision)
> +           = ;            &n= bsp;            = ; *revision =3D ip->revision;
>            = ;            &n= bsp;       return 0;
>            = ;            }
>            = ;            ip_offs= et +=3D sizeof(*ip) + 4 * (ip->num_base_address - 1);
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h b/drivers/g= pu/drm/amd/amdgpu/amdgpu_discovery.h
> index 5a6693d7d269..ba78e15d9b05 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.h
> @@ -30,7 +30,7 @@ int amdgpu_discovery_init(struct amdgpu_device *= adev);
>  void amdgpu_discovery_fini(struct amdgpu_device *adev);
>  int amdgpu_discovery_reg_base_init(struct amdgpu_device *adev);<= br> >  int amdgpu_discovery_get_ip_version(struct amdgpu_device *adev, = int hw_id,
> -           &nb= sp;            =             int *maj= or, int *minor);
> +           = ;            &n= bsp;            int = *major, int *minor, int *revision);
>  int amdgpu_discovery_get_gfx_info(struct amdgpu_device *adev); > 
>  #endif /* __AMDGPU_DISCOVERY__ */
>

--_000_DM5PR12MB25351094FEEF76BE2325FB1895920DM5PR12MB2535namp_-- --===============1017752991== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 --===============1017752991==--