All of
 help / color / mirror / Atom feed
From: "Kim, Jonathan" <>
To: "Yang, Philip" <>,
	"Sierra Guiza, Alejandro (Alex)" <>,
	"" <>
Subject: RE: [PATCH] drm/amdkfd: drop process ref count when xnack disable
Date: Wed, 1 Sep 2021 13:45:50 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]

[AMD Official Use Only]

We were seeing process leaks on a couple of machines running certain tests that triggered vm faults on purpose.
I think svm_range_restore_pages gets called unconditionally on vm fault handling (unless the retry interrupt payload bit is supposed to be clear with xnack off)?

Either way, this patch prevents the process leaks we seeing and is also:
Reviewed-by: Jonathan Kim <>



From: amd-gfx <> On Behalf Of philip yang
Sent: Wednesday, September 1, 2021 7:30 AM
To: Sierra Guiza, Alejandro (Alex) <>;
Subject: Re: [PATCH] drm/amdkfd: drop process ref count when xnack disable

[CAUTION: External Email]

On 2021-08-31 10:41 p.m., Alex Sierra wrote:

During svm restore pages interrupt handler, kfd_process ref count was

never dropped when xnack was disabled. Therefore, the object was never


Good catch, but if xnack is off, we should not get here to recover fault.

The fix looks good to me.

Reviewed-by: Philip Yang <><>

Signed-off-by: Alex Sierra <><>


 drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 3 ++-

 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c

index 8f9b5b53dab5..110c46cd7fac 100644

--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c

+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c

@@ -2484,7 +2484,8 @@ svm_range_restore_pages(struct amdgpu_device *adev, unsigned int pasid,


         if (!p->xnack_enabled) {

                pr_debug("XNACK not enabled for pasid 0x%x\n", pasid);

-               return -EFAULT;

+               r = -EFAULT;

+               goto out;


         svms = &p->svms;

[-- Attachment #2: Type: text/html, Size: 6116 bytes --]

  reply	other threads:[~2021-09-01 13:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01  2:41 [PATCH] drm/amdkfd: drop process ref count when xnack disable Alex Sierra
2021-09-01 11:29 ` philip yang
2021-09-01 13:45   ` Kim, Jonathan [this message]
2021-09-01 16:29     ` philip yang
2021-09-01 16:59       ` Kim, Jonathan
2021-09-01 17:54         ` Felix Kuehling
2021-09-01 19:43           ` Felix Kuehling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.