From: Tom Talpey <ttalpey-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
To: Ronnie Sahlberg
<lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-cifs <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: RE: [PATCH 1/2] cifs: remove rfc1002 header from all SMB2 response structures
Date: Wed, 3 Jan 2018 18:26:52 +0000 [thread overview]
Message-ID: <DM5PR2101MB0886F4E951689CB179F9215FA01E0@DM5PR2101MB0886.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20180102223524.8389-2-lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> -----Original Message-----
> From: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-cifs-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Ronnie Sahlberg
> Sent: Tuesday, January 2, 2018 5:35 PM
> To: linux-cifs <linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
> Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Subject: [PATCH 1/2] cifs: remove rfc1002 header from all SMB2 response
> structures
>
> Separate out all the 4 byte rfc1002 headers so that they are no longer
> part of the SMB2 header structures to prepare for future work to add
> compounding support.
>
> When using compounding, the wire format will consist of a single
> rfc1002 length header followed by one, or more, SMB2 headers, like this :
>
> * 4 byte rfc1002 length
> * SMB2 header
> * SMB2 header
> * ...
Comment purely on the changelog.
This second paragraph is somewhat misleading, and should perhaps be omitted.
The RFC1002 length is a transport frame marker, and used only on stream-based
transports such as TCP. For example, it's not present when the transport is
SMB Direct. There is no protocol dependency on its use by Compounding.
Tom.
next prev parent reply other threads:[~2018-01-03 18:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 22:35 [PATCH 0/2] Remove rfc1002 headers from SMB2 responses Ronnie Sahlberg
[not found] ` <20180102223524.8389-1-lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-02 22:35 ` [PATCH 1/2] cifs: remove rfc1002 header from all SMB2 response structures Ronnie Sahlberg
[not found] ` <20180102223524.8389-2-lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-03 18:26 ` Tom Talpey [this message]
2018-01-11 2:41 ` Long Li
2018-01-02 22:35 ` [PATCH 2/2] cifs: update multiplex loop to handle compounded responses Ronnie Sahlberg
2018-01-02 22:43 ` [PATCH 0/2] Remove rfc1002 headers from SMB2 responses ronnie sahlberg
2018-01-21 22:06 [PATCH 0/2] cifs: remove rfc1002 length field from all SMB2 response structures Ronnie Sahlberg
[not found] ` <20180121220644.7907-1-lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-21 22:06 ` [PATCH 1/2] cifs: remove rfc1002 header " Ronnie Sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR2101MB0886F4E951689CB179F9215FA01E0@DM5PR2101MB0886.namprd21.prod.outlook.com \
--to=ttalpey-0li6otcxbfhby3ivrkzq2a@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lsahlber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.