* [PATCH] uapi: fix asm/bootparam.h userspace compilation errors
@ 2018-04-05 4:32 Dmitry V. Levin
2018-04-05 7:25 ` Jan Kiszka
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Dmitry V. Levin @ 2018-04-05 4:32 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Thomas Gleixner, x86, linux-kernel
Consistently use types provided by <linux/types.h> to fix the following
asm/bootparam.h userspace compilation errors:
/usr/include/asm/bootparam.h:140:2: error: unknown type name 'u16'
u16 version;
/usr/include/asm/bootparam.h:141:2: error: unknown type name 'u16'
u16 compatible_version;
/usr/include/asm/bootparam.h:142:2: error: unknown type name 'u16'
u16 pm_timer_address;
/usr/include/asm/bootparam.h:143:2: error: unknown type name 'u16'
u16 num_cpus;
/usr/include/asm/bootparam.h:144:2: error: unknown type name 'u64'
u64 pci_mmconfig_base;
/usr/include/asm/bootparam.h:145:2: error: unknown type name 'u32'
u32 tsc_khz;
/usr/include/asm/bootparam.h:146:2: error: unknown type name 'u32'
u32 apic_khz;
/usr/include/asm/bootparam.h:147:2: error: unknown type name 'u8'
u8 standard_ioapic;
/usr/include/asm/bootparam.h:148:2: error: unknown type name 'u8'
u8 cpu_ids[255];
Fixes: 4a362601baa6 ("x86/jailhouse: Add infrastructure for running in non-root cell")
Cc: <stable@vger.kernel.org> # v4.16
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
arch/x86/include/uapi/asm/bootparam.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h
index aebf60357758..a06cbf019744 100644
--- a/arch/x86/include/uapi/asm/bootparam.h
+++ b/arch/x86/include/uapi/asm/bootparam.h
@@ -137,15 +137,15 @@ struct boot_e820_entry {
* setup data structure.
*/
struct jailhouse_setup_data {
- u16 version;
- u16 compatible_version;
- u16 pm_timer_address;
- u16 num_cpus;
- u64 pci_mmconfig_base;
- u32 tsc_khz;
- u32 apic_khz;
- u8 standard_ioapic;
- u8 cpu_ids[255];
+ __u16 version;
+ __u16 compatible_version;
+ __u16 pm_timer_address;
+ __u16 num_cpus;
+ __u64 pci_mmconfig_base;
+ __u32 tsc_khz;
+ __u32 apic_khz;
+ __u8 standard_ioapic;
+ __u8 cpu_ids[255];
} __attribute__((packed));
/* The so-called "zeropage" */
--
ldv
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] uapi: fix asm/bootparam.h userspace compilation errors
2018-04-05 4:32 [PATCH] uapi: fix asm/bootparam.h userspace compilation errors Dmitry V. Levin
@ 2018-04-05 7:25 ` Jan Kiszka
2018-04-05 12:20 ` Dmitry V. Levin
2018-04-05 9:18 ` [tip:x86/pti] x86/uapi: Fix " tip-bot for Dmitry V. Levin
2018-04-09 3:36 ` [PATCH] uapi: fix " Sasha Levin
2 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2018-04-05 7:25 UTC (permalink / raw)
To: Dmitry V. Levin; +Cc: Thomas Gleixner, x86, linux-kernel
On 2018-04-05 06:32, Dmitry V. Levin wrote:
> Consistently use types provided by <linux/types.h> to fix the following
> asm/bootparam.h userspace compilation errors:
>
> /usr/include/asm/bootparam.h:140:2: error: unknown type name 'u16'
> u16 version;
> /usr/include/asm/bootparam.h:141:2: error: unknown type name 'u16'
> u16 compatible_version;
> /usr/include/asm/bootparam.h:142:2: error: unknown type name 'u16'
> u16 pm_timer_address;
> /usr/include/asm/bootparam.h:143:2: error: unknown type name 'u16'
> u16 num_cpus;
> /usr/include/asm/bootparam.h:144:2: error: unknown type name 'u64'
> u64 pci_mmconfig_base;
> /usr/include/asm/bootparam.h:145:2: error: unknown type name 'u32'
> u32 tsc_khz;
> /usr/include/asm/bootparam.h:146:2: error: unknown type name 'u32'
> u32 apic_khz;
> /usr/include/asm/bootparam.h:147:2: error: unknown type name 'u8'
> u8 standard_ioapic;
> /usr/include/asm/bootparam.h:148:2: error: unknown type name 'u8'
> u8 cpu_ids[255];
>
> Fixes: 4a362601baa6 ("x86/jailhouse: Add infrastructure for running in non-root cell")
> Cc: <stable@vger.kernel.org> # v4.16
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
> arch/x86/include/uapi/asm/bootparam.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h
> index aebf60357758..a06cbf019744 100644
> --- a/arch/x86/include/uapi/asm/bootparam.h
> +++ b/arch/x86/include/uapi/asm/bootparam.h
> @@ -137,15 +137,15 @@ struct boot_e820_entry {
> * setup data structure.
> */
> struct jailhouse_setup_data {
> - u16 version;
> - u16 compatible_version;
> - u16 pm_timer_address;
> - u16 num_cpus;
> - u64 pci_mmconfig_base;
> - u32 tsc_khz;
> - u32 apic_khz;
> - u8 standard_ioapic;
> - u8 cpu_ids[255];
> + __u16 version;
> + __u16 compatible_version;
> + __u16 pm_timer_address;
> + __u16 num_cpus;
> + __u64 pci_mmconfig_base;
> + __u32 tsc_khz;
> + __u32 apic_khz;
> + __u8 standard_ioapic;
> + __u8 cpu_ids[255];
> } __attribute__((packed));
>
> /* The so-called "zeropage" */
>
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
But how did you trigger this?
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:x86/pti] x86/uapi: Fix asm/bootparam.h userspace compilation errors
2018-04-05 4:32 [PATCH] uapi: fix asm/bootparam.h userspace compilation errors Dmitry V. Levin
2018-04-05 7:25 ` Jan Kiszka
@ 2018-04-05 9:18 ` tip-bot for Dmitry V. Levin
2018-04-09 3:36 ` [PATCH] uapi: fix " Sasha Levin
2 siblings, 0 replies; 5+ messages in thread
From: tip-bot for Dmitry V. Levin @ 2018-04-05 9:18 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, linux-kernel, mingo, ldv, torvalds, tglx, hpa, jan.kiszka
Commit-ID: 9820e1c3376c641299624dd24646aed3167ad5b1
Gitweb: https://git.kernel.org/tip/9820e1c3376c641299624dd24646aed3167ad5b1
Author: Dmitry V. Levin <ldv@altlinux.org>
AuthorDate: Thu, 5 Apr 2018 07:32:10 +0300
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 5 Apr 2018 10:05:21 +0200
x86/uapi: Fix asm/bootparam.h userspace compilation errors
Consistently use types provided by <linux/types.h> to fix the following
asm/bootparam.h userspace compilation errors:
/usr/include/asm/bootparam.h:140:2: error: unknown type name 'u16'
u16 version;
/usr/include/asm/bootparam.h:141:2: error: unknown type name 'u16'
u16 compatible_version;
/usr/include/asm/bootparam.h:142:2: error: unknown type name 'u16'
u16 pm_timer_address;
/usr/include/asm/bootparam.h:143:2: error: unknown type name 'u16'
u16 num_cpus;
/usr/include/asm/bootparam.h:144:2: error: unknown type name 'u64'
u64 pci_mmconfig_base;
/usr/include/asm/bootparam.h:145:2: error: unknown type name 'u32'
u32 tsc_khz;
/usr/include/asm/bootparam.h:146:2: error: unknown type name 'u32'
u32 apic_khz;
/usr/include/asm/bootparam.h:147:2: error: unknown type name 'u8'
u8 standard_ioapic;
/usr/include/asm/bootparam.h:148:2: error: unknown type name 'u8'
u8 cpu_ids[255];
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
Cc: <stable@vger.kernel.org> # v4.16
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 4a362601baa6 ("x86/jailhouse: Add infrastructure for running in non-root cell")
Link: http://lkml.kernel.org/r/20180405043210.GA13254@altlinux.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/uapi/asm/bootparam.h | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h
index aebf60357758..a06cbf019744 100644
--- a/arch/x86/include/uapi/asm/bootparam.h
+++ b/arch/x86/include/uapi/asm/bootparam.h
@@ -137,15 +137,15 @@ struct boot_e820_entry {
* setup data structure.
*/
struct jailhouse_setup_data {
- u16 version;
- u16 compatible_version;
- u16 pm_timer_address;
- u16 num_cpus;
- u64 pci_mmconfig_base;
- u32 tsc_khz;
- u32 apic_khz;
- u8 standard_ioapic;
- u8 cpu_ids[255];
+ __u16 version;
+ __u16 compatible_version;
+ __u16 pm_timer_address;
+ __u16 num_cpus;
+ __u64 pci_mmconfig_base;
+ __u32 tsc_khz;
+ __u32 apic_khz;
+ __u8 standard_ioapic;
+ __u8 cpu_ids[255];
} __attribute__((packed));
/* The so-called "zeropage" */
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] uapi: fix asm/bootparam.h userspace compilation errors
2018-04-05 7:25 ` Jan Kiszka
@ 2018-04-05 12:20 ` Dmitry V. Levin
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry V. Levin @ 2018-04-05 12:20 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Thomas Gleixner, x86, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2556 bytes --]
On Thu, Apr 05, 2018 at 09:25:26AM +0200, Jan Kiszka wrote:
> On 2018-04-05 06:32, Dmitry V. Levin wrote:
> > Consistently use types provided by <linux/types.h> to fix the following
> > asm/bootparam.h userspace compilation errors:
> >
> > /usr/include/asm/bootparam.h:140:2: error: unknown type name 'u16'
> > u16 version;
> > /usr/include/asm/bootparam.h:141:2: error: unknown type name 'u16'
> > u16 compatible_version;
> > /usr/include/asm/bootparam.h:142:2: error: unknown type name 'u16'
> > u16 pm_timer_address;
> > /usr/include/asm/bootparam.h:143:2: error: unknown type name 'u16'
> > u16 num_cpus;
> > /usr/include/asm/bootparam.h:144:2: error: unknown type name 'u64'
> > u64 pci_mmconfig_base;
> > /usr/include/asm/bootparam.h:145:2: error: unknown type name 'u32'
> > u32 tsc_khz;
> > /usr/include/asm/bootparam.h:146:2: error: unknown type name 'u32'
> > u32 apic_khz;
> > /usr/include/asm/bootparam.h:147:2: error: unknown type name 'u8'
> > u8 standard_ioapic;
> > /usr/include/asm/bootparam.h:148:2: error: unknown type name 'u8'
> > u8 cpu_ids[255];
> >
> > Fixes: 4a362601baa6 ("x86/jailhouse: Add infrastructure for running in non-root cell")
> > Cc: <stable@vger.kernel.org> # v4.16
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> > ---
> > arch/x86/include/uapi/asm/bootparam.h | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/arch/x86/include/uapi/asm/bootparam.h b/arch/x86/include/uapi/asm/bootparam.h
> > index aebf60357758..a06cbf019744 100644
> > --- a/arch/x86/include/uapi/asm/bootparam.h
> > +++ b/arch/x86/include/uapi/asm/bootparam.h
> > @@ -137,15 +137,15 @@ struct boot_e820_entry {
> > * setup data structure.
> > */
> > struct jailhouse_setup_data {
> > - u16 version;
> > - u16 compatible_version;
> > - u16 pm_timer_address;
> > - u16 num_cpus;
> > - u64 pci_mmconfig_base;
> > - u32 tsc_khz;
> > - u32 apic_khz;
> > - u8 standard_ioapic;
> > - u8 cpu_ids[255];
> > + __u16 version;
> > + __u16 compatible_version;
> > + __u16 pm_timer_address;
> > + __u16 num_cpus;
> > + __u64 pci_mmconfig_base;
> > + __u32 tsc_khz;
> > + __u32 apic_khz;
> > + __u8 standard_ioapic;
> > + __u8 cpu_ids[255];
> > } __attribute__((packed));
> >
> > /* The so-called "zeropage" */
> >
>
> Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> But how did you trigger this?
Our equivalent of glibc-kernheaders package contains a test
for regressions of this kind.
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] uapi: fix asm/bootparam.h userspace compilation errors
2018-04-05 4:32 [PATCH] uapi: fix asm/bootparam.h userspace compilation errors Dmitry V. Levin
2018-04-05 7:25 ` Jan Kiszka
2018-04-05 9:18 ` [tip:x86/pti] x86/uapi: Fix " tip-bot for Dmitry V. Levin
@ 2018-04-09 3:36 ` Sasha Levin
2 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2018-04-09 3:36 UTC (permalink / raw)
To: Sasha Levin, Dmitry V. Levin, Jan Kiszka
Cc: Thomas Gleixner, x86, stable, stable
Hi,
[This is an automated email]
This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 4a362601baa6 x86/jailhouse: Add infrastructure for running in non-root cell.
The bot has also determined it's probably a bug fixing patch. (score: 96.8422)
The bot has tested the following trees: v4.16.
v4.16: Build OK!
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-09 3:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-05 4:32 [PATCH] uapi: fix asm/bootparam.h userspace compilation errors Dmitry V. Levin
2018-04-05 7:25 ` Jan Kiszka
2018-04-05 12:20 ` Dmitry V. Levin
2018-04-05 9:18 ` [tip:x86/pti] x86/uapi: Fix " tip-bot for Dmitry V. Levin
2018-04-09 3:36 ` [PATCH] uapi: fix " Sasha Levin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.