From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client From: Radhey Shyam Pandey Message-Id: Date: Wed, 30 May 2018 17:29:47 +0000 To: Peter Ujfalusi , Vinod Koul Cc: Lars-Peter Clausen , "michal.simek@xilinx.com" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "dan.j.williams@intel.com" , Appana Durga Kedareswara Rao , "linux-arm-kernel@lists.infradead.org" List-ID: U0drc0RRb05DajRnTFMwdExTMVBjbWxuYVc1aGJDQk5aWE56WVdkbExTMHRMUzBOQ2o0Z1JuSnZi VG9nVUdWMFpYSWdWV3BtWVd4MQpjMmtnVzIxaGFXeDBienB3WlhSbGNpNTFhbVpoYkhWemFVQjBh UzVqYjIxZERRbytJRk5sYm5RNklGUjFaWE5rWVhrc0lFMWhlU0F5Ck9Td2dNakF4T0NBNE9qTTFJ RkJORFFvK0lGUnZPaUJTWVdSb1pYa2dVMmg1WVcwZ1VHRnVaR1Y1SUR4eVlXUm9aWGx6UUhocGJH bHUKZUM1amIyMCtPeUJXYVc1dlpDQkxiM1ZzRFFvK0lEeDJhVzV2WkM1cmIzVnNRR2x1ZEdWc0xt TnZiVDROQ2o0Z1EyTTZJRXhoY25NdApVR1YwWlhJZ1EyeGhkWE5sYmlBOGJHRnljMEJ0WlhSaFpt OXZMbVJsUGpzZ2JXbGphR0ZzTG5OcGJXVnJRSGhwYkdsdWVDNWpiMjA3CklHeHBiblY0TFEwS1Bp QnJaWEp1Wld4QWRtZGxjaTVyWlhKdVpXd3ViM0puT3lCa2JXRmxibWRwYm1WQWRtZGxjaTVyWlhK dVpXd3UKYjNKbk93MEtQaUJrWVc0dWFpNTNhV3hzYVdGdGMwQnBiblJsYkM1amIyMDdJRUZ3Y0dG dVlTQkVkWEpuWVNCTFpXUmhjbVZ6ZDJGeQpZU0JTWVc4TkNqNGdQR0Z3Y0dGdVlXUkFlR2xzYVc1 NExtTnZiVDQ3SUd4cGJuVjRMV0Z5YlMxclpYSnVaV3hBYkdsemRITXVhVzVtCmNtRmtaV0ZrTG05 eVp3MEtQaUJUZFdKcVpXTjBPaUJTWlRvZ1cxSkdReUF5THpaZElHUnRZV1Z1WjJsdVpUb2dlR2xz YVc1NFgyUnQKWVRvZ1VHRnpjeUJCV0VrMExWTjBjbVZoYlNCamIyNTBjbTlzSUhkdmNtUnpEUW8r SUhSdklHNWxkR1JsZGlCa2JXRWdZMnhwWlc1MApEUW8rSUEwS1BpQklhU3dOQ2o0Z0RRbytJRTl1 SURJd01UZ3RNRFV0TVRjZ01EazZNemtzSUZKaFpHaGxlU0JUYUhsaGJTQlFZVzVrClpYa2dkM0p2 ZEdVNkRRbytJRDQrSUZkbGJHd3NJR3hsZENkeklITmxaU0IzYUdWeVpTQjBhR2x6SUdseklHZHZh VzVuSUhSdklHZHYKSUhkb1pXNGdTU0JqWVc0Z2MyVnVaQ0IwYUdVZ2NHRjBZMmhsY3cwS1BpQStQ aUJtYjNJZ2NtVjJhV1YzTGcwS1BpQStJRlJvWVc1cgpjeUJoYkd3dUlFQlFaWFJsY2pvZ1NXWWdk MlVnYUdGMlpTQnRaWFJoWkdGMFlTQndZWFJqYUhObGRDQnlaV0ZrZVNCdFlYa2dZbVVnCloyOXZa QTBLUGlBK0lIUnZJSE5sYm1RZ1lXNGdVa1pEUHcwS1BpQU5DajRnVTI5eWNua2dabTl5SUhSb1pT QmtaV3hoZVN3Z1NTQm4KYjNRZ1pHbHpkSEpoWTNSbFpDQmllU0IwYUdsek9nMEtQaUJvZEhSd09p OHZkM2QzTG5ScExtTnZiUzlzYVhRdmNHUm1MM053Y25WcApaRGNnUTJoaGNIUmxjaUF4TUM0TkNq NGdEUW8rSUVrZ2FHRjJaU0JuYVhabGJpQnpiMjFsSUhSdmRXZG9JSFJ2SUhSb1pTQnRaWFJoClpH RjBZU0JoZEhSaFkyZ2djR0YwWTJobGN5NE5DajRnU1c0Z2JYa2dZMkZ6WlNCMGFHVWdKMjFsZEdG a1lYUmhKeUJwY3lCdGIzSmwKSUd4cGEyVWdjSEpwZG1GMFpTQmtZWFJoSUhObFkzUnBiMjRnZDJs MGFHbHVJSFJvWlEwS1BpQkVUVUVnWkdWelkzSnBjSFJ2Y2lBbwpNVEF1TVM0eUxqSXVNU2tnZDJo cFkyZ2dhWE1nZFhObFpDQmllU0IwYUdVZ2NtVnRiM1JsSUhCbGNtbHdhR1Z5WVd3Z1lXNWtEUW8r CklIUm9aU0JrY21sMlpYSWdabTl5SUhSb1pTQm5hWFpsYmlCd1pYSnBjR2hsY21Gc0lHRnVaQ0Jw ZENCcGN5QnZjSFJwYjI1aGJDNE4KQ2o0Z0RRbytJRWtnYkdsclpXUWdkR2hsSUdsa1pXRWdiMlln ZEhKbFlYUnBibWNnYVhRZ1lYTWdiV1YwWVdSaGRHRWdZWE1nYVhRZwpaMmwyWlhNZ2JXOXlaU0Ju Wlc1bGNtbGpJRUZRU1EwS1BpQjNhR2xqYUNCallXNGdZbVVnWVdSdmNIUmxaQ0JpZVNCdmRHaGxj aUJrCmNtbDJaWEp6SUdsbUlIUm9aWGtnYm1WbFpDQnpiMjFsZEdocGJtY2djMmx0YVd4aGNpNE5D ajRnRFFvK0lFRnViM1JvWlhJZ2FYTnoKZFdVZ1NTQm9ZWFpsSUhkcGRHZ2dkR2hsSUdGMGRHRmph Q0J0WlhSaFpHRjBZU0IzWVhrZ2FYTWdkR2hoZENCcGRDQjNiM1ZzWkEwSwpQaUJ5WlhGMWFYSmxJ Rzl1WlNCdFpXMWpjSGtnZEc4Z1kyOXdlU0IwYUdVZ1pHRjBZU0IwYnlCMGFHVWdSRTFCSUdSbGMy TnlhWEIwCmIzSWdZVzVrSUdsdUlHaHBaMmdOQ2o0Z2RHaHliM1ZuYUhCMWRDQmpZWE5sSUdsMElH bHpJRzV2ZENCaFkyTmxjSFJoWW14bExnMEsKRFFwSklIUm9hVzVySUcxbGJXTndlU0JwY3lCdVpX VmtaV1FnS0dGc2RHVnlibUYwYVhabFB5a2dhV1lnWkcxaElHVnVaMmx1WlNCawpiMlZ6YnVLQW1Y UWdaR2x5WldOMGJIa05DblZ3WkdGMFpTQnRaWFJoWkdGMFlTQmlkV1ptWlhKeklHa3VaU0JwYmlC U1dDd2dkMlVnCmJtVmxaQ0IwYnlCamIzQjVJRzFsZEdGa1lYUmhJR1p5YjIwZ0RRcGtiV0VnWkdW elkzSnBjSFJ2Y2lCbWFXVnNaSE1nZEc4Z1kyeHAKWlc1MElHRnNiRzlqWVhSbFpDQnRaWFJoWkdG MFlTQmlkV1ptWlhJZ0tITnBaR1ZpWVc1a0x3MEtiV1YwWVdSaGRHRWdhVzVtYnlCcApjeUJ3WVhK MElHOW1JRUoxWm1abGNpQmtaWE5qY21sd2RHOXlJR1pwWld4a2N5a2dEUW9OQ20xbGJXTndlU2ho Y0hCZmR5d2dhSGN0ClBtRndjQ3dnYzJsNlpXOW1LSFV6TWlrZ0tpQllTVXhKVGxoZlJFMUJYMDVW VFY5QlVGQmZWMDlTUkZNcE93MEtEUXBFWlhOamNtbHcKZEc5eUlFWnBaV3hrY3cwS1FXUmtjbVZ6 Y3lCVGNHRmpaU0FnSUNBZ0lDQWdJQ0FnSUNBZ0lFOW1abk5sZENBZ0lDQWdJQ0FnSUNCTwpZVzFs SUVSbGMyTnlhWEIwYVc5dURRb3lNR2dnSUNBZ0lDQWdJQ0FnSUNBZ0lDQWdJQ0FnSUNBZ0lDQWdJ Q0FnSUNBZ0lDQWdRVkJRCk1DQWdJQ0FnSUNBZ0lDQWdWWE5sY2lCQmNIQnNhV05oZEdsdmJpQkdh V1ZzWkNBd0RRb3lOR2dnSUNBZ0lDQWdJQ0FnSUNBZ0lDQWcKSUNBZ0lDQWdJQ0FnSUNBZ0lDQWdJ Q0FnUVZCUU1TQWdJQ0FnSUNBZ0lDQWdWWE5sY2lCQmNIQnNhV05oZEdsdmJpQkdhV1ZzWkNBeApE UW91TGk0TkNqTXdhQ0FnSUNBZ0lDQWdJQ0FnSUNBZ0lDQWdJQ0FnSUNBZ0lDQWdJQ0FnSUNBZ0lF RlFVRFVnSUNBZ0lDQWdJQ0FnCklGVnpaWElnUVhCd2JHbGpZWFJwYjI0Z1JtbGxiR1FnTlEwS0RR bytJQTBLUGlCR2IzSWdiV1VnY0hKdlltRmliSGtnWVNBdVoyVjAKWDNCeWFYWmhkR1ZmWVhKbFlT QXZJQzV3ZFhSZmNISnBkbUYwWlY5aGNtVmhJR3hwYTJVZ1FWQkpJSGR2ZFd4a0RRbytJR0psSUdS bApjMmx5WVdKc1pTQjNhR1Z5WlNCSklHTmhiaUJuYVhabElIUm9aU0J3YjJsdWRHVnlJRzltSUhS b1pTQW5iV1YwWVdSaGRHRW5JR0Z5ClpTQW9ZVzVrRFFvK0lITnBlbVVwSUhSdklIUm9aU0IxYzJW eUxnMEtQaUFOQ2o0Z1FuVjBJSFJvWlhObElHTmhiaUJqYnkxbGVHbHoKZENCcGJpQnRlU0J2Y0ds dWFXOXVJR0Z1WkNCRVRVRWdaSEpwZG1WeWN5QmpZVzRnYjNCMElIUnZEUW8rSUdsdGNHeGxiV1Z1 ZENCdQpiMjVsTENCbGFYUm9aWElnYjNJZ1ltOTBhQ0J2WmlCMGFHVWdZMkZzYkdKaFkydHpMZzBL UGlBTkNqNGdTVzRnWTI5MWNHeGxJRzltCklHUmhlWE1nU1NCallXNGdkWEJrWVhSbElIUm9aU0J0 WlhSaFpHRjBZU0J3WVhSamFHVnpJRWtnYUdGMlpTQmhkRzBnWVc1a0lITmwKYm1RTkNqNGdZWE1n VWtaRExnMEtQaUFOQ2o0Z1NYTWdkR2hsY21VZ1lXNTVkR2hwYm1jZ1puSnZiU0I1YjNWeUlITnBa R1VnU1NCegphRzkxYkdRZ2RHRnJaU0JwYm5SdklHRmpZMjkxYm5RZ2QyaGxiaUJrYjJsdVp5QjBh R0YwUHcwS1NTQjBhR2x1YXlCaElHZGxibVZ5CmFXTWdhVzUwWlhKbVlXTmxJSFJ2SUdGMGRHRmph Qzl6YUdGeVpTQnRaWFJoWkdGMFlTQmlkV1ptWlhJZ1lpOTNJR05zYVdWdWRDQmgKYm1RZ2RHaGxE UXBrYldGbGJtZHBibVVnWkhKcGRtVnlJR2x6SUdkdmIyUWdaVzV2ZFdkb0xpQkpjeUJ0WlhSaFpH RjBZU0J3WVhSagphSE5sZENBb1pXRnliSGtnZG1WeWMybHZiaWtnRFFwaGRtRnBiR0ZpYkdVZ2FX NGdWRWtnWlhoMFpYSnVZV3dnY21Wd2IzTS9JQTBLCkRRcFVhR0Z1YTNNc0RRcFNZV1JvWlhrTkNn MEtQaUFOQ2o0Z0xTQlF3NmwwWlhJTkNqNGdEUW8rSUZSbGVHRnpJRWx1YzNSeWRXMWwKYm5SeklF WnBibXhoYm1RZ1Qza3NJRkJ2Y210cllXeGhibXRoZEhVZ01qSXNJREF3TVRnd0lFaGxiSE5wYm10 cExnMEtQaUJaTFhSMQpibTUxY3k5Q2RYTnBibVZ6Y3lCSlJEb2dNRFl4TlRVeU1TMDBMaUJMYjNS cGNHRnBhMnRoTDBSdmJXbGphV3hsT2lCSVpXeHphVzVyCmFRMEsKLS0tClRvIHVuc3Vic2NyaWJl IGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBkbWFlbmdpbmUiIGlu CnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUg bWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8u aHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbeE3R36 (ORCPT ); Wed, 30 May 2018 13:29:58 -0400 Received: from mail-by2nam01on0079.outbound.protection.outlook.com ([104.47.34.79]:52327 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751817AbeE3R3y (ORCPT ); Wed, 30 May 2018 13:29:54 -0400 From: Radhey Shyam Pandey To: Peter Ujfalusi , Vinod Koul CC: Lars-Peter Clausen , "michal.simek@xilinx.com" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "dan.j.williams@intel.com" , Appana Durga Kedareswara Rao , "linux-arm-kernel@lists.infradead.org" Subject: RE: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client Thread-Topic: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client Thread-Index: AQHTym7m2V209m7Mdku6MMzd169mt6P7VJGAgAmMXFCAACC9AIAADoKAgAADQwCAAA9+gIAAEQmAgAD0/ICAAG4+gIABel0AgAdZ2ICAAGMogIAj6UOAgBNwBwCAAawZwA== Date: Wed, 30 May 2018 17:29:47 +0000 Message-ID: References: <20180411090854.GY6014@localhost> <7f549d2e-fc96-8c7e-d839-edb86ae088a5@metafoo.de> <4ba085c7-5256-6c8a-5697-c0d5736a6e46@ti.com> <1fc10bec-5c2c-98f1-1d5b-b768dea844ed@metafoo.de> <78828d31-e4cd-5211-f1b6-8918ac38f599@ti.com> <8c7a5ac8-0747-9dad-f6e5-74890b64f618@ti.com> <20180424035548.GA6014@localhost> <99581088-7ef8-6fac-c934-91eadddfb04e@ti.com> In-Reply-To: <99581088-7ef8-6fac-c934-91eadddfb04e@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=radheys@xilinx.com; x-originating-ip: [183.83.203.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM6PR02MB4443;7:DAP239DUQjcp5dK/LRoRxzyOa9kx4BgrKztwchnaZL6IdO5x0iVDXWszVOYfx1xb5iakxGMG+3i7hRVHmfbPWF0/OpFZQn6NHxF+kxXyIoKX1jdLikGf7eC9mtjFS8Vi+tiJpkbgra3rgmwWWBJb+eFuqJKu3kWerADqRBeT482kaBbgCCp1cgePT6QR8hj3S6l7NgrILlEOrp6nJDz2x4C4sPfO60r4/HufKBghgTfHw6DRpGO3IgLrbHIKfg1H x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(39860400002)(39380400002)(346002)(376002)(396003)(366004)(13464003)(189003)(199004)(26005)(7696005)(478600001)(81166006)(5660300001)(4326008)(106356001)(99286004)(966005)(25786009)(305945005)(105586002)(97736004)(8936002)(86362001)(14454004)(7736002)(11346002)(476003)(446003)(53936002)(229853002)(486006)(33656002)(6246003)(9686003)(6306002)(55016002)(74316002)(5250100002)(3846002)(6116002)(66066001)(6436002)(54906003)(110136005)(5890100001)(93886005)(316002)(2906002)(186003)(76176011)(53546011)(102836004)(8676002)(2900100001)(68736007)(1720100001)(3280700002)(59450400001)(3660700001)(6506007)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR02MB4443;H:DM6PR02MB4361.namprd02.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DM6PR02MB4443; x-ms-traffictypediagnostic: DM6PR02MB4443: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(31051911155226)(9452136761055)(258649278758335)(192813158149592)(106291317490208)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016);SRVR:DM6PR02MB4443;BCL:0;PCL:0;RULEID:;SRVR:DM6PR02MB4443; x-forefront-prvs: 0688BF9B46 x-microsoft-antispam-message-info: uSBffaP+1NxfqIihqF1G7PsO9w1Pm8cKzLvDLCUVGvkk0PnTASe9azSDYVkU5V77wJUOpofqXhhYOtyI954HqY+M7j+lUqGNMBLrTRrcD4K0Kk56Huh26Sh9Ljeo7f275lPIKQYYuinWwBbbyPe70Xjydb1Q2t+fjZe75ojepBy7lpNqTmoGK6zHy13FISTz spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5f7608d6-cd36-4b3f-188e-08d5c652f12b X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f7608d6-cd36-4b3f-188e-08d5c652f12b X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2018 17:29:47.6222 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4443 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w4UHUD3C003006 Hi, > -----Original Message----- > From: Peter Ujfalusi [mailto:peter.ujfalusi@ti.com] > Sent: Tuesday, May 29, 2018 8:35 PM > To: Radhey Shyam Pandey ; Vinod Koul > > Cc: Lars-Peter Clausen ; michal.simek@xilinx.com; linux- > kernel@vger.kernel.org; dmaengine@vger.kernel.org; > dan.j.williams@intel.com; Appana Durga Kedareswara Rao > ; linux-arm-kernel@lists.infradead.org > Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words > to netdev dma client > > Hi, > > On 2018-05-17 09:39, Radhey Shyam Pandey wrote: > >> Well, let's see where this is going to go when I can send the patches > >> for review. > > Thanks all. @Peter: If we have metadata patchset ready may be good > > to send an RFC? > > Sorry for the delay, I got distracted by this: > http://www.ti.com/lit/pdf/spruid7 Chapter 10. > > I have given some tough to the metadata attach patches. > In my case the 'metadata' is more like private data section within the > DMA descriptor (10.1.2.2.1) which is used by the remote peripheral and > the driver for the given peripheral and it is optional. > > I liked the idea of treating it as metadata as it gives more generic API > which can be adopted by other drivers if they need something similar. > > Another issue I have with the attach metadata way is that it would > require one memcpy to copy the data to the DMA descriptor and in high > throughput case it is not acceptable. I think memcpy is needed (alternative?) if dma engine doesn’t directly update metadata buffers i.e in RX, we need to copy metadata from dma descriptor fields to client allocated metadata buffer (sideband/ metadata info is part of Buffer descriptor fields) memcpy(app_w, hw->app, sizeof(u32) * XILINX_DMA_NUM_APP_WORDS); Descriptor Fields Address Space Offset Name Description 20h APP0 User Application Field 0 24h APP1 User Application Field 1 ... 30h APP5 User Application Field 5 > > For me probably a .get_private_area / .put_private_area like API would > be desirable where I can give the pointer of the 'metadata' are (and > size) to the user. > > But these can co-exist in my opinion and DMA drivers can opt to > implement none, either or both of the callbacks. > > In couple of days I can update the metadata patches I have atm and send > as RFC. > > Is there anything from your side I should take into account when doing that? I think a generic interface to attach/share metadata buffer b/w client and the dmaengine driver is good enough. Is metadata patchset (early version) available in TI external repos? Thanks, Radhey > > - Péter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 From: radheys@xilinx.com (Radhey Shyam Pandey) Date: Wed, 30 May 2018 17:29:47 +0000 Subject: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words to netdev dma client In-Reply-To: <99581088-7ef8-6fac-c934-91eadddfb04e@ti.com> References: <20180411090854.GY6014@localhost> <7f549d2e-fc96-8c7e-d839-edb86ae088a5@metafoo.de> <4ba085c7-5256-6c8a-5697-c0d5736a6e46@ti.com> <1fc10bec-5c2c-98f1-1d5b-b768dea844ed@metafoo.de> <78828d31-e4cd-5211-f1b6-8918ac38f599@ti.com> <8c7a5ac8-0747-9dad-f6e5-74890b64f618@ti.com> <20180424035548.GA6014@localhost> <99581088-7ef8-6fac-c934-91eadddfb04e@ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, > -----Original Message----- > From: Peter Ujfalusi [mailto:peter.ujfalusi at ti.com] > Sent: Tuesday, May 29, 2018 8:35 PM > To: Radhey Shyam Pandey ; Vinod Koul > > Cc: Lars-Peter Clausen ; michal.simek at xilinx.com; linux- > kernel at vger.kernel.org; dmaengine at vger.kernel.org; > dan.j.williams at intel.com; Appana Durga Kedareswara Rao > ; linux-arm-kernel at lists.infradead.org > Subject: Re: [RFC 2/6] dmaengine: xilinx_dma: Pass AXI4-Stream control words > to netdev dma client > > Hi, > > On 2018-05-17 09:39, Radhey Shyam Pandey wrote: > >> Well, let's see where this is going to go when I can send the patches > >> for review. > > Thanks all. @Peter: If we have metadata patchset ready may be good > > to send an RFC? > > Sorry for the delay, I got distracted by this: > http://www.ti.com/lit/pdf/spruid7 Chapter 10. > > I have given some tough to the metadata attach patches. > In my case the 'metadata' is more like private data section within the > DMA descriptor (10.1.2.2.1) which is used by the remote peripheral and > the driver for the given peripheral and it is optional. > > I liked the idea of treating it as metadata as it gives more generic API > which can be adopted by other drivers if they need something similar. > > Another issue I have with the attach metadata way is that it would > require one memcpy to copy the data to the DMA descriptor and in high > throughput case it is not acceptable. I think memcpy is needed (alternative?) if dma engine doesn?t directly update metadata buffers i.e in RX, we need to copy metadata from dma descriptor fields to client allocated metadata buffer (sideband/ metadata info is part of Buffer descriptor fields) memcpy(app_w, hw->app, sizeof(u32) * XILINX_DMA_NUM_APP_WORDS); Descriptor Fields Address Space Offset Name Description 20h APP0 User Application Field 0 24h APP1 User Application Field 1 ... 30h APP5 User Application Field 5 > > For me probably a .get_private_area / .put_private_area like API would > be desirable where I can give the pointer of the 'metadata' are (and > size) to the user. > > But these can co-exist in my opinion and DMA drivers can opt to > implement none, either or both of the callbacks. > > In couple of days I can update the metadata patches I have atm and send > as RFC. > > Is there anything from your side I should take into account when doing that? I think a generic interface to attach/share metadata buffer b/w client and the dmaengine driver is good enough. Is metadata patchset (early version) available in TI external repos? Thanks, Radhey > > - P?ter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki