From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: trigger: Staticise stub functions
Date: Sat, 18 Jul 2020 17:10:16 +0000 [thread overview]
Message-ID: <DM6PR03MB4411D0B8239819F58B33F7BCF97D0@DM6PR03MB4411.namprd03.prod.outlook.com> (raw)
In-Reply-To: <017b33b1-b6f9-107b-b9c4-8c0abd0d6a3b@metafoo.de>
Apologies from my side for being too much of a patch-bot here.
I should have also given some more thought to the patch.
Atm, I'm sending this from Outlook, since [for some reason] the Linux mail-client isn't working.
[ Which is why this isn't properly inlined either ]
I'll send a V2.
-----Original Message-----
From: Lars-Peter Clausen <lars@metafoo.de>
Sent: Saturday, July 18, 2020 7:37 PM
To: Jonathan Cameron <jic23@kernel.org>; Ardelean, Alexandru <alexandru.Ardelean@analog.com>
Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: trigger: Staticise stub functions
[External]
On 7/18/20 6:25 PM, Jonathan Cameron wrote:
> On Tue, 14 Jul 2020 17:24:56 +0300
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
>> From: Lars-Peter Clausen <lars@metafoo.de>
>>
>> Make sure that the trigger function stubs are all static inline.
>> Otherwise we'll get linker errors due to multiple definitions of the same function.
>>
>> Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> I'm curious on what the actual build error is? Static functions
> should result in independent implementations in each C file that
> includes them. Inline is normally considered a hint. Hence what am I missing?
It's a bad commit message, my fault. This should have been
Make sure that the trigger function stubs are all static inline.
Otherwise we might see compiler warnings about declared but unused functions.
next prev parent reply other threads:[~2020-07-18 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 14:24 [PATCH] iio: trigger: Staticise stub functions Alexandru Ardelean
2020-07-18 16:25 ` Jonathan Cameron
2020-07-18 16:36 ` Lars-Peter Clausen
2020-07-18 17:10 ` Ardelean, Alexandru [this message]
2020-07-20 13:51 ` [PATCH v2] iio: trigger: make stub functions static inline Alexandru Ardelean
2020-07-26 12:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR03MB4411D0B8239819F58B33F7BCF97D0@DM6PR03MB4411.namprd03.prod.outlook.com \
--to=alexandru.ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.