From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/3] block: Allow mapping of vmalloc-ed buffers
Date: Wed, 26 Jun 2019 04:19:27 +0000 [thread overview]
Message-ID: <DM6PR04MB57541624801EC01B620455F086E20@DM6PR04MB5754.namprd04.prod.outlook.com> (raw)
In-Reply-To: BYAPR04MB58160BAAFBDE4C399C412F1FE7E20@BYAPR04MB5816.namprd04.prod.outlook.com
On 6/25/19 6:38 PM, Damien Le Moal wrote:
> On 2019/06/26 1:06, Chaitanya Kulkarni wrote:
>> On 06/25/2019 08:59 AM, Bart Van Assche wrote:
>>> On 6/24/19 8:24 PM, Chaitanya Kulkarni wrote:
>>>> nit:- Can we use is_vmalloc_addr() call directly so that
>>>> "if (is_vmalloc)" -> "if (is_vmalloc_addr(data))" and remove is_vmalloc
>>>> variable.
>>> That would change a single call of is_vmalloc_addr() into multiple?
>>
>> Well is_vmalloc_addr() it is an in-line helper with address comparison.
>>
>> is it too expensive to have such a comparison in the loop ?
>
> Probably not, but I do not see the point in calling it for every page either
> since the cost of the additional bool on the stack is likely also very low.
>
Okay.
next prev parent reply other threads:[~2019-06-26 4:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 2:46 [PATCH 0/3] Fix zone revalidation memory allocation failures Damien Le Moal
2019-06-25 2:46 ` [PATCH 1/3] block: Allow mapping of vmalloc-ed buffers Damien Le Moal
2019-06-25 3:24 ` Chaitanya Kulkarni
2019-06-25 15:59 ` Bart Van Assche
2019-06-25 16:06 ` Chaitanya Kulkarni
2019-06-26 1:38 ` Damien Le Moal
2019-06-26 4:19 ` Chaitanya Kulkarni [this message]
2019-06-25 15:59 ` Bart Van Assche
2019-06-25 16:22 ` Christoph Hellwig
2019-06-25 2:46 ` [PATCH 2/3] sd_zbc: Fix report zones buffer allocation Damien Le Moal
2019-06-25 10:37 ` kbuild test robot
2019-06-25 16:07 ` Bart Van Assche
2019-06-25 2:46 ` [PATCH 3/3] block: Limit zone array allocation size Damien Le Moal
2019-06-25 16:10 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB57541624801EC01B620455F086E20@DM6PR04MB5754.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.