All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: "Nishad Kamdar" <nishadkamdar@gmail.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Adrian Hunter" <adrian.hunter@intel.com>,
	"Bean Huo" <beanhuo@micron.com>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Huijin Park" <huijin.park@samsung.com>,
	"Yue Hu" <huyue2@yulong.com>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Christian Löhle" <CLoehle@hyperstone.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mmc: core: Add support for the eMMC RTC feature in mmc_ops
Date: Tue, 7 Dec 2021 09:33:46 +0000	[thread overview]
Message-ID: <DM6PR04MB6575BF4FC2DE49885D0EEDF0FC6E9@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20211207093009.GA11794@nishad>

> On Tue, Dec 07, 2021 at 08:28:42AM +0000, Avri Altman wrote:
> >
> > > This patch adds support to set the RTC information in the eMMC
> > > device. This is based on the JEDEC specification.
> > >
> > > There is no way however, to read the RTC time from the device. Hence
> > > we rely on the response of the CMD49 to confirm the completion of
> > > the operation.
> > >
> > > This patch has been tested successfully with the ioctl interface.
> > > This patch has also been tested suceessfully with all the three
> > > RTC_INFO_TYPEs.
> > If this is triggered from user-space via ioctl anyway, Why do we need
> > this command to be implemented in the kernel?
> > Why not just add this to mmc-utils?
> >
> > Thanks,
> > Avri
> As per the spec, B51: Section 6.6.35:
> Providing RTC info may be useful for internal maintainance operations.
> And the host should send it on the following events:
> - power-up
> - wake-up
> - Periodically
> Hence IMO, the Kernel would be the right place of peforming this operation.
But your patch doesn't do that, is it?

Thanks,
Avri

  reply	other threads:[~2021-12-07  9:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-05 19:10 [PATCH] mmc: core: Add support for the eMMC RTC feature in mmc_ops Nishad Kamdar
2021-12-06 20:44 ` Stephen Boyd
2021-12-07  5:26   ` Nishad Kamdar
2021-12-07  8:28 ` Avri Altman
2021-12-07  9:30   ` Nishad Kamdar
2021-12-07  9:33     ` Avri Altman [this message]
2021-12-07  9:43       ` Nishad Kamdar
2021-12-07  9:51         ` Greg Kroah-Hartman
2021-12-07  8:52 ` Christian Löhle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR04MB6575BF4FC2DE49885D0EEDF0FC6E9@DM6PR04MB6575.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=CLoehle@hyperstone.com \
    --cc=adrian.hunter@intel.com \
    --cc=axboe@kernel.dk \
    --cc=beanhuo@micron.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=huijin.park@samsung.com \
    --cc=huyue2@yulong.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=nishadkamdar@gmail.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=swboyd@chromium.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.