All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pawel Laszczak <pawell@cadence.com>
To: Peter Chen <peter.chen@nxp.com>,
	"balbi@kernel.org" <balbi@kernel.org>,
	"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"rogerq@ti.com" <rogerq@ti.com>,
	"jun.li@nxp.com" <jun.li@nxp.com>
Subject: RE: [PATCH v5 8/9] usb: cdns3: host: add .suspend_quirk for xhci-plat.c
Date: Mon, 17 Aug 2020 04:39:53 +0000	[thread overview]
Message-ID: <DM6PR07MB55294EE55EBBCB5EDC45F759DD5F0@DM6PR07MB5529.namprd07.prod.outlook.com> (raw)
In-Reply-To: <20200707074941.28078-9-peter.chen@nxp.com>

>
>cdns3 has some special PM sequence between xhci_bus_suspend and
>xhci_suspend, add quirk to implement it.
>
>Signed-off-by: Peter Chen <peter.chen@nxp.com>
>---
> drivers/usb/cdns3/host-export.h |  6 +++++
> drivers/usb/cdns3/host.c        | 40 +++++++++++++++++++++++++++++++++
> 2 files changed, 46 insertions(+)
>
>diff --git a/drivers/usb/cdns3/host-export.h b/drivers/usb/cdns3/host-export.h
>index ae11810f8826..26041718a086 100644
>--- a/drivers/usb/cdns3/host-export.h
>+++ b/drivers/usb/cdns3/host-export.h
>@@ -9,9 +9,11 @@
> #ifndef __LINUX_CDNS3_HOST_EXPORT
> #define __LINUX_CDNS3_HOST_EXPORT
>
>+struct usb_hcd;
> #ifdef CONFIG_USB_CDNS3_HOST
>
> int cdns3_host_init(struct cdns3 *cdns);
>+int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd);
>
> #else
>
>@@ -21,6 +23,10 @@ static inline int cdns3_host_init(struct cdns3 *cdns)
> }
>
> static inline void cdns3_host_exit(struct cdns3 *cdns) { }
>+static inline int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>+{
>+	return 0;
>+}
>
> #endif /* CONFIG_USB_CDNS3_HOST */
>
>diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
>index b579ef15f4e0..030d6421abd3 100644
>--- a/drivers/usb/cdns3/host.c
>+++ b/drivers/usb/cdns3/host.c
>@@ -14,6 +14,18 @@
> #include "drd.h"
> #include "host-export.h"
> #include <linux/usb/hcd.h>
>+#include "../host/xhci.h"
>+#include "../host/xhci-plat.h"
>+
>+#define XECP_PORT_CAP_REG	0x8000
>+#define XECP_AUX_CTRL_REG1	0x8120
>+
>+#define CFG_RXDET_P3_EN		(1 << 15)
>+#define LPM_2_STB_SWITCH_EN	(1 << 25)
>+

Please use BIT(15) and BIT(25)
Reviewed-by: Pawel Laszczak <pawell@cadence.com>

Regards
Pawel

>+static const struct xhci_plat_priv xhci_plat_cdns3_xhci = {
>+	.suspend_quirk = xhci_cdns3_suspend_quirk,
>+};
>
> static int __cdns3_host_init(struct cdns3 *cdns)
> {
>@@ -39,6 +51,11 @@ static int __cdns3_host_init(struct cdns3 *cdns)
> 		goto err1;
> 	}
>
>+	ret = platform_device_add_data(xhci, &xhci_plat_cdns3_xhci,
>+			sizeof(struct xhci_plat_priv));
>+	if (ret)
>+		goto err1;
>+
> 	ret = platform_device_add(xhci);
> 	if (ret) {
> 		dev_err(cdns->dev, "failed to register xHCI device\n");
>@@ -56,6 +73,29 @@ static int __cdns3_host_init(struct cdns3 *cdns)
> 	return ret;
> }
>
>+int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
>+{
>+	struct xhci_hcd	*xhci = hcd_to_xhci(hcd);
>+	u32 value;
>+
>+	/* set usbcmd.EU3S */
>+	value = readl(&xhci->op_regs->command);
>+	value |= CMD_PM_INDEX;
>+	writel(value, &xhci->op_regs->command);
>+
>+	if (hcd->regs) {
>+		value = readl(hcd->regs + XECP_AUX_CTRL_REG1);
>+		value |= CFG_RXDET_P3_EN;
>+		writel(value, hcd->regs + XECP_AUX_CTRL_REG1);
>+
>+		value = readl(hcd->regs + XECP_PORT_CAP_REG);
>+		value |= LPM_2_STB_SWITCH_EN;
>+		writel(value, hcd->regs + XECP_PORT_CAP_REG);
>+	}
>+
>+	return 0;
>+}
>+
> static void cdns3_host_exit(struct cdns3 *cdns)
> {
> 	platform_device_unregister(cdns->host_dev);
>--
>2.17.1


  reply	other threads:[~2020-08-17  4:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07  7:49 [PATCH v5 0/9] usb: some PM changes for cdns3 and xhci-plat Peter Chen
2020-07-07  7:49 ` [PATCH v5 1/9] usb: cdns3: introduce set_phy_power_on{off} APIs Peter Chen
2020-08-13 12:09   ` Pawel Laszczak
2020-08-14  5:29     ` Peter Chen
2020-07-07  7:49 ` [PATCH v5 2/9] usb: cdns3: add runtime PM support Peter Chen
2020-08-13 13:10   ` Pawel Laszczak
2020-07-07  7:49 ` [PATCH v5 3/9] usb: cdns3: imx: add glue layer runtime pm implementation Peter Chen
2020-08-13 13:20   ` Pawel Laszczak
2020-07-07  7:49 ` [PATCH v5 4/9] usb: host: xhci-plat: add platform data support Peter Chen
2020-07-07  7:49 ` [PATCH v5 5/9] usb: host: xhci-plat: add .suspend_quirk for struct xhci_plat_priv Peter Chen
2020-07-07  7:49 ` [PATCH v5 6/9] usb: host: xhci-plat: delete the unnecessary code Peter Chen
2020-07-07  7:49 ` [PATCH v5 7/9] usb: host: xhci-plat: add priv quirk for skip PHY initialization Peter Chen
2020-07-24  6:24   ` Peter Chen
2020-07-07  7:49 ` [PATCH v5 8/9] usb: cdns3: host: add .suspend_quirk for xhci-plat.c Peter Chen
2020-08-17  4:39   ` Pawel Laszczak [this message]
2020-07-07  7:49 ` [PATCH v5 9/9] usb: cdns3: host: add xhci_plat_priv quirk XHCI_SKIP_PHY_INIT Peter Chen
2020-08-17  4:37   ` Pawel Laszczak
2020-07-17  6:13 ` [PATCH v5 0/9] usb: some PM changes for cdns3 and xhci-plat Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR07MB55294EE55EBBCB5EDC45F759DD5F0@DM6PR07MB5529.namprd07.prod.outlook.com \
    --to=pawell@cadence.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jun.li@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=peter.chen@nxp.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.