From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thierry Herbelot <thierry.herbelot@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] table: fix typo
Date: Mon, 24 May 2021 11:30:46 +0000 [thread overview]
Message-ID: <DM6PR11MB2796DFFBE747C8B9A66D2818EB269@DM6PR11MB2796.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210524112836.28224-1-thierry.herbelot@6wind.com>
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Monday, May 24, 2021 12:29 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; stable@dpdk.org; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH v2] table: fix typo
>
> Check Bucket key for all possible indices.
>
> Fixes: d0a00966618ba ("table: add exact match SWX table")
> Cc: stable@dpdk.org
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V2: reword patch title
> ---
> lib/table/rte_swx_table_em.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
> index 788e25f6b912..03b28c4c9da0 100644
> --- a/lib/table/rte_swx_table_em.c
> +++ b/lib/table/rte_swx_table_em.c
> @@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
> static inline int
> bkt_is_empty(struct bucket_extension *bkt)
> {
> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> ?
> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> ?
> 1 : 0;
> }
>
> --
> 2.29.2
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Thierry, thanks again, you could have actually added my ack from V1 :)
next prev parent reply other threads:[~2021-05-24 11:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 8:53 [dpdk-dev] [PATCH] rte_swx: fix typo Thierry Herbelot
2021-05-24 11:25 ` Dumitrescu, Cristian
2021-05-24 11:28 ` [dpdk-dev] [PATCH v2] table: " Thierry Herbelot
2021-05-24 11:30 ` Dumitrescu, Cristian [this message]
2021-06-17 7:01 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-06-17 7:11 ` Thierry Herbelot
2021-06-21 15:44 ` Dumitrescu, Cristian
2021-06-21 15:54 ` Thierry Herbelot
2021-06-21 16:14 ` Thomas Monjalon
2021-06-21 16:56 ` Dumitrescu, Cristian
2021-06-29 11:35 ` Dumitrescu, Cristian
2021-06-29 13:41 ` Thomas Monjalon
2021-06-29 13:51 ` Dumitrescu, Cristian
2021-07-03 0:07 ` Dumitrescu, Cristian
2021-06-21 17:23 ` Thierry Herbelot
2021-07-07 11:19 ` [dpdk-dev] [PATCH V3] table: fix bucket empty logic Thierry Herbelot
2021-07-07 11:23 ` Dumitrescu, Cristian
2021-07-09 20:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2796DFFBE747C8B9A66D2818EB269@DM6PR11MB2796.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.