From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C47E2C433B4 for ; Wed, 28 Apr 2021 13:29:38 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 1EA4E61151 for ; Wed, 28 Apr 2021 13:29:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EA4E61151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B1F140697; Wed, 28 Apr 2021 15:29:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 368A240147 for ; Wed, 28 Apr 2021 15:29:35 +0200 (CEST) IronPort-SDR: Js9SbwrXVPn0IMEUuUf121zNstGdprKWGA8C/aKjZo0cnKm/RXUar0uHz4qfr+Nrt3fB9xD2yx KVcoLPh3iLEQ== X-IronPort-AV: E=McAfee;i="6200,9189,9968"; a="196795540" X-IronPort-AV: E=Sophos;i="5.82,258,1613462400"; d="scan'208";a="196795540" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 06:29:33 -0700 IronPort-SDR: 5xPwDxCnHhN4Bl5A6lAnb5v5Q0DSM3VYXLwO9JdzS/FU47/gGVvzFmHJdN0vULWOm3xn1lJT0W XInZWKPMNaYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,258,1613462400"; d="scan'208";a="458182505" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 28 Apr 2021 06:29:33 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 28 Apr 2021 06:29:33 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 28 Apr 2021 06:29:32 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 28 Apr 2021 06:29:32 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 28 Apr 2021 06:29:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wvx4sVtiTGZuxY2JgoNAzmxHAbaUXfpgL5s22O6u92rGqw211QAtZw4wppfybSWb8OBpeniuBxpNLfN758OQWqN2UA4klDp43r/78qxXlKtQKE4T6ZsN40ZhE5z6AM3bcG2mZRP8tVvVPTgCilKRFTFLNqnkRfspXxzhrT9BZQNGCjzYOVZvNyXOiATBVSWBbtVTwj6sWswH/IkbTtoX++7zj+3MDsVUJvSesihgooQfPg9TxyRFRZpoNqTl6TbryhUK7BsmbUYjcKN2AcVm0z2PhnbrSC82nKwfKyNe0fyfKBvDaIrAKLsl5KGpWWxQgAooa7KDETRXaKfNSOc+gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xvf4zN2Sw8ZQ+VU9WCpXR7e4FqISTyFj5A3Cfm3WR1M=; b=Xt+B35O99JBBBhmXa14v6HYpXglCnQYkE0+lUr80Y4eDUZlscm+nfc0eMjV43nUeZ/kO5NNhKW3QQ0YMYkMUz2Y3qjHfJh64hM3u4Tg1dLF/2QQK/9+0X9Guaq+0zdGirqByzpykpveyspf7FLnFJnKUPTDxkhztRe3Ctj8tYbireJsy6+FH6wsQq6FVG1YZ42VlPDidccAkbqrmdNvwz1ysQVXXOWxpG0ZBywKVYM+trDvBQf4wDL/yWx5f4cCtNGcQ7x1VH0IHdcvSVkv3Mn8soIiDr1RX7if3sVANoYJo3yTrrImjazvp/+hcUHoMCukOmUy+Ba7XIqRjw6/7nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xvf4zN2Sw8ZQ+VU9WCpXR7e4FqISTyFj5A3Cfm3WR1M=; b=NLp9o+ijvRO7feyaREs6FtZBt0O2EoSSBWr322vwi2WLiBTis7XdwWRdnP1uuSa2rN9+AqNMSWBkI/1eASaQFsslFqO/0UZkD8fHyqFkP3W7cKwlTNRqWkraVFx0awcBwUMJWBLNNHpw8OK3zeOwe2s/EXLkFFi2Qkw/qcge0nU= Received: from DM6PR11MB2890.namprd11.prod.outlook.com (2603:10b6:5:63::20) by DM6PR11MB4705.namprd11.prod.outlook.com (2603:10b6:5:2a9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Wed, 28 Apr 2021 13:29:30 +0000 Received: from DM6PR11MB2890.namprd11.prod.outlook.com ([fe80::c448:f9a0:c163:8a6c]) by DM6PR11MB2890.namprd11.prod.outlook.com ([fe80::c448:f9a0:c163:8a6c%7]) with mapi id 15.20.4065.027; Wed, 28 Apr 2021 13:29:30 +0000 From: "Iremonger, Bernard" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Kantecki, Tomasz" , "Richardson, Bruce" , "thomas@monjalon.net" Thread-Topic: [PATCH v2 1/3] examples/flow_classify: fix check of port and core Thread-Index: AQHXNnwLajFTo1E5hUGyGcTQu7ktKarJ9w5Q Date: Wed, 28 Apr 2021 13:29:30 +0000 Message-ID: References: <1616830818-3127-1-git-send-email-humin29@huawei.com> <1618988423-5034-1-git-send-email-humin29@huawei.com> <1618988423-5034-2-git-send-email-humin29@huawei.com> In-Reply-To: <1618988423-5034-2-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.45.108.187] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 932b7082-7937-4fa7-8220-08d90a49a750 x-ms-traffictypediagnostic: DM6PR11MB4705: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NefbDBdBNKyZgwGomsFH4a5bBbCemPy0PccgetpzGC9OYaq36zXDj21Cs/moP3yi2IAMtazq5sz7QwHwU6jW4Xqi3LkHP7GnXVq/K0MnaaAyaCZ6bCjbUGT6/nLrdklc9lpuCjiHPkUEjS3URBm/yVRvu7Dv0pDPRZixml4uRfSekD4X/0hxGV/ZuuwPI5L9kHeFtpbVXXf8FYN9cGZvClGvZNVdW0/H5tx/oXp3d+1avq+4I3iMEzjsSiWuJDy4KLwwJy5bAssx9jmErGTEPCeSLT94+nkvEThD6jpPJ2k+VbyjUK4LyiP0Z2nvMzJjAdK780DGHa5DJeBENP1f4WhDXmLvT6L41k9pqscUYDVo5QAHLL9yOGc7r5IOCtwKBy41925RVgjNrsB3O37lYPgW51npGFjy0Qu3dccYWBHW3dmjs7cy8lz4bGTQEMkl+bp45PGc23e3Xm+NWs4dwz8uQYG1uPB2ku6vyXS10QVr/zc/dwOU34IRyHJ13AKo6YXFqMgpROCvp31/VRb9+itbHSn+RI1BsnF6k0I5fdN9ynjf8K7tNWtwV/NgOAit1+vndjcLsh1vUf8KXnhQvVirTI6+5h37SDC834qCwas= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2890.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39860400002)(366004)(346002)(136003)(396003)(38100700002)(86362001)(53546011)(122000001)(66476007)(71200400001)(66556008)(52536014)(5660300002)(33656002)(66446008)(76116006)(66946007)(9686003)(64756008)(6506007)(55016002)(110136005)(83380400001)(54906003)(8936002)(316002)(478600001)(8676002)(186003)(2906002)(4326008)(26005)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?w+DnfUkW3qgZDAnKPADCrpzTG31nu9Z+B/uDAK/7H8InzZfM5fQ18J6H+7Xy?= =?us-ascii?Q?46uZddPZb++/3nuv5eIxFRS/wYkyLtJnEew8Z+/VByJt5YO05SBgfI4MQVqv?= =?us-ascii?Q?DwVWqbdodt1YlxiHo4KIrHRnkv1q21v2vjBHQb2UDGVl4HoEr9R9tv/8L4CR?= =?us-ascii?Q?sC1dajYCCBTo9N3fUa0/p7E1CB7/NyczOxuiYeV/nBbtrKlt74okDaVq/A4d?= =?us-ascii?Q?uZzC+UP+YeT9KsreImCNPGugsAngQWZjiK64Sbggg6pUO619wqA0SY/zm95d?= =?us-ascii?Q?VF5Ke2Lx0u9RzDMsVfO9oCc87FyzAcfXvEJwPO4ZMYkiVD2Zz2TD2qCXUxwP?= =?us-ascii?Q?qhGu/zvvTFOQnVyQ2macTgZQSF+OWyWid+SZW3vcTiAX4zZqk6ik0Bho0yIi?= =?us-ascii?Q?6rTf4jy79P+kj8nuDF3XfrzpbClB5G1QrZfsL4a/x9TSMG6cUuuuPeCImNyi?= =?us-ascii?Q?Q6FLp8Fd31xoVweVemAmd1NswiBk1nv4wzVRVOoSTCucEs6ttuWrVn572UPj?= =?us-ascii?Q?BiOMtS2UBaH7V3EF8+8jXzWC02Nv4ddFDS18eOz63jitFuOXAc4nI+kU9d+I?= =?us-ascii?Q?v3ehXxkPA7QYa1ZSz0WYFH3nOCJdPGnnSFU0GtyOtRfbp8gBP5ekozzu7C+c?= =?us-ascii?Q?pbWrpkD75aAY30cWrawrYBu7SCPXzJL74VxEJuAHyxjXlLG4iYWToGxkye74?= =?us-ascii?Q?tGGZgsk3xtXl8SSAdm38HF1c4jrTevfPmo8fXK4rs3lHO+Oirs0YbUXL7Ty5?= =?us-ascii?Q?0pEZ3d2TkNgBdIhztRH7JU3Ae/x7Xar+Fzf5kS1Sl1EpO/qcWKHERToiDFfQ?= =?us-ascii?Q?RhkkQZWdr1lk7AGQjBP6bfJ7a3FjzAbUYvd18B2aIY39YLVWS8xg4CvbDDDN?= =?us-ascii?Q?lvcDDwMI1tJE94eG4otPjiwuFFeE3V1KlIJdsFsNeU1Yv1T0DBnCEQAwBC4m?= =?us-ascii?Q?dwhkCAlJfdxCOcnF+CmRutVwo6FgynIrtmBO91LW07ZZITLYzEF0NqkqLCm3?= =?us-ascii?Q?3YSk8MP3+w1b5WGK+BWHT+Tli65OCyKgdy9iWsVseQ3fXGY3eollEFZmsTFx?= =?us-ascii?Q?7hZ3nDgqfkNV6mXMyurOhN6kHLK3+sHxnXhvdfEcJT8gA7f1VdLH0rpYZvzj?= =?us-ascii?Q?Dib3eAEoL9vCz76+3tmS4NzRhnlH8XyXLK/HysQv0k1a6MbyC0sOVuu46bty?= =?us-ascii?Q?WiZdQxKDUbYUG1r0WxRecYkGlpp06gRBu0DBzTBkaZ0JvDkSn8S2t1W84spr?= =?us-ascii?Q?Oq0JU2rztUiLCVJJsyErcbKZfD03RXZF+pTjKHrGTGTYygcILrDjVWTJsXSM?= =?us-ascii?Q?3hgwNsBRT9rcXWG83Gzilf5c?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2890.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 932b7082-7937-4fa7-8220-08d90a49a750 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2021 13:29:30.4737 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: C3gNVCoueL6v6dnz035yAbMGugnq/tP9uWUz8Zm495PcP6Dcm3U1fowx/mwbvnN0D1nwUG1uqF9mmFuoXJf6ki5/EZ31QsnNvOb6NS5SKUQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4705 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/3] examples/flow_classify: fix check of port and core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Min, > -----Original Message----- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 8:00 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Iremonger, Bernard > ; Kantecki, Tomasz > ; Richardson, Bruce > ; thomas@monjalon.net > Subject: [PATCH v2 1/3] examples/flow_classify: fix check of port and cor= e >=20 > According to the comments and logging, the author just hope user to use t= he > core and device which are in the same numa node for optimal performance. > If not, A warning gives out. >=20 > For example in flow_classify: > ./build/flow_classify -w 0000:7d:00.1 -l 93 The EAL option "-w" has been replaced by the "-a" option in dpdk-20.05 > Here: > 0000:7d:00.1 is on numa node 0. > core 93 is on numa node 3. >=20 > The two are not in same numa node, but no warning gives out in old codes. >=20 > This patch can fix it. >=20 > Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") > Cc: stable@dpdk.org >=20 > Signed-off-by: Min Hu (Connor) > --- > examples/flow_classify/flow_classify.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/flow_classify/flow_classify.c > b/examples/flow_classify/flow_classify.c > index 335d7d2..277a2f5 100644 > --- a/examples/flow_classify/flow_classify.c > +++ b/examples/flow_classify/flow_classify.c > @@ -284,7 +284,7 @@ lcore_main(struct flow_classifier *cls_app) > * for best performance. > */ > RTE_ETH_FOREACH_DEV(port) > - if (rte_eth_dev_socket_id(port) > 0 && > + if (rte_eth_dev_socket_id(port) >=3D 0 && > rte_eth_dev_socket_id(port) !=3D (int)rte_socket_id()) > { > printf("\n\n"); > printf("WARNING: port %u is on remote NUMA > node\n", > -- > 2.7.4 Tested-by: Bernard Iremonger