From: "Zhang, Tianfei" <tianfei.zhang@intel.com>
To: "Huang, Wei" <wei.huang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>, "Huang, Wei" <wei.huang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: check pointer adapter before derefence
Date: Thu, 5 Nov 2020 09:35:47 +0000 [thread overview]
Message-ID: <DM6PR11MB313166DEB9D8BD9B1022B883E3EE0@DM6PR11MB3131.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1604540969-5503-3-git-send-email-wei.huang@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wei Huang
> Sent: 2020年11月5日 9:49
> To: dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: stable@dpdk.org; Huang, Wei <wei.huang@intel.com>
> Subject: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: check pointer adapter
> before derefence
>
> In opae_adapter_destroy(), pointer "adapter" is not validated before passing
> it to opae_adapter_shm_free() and opae_adapter_mutex_close() which
> derefence it.
>
> Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in
> multi-process") Coverity issue: 363752
>
> Signed-off-by: Wei Huang <wei.huang@intel.com>
> ---
> drivers/raw/ifpga/base/opae_hw_api.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/raw/ifpga/base/opae_hw_api.c
> b/drivers/raw/ifpga/base/opae_hw_api.c
> index 600afdea1..d5cd5fe60 100644
> --- a/drivers/raw/ifpga/base/opae_hw_api.c
> +++ b/drivers/raw/ifpga/base/opae_hw_api.c
> @@ -605,10 +605,12 @@ int opae_adapter_enumerate(struct opae_adapter
> *adapter)
> */
> void opae_adapter_destroy(struct opae_adapter *adapter) {
> - if (adapter && adapter->ops && adapter->ops->destroy)
> - adapter->ops->destroy(adapter);
> - opae_adapter_shm_free(adapter);
> - opae_adapter_mutex_close(adapter);
> + if (adapter) {
> + if (adapter->ops && adapter->ops->destroy)
> + adapter->ops->destroy(adapter);
> + opae_adapter_shm_free(adapter);
> + opae_adapter_mutex_close(adapter);
> + }
> }
Acked-by: Tianfei zhang <tianfei.zhang@intel.com>
prev parent reply other threads:[~2020-11-05 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 1:49 [dpdk-dev] [PATCH v1 0/2] Fix defects found by coverity scan Wei Huang
2020-11-05 1:49 ` [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: unlock mutex when nios init fail Wei Huang
2020-11-05 9:33 ` Zhang, Tianfei
2020-11-05 1:49 ` [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: check pointer adapter before derefence Wei Huang
2020-11-05 9:35 ` Zhang, Tianfei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB313166DEB9D8BD9B1022B883E3EE0@DM6PR11MB3131.namprd11.prod.outlook.com \
--to=tianfei.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.