Re: [igt-dev] [PATCH i-g-t v2] tests/kms_lease: Add subtest description

["Hagaragi, Arundhati" <arundhati.hagaragi@intel.com>]

-----Original Message-----
From: Latvala, Petri <petri.latvala@intel.com> 
Sent: Monday, May 17, 2021 2:48 PM
To: Hagaragi, Arundhati <arundhati.hagaragi@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/kms_lease: Add subtest description

On Thu, May 13, 2021 at 01:48:32PM +0530, Arundhati Hagaragi wrote:
> Added description for subtest
> 
> Signed-off-by: Arundhati Hagaragi <arundhati.hagaragi@intel.com>
> Cc: B S Karthik <karthik.b.s@intel.com>
> 
> v2: Modified & applied description to each tests seperately. (Petri)
> ---
>  tests/kms_lease.c | 35 +++++++++++++++++++++--------------
>  1 file changed, 21 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c index 
> 6397ef8f..0c019a46 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -1281,21 +1281,27 @@ igt_main
>  	const struct {
>  		const char *name;
>  		void (*func)(data_t *);
> +		const char *desc;
>  	} funcs[] = {
> -		{ "simple_lease", simple_lease },
> -		{ "lessee_list", lessee_list },
> -		{ "lease_get", lease_get },
> -		{ "lease_unleased_connector", lease_unleased_connector },
> -		{ "lease_unleased_crtc", lease_unleased_crtc },
> -		{ "lease_revoke", lease_revoke },
> -		{ "lease_again", lease_again },
> -		{ "lease_invalid_connector", lease_invalid_connector },
> -		{ "lease_invalid_crtc", lease_invalid_crtc },
> -		{ "lease_invalid_plane", lease_invalid_plane },
> -		{ "page_flip_implicit_plane", page_flip_implicit_plane },
> -		{ "setcrtc_implicit_plane", setcrtc_implicit_plane },
> -		{ "cursor_implicit_plane", cursor_implicit_plane },
> -		{ "atomic_implicit_crtc", atomic_implicit_crtc },
> +		{ "simple_lease", simple_lease, "Check if create lease ioctl call works correctly" },
> +		{ "lessee_list", lessee_list, "Check if listed lease is same as corrected one" },
> +		{ "lease_get", lease_get, "Tests getting the required contents of a lease" },
> +		{ "lease_unleased_connector", lease_unleased_connector, "Check if func fails on an"
> +			"unleased connector" },
> +		{ "lease_unleased_crtc", lease_unleased_crtc, "Check if func fails on unleased crtc" },
> +		{ "lease_revoke", lease_revoke, "Tests revocation of lease" },
> +		{ "lease_again", lease_again, "Tests leasing objects more than once" },
> +		{ "lease_invalid_connector", lease_invalid_connector, "Tests leasing an invalid connector" },
> +		{ "lease_invalid_crtc", lease_invalid_crtc, "Tests leasing an invalid crtc" },
> +		{ "lease_invalid_plane", lease_invalid_plane, "Tests leasing an invalid plane" },
> +		{ "page_flip_implicit_plane", page_flip_implicit_plane, "Check that page-flip ioclt"
> +			"fails correctly on implicit primary plane" },
> +		{ "setcrtc_implicit_plane", setcrtc_implicit_plane, "Check that setcrtc ioctl fails"
> +			"correctly on implicit primary plane" },
> +		{ "cursor_implicit_plane", cursor_implicit_plane, "Check that setcursor ioctl fails"
> +			"correctly on implicit primary plane" },
> +		{ "atomic_implicit_crtc", atomic_implicit_crtc, "Check that atomic ioctl fails correctly"
> +			"on crtc_id property" },

When splitting strings to multiple lines, make sure you still add the space between words. For example cursor_implicit_plane will have "failscorrectly" with this.

--
Petri Latvala


Sure , Will take care of this.

Thanks,
Arundhati
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev