From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D4FC33CAD for ; Mon, 13 Jan 2020 11:56:29 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1F1D42084D for ; Mon, 13 Jan 2020 11:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="wVhuL40t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F1D42084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53DD21D170; Mon, 13 Jan 2020 12:56:26 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 16D001D170 for ; Mon, 13 Jan 2020 12:56:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 03:56:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="218647193" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga007.fm.intel.com with ESMTP; 13 Jan 2020 03:56:22 -0800 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 03:56:22 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX160.amr.corp.intel.com (10.22.226.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 03:56:22 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 13 Jan 2020 03:56:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dMfg1jg7dazl/rAKco0np/Xz+U7il10MXkJfbncEFU92e2TUztKHabcsaOdsMU4qu5IIAKSskj3gTWkhCJxGoo5q+jazcgAzwIHaa/OsO6aN6Lpq2wDlYoH4AV02clGZduxkZC+q+Qrx+xzlnb0UUUKTFUAzHEKhxNelIGYYgBPHaWUNHOWd6myS2/ML///YLvI1rgrFChVGi7/pTOHUEhRKVVyv6YnlX7TIDH4ArI69dx7puEuy2e6Iv5LZXvrTojBktmkvUpHAdphEtE+j/wHwvbSdN3M8lDZjPIazqNzWbJaBrYIL73/s4ei5AtJUIOXTMg4zGGeVY0teyI6IUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TybPltixblGrZePf2/yzxThfBVpwVt+FFNeKK7x/8+Y=; b=DcL9LHIQZ3Hv4nMfQ4cLNAEo2+td6eIw1xgVizUTFVvxa59jlZBZSjZ+k1bCqIUaHlilzWSU8rx52sKU2iHXSpULMyoCwN09kyyrZQycMO+Zn8ZKh7ZgsSU9WBnD97c2R0pQTc/dnT7oHPlOUKZf/zRv4LhTtgBKEtlXvVBovwDZw4tuFXC3Em+bY9Gr8fFdVJDz91ULgMgiGOmT3d1sMeuNv2zPGvUodM+BFGUN4wFctKYBqyHhEM5p+j2jKTYpgaAWiYlNzxDiBtqzaYLYCeq3iXdcgy2EMwTIHnEXLZQDzGOa9v1KdjnTzD4fXwxmADqoDJDc/j5WzS+DP1rZeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TybPltixblGrZePf2/yzxThfBVpwVt+FFNeKK7x/8+Y=; b=wVhuL40tDZL90nNDoUMCj4wLDdEXwovvkeV387jJpvTVRYgbL7vIWp/LBFOe25XEAyT1ivVZXAqWDXGMidjZj7YtrVrvN8JSpKqPzX06ZXKUDRljxodet+Bk/QpHcsxo/wInSKFmh9KGXOI65EGgBfkXaTFE/plxAygEN6n8n6A= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (20.176.126.24) by DM6PR11MB3483.namprd11.prod.outlook.com (20.176.123.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.10; Mon, 13 Jan 2020 11:56:19 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26%6]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 11:56:19 +0000 From: "Iremonger, Bernard" To: "Zhang, Qi Z" , "dev@dpdk.org" , "Xing, Beilei" , "Doherty, Declan" CC: "Ananyev, Konstantin" , "Byrne, Stephen1" , "Zhang, Helin" Thread-Topic: [PATCH v3 5/9] net/i40e: process ESP flows Thread-Index: AQHVxubCreckpTLpl0qVPla5XUzeqKfiXIuAgAYmAFA= Date: Mon, 13 Jan 2020 11:56:19 +0000 Message-ID: References: <1576577756-648-1-git-send-email-bernard.iremonger@intel.com> <1578572194-594-6-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E7061153E0219A@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153E0219A@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzY5YzU2OTctOThmNS00ODkyLThkNTYtYzJhMjk4ZDJlOGMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC8yUmJ0azFMaElCN0Uya0ttd1RiVWdKNm9RV2Nmdk4wVCsxNjIzMUlCK2xjVlhzbkZyZHlnaVVFRDdlMkVTU0kifQ== dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.160] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a5cefb4d-71ea-4199-6e18-08d7981f9a79 x-ms-traffictypediagnostic: DM6PR11MB3483: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:483; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(366004)(396003)(39860400002)(346002)(136003)(199004)(189003)(54906003)(66476007)(76116006)(66556008)(5660300002)(110136005)(107886003)(71200400001)(316002)(55016002)(2906002)(8936002)(66946007)(30864003)(52536014)(64756008)(66446008)(9686003)(6636002)(53546011)(6506007)(26005)(33656002)(7696005)(186003)(4326008)(86362001)(81156014)(8676002)(81166006)(478600001)(579004)(559001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB3483; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1FOFYHtnWO7kPs6X+FHPrk93zD0UpNTI4dmotR4Owpz4YUtpEp1HrToO4wykuzAtcnrx3AqSpANHpqryrPMy8HuNr0P5qwCzbHGjQO16KOMOvYZulz6bGh5SAXnVziGAhhIdsVlcxxePObxgEnKnConmPft0Sxo727+SSfDfRL2hJ+waxyZKzrs/pJ8SRQkPOs/lMkqHBgwET2/8W0ENtc51eZvauOiNVeixrvEyXwFxQ1RZH7H0S3c5Mz2Kz7U+ynoVvZzma3hDnFFWHYrp3NKi7eLXiZXbeqFZK/ippjdjTny3FpZEjgXb3fPAUNSI/tLadSvuy8gt7Fchmxa7C87IhMRCEMl/xbhzbWCso2BnGE460kFawaFGoqLT0O5wsbY3Yoj5Tl3ysAL0NRhi+0Ref6w+r1+EBlhr6k1GmRct652bEe7IZwU5uXMSbN5y Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a5cefb4d-71ea-4199-6e18-08d7981f9a79 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 11:56:19.8142 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2dyS9pHLSL7TQforf+3muE1mt5FGj17/28hiqgyWcIT53Xs4PSUCyPAm5Yr5E7gWqpClefhWGKQknXEKIQVck6dk0w/fhtiobatCwtN1SUI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3483 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 5/9] net/i40e: process ESP flows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, January 9, 2020 2:01 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 5/9] net/i40e: process ESP flows >=20 > Hi Bernard: >=20 > > -----Original Message----- > > From: Iremonger, Bernard > > Sent: Thursday, January 9, 2020 8:17 PM > > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, > > Stephen1 ; Zhang, Helin > > ; Iremonger, Bernard > > > > Subject: [PATCH v3 5/9] net/i40e: process ESP flows > > > > Process ESP flows on Flow Director and RSS. > > > > add eth/ipv4/esp and eth/ipv6/esp patterns add eth/ipv4/udp/esp and > > eth/ipv6/esp/udp patterns add flow structures for above patterns > > update > > i40e_flow_parse_fdir_filter() add i40e_flow_set_filter_spi() add > > fill_ip6_head() add oip_type in filter add is_udp in filter use > > tenant_id in filter for spi handle ESP and AH pctypes in ESP-AH > > profile update customized code for ESP hardcode udp destination port > > to 4500 >=20 > Looks like the patch could be separate into 3 parts for easy review. >=20 > One is for the DDP package process, (rte_pmd_i40e_process_ddp_package - > > i40e_update_customized_info -> i40e_update_customized_pctype One is > for fdir related - training packet construction .. etc. > And one for adding all rte_flow parser >=20 > Regards > Qi I have refactored this patch into 4 patches in the v4 patchset. >=20 > > > > Signed-off-by: Bernard Iremonger > > --- > > drivers/net/i40e/i40e_ethdev.c | 44 +++++++++++++- > > drivers/net/i40e/i40e_ethdev.h | 38 ++++++++++++ > > drivers/net/i40e/i40e_fdir.c | 128 > > +++++++++++++++++++++++++++++++++++--- > > drivers/net/i40e/i40e_flow.c | 135 > > ++++++++++++++++++++++++++++++++++++++++- > > 4 files changed, 332 insertions(+), 13 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 5f1cf8a..a462eba 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -1106,6 +1106,7 @@ i40e_init_customized_info(struct i40e_pf *pf) > > } > > > > pf->gtp_support =3D false; > > + pf->esp_support =3D false; > > } > > > > void > > @@ -12337,6 +12338,7 @@ i40e_update_customized_pctype(struct > > rte_eth_dev *dev, uint8_t *pkg, > > } > > } > > name[strlen(name) - 1] =3D '\0'; > > + PMD_DRV_LOG(INFO, "name =3D %s\n", name); > > if (!strcmp(name, "GTPC")) > > new_pctype =3D > > i40e_find_customized_pctype(pf, > > @@ -12353,6 +12355,30 @@ i40e_update_customized_pctype(struct > > rte_eth_dev *dev, uint8_t *pkg, > > new_pctype =3D > > i40e_find_customized_pctype(pf, > > > I40E_CUSTOMIZED_GTPU); > > + else if (!strcmp(name, "IPV4_ESP")) > > + new_pctype =3D > > + i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_ESP_IPV4); > > + else if (!strcmp(name, "IPV6_ESP")) > > + new_pctype =3D > > + i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_ESP_IPV6); > > + else if (!strcmp(name, "IPV4_UDP_ESP")) > > + new_pctype =3D > > + i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_ESP_IPV4_UDP); > > + else if (!strcmp(name, "IPV6_UDP_ESP")) > > + new_pctype =3D > > + i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_ESP_IPV6_UDP); > > + else if (!strcmp(name, "IPV4_AH")) > > + new_pctype =3D > > + i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_AH_IPV4); > > + else if (!strcmp(name, "IPV6_AH")) > > + new_pctype =3D > > + i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_AH_IPV6); > > if (new_pctype) { > > if (op =3D=3D RTE_PMD_I40E_PKG_OP_WR_ADD) { > > new_pctype->pctype =3D pctype_value; @@ - > 12448,6 +12474,7 @@ > > i40e_update_customized_ptype(struct > > rte_eth_dev *dev, uint8_t *pkg, > > continue; > > memset(name, 0, sizeof(name)); > > strcpy(name, proto[n].name); > > + PMD_DRV_LOG(INFO, "name =3D %s\n", > name); > > if (!strncasecmp(name, "PPPOE", 5)) > > ptype_mapping[i].sw_ptype |=3D > > > RTE_PTYPE_L2_ETHER_PPPOE; > > @@ -12541,6 +12568,10 @@ i40e_update_customized_ptype(struct > > rte_eth_dev *dev, uint8_t *pkg, > > ptype_mapping[i].sw_ptype |=3D > > RTE_PTYPE_TUNNEL_GTPU; > > in_tunnel =3D true; > > + } else if (!strncasecmp(name, "ESP", 3)) { > > + ptype_mapping[i].sw_ptype |=3D > > + RTE_PTYPE_TUNNEL_ESP; > > + in_tunnel =3D true; > > } else if (!strncasecmp(name, "GRENAT", 6)) { > > ptype_mapping[i].sw_ptype |=3D > > > RTE_PTYPE_TUNNEL_GRENAT; > > @@ -12560,7 +12591,7 @@ i40e_update_customized_ptype(struct > > rte_eth_dev *dev, uint8_t *pkg, > > ret =3D rte_pmd_i40e_ptype_mapping_update(port_id, > ptype_mapping, > > ptype_num, 0); > > if (ret) > > - PMD_DRV_LOG(ERR, "Failed to update mapping table."); > > + PMD_DRV_LOG(ERR, "Failed to update ptype mapping > table."); > > > > rte_free(ptype_mapping); > > rte_free(ptype); > > @@ -12625,6 +12656,17 @@ i40e_update_customized_info(struct > > rte_eth_dev *dev, uint8_t *pkg, > > } > > } > > > > + /* Check if ESP is supported. */ > > + for (i =3D 0; i < proto_num; i++) { > > + if (!strncmp(proto[i].name, "ESP", 3)) { > > + if (op =3D=3D RTE_PMD_I40E_PKG_OP_WR_ADD) > > + pf->esp_support =3D true; > > + else > > + pf->esp_support =3D false; > > + break; > > + } > > + } > > + > > /* Update customized pctype info */ > > ret =3D i40e_update_customized_pctype(dev, pkg, pkg_size, > > proto_num, proto, op); > > diff --git a/drivers/net/i40e/i40e_ethdev.h > > b/drivers/net/i40e/i40e_ethdev.h index 295ad59..792a047 100644 > > --- a/drivers/net/i40e/i40e_ethdev.h > > +++ b/drivers/net/i40e/i40e_ethdev.h > > @@ -501,6 +501,29 @@ struct i40e_gtp_ipv6_flow { > > struct rte_eth_ipv6_flow ip6; > > }; > > > > +/* A structure used to define the input for ESP IPV4 flow */ struct > > +i40e_esp_ipv4_flow { > > + struct rte_eth_ipv4_flow ipv4; > > + uint32_t spi; /* SPI in big endian. */ > > +}; > > + > > +/* A structure used to define the input for ESP IPV6 flow */ struct > > +i40e_esp_ipv6_flow { > > + struct rte_eth_ipv6_flow ipv6; > > + uint32_t spi; /* SPI in big endian. */ > > +}; > > +/* A structure used to define the input for ESP IPV4 UDP flow */ > > +struct i40e_esp_ipv4_udp_flow { > > + struct rte_eth_udpv4_flow udp; > > + uint32_t spi; /* SPI in big endian. */ > > +}; > > + > > +/* A structure used to define the input for ESP IPV6 UDP flow */ > > +struct i40e_esp_ipv6_udp_flow { > > + struct rte_eth_udpv6_flow udp; > > + uint32_t spi; /* SPI in big endian. */ > > +}; > > + > > /* A structure used to define the input for raw type flow */ struct > > i40e_raw_flow { > > uint16_t pctype; > > @@ -526,6 +549,10 @@ union i40e_fdir_flow { > > struct i40e_gtp_ipv4_flow gtp_ipv4_flow; > > struct i40e_gtp_ipv6_flow gtp_ipv6_flow; > > struct i40e_raw_flow raw_flow; > > + struct i40e_esp_ipv4_flow esp_ipv4_flow; > > + struct i40e_esp_ipv6_flow esp_ipv6_flow; > > + struct i40e_esp_ipv4_udp_flow esp_ipv4_udp_flow; > > + struct i40e_esp_ipv6_udp_flow esp_ipv6_udp_flow; > > }; > > > > enum i40e_fdir_ip_type { > > @@ -542,8 +569,10 @@ struct i40e_fdir_flow_ext { > > uint16_t dst_id; /* VF ID, available when is_vf is 1*/ > > bool inner_ip; /* If there is inner ip */ > > enum i40e_fdir_ip_type iip_type; /* ip type for inner ip */ > > + enum i40e_fdir_ip_type oip_type; /* ip type for outer ip */ > > bool customized_pctype; /* If customized pctype is used */ > > bool pkt_template; /* If raw packet template is used */ > > + bool is_udp; /* ipv4|ipv6 udp flow */ > > }; > > > > /* A structure used to define the input for a flow director filter > > entry */ @@ > > -769,6 +798,8 @@ enum i40e_tunnel_type { > > I40E_TUNNEL_TYPE_QINQ, > > I40E_TUNNEL_TYPE_GTPC, > > I40E_TUNNEL_TYPE_GTPU, > > + I40E_TUNNEL_TYPE_ESPoUDP, > > + I40E_TUNNEL_TYPE_ESPoIP, > > I40E_TUNNEL_TYPE_MAX, > > }; > > > > @@ -897,6 +928,12 @@ enum i40e_new_pctype { > > I40E_CUSTOMIZED_GTPU_IPV4, > > I40E_CUSTOMIZED_GTPU_IPV6, > > I40E_CUSTOMIZED_GTPU, > > + I40E_CUSTOMIZED_ESP_IPV4, > > + I40E_CUSTOMIZED_ESP_IPV6, > > + I40E_CUSTOMIZED_ESP_IPV4_UDP, > > + I40E_CUSTOMIZED_ESP_IPV6_UDP, > > + I40E_CUSTOMIZED_AH_IPV4, > > + I40E_CUSTOMIZED_AH_IPV6, > > I40E_CUSTOMIZED_MAX, > > }; > > > > @@ -1001,6 +1038,7 @@ struct i40e_pf { > > > > /* Dynamic Device Personalization */ > > bool gtp_support; /* 1 - support GTP-C and GTP-U */ > > + bool esp_support; /* 1 - support ESP SPI */ > > /* customer customized pctype */ > > struct i40e_customized_pctype > > customized_pctype[I40E_CUSTOMIZED_MAX]; > > /* Switch Domain Id */ > > diff --git a/drivers/net/i40e/i40e_fdir.c > > b/drivers/net/i40e/i40e_fdir.c index > > dee007d..3fa6297 100644 > > --- a/drivers/net/i40e/i40e_fdir.c > > +++ b/drivers/net/i40e/i40e_fdir.c > > @@ -54,6 +54,8 @@ > > #define I40E_FDIR_GTP_MSG_TYPE_0X01 0x01 > > #define I40E_FDIR_GTP_MSG_TYPE_0XFF 0xFF > > > > +#define I40E_FDIR_ESP_DST_PORT 4500 > > + > > /* Wait time for fdir filter programming */ #define > > I40E_FDIR_MAX_WAIT_US 10000 > > > > @@ -971,6 +973,37 @@ i40e_flow_fdir_find_customized_pctype(struct > > i40e_pf *pf, uint8_t pctype) } > > > > static inline int > > +fill_ip6_head(const struct i40e_fdir_input *fdir_input, unsigned char > > *raw_pkt, > > + uint8_t next_proto, uint8_t len, uint16_t *ether_type) { > > + struct rte_ipv6_hdr *ip6; > > + > > + ip6 =3D (struct rte_ipv6_hdr *)raw_pkt; > > + > > + *ether_type =3D rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV6); > > + ip6->vtc_flow =3D > rte_cpu_to_be_32(I40E_FDIR_IPv6_DEFAULT_VTC_FLOW > > | > > + (fdir_input->flow.ipv6_flow.tc << > I40E_FDIR_IPv6_TC_OFFSET)); > > + ip6->payload_len =3D > rte_cpu_to_be_16(I40E_FDIR_IPv6_PAYLOAD_LEN); > > + ip6->proto =3D fdir_input->flow.ipv6_flow.proto ? > > + fdir_input->flow.ipv6_flow.proto : next_proto; > > + ip6->hop_limits =3D fdir_input->flow.ipv6_flow.hop_limits ? > > + fdir_input->flow.ipv6_flow.hop_limits : > > + I40E_FDIR_IPv6_DEFAULT_HOP_LIMITS; > > + /** > > + * The source and destination fields in the transmitted packet > > + * need to be presented in a reversed order with respect > > + * to the expected received packets. > > + */ > > + rte_memcpy(&ip6->src_addr, &fdir_input->flow.ipv6_flow.dst_ip, > > + IPV6_ADDR_LEN); > > + rte_memcpy(&ip6->dst_addr, &fdir_input->flow.ipv6_flow.src_ip, > > + IPV6_ADDR_LEN); > > + len +=3D sizeof(struct rte_ipv6_hdr); > > + > > + return len; > > +} > > + > > +static inline int > > i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf *pf, > > const struct i40e_fdir_input *fdir_input, > > unsigned char *raw_pkt, > > @@ -1045,16 +1078,29 @@ i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf > > *pf, > > ip->src_addr =3D fdir_input->flow.ip4_flow.dst_ip; > > ip->dst_addr =3D fdir_input->flow.ip4_flow.src_ip; > > > > - if (!is_customized_pctype) > > + if (!is_customized_pctype) { > > ip->next_proto_id =3D fdir_input->flow.ip4_flow.proto > ? > > fdir_input->flow.ip4_flow.proto : > > next_proto[fdir_input->pctype]; > > - else if (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPC || > > + len +=3D sizeof(struct rte_ipv4_hdr); > > + } else if (cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPC || > > cus_pctype->index =3D=3D > I40E_CUSTOMIZED_GTPU_IPV4 || > > cus_pctype->index =3D=3D > I40E_CUSTOMIZED_GTPU_IPV6 || > > - cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU) > > + cus_pctype->index =3D=3D I40E_CUSTOMIZED_GTPU) { > > ip->next_proto_id =3D IPPROTO_UDP; > > - len +=3D sizeof(struct rte_ipv4_hdr); > > + len +=3D sizeof(struct rte_ipv4_hdr); > > + } else if (cus_pctype->index =3D=3D > I40E_CUSTOMIZED_ESP_IPV4) { > > + ip->next_proto_id =3D IPPROTO_ESP; > > + len +=3D sizeof(struct rte_ipv4_hdr); > > + } else if (cus_pctype->index =3D=3D > I40E_CUSTOMIZED_ESP_IPV4_UDP) { > > + ip->next_proto_id =3D IPPROTO_UDP; > > + len +=3D sizeof(struct rte_ipv4_hdr); > > + } else if (cus_pctype->index =3D=3D > I40E_CUSTOMIZED_ESP_IPV6) > > + len =3D fill_ip6_head(fdir_input, raw_pkt, > IPPROTO_ESP, > > + len, ether_type); > > + else if (cus_pctype->index =3D=3D > I40E_CUSTOMIZED_ESP_IPV6_UDP) > > + len =3D fill_ip6_head(fdir_input, raw_pkt, > IPPROTO_UDP, > > + len, ether_type); > > } else if (pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV6_TCP || > > pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV6_UDP || > > pctype =3D=3D I40E_FILTER_PCTYPE_NONF_IPV6_SCTP || @@ > > -1088,8 +1134,7 @@ i40e_flow_fdir_fill_eth_ip_head(struct i40e_pf *pf, > > IPV6_ADDR_LEN); > > len +=3D sizeof(struct rte_ipv6_hdr); > > } else { > > - PMD_DRV_LOG(ERR, "unknown pctype %u.", > > - fdir_input->pctype); > > + PMD_DRV_LOG(ERR, "unknown pctype %u.", fdir_input- > >pctype); > > return -1; > > } > > > > @@ -1115,6 +1160,10 @@ i40e_flow_fdir_construct_pkt(struct i40e_pf > *pf, > > struct rte_flow_item_gtp *gtp; > > struct rte_ipv4_hdr *gtp_ipv4; > > struct rte_ipv6_hdr *gtp_ipv6; > > + struct rte_flow_item_esp *esp; > > + struct rte_ipv4_hdr *esp_ipv4; > > + struct rte_ipv6_hdr *esp_ipv6; > > + > > uint8_t size, dst =3D 0; > > uint8_t i, pit_idx, set_idx =3D I40E_FLXPLD_L4_IDX; /* use l4 by > default*/ > > int len; > > @@ -1285,10 +1334,71 @@ i40e_flow_fdir_construct_pkt(struct i40e_pf > *pf, > > } else > > payload =3D (unsigned char *)gtp + > > sizeof(struct rte_flow_item_gtp); > > + } else if (cus_pctype->index =3D=3D I40E_CUSTOMIZED_ESP_IPV4 > || > > + cus_pctype->index =3D=3D I40E_CUSTOMIZED_ESP_IPV6 > || > > + cus_pctype->index =3D=3D > I40E_CUSTOMIZED_ESP_IPV4_UDP || > > + cus_pctype->index =3D=3D > I40E_CUSTOMIZED_ESP_IPV6_UDP) { > > + if (cus_pctype->index =3D=3D > I40E_CUSTOMIZED_ESP_IPV4) { > > + esp_ipv4 =3D (struct rte_ipv4_hdr *) > > + (raw_pkt + len); > > + esp =3D (struct rte_flow_item_esp *)esp_ipv4; > > + esp->hdr.spi =3D > > + fdir_input->flow.esp_ipv4_flow.spi; > > + payload =3D (unsigned char *)esp + > > + sizeof(struct rte_esp_hdr); > > + len +=3D sizeof(struct rte_esp_hdr); > > + } else if (cus_pctype->index =3D=3D > > + I40E_CUSTOMIZED_ESP_IPV4_UDP) { > > + esp_ipv4 =3D (struct rte_ipv4_hdr *) > > + (raw_pkt + len); > > + udp =3D (struct rte_udp_hdr *)esp_ipv4; > > + udp->dst_port =3D rte_cpu_to_be_16 > > + (I40E_FDIR_ESP_DST_PORT); > > + > > + udp->dgram_len =3D rte_cpu_to_be_16 > > + > (I40E_FDIR_UDP_DEFAULT_LEN); > > + esp =3D (struct rte_flow_item_esp *) > > + ((unsigned char *)esp_ipv4 + > > + sizeof(struct rte_udp_hdr)); > > + esp->hdr.spi =3D > > + fdir_input- > >flow.esp_ipv4_udp_flow.spi; > > + payload =3D (unsigned char *)esp + > > + sizeof(struct rte_esp_hdr); > > + len +=3D sizeof(struct rte_udp_hdr) + > > + sizeof(struct rte_esp_hdr); > > + } else if (cus_pctype->index =3D=3D > > + I40E_CUSTOMIZED_ESP_IPV6) { > > + esp_ipv6 =3D (struct rte_ipv6_hdr *) > > + (raw_pkt + len); > > + esp =3D (struct rte_flow_item_esp *)esp_ipv6; > > + esp->hdr.spi =3D > > + fdir_input->flow.esp_ipv6_flow.spi; > > + payload =3D (unsigned char *)esp + > > + sizeof(struct rte_esp_hdr); > > + len +=3D sizeof(struct rte_esp_hdr); > > + } else if (cus_pctype->index =3D=3D > > + I40E_CUSTOMIZED_ESP_IPV6_UDP) { > > + esp_ipv6 =3D (struct rte_ipv6_hdr *) > > + (raw_pkt + len); > > + udp =3D (struct rte_udp_hdr *)esp_ipv6; > > + udp->dst_port =3D rte_cpu_to_be_16 > > + (I40E_FDIR_ESP_DST_PORT); > > + > > + udp->dgram_len =3D rte_cpu_to_be_16 > > + (I40E_FDIR_UDP_DEFAULT_LEN); > > + esp =3D (struct rte_flow_item_esp *) > > + ((unsigned char *)esp_ipv6 + > > + sizeof(struct rte_udp_hdr)); > > + esp->hdr.spi =3D > > + fdir_input- > >flow.esp_ipv6_udp_flow.spi; > > + payload =3D (unsigned char *)esp + > > + sizeof(struct rte_esp_hdr); > > + len +=3D sizeof(struct rte_udp_hdr) + > > + sizeof(struct rte_esp_hdr); > > + } > > } > > } else { > > - PMD_DRV_LOG(ERR, "unknown pctype %u.", > > - fdir_input->pctype); > > + PMD_DRV_LOG(ERR, "unknown pctype %u.", fdir_input- > >pctype); > > return -1; > > } > > > > @@ -1305,7 +1415,7 @@ i40e_flow_fdir_construct_pkt(struct i40e_pf *pf, > > &fdir_input->flow_ext.flexbytes[dst], > > size * sizeof(uint16_t)); > > } > > - > > + rte_hexdump(stdout, NULL, raw_pkt, len); > > return 0; > > } > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index 6102103..c585d8b 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -110,8 +110,7 @@ static int i40e_flow_destroy_tunnel_filter(struct > > i40e_pf *pf, static int i40e_flow_flush_fdir_filter(struct i40e_pf > > *pf); static int i40e_flow_flush_ethertype_filter(struct i40e_pf > > *pf); static int i40e_flow_flush_tunnel_filter(struct i40e_pf *pf); > > -static int -i40e_flow_flush_rss_filter(struct rte_eth_dev *dev); > > +static int i40e_flow_flush_rss_filter(struct rte_eth_dev *dev); > > static int > > i40e_flow_parse_qinq_filter(struct rte_eth_dev *dev, > > const struct rte_flow_attr *attr, @@ -1615,6 > +1614,36 @@ > > static enum rte_flow_item_type pattern_qinq_1[] =3D { > > RTE_FLOW_ITEM_TYPE_END, > > }; > > > > +static enum rte_flow_item_type pattern_fdir_ipv4_esp[] =3D { > > + RTE_FLOW_ITEM_TYPE_ETH, > > + RTE_FLOW_ITEM_TYPE_IPV4, > > + RTE_FLOW_ITEM_TYPE_ESP, > > + RTE_FLOW_ITEM_TYPE_END, > > +}; > > + > > +static enum rte_flow_item_type pattern_fdir_ipv6_esp[] =3D { > > + RTE_FLOW_ITEM_TYPE_ETH, > > + RTE_FLOW_ITEM_TYPE_IPV6, > > + RTE_FLOW_ITEM_TYPE_ESP, > > + RTE_FLOW_ITEM_TYPE_END, > > +}; > > + > > +static enum rte_flow_item_type pattern_fdir_ipv4_udp_esp[] =3D { > > + RTE_FLOW_ITEM_TYPE_ETH, > > + RTE_FLOW_ITEM_TYPE_IPV4, > > + RTE_FLOW_ITEM_TYPE_UDP, > > + RTE_FLOW_ITEM_TYPE_ESP, > > + RTE_FLOW_ITEM_TYPE_END, > > +}; > > + > > +static enum rte_flow_item_type pattern_fdir_ipv6_udp_esp[] =3D { > > + RTE_FLOW_ITEM_TYPE_ETH, > > + RTE_FLOW_ITEM_TYPE_IPV6, > > + RTE_FLOW_ITEM_TYPE_UDP, > > + RTE_FLOW_ITEM_TYPE_ESP, > > + RTE_FLOW_ITEM_TYPE_END, > > +}; > > + > > static struct i40e_valid_pattern i40e_supported_patterns[] =3D { > > /* Ethertype */ > > { pattern_ethertype, i40e_flow_parse_ethertype_filter }, @@ - > 1628,6 > > +1657,8 @@ static struct i40e_valid_pattern i40e_supported_patterns[] > > +=3D { > > { pattern_fdir_ipv4_gtpu, i40e_flow_parse_fdir_filter }, > > { pattern_fdir_ipv4_gtpu_ipv4, i40e_flow_parse_fdir_filter }, > > { pattern_fdir_ipv4_gtpu_ipv6, i40e_flow_parse_fdir_filter }, > > + { pattern_fdir_ipv4_esp, i40e_flow_parse_fdir_filter }, > > + { pattern_fdir_ipv4_udp_esp, i40e_flow_parse_fdir_filter }, > > { pattern_fdir_ipv6, i40e_flow_parse_fdir_filter }, > > { pattern_fdir_ipv6_udp, i40e_flow_parse_fdir_filter }, > > { pattern_fdir_ipv6_tcp, i40e_flow_parse_fdir_filter }, @@ -1636,6 > > +1667,8 @@ static struct i40e_valid_pattern i40e_supported_patterns[] > > +=3D { > > { pattern_fdir_ipv6_gtpu, i40e_flow_parse_fdir_filter }, > > { pattern_fdir_ipv6_gtpu_ipv4, i40e_flow_parse_fdir_filter }, > > { pattern_fdir_ipv6_gtpu_ipv6, i40e_flow_parse_fdir_filter }, > > + { pattern_fdir_ipv6_esp, i40e_flow_parse_fdir_filter }, > > + { pattern_fdir_ipv6_udp_esp, i40e_flow_parse_fdir_filter }, > > /* FDIR - support default flow type with flexible payload */ > > { pattern_fdir_ethertype_raw_1, i40e_flow_parse_fdir_filter }, > > { pattern_fdir_ethertype_raw_2, i40e_flow_parse_fdir_filter }, @@ > > -2420,6 +2453,28 @@ i40e_flow_fdir_get_pctype_value(struct i40e_pf *pf, > > cus_pctype =3D i40e_find_customized_pctype(pf, > > > I40E_CUSTOMIZED_GTPU_IPV6); > > break; > > + case RTE_FLOW_ITEM_TYPE_ESP: > > + if (!filter->input.flow_ext.is_udp) { > > + if (filter->input.flow_ext.oip_type =3D=3D > > + I40E_FDIR_IPTYPE_IPV4) > > + cus_pctype =3D > i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_ESP_IPV4); > > + else if (filter->input.flow_ext.oip_type =3D=3D > > + I40E_FDIR_IPTYPE_IPV6) > > + cus_pctype =3D > i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_ESP_IPV6); > > + } else { > > + if (filter->input.flow_ext.oip_type =3D=3D > > + I40E_FDIR_IPTYPE_IPV4) > > + cus_pctype =3D > i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_ESP_IPV4_UDP); > > + else if (filter->input.flow_ext.oip_type =3D=3D > > + I40E_FDIR_IPTYPE_IPV6) > > + cus_pctype =3D > i40e_find_customized_pctype(pf, > > + > I40E_CUSTOMIZED_ESP_IPV6_UDP); > > + filter->input.flow_ext.is_udp =3D false; > > + } > > + break; > > default: > > PMD_DRV_LOG(ERR, "Unsupported item type"); > > break; > > @@ -2431,6 +2486,30 @@ i40e_flow_fdir_get_pctype_value(struct i40e_pf > > *pf, > > return I40E_FILTER_PCTYPE_INVALID; > > } > > > > +static void > > +i40e_flow_set_filter_spi(struct i40e_fdir_filter_conf *filter, > > + const struct rte_flow_item_esp *esp_spec) { > > + if (filter->input.flow_ext.oip_type =3D=3D > > + I40E_FDIR_IPTYPE_IPV4) { > > + if (filter->input.flow_ext.is_udp) > > + filter->input.flow.esp_ipv4_udp_flow.spi =3D > > + esp_spec->hdr.spi; > > + else > > + filter->input.flow.esp_ipv4_flow.spi =3D > > + esp_spec->hdr.spi; > > + } > > + if (filter->input.flow_ext.oip_type =3D=3D > > + I40E_FDIR_IPTYPE_IPV6) { > > + if (filter->input.flow_ext.is_udp) > > + filter->input.flow.esp_ipv6_udp_flow.spi =3D > > + esp_spec->hdr.spi; > > + else > > + filter->input.flow.esp_ipv6_flow.spi =3D > > + esp_spec->hdr.spi; > > + } > > +} > > + > > /* 1. Last in item should be NULL as range is not supported. > > * 2. Supported patterns: refer to array i40e_supported_patterns. > > * 3. Default supported flow type and input set: refer to array @@ > > -2459,6 > > +2538,7 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, > > const struct rte_flow_item_udp *udp_spec, *udp_mask; > > const struct rte_flow_item_sctp *sctp_spec, *sctp_mask; > > const struct rte_flow_item_gtp *gtp_spec, *gtp_mask; > > + const struct rte_flow_item_esp *esp_spec, *esp_mask; > > const struct rte_flow_item_raw *raw_spec, *raw_mask; > > const struct rte_flow_item_vf *vf_spec; > > > > @@ -2654,10 +2734,18 @@ i40e_flow_parse_fdir_pattern(struct > > rte_eth_dev *dev, > > ipv4_spec->hdr.src_addr; > > filter->input.flow.ip4_flow.dst_ip =3D > > ipv4_spec->hdr.dst_addr; > > + > > + filter->input.flow_ext.inner_ip =3D false; > > + filter->input.flow_ext.oip_type =3D > > + I40E_FDIR_IPTYPE_IPV4; > > } else if (!ipv4_spec && !ipv4_mask && !outer_ip) { > > filter->input.flow_ext.inner_ip =3D true; > > filter->input.flow_ext.iip_type =3D > > I40E_FDIR_IPTYPE_IPV4; > > + } else if (!ipv4_spec && !ipv4_mask && outer_ip) { > > + filter->input.flow_ext.inner_ip =3D false; > > + filter->input.flow_ext.oip_type =3D > > + I40E_FDIR_IPTYPE_IPV4; > > } else if ((ipv4_spec || ipv4_mask) && !outer_ip) { > > rte_flow_error_set(error, EINVAL, > > > RTE_FLOW_ERROR_TYPE_ITEM, > > @@ -2716,6 +2804,10 @@ i40e_flow_parse_fdir_pattern(struct > rte_eth_dev > > *dev, > > filter->input.flow.ipv6_flow.hop_limits =3D > > ipv6_spec->hdr.hop_limits; > > > > + filter->input.flow_ext.inner_ip =3D false; > > + filter->input.flow_ext.oip_type =3D > > + I40E_FDIR_IPTYPE_IPV6; > > + > > rte_memcpy(filter- > >input.flow.ipv6_flow.src_ip, > > ipv6_spec->hdr.src_addr, 16); > > rte_memcpy(filter- > >input.flow.ipv6_flow.dst_ip, > > @@ -2729,6 +2821,10 @@ i40e_flow_parse_fdir_pattern(struct > rte_eth_dev > > *dev, > > filter->input.flow_ext.inner_ip =3D true; > > filter->input.flow_ext.iip_type =3D > > I40E_FDIR_IPTYPE_IPV6; > > + } else if (!ipv6_spec && !ipv6_mask && outer_ip) { > > + filter->input.flow_ext.inner_ip =3D false; > > + filter->input.flow_ext.oip_type =3D > > + I40E_FDIR_IPTYPE_IPV6; > > } else if ((ipv6_spec || ipv6_mask) && !outer_ip) { > > rte_flow_error_set(error, EINVAL, > > > RTE_FLOW_ERROR_TYPE_ITEM, > > @@ -2828,7 +2924,7 @@ i40e_flow_parse_fdir_pattern(struct > rte_eth_dev > > *dev, > > udp_spec->hdr.dst_port; > > } > > } > > - > > + filter->input.flow_ext.is_udp =3D true; > > layer_idx =3D I40E_FLXPLD_L4_IDX; > > > > break; > > @@ -2863,6 +2959,39 @@ i40e_flow_parse_fdir_pattern(struct > rte_eth_dev > > *dev, > > cus_proto =3D item_type; > > } > > break; > > + case RTE_FLOW_ITEM_TYPE_ESP: > > + if (!pf->esp_support) { > > + rte_flow_error_set(error, EINVAL, > > + > RTE_FLOW_ERROR_TYPE_ITEM, > > + item, > > + "Unsupported ESP > protocol"); > > + return -rte_errno; > > + } > > + > > + esp_spec =3D item->spec; > > + esp_mask =3D item->mask; > > + > > + if (!esp_spec || !esp_mask) { > > + rte_flow_error_set(error, EINVAL, > > + > RTE_FLOW_ERROR_TYPE_ITEM, > > + item, > > + "Invalid ESP item"); > > + return -rte_errno; > > + } > > + > > + if (esp_spec && esp_mask) { > > + if (esp_mask->hdr.spi !=3D UINT32_MAX) { > > + rte_flow_error_set(error, EINVAL, > > + > RTE_FLOW_ERROR_TYPE_ITEM, > > + item, > > + "Invalid ESP mask"); > > + return -rte_errno; > > + } > > + i40e_flow_set_filter_spi(filter, esp_spec); > > + filter->input.flow_ext.customized_pctype =3D > true; > > + cus_proto =3D item_type; > > + } > > + break; > > case RTE_FLOW_ITEM_TYPE_SCTP: > > sctp_spec =3D item->spec; > > sctp_mask =3D item->mask; > > -- > > 2.7.4 >=20 Regards, Bernard.