From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B74C282DD for ; Thu, 9 Jan 2020 14:03:09 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 7B5842075D for ; Thu, 9 Jan 2020 14:03:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="AXEVvv2l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B5842075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B27F91DDBF; Thu, 9 Jan 2020 15:03:08 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3C4FB1DDBD for ; Thu, 9 Jan 2020 15:03:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 06:02:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208";a="235040412" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 09 Jan 2020 06:02:49 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 06:02:49 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 06:02:49 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 06:02:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ieqOCQpdd4AIeT/MBzyxC3sRkSAGMU0baPcmqhWqB9ZNHI3sGYlzhRVl03RVDSQljuZ+6JLeNuk9dm6d8sQ0Q27QvPbMtEJdgUHQRnCzHX66mrs4m5f4lMQPp+R/u8UzL+ohHlfE93KI9jmnOi9mSdaj/dYzbMaH6hdeWiVu0TKSOIknBxEYBl42rg+la69Qn+UBLPa4VUKGwqcj+szgIuqVW0PBp/lVus6n+0dqCs5q1Q0HECmkq7QoEaE039Nhp9tTQjMD+WeN6QL5cfB3gfMU07QcI8pzqofZTlZ+F0rMcKnudnkj+OdgIuv9aI5C15OA/OzBg2iFcNqVUNd5Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5au9wjol4krUmgck1V3XRygY1MtJD/M1RG4unujiHr8=; b=SaPuVnDDKw+mAvC6H9S9Vni2etX7NHSb2JanQJw7mrFA8WafO9JJQ7A9HLSuSvqL/42TiLPJ7dPHvNjTGvZgVuSPc/XZ7sAbeDgyub4B1HzK3CSfa4dgbmTbnaOlmK3ruJS3lf8u0IxFREXz+wtZcCWze8Gw5Rf0TlVW9WUNxskVq2tM8qQ6YB0H8ScnHVz1absjyPhrUUmCQ0oD6vPnK/BnXd6IxjFAqkph89j0W/RXFleA5Fzuu6Gg6nbb46dFZNJ12lOwHhKs2/Qwl3vtGQtD6fy/1GCdB73w1kszm4PCh/BmfaLZmwGWr23057IP3+YuFelrDNVCSkeQxREQCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5au9wjol4krUmgck1V3XRygY1MtJD/M1RG4unujiHr8=; b=AXEVvv2l3Ibd/xfSQgWdUtr7Q+it4GKxDoQUKkcUHUuXr8VACoj7HBBRaU0L/SGmn+0vswGXW5rHA9nxa6J+GFEp5tRXvihTaK8iSiqw8jnYxh3LR4f+xOmMqX8EaJVYTXm9E/Tsl9KO0x1bvasd+eG3k35hoS55r59s+7ocVOA= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (20.176.126.24) by DM6PR11MB3401.namprd11.prod.outlook.com (20.176.119.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.10; Thu, 9 Jan 2020 14:02:47 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26%6]) with mapi id 15.20.2623.011; Thu, 9 Jan 2020 14:02:47 +0000 From: "Iremonger, Bernard" To: "Zhang, Qi Z" , "dev@dpdk.org" , "Xing, Beilei" , "Doherty, Declan" CC: "Ananyev, Konstantin" , "Byrne, Stephen1" , "Zhang, Helin" Thread-Topic: [PATCH v3 6/9] net/i40e: display Flow Director packet Thread-Index: AQHVxubLSbMHfVRhnEu28nil9pPxtKfiRzSAgAAU5AA= Date: Thu, 9 Jan 2020 14:02:47 +0000 Message-ID: References: <1576577756-648-1-git-send-email-bernard.iremonger@intel.com> <1578572194-594-7-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E7061153E020E9@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153E020E9@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGMwYzdiNzUtZDNkNC00MzgzLWE2ODItYjJmMjc2OTMwOTVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRHp3R3Y3d3ArZVwvakhcL3VcLzl5U2RpMHdjYVJtQUFKYUpGMDNRNmgrUWVYZFhScnJpTCtCWkNJK3NRSjlZSlFGNiJ9 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78da4826-5bb0-4e69-a383-08d7950c9b52 x-ms-traffictypediagnostic: DM6PR11MB3401: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-forefront-prvs: 02778BF158 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(396003)(376002)(366004)(346002)(136003)(13464003)(199004)(189003)(6636002)(5660300002)(8936002)(478600001)(110136005)(54906003)(9686003)(81166006)(107886003)(55016002)(4326008)(52536014)(81156014)(316002)(26005)(86362001)(33656002)(2906002)(76116006)(64756008)(66946007)(66556008)(71200400001)(66476007)(6506007)(186003)(8676002)(66446008)(53546011)(7696005); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB3401; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gmdZM5zAa44elO7cI9+M6BgKvRg9uKmRe6lSXN0tG9H1+s1/2gHAN+v8ooFayVvDYv1Ld6YC0VBoVMECG9VtUlav0ymhHUdXWIX59EBSW+wOWGTGAOnLK3pSdsd9yJ+pYJxdNMghhovCDtC0htblZERGJTU+VYUZfJ2Fo2X+QvJ7Q9ExSOrpJ7n9KxK5mjAA1lysR2EVdH6FBVgEljhc+GnD1QRid8Q5Gby4JguOeu9fv0PpYTdlTuBS9Cy4/HFi7IkPQTGqD6XbycF06CTjPFvgojRd3rDycJ9R9FCm4BMuFCGqpUY1kRcZCDmS/kzUaiPfbNpnys+lILfiTKPG6ghGykljo/ZCZGsZNMjVafPVmGYBWLqCpm/rQZaE7PQxR101HR6EZKraekeRJSQfI/sKqfO3K/8niwpwAcCQLusW4XlQoCLIBeORWGjw7FTZp6V0Obyzkyj+UN2fQPL4QsYIZdZU29oMRr1aHIt3+iFTn4PFwEG846M71aepjk2F Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 78da4826-5bb0-4e69-a383-08d7950c9b52 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2020 14:02:47.1746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rzzChw1Mt1rXu0vNk9Ntrqu4jZ8/K+ZurfG9P9Wb3++R7znhG0TPqQuNNEriE2sbKkNCS+NcrmKz2Gcb5dNkoZWfUxOYaoRbuqpzFlbjd3g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3401 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, January 9, 2020 12:44 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Director packet >=20 > Hi Bernard: >=20 > > -----Original Message----- > > From: Iremonger, Bernard > > Sent: Thursday, January 9, 2020 8:17 PM > > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, > > Stephen1 ; Zhang, Helin > > ; Iremonger, Bernard > > > > Subject: [PATCH v3 6/9] net/i40e: display Flow Director packet > > > > call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c > > > > Signed-off-by: Bernard Iremonger > > --- > > drivers/net/i40e/i40e_fdir.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_fdir.c > > b/drivers/net/i40e/i40e_fdir.c index > > 3fa6297..78329d2 100644 > > --- a/drivers/net/i40e/i40e_fdir.c > > +++ b/drivers/net/i40e/i40e_fdir.c > > @@ -21,6 +21,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "i40e_logs.h" > > #include "base/i40e_type.h" > > @@ -805,6 +806,7 @@ i40e_fdir_fill_eth_ip_head(const struct > > rte_eth_fdir_input *fdir_input, > > fdir_input->flow_type); > > return -1; > > } > > + rte_hexdump(stdout, NULL, raw_pkt, len); >=20 > Why we need this? Does this just for debug? Useful to see the packet constructed by this function, otherwise no visibil= ity on what is happening. Needed for debug. >=20 > Regards > Qi >=20 > > return len; > > } > > > > @@ -954,7 +956,7 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf, > > &fdir_input->flow_ext.flexbytes[dst], > > size * sizeof(uint16_t)); > > } > > - > > + rte_hexdump(stdout, NULL, raw_pkt, len); > > return 0; > > } > > > > -- > > 2.7.4 >=20 Regards, Bernard.