RE: [PATCH v1 2/2] clocksource: Add Intel Keem Bay Timer Support

["Ayyathurai, Vijayakannan" <vijayakannan.ayyathurai@intel.com>]

Hi Daniel,
Thanks for reviewing this patch.

> From: Daniel Lezcano <daniel.lezcano@linaro.org>
> >
> > +++ b/drivers/clocksource/Kconfig
> > @@ -738,4 +738,14 @@ config MICROCHIP_PIT64B
> >  	  modes and high resolution. It is used as a clocksource
> >  	  and a clockevent.
> >
> > +config KEEMBAY_TIMER
> > +	bool "Intel Keem Bay timer driver"
> > +	depends on ARCH_KEEMBAY || (ARM64 && COMPILE_TEST)
> 
> The timer drivers subsystem wants silent options and let the platform to
> select the timer.
> 
> Please select the timer in arch/arm64/Kconfig.platforms in the
> ARCH_KEEMBAY section.
> 
> So it would come:
> 
> config KEEMBAY_TIMER
> 	bool "bla bla" if COMPILE_TEST
> 

Ok. I will check that and update in next version.

> 
> 
> > +	select TIMER_OF
> > +	help
> > +	  This option enables the support for the Intel Keem Bay general
> > +	  purpose timer and free running counter driver. Each timer can
> > +	  generate an individual interrupt and the 64 bit counter can also
> > +	  be used as one of the clock source.
> > +
> 
> [ ... ]
> 
> > +static struct timer_of keembay_ce_to = {
> > +	.flags	= TIMER_OF_IRQ | TIMER_OF_BASE | TIMER_OF_CLOCK,
> > +	.clkevt = {
> > +		.name			= "keembay_timer",
> > +		.features		= CLOCK_EVT_FEAT_PERIODIC |
> > +					  CLOCK_EVT_FEAT_ONESHOT,
> 
> May be consider CLOCK_EVT_FEAT_DYNIRQ ?
> 
> see commit d2348fb6fdc6d67
> 

Sure. I will add it in the next version.

> Other than that, LGTM
> 
> Thanks
> 
>   -- Daniel
> 

Thanks,
Vijay