From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FABFC07E95 for ; Fri, 16 Jul 2021 14:10:21 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id DABA3613E3 for ; Fri, 16 Jul 2021 14:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DABA3613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 081F54067B; Fri, 16 Jul 2021 16:10:20 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 66ADA40151; Fri, 16 Jul 2021 16:10:18 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10046"; a="207710445" X-IronPort-AV: E=Sophos;i="5.84,245,1620716400"; d="scan'208";a="207710445" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2021 07:10:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,245,1620716400"; d="scan'208";a="452747430" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 16 Jul 2021 07:10:16 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 16 Jul 2021 07:10:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 16 Jul 2021 07:10:16 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 16 Jul 2021 07:10:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YHISKHvbVgoT4JEHsP35LK2jCmTAvCM/lavD5sgLBngtdgT3w/PaEDrewvGaA8JXi5pvFUjltlBKBLXkkGL9jnQp7Z+iI2AiPxzsqp+9pxW0oaUAlvsnk7UNbBn/AjzDIwhjfwkLeIBN7M+uhJeQQhtEP+LbsjQDRm3rPgdjnAG96me0jO05Oy8gocGWYTe9ga5aq1gGv2uzzRd6PBdi2NKk7MtQDcmo4KkfP5QrgZl/cE8TgDtGeoWdkNkbHQYxKFya/Hmw2fzGjb/+h/tH5/3ifOptTIYIvvFbrEb8AOUSGVWsN4b6rPwvJap1taa2awLM2f3zmBy93mV82d9EZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lMOhwHVUUybP7MN6mikjqG3lXIPJqXHmcwRt0BdredU=; b=L/jxKiHAqBT4kjTjbmKxvBj2wd9ZQ+weLgfJqRfvsJA6adUK8PPMHta6ZFLevL09jbBGdkd9jtD86LYy9G0cahrMK9YyHSZKmbiuiVzqAtjFSAeBayXvM3GxT/P8kh4E4ai4lSFRvaD9SwALtS+CmS4BmDjYhzIWUYCiZHiUbdMqIkz+5+Tw03cbnuBv3qBx/+QE7t9hN2VZJHbBK4pDfnlMnSrJvXQOw06Tmrm3hlwSufsUp7GGbsS6/HQ8cfPPN1WQq0umuU2AsqdyicZe7DhPw9EYgPqjSKREfJj8UZrMSQLde2a/9KW/oL0KH7J8MLS385aRL0EYWZ5ux7dXPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lMOhwHVUUybP7MN6mikjqG3lXIPJqXHmcwRt0BdredU=; b=gZ+H+CUANbTS77wwlhnDrE7Eey2xEBsiMuN9jKfpd5XbvyHZBF3Q2oXsX5UX4AHKlJT0xtI7DOS0YeazZj5sFv/eFIhjRCylMujzEYUZLO8DqLS6i+8h812RQ7A99O4Q5hmXX4rwDBthU+iuVT3uKpPyoLZI09nJ02SBCIkKgow= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3129.namprd11.prod.outlook.com (2603:10b6:5:65::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Fri, 16 Jul 2021 14:10:14 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7dc4:66b0:f76b:6d48]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7dc4:66b0:f76b:6d48%7]) with mapi id 15.20.4331.026; Fri, 16 Jul 2021 14:10:14 +0000 From: "Ananyev, Konstantin" To: "Laatz, Kevin" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Richardson, Bruce" Thread-Topic: [PATCH] raw/ioat: fix config script queue size calculation Thread-Index: AQHXekWSHvzvkJgSYkGfZgQ/ghPXcqtFo8GA Date: Fri, 16 Jul 2021 14:10:14 +0000 Message-ID: References: <20210716132155.1498858-1-kevin.laatz@intel.com> In-Reply-To: <20210716132155.1498858-1-kevin.laatz@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0c39f60c-da4d-47cf-1b86-08d948636e8f x-ms-traffictypediagnostic: DM6PR11MB3129: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lg/P17zLBiQSVmI48Sq+sdCz6ps7SYWkuCWBI49WmdxS8He8M8u/Ebrs1G84nUJ7lUEva5QdYfj13zjzN9/t3767OPD6d/ZQI2mbM5Ty083KlLM3yAVJ4vP7XIH7uWcnHKJmKG8qLQbvJxeIP2IXTd1z5P1ktzKewBoCaCjiIlKjtwvg4u7H8kbWf4+f54iMEvr8GbVc//Bv8Oe+LVei+1vC2wjeaYUBYZfpVZrmi5Dv0r9VswwIwZFJPs1cqKLnXmifdGXkm7mjF17lvd2d8vc8OvmIaKBGmjGXQcHj1xnPfYCHYpRZ8GbvZQi2jKCU7tGHcNVheKwEnbssg3vg1w0Wkeb1HF2OV3+MMCIBUcBZc9XJhdnqgt6QtXfTZx5lGRzuzIDZOyMKotQVU8h+tke556iXszkl0MTmcnHkYAN4KYI9ACHkfvq6dGNeBZPLsykMnthf+sc9Qjq/onohM5s6s3wBw+FiGG2NgA+6TnwB5SNo/jiZjmCFAGU7KXm/YOG96vlvw+cJHsnEVO9MokL1jvJ/24/EI/HfyiKPmYtdvy0Vp/NPagocQmVYgnVMQqQ1XmVKmVpRi51YHArFKM4/dHE5RrhAUbD54QHfY1284cTNh5nV1mKm0o5Qe58tM9NICwPAwxHxuoQ/3bBWVaKOrlXFY+Bh3pokX4vi/cJ+dmBaK72B+B68EGaxuajgsB049D5ujGDZ/2KKs8FDsA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(86362001)(2906002)(6506007)(8676002)(33656002)(26005)(71200400001)(38100700002)(122000001)(186003)(9686003)(55016002)(83380400001)(8936002)(450100002)(66946007)(4326008)(316002)(54906003)(110136005)(107886003)(52536014)(64756008)(478600001)(66446008)(66476007)(66556008)(76116006)(5660300002)(55236004)(7696005)(38070700004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E6ziXvQI2fKL+Q7rnr2yfJm98p+/yLrPJd1ywrOUoBEyI+5o1PAfl4+55zGh?= =?us-ascii?Q?KEYgqzpXn781Y3JQF1phCVDcPjhTfqsdkNGyPcEAZkWwIlbH+f+wzkuoUGQm?= =?us-ascii?Q?arxIxmluDMi8X80//2c0FxPSqUrpt2/JzucMnRoRVwQfaaZHWldTUkkahVkU?= =?us-ascii?Q?7ypA6S5u+0TUDmXEE6tkVWWqDYm1nBsRnrrfutJKPnqHy93ZEg1SXbUEavAR?= =?us-ascii?Q?AWITqOSADrN35tLcVntpkiiA2TZZqSnHXUE9nNkXj15t9UF6a3i9ppMft5YB?= =?us-ascii?Q?swYD3Ph0gO/qGn6swksJ5iP+AzfAeZeysiAvN3Aj16myX6drXnzKMIrvLYwT?= =?us-ascii?Q?Fb+Tz/UdtqFB3MpikUanKKjaszqw43Amd/q+D0136/yXQl0EJX6wzUAwqqW6?= =?us-ascii?Q?imGS1eE4DaXpAhPZmCHyhuDK0Eozj5iyXqWvZQYH08tia+UvvFcbeXjN2ww+?= =?us-ascii?Q?E+zb7hPOkiIGBZd9lKzdViW7wAU8fFF9s1ZoC74AEqCdz1gq3gDcBFQNe3FI?= =?us-ascii?Q?7LH8gq5wfkOsKb+gxtpmw5jcA1Otz7GhXlMHRBzralb0LZoTVuePwcimNo4d?= =?us-ascii?Q?RYfRNr/mpV8TykSiO7hAixCni/p+g59rCgyGJsteNnwlUir5UxEz5x4YcfaK?= =?us-ascii?Q?PSjkaTWqGCOtfaNzlrzLnAH0E/IvtIloAFTJnlIjRqujmH4UGnG5Kr4uyIID?= =?us-ascii?Q?tx/TtIUQQ7/vICDR+zR+RUN6+MQiZSmSFWGQRnfiM1kof7eiQ8rH1bHVr++J?= =?us-ascii?Q?88BHFFfZCOB5i5tvTZYPyqlmQOh4yGaQYhhs80Nm+S3ujlhtXOD53xkMUH+j?= =?us-ascii?Q?lb1b4xWbOQUVVEs9kWyhHl0f6AVUpIFrKxS0PaIXgW2+5Iey5IgDkZqKbtyN?= =?us-ascii?Q?JGjxAAch6n22TCjt6taSnDexN77Uww7FIbdOripRLE9Wn/iyL4E+eOiQILiy?= =?us-ascii?Q?sdNP15cs7PYth17QR9A8/OktIsRKjjilsEJ0+7PjeWIzNJ4r823JnjLYZlW/?= =?us-ascii?Q?vkmQ5eMPiZOHbLNsEF1MrdXPTYD+WuHWPHfJO9Tyx+2BFx0nkcBKNuN8R2uB?= =?us-ascii?Q?/cCBtIj4zBrNrOkjdbB/hgKMovY0WZ8o9sqmuuooHec9b8W3PwhcCXoyJHKm?= =?us-ascii?Q?1WemBe22ijGbgSSsmUXFxS9e4q+2164EVHYfuTkS2AMmBArl0Kll+gpop399?= =?us-ascii?Q?lrOCyUrF2wZI1vPI9srEX6BiZclWxRvGltECjoXWYgt/ZYpoF5tIacG2eQry?= =?us-ascii?Q?NF5z+s9/Bl+zwN886zAILQItzNy5KZAM308Gn+GZ0SDvGVdQb0P/nuj0PTDo?= =?us-ascii?Q?0y6GQPcXko84YRMAj8ptDgWY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c39f60c-da4d-47cf-1b86-08d948636e8f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2021 14:10:14.1941 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8rpuonDaIgX/Pdg4cit/R2Q9w/a1y2kDN0ttUFoJR1IBGd+bKpRtWn+8l7IH5Ntgb6C0EIgFKX+IsRHU1oQBTTDhMcU1EtxIrabA567glz0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3129 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix config script queue size calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > The queue size calculation is currently based on "max_tokens" rather than > "max_work_queues_size". This is resulting in the queue size being > incorrectly configured when using the script to configure devices bound t= o > the IDXD kernel driver. > This patch fixes this miscalculation so devices are configured with > appropriate queue size. >=20 > Fixes: 01863b9d2354 ("raw/ioat: include example configuration script") > Cc: stable@dpdk.org >=20 > Reported-by: Konstantin Ananyev > Signed-off-by: Kevin Laatz > --- > drivers/raw/ioat/dpdk_idxd_cfg.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/raw/ioat/dpdk_idxd_cfg.py b/drivers/raw/ioat/dpdk_id= xd_cfg.py > index 83ef4817db..fcc27822ef 100755 > --- a/drivers/raw/ioat/dpdk_idxd_cfg.py > +++ b/drivers/raw/ioat/dpdk_idxd_cfg.py > @@ -63,7 +63,7 @@ def configure_dsa(dsa_id, queues, prefix): > max_groups =3D dsa_dir.read_int("max_groups") > max_engines =3D dsa_dir.read_int("max_engines") > max_queues =3D dsa_dir.read_int("max_work_queues") > - max_tokens =3D dsa_dir.read_int("max_tokens") > + max_work_queues_size =3D dsa_dir.read_int("max_work_queues_size") >=20 > nb_queues =3D min(queues, max_queues) > if queues > nb_queues: > @@ -82,7 +82,7 @@ def configure_dsa(dsa_id, queues, prefix): > "mode": "dedicated", > "name": f"{prefix}_wq{dsa_id}.{q}", > "priority": 1, > - "size": int(max_tokens / nb_queues)}) > + "size": int(max_work_queues_size / nb_queue= s)}) >=20 > # enable device and then queues > drv_dir.write_values({"bind": f"dsa{dsa_id}"}) > -- Acked-by: Konstantin Ananyev > 2.25.1